osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
49602 commits 23 branches 0 tags 1.3 GiB
Commit graph

49602 commits

This branch
This branch
All branches
Author SHA1 Message Date
Michael Mann
bb36a25089 Remove use of pinfo->private_data and just pass the data around through function parameters 
Remove g_pinfo from packet-ansi_637.c and add packet_info* as a function parameter while we're at it.

svn path=/trunk/; revision=52883
 2013-10-27 01:06:44 +00:00
Jeff Morriss
2d20a6c864 Fix up some more svn properties. 
svn path=/trunk/; revision=52882
 2013-10-27 00:51:54 +00:00
Jeff Morriss
04c9e08b19 Don't set svn:keywords on .pod files. Remove it from those that have it. 
Reorganize svnadd a little bit.

svn path=/trunk/; revision=52881
 2013-10-27 00:50:26 +00:00
Pascal Quantin
ef24e09f5d From robionekenobi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9328 : 
Suppress some VS2013 warnings when compiling gtk ui

svn path=/trunk/; revision=52880
 2013-10-26 21:04:53 +00:00
Evan Huus
01c2eecc35 Updates to radiotap-iter licensing terms. The upstream version has a COPYING 
file containing what is actually the ISC license (BSD-like), so add that to the
header for licensecheck's sake (and remove the confusing reference to the BSD
license). This makes the code actually your choice of ISC
and GPL2 (since it is used in the Linux kernel which is GPL2-only). ISC is
already acceptable for us, so ISC \union * must be also, so add ISC+GPL2 to
checlicenses' list.

Upstream COPYING file, for reference:
http://git.sipsolutions.net/?p=radiotap.git;a=blob;f=COPYING;hb=97478c8467ce7ab56b7c9e8fd7cdc0f4e2cb22ed

svn path=/trunk/; revision=52879
 2013-10-26 20:57:38 +00:00
Pascal Quantin
99c75b2295 From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9330: 
Add OID tests for adding named arcs

svn path=/trunk/; revision=52878
 2013-10-26 20:50:51 +00:00
Michael Mann
9804a7b332 Don't use private_data for pwatm_private_data_t and instead pass it into the dissectors. 
svn path=/trunk/; revision=52877
 2013-10-26 19:18:12 +00:00
Alexis La Goutte
5b28dba199 Fix Dead Store (Dead assignement/Dead increment) warning found by Clang 
svn path=/trunk/; revision=52876
 2013-10-26 17:20:18 +00:00
Alexis La Goutte
3a1041c084 Fix Dead Store (Dead assignement/Dead increment) warning found by Clang 
svn path=/trunk/; revision=52875
 2013-10-26 17:18:24 +00:00
Alexis La Goutte
39f4eb2edd Fix Dead Store (Dead assignement/Dead increment) warning found by Clang 
svn path=/trunk/; revision=52874
 2013-10-26 17:18:12 +00:00
Alexis La Goutte
70b52fc4f5 Fix Dead Store (Dead assignement/Dead increment) warning found by Clang 
svn path=/trunk/; revision=52873
 2013-10-26 17:17:53 +00:00
Alexis La Goutte
6895d1f63d Remove unused variable 
svn path=/trunk/; revision=52872
 2013-10-26 17:17:38 +00:00
Alexis La Goutte
8bcefa0f42 Fix indent and add modelines info 
svn path=/trunk/; revision=52871
 2013-10-26 17:17:17 +00:00
Evan Huus
3342e3bc89 Convert some emem to wmem. It took some manual flow analysis, but they are only 
used during actual packet dissection.

svn path=/trunk/; revision=52870
 2013-10-26 16:04:21 +00:00
Michael Mann
df5a9be3db Bluetooth: SDP: Decode custom 128bit UUIDs and minor fixes. Bug 9327 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327) 
From Michal Labedzki

svn path=/trunk/; revision=52869
 2013-10-26 13:28:47 +00:00
Michael Mann
e154ac38f8 Bluetooth: OBEX: PBAP: Fix Filter parameter. Bug 9327 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327) 
From Michal Labedzki

svn path=/trunk/; revision=52868
 2013-10-26 13:18:21 +00:00
Anders Broman
24164080b1 Convert to value_str_ext in a couple of places. 
svn path=/trunk/; revision=52867
 2013-10-26 09:37:47 +00:00
Bill Meier
21bed98150 Fix several [-Wunused-const-variable] warnings (using '#if 0'). 
svn path=/trunk/; revision=52866
 2013-10-26 03:16:57 +00:00
Evan Huus
70cf133bf5 Cleanups to the TPNCP database parser/loader: 
- use and free glib memory instead of ep_ memory - another dissector down
- propogate errors correctly
- produce a warning if an error occurs loading the DB
- add XXX comments about realloc handling that may or may not be a memory leak
  in failure cases

svn path=/trunk/; revision=52865
 2013-10-26 02:54:58 +00:00
Michael Mann
2ebf40a1c2 Bluetooth: SDP: Decode all types of UUIDs. Bug 9327 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327). 
From Michal Labedzki

svn path=/trunk/; revision=52864
 2013-10-26 02:36:56 +00:00
Michael Mann
3cc6957fa8 Bluetooth: Use items for logical block objects. Bug 9327 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327) 
Bluetooth protocols use items, so dissect it to improve filtering and better user experience - text object cannot be filterable or comparable.

From Michal Labedzki

svn path=/trunk/; revision=52863
 2013-10-26 02:24:04 +00:00
Bill Meier
6dd42b581a Fix some [-Wunused-const-variable] warnings (using '#if 0') 
svn path=/trunk/; revision=52862
 2013-10-26 02:09:14 +00:00
Michael Mann
63869c4037 Bluetooth: SDP: Add MultiProfile UUIDs. Bug 9327 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327) 
From Michal Labedzki

svn path=/trunk/; revision=52861
 2013-10-26 00:53:23 +00:00
Jeff Morriss
d8f1af511f Mark a bunch of no-longer-used parameters as unused. Remove a couple of 
unused parameters.

svn path=/trunk/; revision=52860
 2013-10-26 00:41:54 +00:00
Michael Mann
250568ca91 Bluetooth: SDP: Fix PBAP features presentation. Bug 9327 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327) 
From Michal Labedzki

svn path=/trunk/; revision=52859
 2013-10-26 00:36:16 +00:00
Michael Mann
68a5e46e9d OBEX: Fix Presentation of Reserved Fields. Bug 9327 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327) 
From Michal Labedzki

svn path=/trunk/; revision=52858
 2013-10-26 00:31:42 +00:00
Michael Mann
5030e21822 Replace tabs by spaces. Bug 9327 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327) 
From Michal Labedzki

svn path=/trunk/; revision=52857
 2013-10-26 00:26:41 +00:00
Michael Mann
1e0405a3a3 Remove SMB's use of private_data and just pass the data through all of the dissection functions 
svn path=/trunk/; revision=52856
 2013-10-25 23:59:30 +00:00
Gerald Combs
7a2de9f471 More sequence dialog updates. 
Draw item labels and port numbers.  Update the hint text. Make items
selectable.  Resize fonts similar to the GTK+ version.  Add scrollbars.
Update the cursor.  Use pango_layout_set_ellipsize() in the GTK+ code.
Fixup comments.

svn path=/trunk/; revision=52855
 2013-10-25 23:16:56 +00:00
Evan Huus
95f484a91e Add a very small hack to make the UAT update callback error string freeable, and 
convert all existing UAT update callbacks to use glib memory instead of
ephemeral memory for that string.

UAT code paths are entirely distinct from packet dissection, so using ephemeral
memory was the wrong choice, because there was no guarantees about when it would
be freed.

The move away from emem still needs to be propogated deeper into the UAT code
itself at some point.

Net effect: remove another bunch of emem calls from dissectors, where replacing
with wmem would have caused assertions.

svn path=/trunk/; revision=52854
 2013-10-25 22:14:25 +00:00
Gerald Combs
7a3febacac Exit if we're building with Qt and we can't find macdeployqt. 
svn path=/trunk/; revision=52853
 2013-10-25 21:37:30 +00:00
Chris Maynard
a049a2027c Sync up with packet-pana.c. 
svn path=/trunk/; revision=52852
 2013-10-25 21:16:39 +00:00
Chris Maynard
9fd46d8299 wmemify. 
svn path=/trunk/; revision=52851
 2013-10-25 21:04:22 +00:00
Jeff Morriss
b190de385a Fix CID 281375 (dead code) while hopefully fixing detection of Class-2 ERR 
messages.

Also fix a couple of incorrect MTP3 standard detections that I found.

svn path=/trunk/; revision=52850
 2013-10-25 20:38:50 +00:00
Evan Huus
ce22ab5ef6 Add an exception to the license-checker for Samba's special IDL license which 
appears to be compatible as far as I can tell (not a lawyer). See:
https://www.wireshark.org/lists/wireshark-dev/201310/msg00234.html

svn path=/trunk/; revision=52849
 2013-10-25 18:14:36 +00:00
Jeff Morriss
274596eaab Fix up some formatting and white space. 
svn path=/trunk/; revision=52848
 2013-10-25 15:25:46 +00:00
Jeff Morriss
ce23d50028 Fix CID 715143: assert that the preference we were looking for was found. It 
should be which is why this is an assertion not a NULL check.

svn path=/trunk/; revision=52847
 2013-10-25 15:00:00 +00:00
Jeff Morriss
81b0681c12 Fix CID 715144: assert that the preference we were looking for was found. It 
should be which is why this is an assertion not a NULL check.

svn path=/trunk/; revision=52846
 2013-10-25 14:57:55 +00:00
Jeff Morriss
4cfc0f27cb Kafka's CRC is 4 bytes long and is added with ENC_BIG_ENDIAN. Make the hf 
FT_UINT32 instead of FT_BYTES to match.

svn path=/trunk/; revision=52845
 2013-10-25 14:41:12 +00:00
Jeff Morriss
3440dd73f2 Fix CID 1080758: be prepared for tvb_child_uncompress() failing (and returning 
NULL).

svn path=/trunk/; revision=52844
 2013-10-25 14:38:39 +00:00
Jeff Morriss
2aae7bc4a6 Fix CID 280081: ENC_NULL can't be used as an array index into ciphers[], rather 
ENC_NULL-0x30 needs to be used.

(This could probably use some cleanup...)

svn path=/trunk/; revision=52843
 2013-10-25 14:15:28 +00:00
Jeff Morriss
ab97b9d50b Fix CID 1111806: it's not safe to check if "tag < sizeof(tag_to_type)" before 
accessing tag_to_type[tag]: while the array is made of enums and the values of
the enum will fit in a guint8 (making the conditional safe) compilers don't
*have* to "right size" the storage for the enum.  They very well could be lazy
and store the enum in int's.

Replace it with a macro that tells us the size of the array.

svn path=/trunk/; revision=52842
 2013-10-25 14:04:22 +00:00
Michael Mann
02784747f7 Make sure "mp2t-dsmcc" dissector is registered by name so it can be picked up by etv dissector. 
svn path=/trunk/; revision=52841
 2013-10-25 13:37:10 +00:00
Jeff Morriss
3e4c954fd8 Fix checkAPIs: don't add hf_zbee_beacon_protocol with 
proto_tree_add_uint(..., ENC_NA); use proto_tree_add_item() as it appears
was intended.

svn path=/trunk/; revision=52840
 2013-10-25 13:24:29 +00:00
Jeff Morriss
86b6659210 Fix CID 1111814: segment_item is set but not used (in one conditional). 
Move a URL from in the middle of the copyright notice to up where it (appears
to) belong.

svn path=/trunk/; revision=52839
 2013-10-25 13:23:17 +00:00
Chris Maynard
62b66aca7c Display the frame number on the packet summary line if it's one of the configured columns. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9317 
#BACKPORT(1.10,1.8)

svn path=/trunk/; revision=52838
 2013-10-25 12:51:16 +00:00
Michael Mann
cf1f098afb Improvements for the KDSP dissector. Bug 8891 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8891) 
From Yuri Schaeffer

svn path=/trunk/; revision=52837
 2013-10-25 02:41:47 +00:00
Michael Mann
c09b328e13 Pass ieee802154_packet data into the heuristic check instead of using private_data. 
svn path=/trunk/; revision=52836
 2013-10-25 02:02:02 +00:00
Michael Mann
ab0ad4aa1c Make TAPA dissector heuristic instead of "ugly hack" now that IP dissector supports heuristics. 
IP heuristics pass in IP header to help subdissectors decide what to do.

svn path=/trunk/; revision=52835
 2013-10-25 01:54:53 +00:00
Jeff Morriss
0cc2c88c2e Fix more SVN properties. 
svn path=/trunk/; revision=52834
 2013-10-25 01:25:23 +00:00