Commit graph

24417 commits

Author SHA1 Message Date
Stig Bjørlykke
b205017b3e Display the interface comment if defined.
On non-win32 also display the interface name.

svn path=/trunk/; revision=25114
2008-04-18 14:29:54 +00:00
Jeff Morriss
2f78f0145d filename2uri() doesn't modify its parameter (and in at least one place we hand it a const argument) so make the parameter const. Also move the function up in the file (before its first use).
svn path=/trunk/; revision=25113
2008-04-18 12:47:05 +00:00
Jeff Morriss
7ca7f149ce Change an assignment-in-an-if to a comparison.
svn path=/trunk/; revision=25112
2008-04-18 12:42:27 +00:00
Richard van der Hoff
9f8f32ded8 update originals as per r25110
svn path=/trunk/; revision=25111
2008-04-18 11:37:48 +00:00
Richard van der Hoff
d8356ff748 fix decoding of amr in h323/h324 calls
svn path=/trunk/; revision=25110
2008-04-18 11:30:22 +00:00
Gerald Combs
15d0f668cf Minor banner tweaks.
svn path=/trunk/; revision=25109
2008-04-17 23:59:56 +00:00
Stig Bjørlykke
a4f76f95a0 Added an option to display hidden protocol items.
svn path=/trunk/; revision=25108
2008-04-17 23:14:01 +00:00
Ulf Lamping
b11501c457 as the welcome page seems generally accepted, remove #ifdef SHOW_WELCOME_PAGE around it
svn path=/trunk/; revision=25107
2008-04-17 22:11:21 +00:00
Anders Broman
b40673e0fa From Vasil Velichkov :
Fix missing dissection of SignalInfo in MAP SMS operations

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2469

svn path=/trunk/; revision=25106
2008-04-17 20:26:00 +00:00
Bill Meier
7e9b56cbeb On Windows: filemanager_open_directory: ensure a trailing '\' on path to ShellExecute;
svn path=/trunk/; revision=25105
2008-04-17 20:00:26 +00:00
Guy Harris
1bf91a279c In filemanager_open_directory(), if we're not on Windows or OS X and
don't have xdg-open, convert the pathname to a URI and hand it to the
browser.

svn path=/trunk/; revision=25104
2008-04-17 19:37:40 +00:00
Guy Harris
572efdc1c4 Use the "explore" verb when opening directories; that doesn't fix the case
where there's an openable file and a directory with the same pathname
except for the extension, but at least it prevents us from trying to open
the file.

svn path=/trunk/; revision=25103
2008-04-17 18:40:45 +00:00
Gerald Combs
53f9968447 Add descriptions of the "Rel Start" and "Duration" columns in the
Conversations window.

svn path=/trunk/; revision=25102
2008-04-17 17:51:57 +00:00
Guy Harris
37c537ec48 Don't use "%ll[doux]" to print a guint64 - use G_GINT64_MODIFIER.
svn path=/trunk/; revision=25101
2008-04-17 16:54:32 +00:00
Guy Harris
2172b8dfb1 Sigh. g_spawn_async() should take a "const gchar **" argument for argv,
as it shouldn't be modifying the strings, but it's "gchar **", so we
can't make argv an array of "const gchar *" - which means that you can't
put a "{g}char *" into it without a cast.

Clean up white space.

svn path=/trunk/; revision=25100
2008-04-17 16:53:41 +00:00
Bill Meier
9f35411f35 Infos --> Information
svn path=/trunk/; revision=25099
2008-04-17 16:24:55 +00:00
Jeff Morriss
196d9651ae Another (somewhat blind) attempt to help bug 2053: don't create the INAP handle nor call oid_add_from_string() more than once (by putting that code inside the "We haven't been through the handoff function before" condition).
svn path=/trunk/; revision=25098
2008-04-17 16:22:47 +00:00
Guy Harris
b2f4f0a228 If we have xdg-open, define HAVE_XDG_OPEN.
Add a routine "filemanager_open_directory()", which takes a pathname
(presumed to be UTF-8 in Windows and Mac OS X; this might need work for
other UN*Xes) and attempts to open a file manager window for it, using
ShellExecute on Windows, Launch Services on OS X, and, for now, running
xdg-open on other OSes if we have it (should we have a preference for
the file manaager, just as we have one for the Web browser?).

(For that matter, if we have xdg-open, do we need a preference for the
Web browser, or should we just have xdg-open open the Web browser?)

svn path=/trunk/; revision=25097
2008-04-17 16:14:22 +00:00
Ronnie Sahlberg
331e026f6c Add autogenerated dissector for DCE/RPC MAPI and also the (non-NDR)
protocol that is transported within 


svn path=/trunk/; revision=25096
2008-04-17 12:05:16 +00:00
Ulf Lamping
d570c787cc set_sensitive(FALSE) for recent files that are currently not available
svn path=/trunk/; revision=25095
2008-04-17 08:53:09 +00:00
Stig Bjørlykke
ae93228212 From Vasil Velichkov (bug 2471):
Add ASN definition of MAP BeginSubscriberActivity operation.
Add call to dissect function in packet template.

svn path=/trunk/; revision=25094
2008-04-17 07:47:02 +00:00
Ulf Lamping
51baf7769a cut filenames in the middle (not just at the start) and add tooltips for it
svn path=/trunk/; revision=25093
2008-04-17 04:05:14 +00:00
Ulf Lamping
ebe83ebcb3 add tooltips for the welcome page buttons
svn path=/trunk/; revision=25092
2008-04-17 03:24:24 +00:00
Guy Harris
cc1da67ca7 A GtkImage doesn't take any input, so it doesn't support the "clicked"
signal.

Fix the description for the "Interface List" welcome button.

svn path=/trunk/; revision=25091
2008-04-17 03:06:22 +00:00
Guy Harris
22ae89d766 colors_init() doesn't have anything to do with packet coloring, it's
just our initialization routine for low-level GTK+ stuff, such as
getting the system colormap and the "black" and "white" colors; we have
to call it before calling get_color().

svn path=/trunk/; revision=25090
2008-04-17 02:55:29 +00:00
Guy Harris
1b4b6462e8 Put a space between the number of bytes (for a file < 1024 bytes) and
"Bytes".

"Interface description" vs. "interface name" isn't Windows vs. UN*X,
it's "has a description" vs. "doesn't have a description" - the lack of
descriptions in UN*X is a result of

	1) lack of a mechanism to supply descriptions in some UN*Xes

and

	2) lack of code in libpcap to get those descriptions in some
	   other UN*Xes

and I need to work on fixing 2) (I think it can be dredged out of
FreeBSD 6 and 7, I seem to remember current OpenBSD supplying them, and
for OS X we might as well cheat the way the network preference pane does
and just call en0 the main Ethernet and en1 the AirPort interface).

Use an adverb rather than an adjective to modify a noun, as per Chris
Maynard's suggestion.

svn path=/trunk/; revision=25089
2008-04-17 02:38:21 +00:00
Guy Harris
04daff59de Oh, what the heck, go for it - do the size calculations in 64 bits, just
in case a file has more than 2^32 megabytes of data :-); we already
require 64-bit support for calculations and formatting.

svn path=/trunk/; revision=25088
2008-04-17 02:29:43 +00:00
Ulf Lamping
fe630dbde0 ... bring into alphabetical order
svn path=/trunk/; revision=25087
2008-04-17 02:17:55 +00:00
Ulf Lamping
85e14ceb86 rename REGISTER_xxx_GROUP_NONE to REGISTER_xxx_GROUP_UNSORTED, as NONE seems a bit misleading
svn path=/trunk/; revision=25086
2008-04-17 02:16:39 +00:00
Stephen Fisher
3ad27f2ff8 Mark a paramter as unused
svn path=/trunk/; revision=25085
2008-04-17 02:08:23 +00:00
Ulf Lamping
f7a6d27307 fix comments
svn path=/trunk/; revision=25084
2008-04-17 01:45:37 +00:00
Ulf Lamping
061df434cb try to fix the buildbot
svn path=/trunk/; revision=25083
2008-04-17 01:13:06 +00:00
Ulf Lamping
8a6bd7e262 enable welcome page
add file size of recent files
tweak colors
code cleanup

svn path=/trunk/; revision=25082
2008-04-17 00:31:38 +00:00
Anders Broman
19b0132216 Handle:
SAEB-IE-ContainerList
SAEB-IE-ContainerPairList
and
ProtocolError-IE-ContainerList

svn path=/trunk/; revision=25081
2008-04-16 20:47:34 +00:00
Jeff Morriss
10a67c2028 sccp_ssn_table is not used so remove it. The handoff function does not need to be called after preference changes so stop doing that. Found this on the hunt for bug 2053's cause but it shouldn't (AFAICS) be related.
svn path=/trunk/; revision=25080
2008-04-16 14:28:22 +00:00
Jeff Morriss
1c4a7f8f30 Remove (no longer needed) forward declaration of handoff function
svn path=/trunk/; revision=25079
2008-04-16 14:15:04 +00:00
Stig Bjørlykke
f79f9c8504 Added missing comment closing.
svn path=/trunk/; revision=25078
2008-04-16 11:55:23 +00:00
Ulf Lamping
63acc87cf2 ups, missed one
svn path=/trunk/; revision=25077
2008-04-16 10:00:19 +00:00
Ulf Lamping
ed7018b6e4 flip the import and export button "sequence", that the import button comes first. So we have the same sequence as the usual open/save menu.
svn path=/trunk/; revision=25076
2008-04-16 09:57:21 +00:00
Ulf Lamping
be75f6fa16 remove the copied xpm stock icon files from SVN and use the "GTK built in" stock icons
this will also prevent us from showing different stock icons for "our" xpm stock icons and the "system defaults". GTK (for Windows?) changed the icon theme somewhere around V2.10 (or later?) and/or the user might use a different icon theme, so this isn't an esoteric case ;-)

svn path=/trunk/; revision=25075
2008-04-16 09:54:55 +00:00
Richard van der Hoff
bcfb45de67 fields passed into proto_tree_add_bits_* should have bits==0
svn path=/trunk/; revision=25074
2008-04-16 09:49:39 +00:00
Ulf Lamping
f3a40604dc use a GTK_STOCK_CLEAR here
svn path=/trunk/; revision=25073
2008-04-16 08:54:50 +00:00
Ulf Lamping
45d5280ff1 add "Save As" and "Save All" buttons to the dialog / stock_icons utils
use them in the export object dialog

svn path=/trunk/; revision=25072
2008-04-16 08:47:12 +00:00
Ulf Lamping
a18fefb91f a better spacing between the help and copy buttons
svn path=/trunk/; revision=25071
2008-04-16 08:06:55 +00:00
Guy Harris
b346a99d0b tvb_get_ephemeral_string() is defined never to return null (currently,
it aborts - even if we don't make it abort, we should make it throw an
assertion, so we abort the dissection of the packet and let the user
know that we ran out of memory).

svn path=/trunk/; revision=25069
2008-04-16 07:23:56 +00:00
Guy Harris
266b212aad The right length to use when scanning all the data in a packet is the
*reported* length, so that if the packet was cut short by a snapshot
length, we get an exception because we run past the end, and the packet
is marked as having been cut short.

Do not use DISSECTOR_ASSERT() to check for the validity of packet data;
dissectors should try to handle even malformed packets, they shouldn't
report malformed packets as dissector bugs (if DISSECTOR_ASSERT(), that
is *ipso facto* evidence of a dissector bug, *even if the packet is
malformed*).

Update the offset when scanning the packet even if we *aren't* building
the protocol tree.

svn path=/trunk/; revision=25068
2008-04-16 07:18:08 +00:00
Stig Bjørlykke
00f1fcf13c From Chris:
The attached simple patch adds 2 missing help files to HELP and
alphabetizes all of them.

svn path=/trunk/; revision=25067
2008-04-16 06:28:26 +00:00
Ulf Lamping
561c514688 add packet-h263.h
svn path=/trunk/; revision=25066
2008-04-16 00:48:57 +00:00
Ulf Lamping
0f34f9fd6a don't use a Close button for the preparation dialog, use a Cancel one instead
svn path=/trunk/; revision=25065
2008-04-16 00:46:16 +00:00
Ulf Lamping
80abf46094 fix button sequence, show filter... button left to Cancel button
svn path=/trunk/; revision=25064
2008-04-16 00:45:23 +00:00