osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
30125 commits 23 branches 0 tags 1.3 GiB
Commit graph

9116 commits

Author SHA1 Message Date
Guy Harris
c9b5bc30d0 assert() doesn't throw an exception, it just immediately crashes the 
app, and DISSECTOR_ASSERT() throws an exception, but claims the problem
is a dissector bug, not a malformed packet.  Presumably the error in
question is the result of a malformed packet, so throw
ReportedBoundsError to indicate that (it's not really the *right*
exception, but the right exception doesn't exist).

svn path=/trunk/; revision=30776
 2009-10-31 08:31:21 +00:00
Jaap Keuter
134e77034e From Márton Németh: 
When an unknown requests arrives try to parse it using the usual request format.

svn path=/trunk/; revision=30775
 2009-10-30 22:46:30 +00:00
Jaap Keuter
a1e524ca85 From Márton Németh: 
Add support for USB HUB class-specific requests as specified in USB 2.0 Chapter 11 Hub Specification.

svn path=/trunk/; revision=30774
 2009-10-30 22:24:23 +00:00
Anders Broman
1a2f69aa03 Remove debug code 
svn path=/trunk/; revision=30772
 2009-10-30 16:25:11 +00:00
Anders Broman
77377a9d22 - Bitrate must be FT_UINT64 
- Dissect HandoverCommand

svn path=/trunk/; revision=30771
 2009-10-30 16:15:27 +00:00
Anders Broman
d3b7b182c1 - In new_octet_aligned_subset_bits() the length check must be on octet not bits. 
- try to make the code a bit more readable.

svn path=/trunk/; revision=30770
 2009-10-30 16:09:32 +00:00
Martin Mathieson
c120fa9b8f Sequence number should be displayed in DEC, not HEX! 
svn path=/trunk/; revision=30769
 2009-10-30 15:56:43 +00:00
Stig Bjørlykke
a634ff0a08 Corrected name used for STANAG 4406. 
svn path=/trunk/; revision=30768
 2009-10-30 10:55:43 +00:00
Stig Bjørlykke
5c0369ba97 Apply r30376 to asn1 template files. 
svn path=/trunk/; revision=30767
 2009-10-30 10:21:35 +00:00
Stig Bjørlykke
55f080c9c8 Added SNMP to "Decode ASN.1 file as" list. 
svn path=/trunk/; revision=30766
 2009-10-30 10:05:28 +00:00
Jaap Keuter
5cd74a536c Handle padded RTCP packets ending with SDES correctly as well. 
svn path=/trunk/; revision=30764
 2009-10-29 22:14:54 +00:00
Stig Bjørlykke
1e20ff2638 From Marton Nemeth via bug 4181: 
Take the USB descriptor length from packet.

svn path=/trunk/; revision=30763
 2009-10-29 21:51:20 +00:00
Stig Bjørlykke
6a2aae878d From Marton Nemeth via bug 4173: 
Parse USB HID class-specific requests.

svn path=/trunk/; revision=30762
 2009-10-29 21:42:16 +00:00
Stig Bjørlykke
373fff9846 From Marton Nemeth via bug 4173: 
Move bmRequestType field constants to header file.

svn path=/trunk/; revision=30761
 2009-10-29 21:32:21 +00:00
Martin Mathieson
f36f5897ee Tidy up info column output showing partial NACK. 
svn path=/trunk/; revision=30760
 2009-10-29 19:06:10 +00:00
Anders Broman
67697bad60 From Gerasimos Dimitriadis: 
DTAP: Update of Reject Cause IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4179

svn path=/trunk/; revision=30759
 2009-10-29 18:13:17 +00:00
Anders Broman
e2c0856e09 Fix a typo 
svn path=/trunk/; revision=30754
 2009-10-29 08:02:34 +00:00
Anders Broman
108ec05035 Export ToTargetRNC-Container. 
svn path=/trunk/; revision=30752
 2009-10-29 06:45:42 +00:00
Anders Broman
a26552a27f Update to the Mars verion of the protocol and export HandoverCommand. 
svn path=/trunk/; revision=30751
 2009-10-29 06:19:36 +00:00
Martin Mathieson
2e3dc7f0f4 Flag errors with expert info. 
svn path=/trunk/; revision=30748
 2009-10-28 19:00:41 +00:00
Anders Broman
d5cfd0edc9 - Remove check_col. 
- Make x2ap work.

svn path=/trunk/; revision=30746
 2009-10-28 06:18:05 +00:00
Anders Broman
191f468caf Missed an #include... 
svn path=/trunk/; revision=30745
 2009-10-28 05:13:31 +00:00
Anders Broman
cd8924f759 Update SCTP ppids, fix a faulty #define. 
svn path=/trunk/; revision=30744
 2009-10-28 05:09:32 +00:00
Anders Broman
423b8b31cd From Fred Fierling: 
Fixes bugs in dissection of write attributes, read reporting configuration, and
configure reporting clusters in the ZigBee Cluster Library.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4113

svn path=/trunk/; revision=30731
 2009-10-27 19:13:57 +00:00
Anders Broman
26658ed017 From Francesco Fondelli: 
RSVP extensions for G.709 Optical Transport Networks Control, RFC 4328
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4148

With some changes from me:
-(readme.developer:" Furthermore, 'display' field must be ORed with 'BASE_RANGE_STRING' (e.g. BASE_DEC|BASE_RANGE_STRING)."
- Prefix headerfields with hf_
- Remove check_col

svn path=/trunk/; revision=30727
 2009-10-27 06:05:02 +00:00
Anders Broman
cff062cd44 From Herbert Lischka: 
Minor changes to dissector packet-bacapp.c to solve some strange
views to ReadPropertyMultiple-Acknowledge frames.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4161

svn path=/trunk/; revision=30726
 2009-10-27 05:20:19 +00:00
Martin Mathieson
b712bb0f19 Add a preference to control whether or not comment strings are scanned for oob LTE MAC messages. Scanning them is probably quite slow. 
svn path=/trunk/; revision=30713
 2009-10-26 16:40:57 +00:00
Martin Mathieson
eab33c1bb9 Change a filter string for consistency. 
svn path=/trunk/; revision=30712
 2009-10-26 16:39:46 +00:00
Martin Mathieson
afffcffff9 Add support for displaying/filtering some LTE MAC out-of-band events. 
svn path=/trunk/; revision=30711
 2009-10-26 15:39:00 +00:00
Anders Broman
6d8f1356ba RelocationRequired incorrectly dissected. 
svn path=/trunk/; revision=30710
 2009-10-26 15:12:32 +00:00
Jaap Keuter
4bc1280033 From Jochen Bartl: 
This patch fixes the display filter for the prefix length of IPv6 external
route updates and the length calculation of the destination address in 
IPv6 route updates.

svn path=/trunk/; revision=30703
 2009-10-26 07:00:15 +00:00
Anders Broman
565b8c922c From Jakub Zawadzki: 
Fix memleaks while creating kademlia hash.

svn path=/trunk/; revision=30702
 2009-10-26 05:55:07 +00:00
Martin Mathieson
6dfb4d1f71 Add support for showing/filtering/resaving logged LTE strings. 
svn path=/trunk/; revision=30700
 2009-10-26 00:04:27 +00:00
Martin Mathieson
4474e0d25b Label a short BSR as "short" 
svn path=/trunk/; revision=30699
 2009-10-25 23:03:11 +00:00
Balint Reczey
460e086f9e Decode DSL Forum TR-101 PPPoE tags. 
This fixes bug 3113.

svn path=/trunk/; revision=30697
 2009-10-25 20:11:47 +00:00
Gerald Combs
771e9ef518 Option 2 (Time Offset) is signed. 
svn path=/trunk/; revision=30695
 2009-10-25 17:05:08 +00:00
Anders Broman
88bb44a51e From Jakub Zawadzki: 
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164

svn path=/trunk/; revision=30691
 2009-10-25 11:43:30 +00:00
Stig Bjørlykke
337896f4c6 From Marton Nemeth via bug 4163: 
Add support for input URBs.

svn path=/trunk/; revision=30690
 2009-10-25 10:45:15 +00:00
Anders Broman
53e44c4a73 From Gerasimos Dimitriadis: 
DTAP: MAP component of indefinite length within Facility IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4157

svn path=/trunk/; revision=30688
 2009-10-25 10:14:47 +00:00
Stig Bjørlykke
1637e69118 No point passing a global pointer as a function argument. 
Made check_ndmp_rm() and check_ndmp_hdr() static.

svn path=/trunk/; revision=30686
 2009-10-24 16:30:11 +00:00
Stig Bjørlykke
a3750f1ccf From Robert Simac via bug 3470: 
Add the missing ndmp v4 messages, namely the:
 NDMP_CONFIG_GET_EXT_LIST
 NDMP_CONFIG_SET_EXT_LIST

This may serve as the 1st step into actual extensions (Snapvault etc)
dissector implementation.

svn path=/trunk/; revision=30684
 2009-10-24 15:40:35 +00:00
Jaap Keuter
d90cb60f61 From Mithun Roy: 
The primary header in bundle protocol contains some offset values(destination
scheme offset, destination ssp offset, source scheme offset, source ssp offset,
etc). These are the offsets within the dictionary if the length of the
dictionary length is greater than 0. But if the dictionary length is 0, then
these offset refer to node number and service number respectively(according to
compressed bundle header encoding). For example if destination scheme offset is
2 and the destination ssp offset is 1, then the destination
EID(<node_number>.<service_number>) is 2.1. 

Currently the dtn dissector will consider these offsets to be actual offsets in
the dictionary even if the dictionary length is 0. So the values for the
EID's(destination, source, report, custodian) and their schemes are junk
values. For example if the destination scheme offset is 2 and the destination
ssp offset is 1 and the dictionary length is 0(which means the dictionary is
empty), then the destination scheme is 2 bytes after the beginning of the
metadata block(field after dictionary) and destination is 1 byte after the
beginning of the metadata block.

svn path=/trunk/; revision=30682
 2009-10-24 11:19:23 +00:00
Jeff Morriss
350729607a dissect_udp_bundle(): check if dissect_payload_header() or 
display_metadata_block() return 0 (meaning they failed to decode something and
the offset was not incremented) rather than checking if the resulting offset
is 0.

This fixes the infinite loop reported in:

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4156

svn path=/trunk/; revision=30672
 2009-10-23 15:55:39 +00:00
Anders Broman
9db0d46eba Forgot to remove IA5_7BIT_decode(unsigned char * dest, const unsigned char* src, int len); 
svn path=/trunk/; revision=30671
 2009-10-23 05:32:15 +00:00
Anders Broman
ea679ff697 From Gerasimos Dimitriadis: 
DTAP: Decoding of subaddress information.
sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4150

svn path=/trunk/; revision=30670
 2009-10-23 02:12:39 +00:00
Anders Broman
f82442badc Move IA5_7BIT_decode to strutil.c 
svn path=/trunk/; revision=30669
 2009-10-23 01:56:09 +00:00
Martin Mathieson
f5b4b6e32f Expert error if (non-padded) PDU is shorter than reported. 
svn path=/trunk/; revision=30666
 2009-10-22 17:22:27 +00:00
Martin Mathieson
0f8ee9cdf9 More long BSR fixes. 
svn path=/trunk/; revision=30664
 2009-10-22 11:45:40 +00:00
Martin Mathieson
b3f5ccdae0 Fix issues with long BSR format, and attach expert info for non-zero RAR TA to correct item. 
svn path=/trunk/; revision=30663
 2009-10-22 10:31:13 +00:00
Jaap Keuter
802dc7f334 From Greg Schwendimann: 
The 802.3at Power Via MDI TLV dissector is incomplete as it does not decode the
last three bytes.  I have attached a patch that decodes the type/source/priority, 
PD requested power value, and PSE allocated power value fields.

svn path=/trunk/; revision=30662
 2009-10-22 07:10:05 +00:00
Anders Broman
3faf5345ab From Gerasimos Dimitriadis: 
DTAP: Progress description depends on coding standard.
Changed to export value strings trough .h file
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4146

svn path=/trunk/; revision=30661
 2009-10-22 05:28:53 +00:00
Jeff Morriss
d163d9cad7 Remove non-ASCII characters 
svn path=/trunk/; revision=30656
 2009-10-21 12:56:28 +00:00
Anders Broman
f5f2bf6ecd From Gerasimos Dimitriadis: 
DTAP: Call state depends on coding standard.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4145

svn path=/trunk/; revision=30655
 2009-10-21 09:38:51 +00:00
Jaap Keuter
d42280adb1 From Joe Eykholt: 
The Fibre-Channel Extended Link Service request REC (Read Exchange Concise) 
is used in error recovery.  It is currently identified as REC but not completely 
dissected (the payload is shown as data).

svn path=/trunk/; revision=30654
 2009-10-21 08:01:35 +00:00
Jeff Morriss
4b6e25c627 s/#if HAVE_KERBEROS/#ifdef HAVE_KERBEROS/ 
svn path=/trunk/; revision=30649
 2009-10-20 20:26:51 +00:00
Jeff Morriss
f687349c04 Another, more sensible, attempt to fix the Win64 build. 
svn path=/trunk/; revision=30641
 2009-10-20 16:40:00 +00:00
Anders Broman
e12ab4d346 From Gerasimos Dimitriadis: 
DTAP: Expert info warning when BCD number malformed
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4143

svn path=/trunk/; revision=30637
 2009-10-20 14:42:58 +00:00
Jeff Morriss
d4d62e3e0d Try to get it compiling on Win64 
svn path=/trunk/; revision=30636
 2009-10-20 14:12:41 +00:00
Stig Bjørlykke
d43aab714c From Jakub Zawadzki: 
Make it compile without kerberos.

svn path=/trunk/; revision=30634
 2009-10-20 10:20:14 +00:00
Stig Bjørlykke
a34a6bee5e Extern declare hf_nt_cs_len and hf_nt_cs_size. 
svn path=/trunk/; revision=30633
 2009-10-20 10:03:55 +00:00
Ronnie Sahlberg
3bb1c2cbd4 From Matthieu Patou 
schannel decryption


svn path=/trunk/; revision=30631
 2009-10-20 08:44:26 +00:00
Stig Bjørlykke
33987544f9 Removed some unused prototypes. 
svn path=/trunk/; revision=30630
 2009-10-20 08:27:25 +00:00
Anders Broman
a85999a691 Fix higlight the correct hex value and add a value_string. 
svn path=/trunk/; revision=30629
 2009-10-20 07:42:27 +00:00
Anders Broman
923b04dd82 From Gerasimos Dimitriadis: 
DTAP: Various enhancements.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4142

svn path=/trunk/; revision=30628
 2009-10-20 07:33:01 +00:00
Anders Broman
40447d1c12 Updated decoding of GMM Cause to V8.6.0, i.e. added cause code 0x19 - "Not authorized for this CSG". Changed to use a range_string. 
Based on 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4132

svn path=/trunk/; revision=30627
 2009-10-20 03:13:56 +00:00
Bill Meier
bd8bb405bd From Matt Watchinski: OMRON-FINS dissector 
(with some restructuring and cleanup by me).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3226

svn path=/trunk/; revision=30625
 2009-10-20 00:12:09 +00:00
Jaap Keuter
288927bc46 Adding RFC 2228 FTP replies. 
svn path=/trunk/; revision=30623
 2009-10-19 21:22:23 +00:00
Jaap Keuter
f55ec2aeff From Jouni Malinen: 
WPS encodes Bool attributes as single-octet values. Selected Registrar
attribute is parsed correctly (packet-wps.c), but many of the other Bool
attributes are marked incorrectly to use two-octet fields. This results in
showing incorrect octets for some of the attributes and incorrectly marking
frames invalid if a Bool attribute is included as the last attribute in a WPS
IE.

svn path=/trunk/; revision=30622
 2009-10-19 18:36:34 +00:00
Stig Bjørlykke
7b138b5455 Use unsigned int for flags to avoid another warning. 
svn path=/trunk/; revision=30615
 2009-10-19 13:29:01 +00:00
Stig Bjørlykke
17aae178a9 Various code cleanup: 
- Added standard copyright boiler plate
- Made all local functions static
- Added several checks for valid pointers
- Fixed some variable shadowing
- Fixed some printf formats (%p)
- Removed unused variables

svn path=/trunk/; revision=30613
 2009-10-19 13:22:45 +00:00
Jeff Morriss
46fc4eea81 new_octet_aligned_subset_bits(): call tvb_ensure_bytes_exist() before 
attmepting to malloc memory to ensure we've been asked to decode a reasonable
number of bits (and thus are asking for a reasonable number of bytes from
malloc()).

That should fix the fuzz failure in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4138

Add a comment to new_octet_aligned_subset() asking why we're resetting the
length to tvb_length()--that means we'll never throw an exception.

svn path=/trunk/; revision=30611
 2009-10-18 23:19:44 +00:00
Stig Bjørlykke
056c915e61 Removed unused argument in v2_attrval2str(). 
svn path=/trunk/; revision=30606
 2009-10-18 21:15:37 +00:00
Stig Bjørlykke
53c447a3aa Remove a shadowed variable. 
svn path=/trunk/; revision=30605
 2009-10-18 21:14:35 +00:00
Stig Bjørlykke
3587a1acb1 Use %f for double in printf. 
svn path=/trunk/; revision=30604
 2009-10-18 21:13:53 +00:00
Stig Bjørlykke
0fcef72fc6 Use correct type for udp port preference. 
svn path=/trunk/; revision=30603
 2009-10-18 21:13:17 +00:00
Stig Bjørlykke
c92177a771 Use %f for double in printf. 
Made some functions static.

svn path=/trunk/; revision=30602
 2009-10-18 20:14:04 +00:00
Jeff Morriss
6bbd17bcf9 Don't se_alloc() the conversation structure which contains pointers to two 
g_hash_tables that we then try to free in ros_reinit().  Instead, g_malloc()
the conversation structure and free it (along with the hash tables) in the
reinit function.

svn path=/trunk/; revision=30601
 2009-10-18 20:13:56 +00:00
Jeff Morriss
2d8acf2a74 Fix an off-by-one error (<= instead of <) that caused the dissector to 
reference uninitialized memory, possibly leading to a crash (found by turning
memory scrubbing on).

svn path=/trunk/; revision=30595
 2009-10-18 14:46:39 +00:00
Jaap Keuter
8809953430 From Kip McAtee: 
Suppress spurious packet length error message for LCP or IPCP in PPPoE. 

svn path=/trunk/; revision=30594
 2009-10-18 13:36:01 +00:00
Jaap Keuter
34f6f0d9e9 From Jouni Malinen: 
IEEE 802.11k added a new Action frame category: Public Action. I'm proposing
some initial code to recognize this and to add a placeholder for switch
statement that can be used for processing vendor specific Public Action frames
(they are defined in IEEE 802.11w).  

svn path=/trunk/; revision=30593
 2009-10-18 12:53:29 +00:00
Bill Meier
5d68a812ab Fix memory leak: re-init defragmentation tables each time a capture file is (re) opened. 
svn path=/trunk/; revision=30589
 2009-10-17 21:42:51 +00:00
Stig Bjørlykke
b7d116667f From Marton Nemeth: 
Add the ability to open JPEG/JFIF files directly.

From me:
Some code cleanup + add new file to cmake.

svn path=/trunk/; revision=30588
 2009-10-17 20:56:06 +00:00
Jaap Keuter
80424e5ced From Joe Eykholt: 
It would be nice to have dissection of the Fibre-Channel FCP 
"Sequence retransmission request" (SRR) request.

This is like an FC ELS request, but it has FC type FCP, so it's 
a little strange.  It seemed like the best place to put it is in 
packet-fcp.c but a slight hook is needed in packet-fc.c to 
recognize that packet-fcp is the correct dissector.

svn path=/trunk/; revision=30587
 2009-10-17 10:19:18 +00:00
Jeff Morriss
bba7f0977c Based on an issue presented in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4050 : 
Add an item and an expert info (warning) if there's more data in the tvb than the length parameter indicates.

svn path=/trunk/; revision=30585
 2009-10-16 22:15:58 +00:00
Bill Meier
81a03aca75 Another Oops: #include <stdio.h> *is* required ..... 
svn path=/trunk/; revision=30584
 2009-10-16 22:12:40 +00:00
Bill Meier
92c387a992 fid_table never used: remove it (Fixes very minor memory leak). 
svn path=/trunk/; revision=30583
 2009-10-16 22:05:49 +00:00
Bill Meier
09cfdb2530 Don't init fc_fragment_table twice via registered_init_routines... 
svn path=/trunk/; revision=30582
 2009-10-16 22:00:41 +00:00
Bill Meier
c4f5ac7cbc sna_reassembled_table never used: remove it; 
Move register_init_routine call to proto_register as per convention...

svn path=/trunk/; revision=30581
 2009-10-16 21:54:17 +00:00
Bill Meier
8e2f6a26cb data_reassembled_table not used: remove it. 
svn path=/trunk/; revision=30580
 2009-10-16 21:47:48 +00:00
Bill Meier
e2379fb4a1 Fix memory leak; init fragment_table & reassembled_table in registered init fcn; 
(Tables were being initted only at Wireshark startup in proto_register)

svn path=/trunk/; revision=30578
 2009-10-16 21:35:39 +00:00
Jaap Keuter
5ac529f786 From Joe Eykholt: 
The FIP dissector shows the VFID descriptor as a 2-byte string instead of the
correct UINT16 type.   Also, the name should be changed to just "VFID".

The "Fabric Name" field of the Fabric descriptor was incorrectly labeled.

Also, some lines grew to longer than 80 columns due to other patches.

svn path=/trunk/; revision=30577
 2009-10-16 21:26:51 +00:00
Bill Meier
f91657feb9 dtls_fragment_table never used; Remove it. 
Remove unneeded #includes.
Adjust some indentation & spacing.

svn path=/trunk/; revision=30576
 2009-10-16 21:17:57 +00:00
Bill Meier
7a43e8853b Oops: #include <stdio.h> *is* required ..... 
svn path=/trunk/; revision=30575
 2009-10-16 16:01:20 +00:00
Bill Meier
92307f0dda (Trivial) Fix a typo in a comment. 
svn path=/trunk/; revision=30574
 2009-10-16 15:28:21 +00:00
Bill Meier
22c70b409a #include <stdio.h> not req'd; Fix some typos in text strings; 
Adjust some indentation & spacing, reformat some long lines.

svn path=/trunk/; revision=30573
 2009-10-16 14:37:40 +00:00
Bill Meier
f59bf50023 Use GSlice instead of GMemChunks for GLib >= 2.10. Fixes a memory leak. 
svn path=/trunk/; revision=30572
 2009-10-16 14:22:00 +00:00
Anders Broman
77c3bfd8c1 From Gerasimos Dimitriadis: 
DTAP: Decoding of Text String in Network Name IE

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4121

svn path=/trunk/; revision=30571
 2009-10-16 10:38:42 +00:00
Ronnie Sahlberg
2ee73bdf0c add proper support for infolevel 105 for ff 
they are different.


svn path=/trunk/; revision=30568
 2009-10-16 06:17:55 +00:00
Ronnie Sahlberg
9339cf747c add dissection of infolevel 0x105 for findfirst 
this is actually identical to infolevel 0x104 in smb  while they differ 
in smb2


svn path=/trunk/; revision=30567
 2009-10-16 05:31:43 +00:00
Bill Meier
d4a921730b (Trivial) Fix a typo in a comment 
svn path=/trunk/; revision=30560
 2009-10-15 02:39:06 +00:00
Martin Mathieson
61eda9b14e Improve DL HARQ resend detection by storing multiple frames per UE. 
svn path=/trunk/; revision=30557
 2009-10-14 10:43:17 +00:00
Ronnie Sahlberg
edcd3abdeb From Matthieu Patou 
Update ntlmssp to automatically re-read the keytab file if it changes


svn path=/trunk/; revision=30556
 2009-10-14 07:22:40 +00:00
Martin Mathieson
af67d9d1d8 Status report bitmap can be empty, so add test. 
svn path=/trunk/; revision=30555
 2009-10-13 13:52:23 +00:00
Martin Mathieson
7e8d401265 Add detection for suspected DL retx (due to HARQ). Needed if logging is done on UE side of link. 
svn path=/trunk/; revision=30554
 2009-10-13 13:36:58 +00:00
Bill Meier
741bc8368e #include <stdio.h> not req'd; 
Adjust some spacing.

svn path=/trunk/; revision=30552
 2009-10-12 20:57:01 +00:00
Bill Meier
594855f394 Remove unneeded #includes; 
Use consistent indentation.

svn path=/trunk/; revision=30550
 2009-10-12 18:27:59 +00:00
Kovarththanan Rajaratnam
c82f5a7085 Make all global variables static 
svn path=/trunk/; revision=30548
 2009-10-12 16:59:12 +00:00
Kovarththanan Rajaratnam
913da7cda9 Remove temp files on (clean) exit 
svn path=/trunk/; revision=30547
 2009-10-12 16:57:23 +00:00
Anders Broman
d31ddb200f From Gerasimos Dimitriadis: 
DTAP: Facility IE resets PROTOCOL and INFO columns

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4110

svn path=/trunk/; revision=30545
 2009-10-12 15:38:16 +00:00
Anders Broman
5ba10f7062 From Gerasimos Dimitriadis: 
DTAP: Decoding of Emergency Number List IE

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4111

svn path=/trunk/; revision=30544
 2009-10-12 15:32:53 +00:00
Kovarththanan Rajaratnam
3a0ba6b1cb Let the pidl subdirectory indicate which protocols it contains 
svn path=/trunk/; revision=30540
 2009-10-12 15:07:56 +00:00
Stig Bjørlykke
fd2662b27f Added a check for num_opts to avoid a theoretical undefined behavior. 
svn path=/trunk/; revision=30537
 2009-10-12 14:43:09 +00:00
Stig Bjørlykke
30b31a46bb Initialize variables which may be used uninitialized. 
svn path=/trunk/; revision=30536
 2009-10-12 14:29:48 +00:00
Bill Meier
f479b75ea3 Remove #define which is no longer req'd. 
svn path=/trunk/; revision=30525
 2009-10-12 00:54:41 +00:00
Guy Harris
6e478c4f6b Initialize radius_call, so it's null if we don't pass through the code 
path that sets it.

svn path=/trunk/; revision=30524
 2009-10-12 00:32:34 +00:00
Bill Meier
14bda86689 Replace GMemChunks usage with se_alloc(); 
Remove unneeded #includes;
Fix some spacing.

svn path=/trunk/; revision=30523
 2009-10-12 00:31:37 +00:00
Bill Meier
dd44270387 Replace use of GMemChunks by se_alloc(); 
@include <stdlib.h> not req'd;
Use consistent indentation.

svn path=/trunk/; revision=30522
 2009-10-12 00:01:59 +00:00
Kovarththanan Rajaratnam
a58c31975e Don't col_set_str + col_append_xxx. Just add the string instead. 
svn path=/trunk/; revision=30521
 2009-10-11 17:37:56 +00:00
Kovarththanan Rajaratnam
81d9f3030d Remove more unused variables/forward declarations 
svn path=/trunk/; revision=30520
 2009-10-11 17:25:04 +00:00
Kovarththanan Rajaratnam
0dcf31b8bc Make some ett/hf variables static 
svn path=/trunk/; revision=30519
 2009-10-11 17:14:19 +00:00
Stig Bjørlykke
6d1dae6f28 Make all proto_* values static. 
svn path=/trunk/; revision=30516
 2009-10-11 16:24:29 +00:00
Stig Bjørlykke
782138e1aa Corrected some HF_FIELD values. 
svn path=/trunk/; revision=30510
 2009-10-11 14:34:33 +00:00
Stig Bjørlykke
0e80b37df3 Change from C++ comments to C comments. 
svn path=/trunk/; revision=30509
 2009-10-11 14:34:02 +00:00
Stig Bjørlykke
f47bd1e8bf Make ett_* values static. 
svn path=/trunk/; revision=30508
 2009-10-11 14:33:04 +00:00
Stig Bjørlykke
e0fbe7624b Make ett_nt_unicode_string static. 
svn path=/trunk/; revision=30507
 2009-10-11 14:32:36 +00:00
Kovarththanan Rajaratnam
4f2332256c Remove unused variable 
svn path=/trunk/; revision=30506
 2009-10-11 14:21:50 +00:00
Kovarththanan Rajaratnam
f86851262f Switch over to using seasonal memory since the mgcp dissector was using g_mem_chunks in a seasonal fashion (memory was only freed during file open) 
svn path=/trunk/; revision=30505
 2009-10-11 14:06:56 +00:00
Kovarththanan Rajaratnam
1e32410765 Switch over to using seasonal memory instead of g_mem_chunkS which are deprecated 
svn path=/trunk/; revision=30502
 2009-10-11 10:00:01 +00:00
Jörg Mayer
ec7380a6b1 Creatig static sublibs was not a good idea: 
=========================================================================
 "du -s build" with sublibs:
 396868  build
 -----------------------------------
 "du -s build" without sublibs:
 197588  build/
 =========================================================================
 tshark with sublibs:
 -rwxr-xr-x 1 jmayer users 27399706 2009-10-11 08:39 tshark*
 -----------------------------------
 tshark without sublibs:
 -rwxr-xr-x 1 jmayer users  226748 2009-10-11 09:05 tshark*
 =========================================================================

So undo the following patches:

 ------------------------------------------------------------------------
 r30459 | krj | 2009-10-10 07:08:48 +0200 (Sa, 10 Okt 2009) | 1 line
 
 Sort subdirectories alphabetically
 ------------------------------------------------------------------------
 r30458 | krj | 2009-10-10 07:03:36 +0200 (Sa, 10 Okt 2009) | 1 line
 
 Add epan/dissectors/CMakeLists.txt which creates a static dissectors library
 ------------------------------------------------------------------------
 --> readd!! *** r30443 | krj | 2009-10-09 21:43:42 +0200 (Fr, 09 Okt 2009) | 1 line
 
 Rename DISSECTOR_ASM_UTILS to LIBWIRESHARK_ASM_FILES since these files belongs to ep
 an not dissectors
 ------------------------------------------------------------------------
 r30442 | krj | 2009-10-09 21:17:26 +0200 (Fr, 09 Okt 2009) | 1 line
 
 Add epan/ftypes/CMakeLists.txt which creates a static ftypes library
 ------------------------------------------------------------------------
 r30441 | krj | 2009-10-09 21:13:01 +0200 (Fr, 09 Okt 2009) | 1 line
 
 Add epan/dfilter/CMakeLists.txt which creates a static dfilter library
 ------------------------------------------------------------------------
 r30440 | krj | 2009-10-09 21:05:29 +0200 (Fr, 09 Okt 2009) | 1 line
 
 Add epan/crypt/CMakeLists.txt which creates a static crypt library
 ------------------------------------------------------------------------
 r30439 | krj | 2009-10-09 20:22:22 +0200 (Fr, 09 Okt 2009) | 1 line
 
 Add epan/crc/CMakeLists.txt which creates a static crc library
 ------------------------------------------------------------------------

To avoid merge problems, I needed to revert r30443 as well, will readd this
one in my next patch.

svn path=/trunk/; revision=30494
 2009-10-11 07:28:26 +00:00
Kovarththanan Rajaratnam
08e0d21a4b Remove redundant forward declarations 
svn path=/trunk/; revision=30485
 2009-10-11 04:38:42 +00:00
Kovarththanan Rajaratnam
bae07625ce Don't clear INFO column. We do that implicitly when we do a col_add_fstr(). 
svn path=/trunk/; revision=30484
 2009-10-11 04:36:43 +00:00
Kovarththanan Rajaratnam
85181bcea1 Don't use C++ reserved keyword 'class' 
svn path=/trunk/; revision=30483
 2009-10-11 04:29:06 +00:00
Bill Meier
9f24b1870b Replace use of GMemChunk by se_alloc; 
This fixes a major memory leak in the NCP dissector
caused by the fact that "in recent versions of GLib" (>= 2.10 ?)
g_mem_chunk_destroy doesn't actually free up the mem_chunk memory.

Note that there still appears to be one or more smaller
memory leaks somehow associated with NCP dissection.

Example:

A 40M capture file with mostly NCP frames which resulted in a memory
usage increase of about 20M each time the file was reloaded now results 
in a 400K-800K memory usage increase each time the file is reloaded.

(If NCP dissection is disabled, there is minimal memory expansion
each time the file is reloaded).


svn path=/trunk/; revision=30481
 2009-10-10 21:13:16 +00:00
Bill Meier
17a2e0b460 Fix a benign no-effect bug; 
Use consistent indentation.

svn path=/trunk/; revision=30480
 2009-10-10 17:49:28 +00:00
Bill Meier
9ac4174e41 Use consistent indentation 
svn path=/trunk/; revision=30479
 2009-10-10 16:57:20 +00:00
Kovarththanan Rajaratnam
b57e27ef8e ns-cert-ext -> ns_cert_exts to make directory name consistent with filenames 
svn path=/trunk/; revision=30478
 2009-10-10 14:20:33 +00:00
Kovarththanan Rajaratnam
19ee815ea4 Regenerate asn1 dissectors (no functionality change) 
svn path=/trunk/; revision=30476
 2009-10-10 13:39:14 +00:00
Kovarththanan Rajaratnam
251124a935 Introduce PROTOCOL_NAME variable in makefiles 
svn path=/trunk/; revision=30467
 2009-10-10 08:33:05 +00:00
Kovarththanan Rajaratnam
1f57b83867 Correct path to pidl 
svn path=/trunk/; revision=30466
 2009-10-10 08:14:38 +00:00
Kovarththanan Rajaratnam
bf2ec50430 Autogenerating epan/dissectors/dcerpc/* now works 
svn path=/trunk/; revision=30465
 2009-10-10 08:10:28 +00:00
Kovarththanan Rajaratnam
0c8dbe1b49 Only dump to stderr if IDL2WRS_DEBUG is defined 
svn path=/trunk/; revision=30464
 2009-10-10 08:02:57 +00:00
Kovarththanan Rajaratnam
64e717ee94 First stab at autogenerating budb dissector 
svn path=/trunk/; revision=30463
 2009-10-10 06:45:04 +00:00
Kovarththanan Rajaratnam
142131917c Compile and link idl2wrs 
svn path=/trunk/; revision=30460
 2009-10-10 05:35:21 +00:00
Kovarththanan Rajaratnam
c3f68b724d Add epan/dissectors/CMakeLists.txt which creates a static dissectors library 
svn path=/trunk/; revision=30458
 2009-10-10 05:03:36 +00:00
Kovarththanan Rajaratnam
78b0ee16e2 Backport r29665 to template file so that the change is not overwritten when we regenerate the dissector 
svn path=/trunk/; revision=30455
 2009-10-09 21:41:06 +00:00
Kovarththanan Rajaratnam
9490d1b74c Regenerate asn1 dissectors (no change, only some line offset changes) 
svn path=/trunk/; revision=30454
 2009-10-09 21:34:49 +00:00
Kovarththanan Rajaratnam
124f16e826 Rename gsmmap -> gsm_map for consistency 
svn path=/trunk/; revision=30453
 2009-10-09 21:33:18 +00:00
Kovarththanan Rajaratnam
acb940488b Make a few variables static 
svn path=/trunk/; revision=30451
 2009-10-09 21:06:56 +00:00
Kovarththanan Rajaratnam
1ed0657e50 Remove unused variable 
svn path=/trunk/; revision=30450
 2009-10-09 21:03:07 +00:00
Kovarththanan Rajaratnam
a831d2d2ca (Windows only) Make sure that register.c depends on make-dissector-reg.py and make-dissector-reg 
svn path=/trunk/; revision=30448
 2009-10-09 20:53:33 +00:00
Jeff Morriss
fc7304c1a2 If we're on Windows and we don't have kerberos, define a dummy version of read_keytab_file_from_preferences to keep the linker happy (since this function is in libwireshark.def). 
svn path=/trunk/; revision=30445
 2009-10-09 20:16:23 +00:00
Bill Meier
f99ca83a8c hf[]: Use NULL for "blurb" instead of dup or empty test string; 
hf[]: Add note about dup filter names;
#include <stdio.h>, <stdlib.h> & <string.h> not needed.

svn path=/trunk/; revision=30432
 2009-10-09 15:46:39 +00:00
Bill Meier
b97e510b9b hf[]: Use NUL for "blurb" instead of empty text string; 
#include <stdio.h> & <stdlib.h> not needed.

svn path=/trunk/; revision=30431
 2009-10-09 15:36:20 +00:00
Bill Meier
3f585abf22 hf[]: Use NULL for "blurb" instead of dup or empty text string; 
#include <stdio.h> & <stdlib.h> not needed.

svn path=/trunk/; revision=30430
 2009-10-09 15:30:32 +00:00
Bill Meier
d23ecf8afb hf[]: Use NULL for "blurb" instead of dup or empty text string; 
#include <stdio.h>, <stdlib.h> not needed.

svn path=/trunk/; revision=30429
 2009-10-09 15:22:38 +00:00
Anders Broman
330b2ce091 From Gerasimos Dimitriadis: 
DTAP: Wrong decoding of ITC in Bearer Capability IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4108

svn path=/trunk/; revision=30426
 2009-10-09 10:14:00 +00:00
Kovarththanan Rajaratnam
49be939059 Add common include file (boiler plate) 
svn path=/trunk/; revision=30424
 2009-10-09 09:34:07 +00:00
Kovarththanan Rajaratnam
3b20964c84 Update makefiles to use new template names 
svn path=/trunk/; revision=30423
 2009-10-09 09:16:58 +00:00
Kovarththanan Rajaratnam
3199e524c9 Give the template filenames more uniqueness 
svn path=/trunk/; revision=30422
 2009-10-09 09:12:59 +00:00
Kovarththanan Rajaratnam
58217b6aa0 Introduce intermediate variables: PROTOCOL_NAME and IDL2WRS 
svn path=/trunk/; revision=30419
 2009-10-09 08:57:52 +00:00
Kovarththanan Rajaratnam
25fd70c3f1 Introduce intermediate variables: PROTOCOL_NAME and IDL2WRS 
svn path=/trunk/; revision=30418
 2009-10-09 08:57:10 +00:00
Kovarththanan Rajaratnam
97c5c65bd5 Introduce intermediate variables: PROTOCOL_NAME and IDL2WRS 
svn path=/trunk/; revision=30417
 2009-10-09 08:55:59 +00:00
Anders Broman
4d2e653901 From Didier Gautheron: 
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107

svn path=/trunk/; revision=30415
 2009-10-09 07:24:33 +00:00
Anders Broman
46aa5c44de From Tobias Witek: 
New protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321).
This does not currently compile cleanly but checking it in to be worked on.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495

svn path=/trunk/; revision=30414
 2009-10-09 06:37:48 +00:00
Ronnie Sahlberg
6c7cf66046 explicitely cast a guin64 to int to avoid compile warnings 
svn path=/trunk/; revision=30412
 2009-10-09 04:19:45 +00:00
Bill Meier
6645d6e47d Fix code so it actually pads a length to an 8 byte boundary. 
svn path=/trunk/; revision=30406
 2009-10-08 16:13:53 +00:00
Kovarththanan Rajaratnam
ad7042d2a4 calculate_crc32c -> crc32c_calculate for proper 'namespacing' 
svn path=/trunk/; revision=30405
 2009-10-08 15:10:43 +00:00
Kovarththanan Rajaratnam
a9ed97b344 From Gerasimos Dimitriadis via. bug 4104: 
When dissecting a h248 message, col_set_str is called with a string from the ephemeral pool and an assertion fails.

svn path=/trunk/; revision=30398
 2009-10-08 13:17:51 +00:00
Jaap Keuter
fe2a12d423 Clean up header fields. 
svn path=/trunk/; revision=30395
 2009-10-08 05:43:19 +00:00
Jaap Keuter
75f1e13c12 Cleanup header fields. 
svn path=/trunk/; revision=30394
 2009-10-07 23:08:22 +00:00
Guy Harris
3f8748951f Fix some LLP64 issues. 
svn path=/trunk/; revision=30393
 2009-10-07 22:36:33 +00:00
Jeff Morriss
4c70f4fad0 Get it compiling when we don't have kerberos libraries. 
svn path=/trunk/; revision=30392
 2009-10-07 21:00:14 +00:00
Jeff Morriss
1bb3148350 From Gregor Jasny via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4073 : 
This patch adds the functionality to decode short capabilies.

svn path=/trunk/; revision=30391
 2009-10-07 19:46:28 +00:00
Anders Broman
1060fd1ede Reverting previous patch as requested by Ronnie. 
svn path=/trunk/; revision=30390
 2009-10-07 15:41:13 +00:00
Anders Broman
6de05a0476 Make the windows build compile again. 
(Probably not the right fix).

svn path=/trunk/; revision=30388
 2009-10-07 09:47:45 +00:00
Stig Bjørlykke
b7d8cd1c6a Switch to using tvb_new_subset_remaining() in .cnf files. 
svn path=/trunk/; revision=30386
 2009-10-07 07:59:11 +00:00
Stig Bjørlykke
843459d075 Made dissect_pres() static. 
Added changes from r29446 to .cnf file:
 Switch a bunch of dissectors over to using tvb_new_subset_remaining()

svn path=/trunk/; revision=30385
 2009-10-07 07:47:41 +00:00
Ronnie Sahlberg
d86f67b925 add a new function read_keytab_file_from_preferences(void) 
that can be called by dissectoirs using kerberos keytab files.
This function will load a new keytab file on demand, if it is changed in 
the preferences.

The previous code had you save the preferences and then restart 
wireshark which is suboptimal from a user friendly perspective



svn path=/trunk/; revision=30384
 2009-10-07 07:03:33 +00:00
Ronnie Sahlberg
c177dd5a0f new samr compiled as a test by the samba4 pidl compiler from mainline 
svn path=/trunk/; revision=30383
 2009-10-07 07:01:55 +00:00
Jeff Morriss
6a5182650c malloc() and free() are prohibited APIs, use the glib equivalents instead. 
svn path=/trunk/; revision=30379
 2009-10-07 00:45:39 +00:00
Jaap Keuter
951c60acb8 From Andreas Becker: 
Add a subdissector Table for BACnet MSTP Frames.

svn path=/trunk/; revision=30378
 2009-10-06 22:59:33 +00:00
Stig Bjørlykke
1559ec3e5f Avoid dereference of null pointer. 
svn path=/trunk/; revision=30377
 2009-10-06 19:21:29 +00:00
Anders Broman
bc9a809b65 From Didier Gautheron: 
ep memory can't be used for tvbs defined as data_source.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4054

svn path=/trunk/; revision=30376
 2009-10-06 19:15:58 +00:00
Anders Broman
0f4d4344dd From Gerasimos Dimitriadis: 
GSM MAP: an-APDU not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4095

svn path=/trunk/; revision=30375
 2009-10-06 19:04:29 +00:00
Anders Broman
1ef7157d71 From Gerasimos Dimitriadis: 
Mobile Classmark3 wrong dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4082

svn path=/trunk/; revision=30372
 2009-10-06 18:51:11 +00:00
Kovarththanan Rajaratnam
cec0e21e2b Use ep_alloc() 
svn path=/trunk/; revision=30367
 2009-10-06 14:20:59 +00:00
Kovarththanan Rajaratnam
71f7469141 Don't include unistd.h 
svn path=/trunk/; revision=30360
 2009-10-06 13:21:44 +00:00
Anders Broman
809e9e9e71 Make it compile on windows. 
svn path=/trunk/; revision=30357
 2009-10-06 11:54:08 +00:00
Ronnie Sahlberg
161667e6bd From Matthieu Patou, 
add code to decrypt ntlmv1 and v2 traffic





svn path=/trunk/; revision=30355
 2009-10-06 09:13:57 +00:00
Ronnie Sahlberg
75b1534c7f more updates to samr to harmonize it with samba 
svn path=/trunk/; revision=30354
 2009-10-06 08:07:17 +00:00
Stig Bjørlykke
999ab12945 Use IANA assigned port number as default UDP port. 
svn path=/trunk/; revision=30352
 2009-10-06 06:54:18 +00:00
Stig Bjørlykke
4d5f636a35 Regenerated to match spec files. 
svn path=/trunk/; revision=30350
 2009-10-05 21:41:35 +00:00
Stig Bjørlykke
50be430dab Return from dissect_snmp_VarBind() when detecting invalid oid. 
svn path=/trunk/; revision=30341
 2009-10-05 18:13:23 +00:00
Stig Bjørlykke
2315117682 Initialize ip_addr to avoid an uninitialized warning. 
svn path=/trunk/; revision=30335
 2009-10-05 16:52:59 +00:00
Stig Bjørlykke
4593ce5ce8 Initialize some values to avoid uninitialized warnings. 
svn path=/trunk/; revision=30334
 2009-10-05 16:48:20 +00:00
Stig Bjørlykke
d200281ff6 Initialize u32BoundElements. 
svn path=/trunk/; revision=30333
 2009-10-05 16:40:38 +00:00
Stig Bjørlykke
be0f4aa44b Moved the block for second octet to avoid a warning about an uninitialized 
variable.

svn path=/trunk/; revision=30332
 2009-10-05 16:36:31 +00:00
Stig Bjørlykke
0488967f29 Corrected check for dtmEgprsHighMultiSlotClassPresent. 
svn path=/trunk/; revision=30331
 2009-10-05 16:33:41 +00:00
Stig Bjørlykke
ea3139f395 Rewrote fc_sof_t and fc_eof_t from enum to defines, as enum 
is defined as signed int.

svn path=/trunk/; revision=30328
 2009-10-05 15:17:41 +00:00
Stig Bjørlykke
fad8c1105e Fixed a signed/unsigned warning. 
svn path=/trunk/; revision=30327
 2009-10-05 15:16:11 +00:00
Anders Broman
d2f6aaa4d1 Change a refrerence. 
svn path=/trunk/; revision=30326
 2009-10-05 08:33:55 +00:00
Anders Broman
f0aaa035a4 From Gerasimos Dimitriadis: 
TCAP problem with indefinite length 'components' SEQ OF.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4053

svn path=/trunk/; revision=30319
 2009-10-04 19:25:46 +00:00
Kovarththanan Rajaratnam
b993cb61d9 RIP packet-6lowpan.h 
svn path=/trunk/; revision=30318
 2009-10-04 18:51:37 +00:00
Bill Meier
bb8fc20cd3 1. There doesn't seem to be a need for a separate .h file; 
2. Move prototype declarations to after the struct declarations
   used by the prototypes.
3. Fix some typos.

svn path=/trunk/; revision=30310
 2009-10-04 17:50:39 +00:00
Kovarththanan Rajaratnam
7a3721dcea Whitespace changes 
svn path=/trunk/; revision=30301
 2009-10-04 14:59:18 +00:00
Anders Broman
18f9aed137 Atemt to fix compilation of packet-dcerpc.c for Windows. 
svn path=/trunk/; revision=30296
 2009-10-04 10:30:48 +00:00
Anders Broman
1888382b1b Atemt to fix compilation of samr for Windows. 
svn path=/trunk/; revision=30294
 2009-10-04 09:53:05 +00:00
Ronnie Sahlberg
400c0c987b more merges from samba samr idl file 
svn path=/trunk/; revision=30292
 2009-10-04 09:00:47 +00:00
Ronnie Sahlberg
384aa6cdfe more merges from the samba samr idl file 
svn path=/trunk/; revision=30290
 2009-10-04 08:34:25 +00:00
Ronnie Sahlberg
95c9089037 use a fake dcerpc_call_data structure before we call into the dcerpc 
helpers


svn path=/trunk/; revision=30289
 2009-10-04 08:33:45 +00:00
Ronnie Sahlberg
0c00fbe644 we must create a fake dcerpc_call_value strucure before we call into the 
dcerpc helpers


svn path=/trunk/; revision=30288
 2009-10-04 08:27:17 +00:00
Ronnie Sahlberg
28cb748f56 we must create a fake dcerpc_call_value structure when we call into the 
dcerpc helpers


svn path=/trunk/; revision=30286
 2009-10-04 08:24:04 +00:00
Ronnie Sahlberg
b6479d592c update the string helpers to be ndr64 aware 
svn path=/trunk/; revision=30285
 2009-10-04 08:11:09 +00:00
Ronnie Sahlberg
c0e3180e9b update dissect_ndr_nt_PSID_ARRAY() to be ndr64 aware 
svn path=/trunk/; revision=30283
 2009-10-04 07:57:45 +00:00
Kovarththanan Rajaratnam
e5f6a7b44e Don't clear and append string to column. Just add it (which will clear the column) 
svn path=/trunk/; revision=30279
 2009-10-04 07:04:32 +00:00
Kovarththanan Rajaratnam
c7b5a98682 We don't use preferences so if (!init) not required 
svn path=/trunk/; revision=30278
 2009-10-04 06:53:05 +00:00
Ronnie Sahlberg
8805b149eb more samr updates for ndr64 
svn path=/trunk/; revision=30273
 2009-10-04 05:44:18 +00:00
Ronnie Sahlberg
061284dbbd merge some changes to samr from the samba idl 
svn path=/trunk/; revision=30272
 2009-10-04 04:14:49 +00:00
Jeff Morriss
50cec93579 Fix a couple (false) uninitialized variable warnings. 
svn path=/trunk/; revision=30271
 2009-10-03 22:47:41 +00:00
Michael Tüxen
923fbf0b98 Make gcc happy. 
svn path=/trunk/; revision=30269
 2009-10-03 10:52:15 +00:00
Jaap Keuter
07a1f3875e From Owen Kirby: 
The attached patch adds a dissector for IPv6 over IEEE 802.15.4 (aka 6LoWPAN).
The protocol is specified in RFC 4944. This dissector also processes the
6LoWPAN draft header compression scheme in draft-ietf-6lowpan-hc-05.

svn path=/trunk/; revision=30268
 2009-10-03 10:06:19 +00:00
Kovarththanan Rajaratnam
939fe90d9c Guard against NULL pointers 
svn path=/trunk/; revision=30266
 2009-10-03 08:26:32 +00:00
Ronnie Sahlberg
e6a48cb668 rename 2or4 to a new type guint1632 and call the dissector for this 
function   dissect_ndr_uint1632()


svn path=/trunk/; revision=30265
 2009-10-03 05:23:48 +00:00
Ronnie Sahlberg
343b961a48 rename dissect_ndr_4or8 to dissect_ndr_uint3264 to match hte name of 
the new datatype uint3264.
create a fake guint3264 type as well


svn path=/trunk/; revision=30264
 2009-10-03 05:16:51 +00:00
Ronnie Sahlberg
7783d0f03e add a helper that supports decoding either a 16 or 32 bit integer based 
on whether nrd or ndr64 is used.


svn path=/trunk/; revision=30263
 2009-10-03 04:49:04 +00:00
Ronnie Sahlberg
ec886a00e2 make dissect_ndr_nt_SID handle ndr64 
svn path=/trunk/; revision=30262
 2009-10-03 03:50:30 +00:00
Ronnie Sahlberg
a6fb5ccdf2 update the handmarshalled code in samr.cnf to handle ndr64 encoding 
svn path=/trunk/; revision=30261
 2009-10-03 03:39:41 +00:00
Ronnie Sahlberg
b70ee1705d a new samr dissector, created using samba PIDL with ndr64 support 
svn path=/trunk/; revision=30259
 2009-10-03 02:49:04 +00:00
Ronnie Sahlberg
e7c7ec44db pild uses a magic alignment of 5 to mean align either to 4 or 8 bytes 
depending on if ndr or ndr64 is used.


svn path=/trunk/; revision=30258
 2009-10-03 02:44:31 +00:00
Jeff Morriss
37aa66532a From Peter Harris via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4067 : 
This patch adds enum support to x11-process-xcb.pl

svn path=/trunk/; revision=30257
 2009-10-03 01:56:10 +00:00
Ronnie Sahlberg
d85de66920 initial support to handle conformance data for NDR64. 
Conformance data items are 4 bytes in NDR but 8 bytes in NDR64


svn path=/trunk/; revision=30256
 2009-10-03 01:12:34 +00:00
Ronnie Sahlberg
d7bdab239c update the alignment for UserInfo so it handles either NDR or NDR64. 
This should be done by PIDL once it gets updated.


svn path=/trunk/; revision=30255
 2009-10-03 00:13:13 +00:00
Ronnie Sahlberg
a9aefe77af add a new macro to do alignment to either 4 or 8 bytes depending on if 
we use ndr or ndr64.
we need this since some structures change their alignment depending on 
the transfer syntax used.


svn path=/trunk/; revision=30254
 2009-10-03 00:10:35 +00:00
Ronnie Sahlberg
0a9289108d teach the dce/rpc pointer dissector about ndr64 and make it dissect 
pointers as 8 byte entities when ndr64 is negotiated


svn path=/trunk/; revision=30253
 2009-10-03 00:03:48 +00:00
Jaap Keuter
d200c2b75e From Jared Renzullo: 
The Cops dissector does not support the IPv6 Classifier object which was added
to PCMM in the I04 spec. The object is identified by Snum = 6, Stype = 3.

svn path=/trunk/; revision=30250
 2009-10-02 17:17:20 +00:00
Jeff Morriss
ef267649c5 One of those if(check_col)'s was hiding another condition (should have been looking closer). Fixes the fuzz failure in bug 4074. 
svn path=/trunk/; revision=30248
 2009-10-02 13:04:00 +00:00
Anders Broman
801f0458e4 Update to 3GPP TS 24.301 V9.0.0 (2009-09) 
svn path=/trunk/; revision=30246
 2009-10-02 09:23:46 +00:00
Jaap Keuter
1551cccaff From Francesco Fondelli: 
Back in August 2002 the check-sum field was removed from the
LMP specification (draft-ietf-ccamp-lmp-05).  This patch aligns
packet-lmp.c dissector with RFC 4204.

svn path=/trunk/; revision=30244
 2009-10-02 07:01:20 +00:00
Jeff Morriss
469012ca87 From Gregor Jasny via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4065 : 
Expose the FNAC family and subtype via a hf_ value so you can filter for
specific messages.

From me:

Re-arrange the code a bit: put dissect_aim() at the bottom near the
registration functions.  Remove unnecessary forward declarations.

Reindent a bunch.

Remove a couple check_col() calls; leave one in since it protects several
other calls.

svn path=/trunk/; revision=30243
 2009-10-01 19:19:58 +00:00
Anders Broman
131296f6f0 From Gerasimos Dimitriadis: 
DTAP decoding of Alerting Pattern IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4072

svn path=/trunk/; revision=30242
 2009-10-01 18:38:14 +00:00
Anders Broman
9967ec683f From Vincent Helfre: 
Update the LTE RRC dissector to september 29 version.

svn path=/trunk/; revision=30241
 2009-10-01 18:22:16 +00:00
Kovarththanan Rajaratnam
1a201e72de Don't pass in ephemeral allocated string to col_set_str() 
Fixed https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4071

svn path=/trunk/; revision=30238
 2009-10-01 15:14:43 +00:00
Anders Broman
8537091ce8 Update to 3GPP TS 36.413 V9.0.0 (2009-09) 
svn path=/trunk/; revision=30232
 2009-10-01 14:21:40 +00:00
Anders Broman
5e6b38d75a Update to 3GPP TS 36.413 V8.7.0 (2009-09) 
svn path=/trunk/; revision=30231
 2009-10-01 13:48:36 +00:00
Ronnie Sahlberg
2ea2589afb we need to copy the information about the transport syntax, i.e. i fit 
is ndr64 or not, from the bind information to the data we store for each 
individual pdu, since the trnasport syntax may change dynamically back 
and forth between "normal" and "ndr64" on the same conversation.



svn path=/trunk/; revision=30226
 2009-10-01 08:55:25 +00:00
Jaap Keuter
64d1ab68bc From Jared Renzullo: 
The IPv6 SubscriberId object, which was added in the I04 spec, is not supported
in the cops dissector for PCMM. It was already supported for DQOS, however. The
object is identified by S-num = 3, S-type = 2.

svn path=/trunk/; revision=30224
 2009-09-30 21:07:55 +00:00
Stig Bjørlykke
332502e77a Removed unused variable. 
svn path=/trunk/; revision=30223
 2009-09-30 19:48:52 +00:00
Stig Bjørlykke
448523881e Removed 'l' modifier for %g, as it will be ignored. 
svn path=/trunk/; revision=30222
 2009-09-30 19:48:10 +00:00
Stig Bjørlykke
6f6497755a Added some check for a valid beep_frame_data. 
Untabify file.

svn path=/trunk/; revision=30220
 2009-09-30 19:33:39 +00:00
Bill Meier
bf85ecb308 Rename hfinfo.ref_count to hfinfo.ref_type since that's now how it's used. 
svn path=/trunk/; revision=30216
 2009-09-30 14:02:49 +00:00