Martin Mathieson
04078dd997
Improve expert and info column strings reporting OOB events.
...
svn path=/trunk/; revision=30859
2009-11-08 00:39:22 +00:00
Guy Harris
be5c1a9e27
Squelch compiler warnings.
...
svn path=/trunk/; revision=30858
2009-11-07 19:56:13 +00:00
Jaap Keuter
71a48b6dbf
From Alex Volinsky:
...
This enhancement implements dissector for Downstream DOCSIS (Data over Cable)
frames, embedded into MPEG packets and encapsulated into L2TPv3 over IP
(DEPI/D-MPT encapsulation). This type of encapsulation is used in Modular Cable
Modem Termination System (M-CMTS) architecture for head-end components that
comply with DOCSIS.
DEPI, the Downstream External PHY Interface, is the interface between the
M-CMTS Core and the EQAM. More specifically, it is an IP Tunnel between the MAC
and PHY in a Modular CMTS system.
L2TPv3 is described in RFC3931.
DOCSIS DEPI data packet transport mechanism is described CM-SP-DEPI-I03-060728
(Downstream External PHY Interface - CableLabs specification)
The format of MPEG packet carrying DOCSIS data is described in
CM-SP-DRFI-I07-081209 (Data-Over-Cable Service Interface Specifications -
CableLabs specification).
svn path=/trunk/; revision=30857
2009-11-07 19:41:58 +00:00
Jaap Keuter
03730e3bc1
From Filipe David Borba Manana:
...
Since it was named Ethereal and up to today, Wireshark wrongly parses
the IPv4 header flags field:
* it considers it as a 4 bits wide field - according to RFC 791 its a 3 bits
wide field (first 3 bits of the 6th octect of the IPv4 header).
* if for example the DF bit is set, Wireshark displays the flag value as 0x04
(0100) when it should be 0x02 (010), idem for the MF flag.
Attached to this bug report, you can find a patch to fix the issue.
svn path=/trunk/; revision=30855
2009-11-07 11:24:05 +00:00
Jörg Mayer
9ee31d1d0e
cmake will now honor -Werror if configured (default: on)
...
svn path=/trunk/; revision=30852
2009-11-07 10:07:00 +00:00
Kovarththanan Rajaratnam
f6dfb9f323
Avoid possible NULL pointer dereference
...
svn path=/trunk/; revision=30851
2009-11-07 08:07:12 +00:00
Gerasimos Dimitriadis
4dbe3a5e3a
Fix for bug 4209:
...
After reading a SysID group, current_offset was off by 1
svn path=/trunk/; revision=30847
2009-11-06 21:20:17 +00:00
Kovarththanan Rajaratnam
f68d2fc933
Remove packet-umts_mac.c from DISSECTOR_INCLUDES
...
svn path=/trunk/; revision=30845
2009-11-06 14:56:28 +00:00
Anders Broman
b35647bb57
From Tobias Witek:
...
Enables correct RRC decoding from RLC.
svn path=/trunk/; revision=30843
2009-11-06 12:09:12 +00:00
Jaap Keuter
a1d82636c1
Add parentheses to satisfy the compiler.
...
svn path=/trunk/; revision=30842
2009-11-06 07:08:40 +00:00
Jörg Mayer
8ef22d4e08
Add a document reference
...
svn path=/trunk/; revision=30841
2009-11-06 06:14:19 +00:00
Jaap Keuter
e2246d08cd
From Owen Kirby:
...
We've discovered a number of bugs in the 6LoWPAN dissector,
and have fixed them in the following patch. The fixed bugs include:
- Incorrect UDP Checksum calculation.
- Incorrect link-local prefix when decompressing IPHC headers.
- Incorrect parsing of the UDP port numbers when not 8-byte aligned.
- Overflow of the datagram offset field when reassembling fragmented packets.
svn path=/trunk/; revision=30840
2009-11-05 22:39:00 +00:00
Anders Broman
54aa776069
From Tobias Witek:
...
w protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495
svn path=/trunk/; revision=30838
2009-11-05 21:54:06 +00:00
Anders Broman
110a5be310
Dissect Source-ToTarget-TransparentContainer in the intra LTE case.
...
svn path=/trunk/; revision=30837
2009-11-05 20:34:56 +00:00
Kovarththanan Rajaratnam
d10ca62304
Fix value strings in packet boundary lookup table
...
svn path=/trunk/; revision=30830
2009-11-05 07:36:02 +00:00
Gerald Combs
b11e3a7ea3
From Jason Rusmisel via bug 4199: Increase the maximum number of
...
template fields we handle from 20 to 30.
svn path=/trunk/; revision=30827
2009-11-05 01:01:01 +00:00
Anders Broman
6300621b52
Check if we have a handle for "v110".
...
svn path=/trunk/; revision=30823
2009-11-04 16:40:52 +00:00
Anders Broman
a8986a995b
Register by name.
...
svn path=/trunk/; revision=30822
2009-11-04 16:39:52 +00:00
Kovarththanan Rajaratnam
dc265696a1
tvb_format_text() always returns a non NULL pointer so don't check return value for NULL pointer
...
svn path=/trunk/; revision=30821
2009-11-04 16:08:47 +00:00
Anders Broman
83231fe94a
From Pascal Quantin:
...
[NAS EPS] Expert Info error triggered when decoding a Security Mode Complete message
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4203
svn path=/trunk/; revision=30820
2009-11-04 13:49:19 +00:00
Kovarththanan Rajaratnam
9b1cbfea87
Fix a couple of value_stringS to match BT 2.1
...
svn path=/trunk/; revision=30819
2009-11-04 12:49:19 +00:00
Kovarththanan Rajaratnam
1fc06caf57
Also apply rev 30817 to command complete events
...
svn path=/trunk/; revision=30818
2009-11-04 12:31:39 +00:00
Kovarththanan Rajaratnam
167a30a6ef
Append the opcode (that lead us to the command status) to the info column
...
svn path=/trunk/; revision=30817
2009-11-04 12:25:01 +00:00
Kovarththanan Rajaratnam
b5d8e71e1f
Correct "Sniff Subrating" typo
...
svn path=/trunk/; revision=30816
2009-11-04 12:14:30 +00:00
Stig Bjørlykke
c60a5b284e
Added offset fix from bug 4202, error introduced in r30770.
...
svn path=/trunk/; revision=30815
2009-11-04 11:41:05 +00:00
Jörg Mayer
ed5453d892
Fix printing of tuple values
...
svn path=/trunk/; revision=30814
2009-11-04 08:49:38 +00:00
Jaap Keuter
caeca294d6
From Robert Hogan:
...
Not incrementing tvb offset in two places in tn3270 dissector.
svn path=/trunk/; revision=30813
2009-11-04 06:58:42 +00:00
Jaap Keuter
8041e9732e
From Jason Rusmisel:
...
The netflow implementation has a bug where the code exists to extract four
fields from a packet, however, the decoder for these fields has not been
registered in proto_register_netflow in the hf_register_info array.
The fix is to include decoders for the fields in the proto_register_netflow.
svn path=/trunk/; revision=30809
2009-11-03 23:01:03 +00:00
Martin Mathieson
da15f9f5ff
Show how many NACKs appeared in status message root.
...
svn path=/trunk/; revision=30806
2009-11-03 16:39:01 +00:00
Anders Broman
64416202c6
From Pascal Quantin:
...
I just realized that I forgot to change one line to get a proper decoding of IMEI
svn path=/trunk/; revision=30805
2009-11-03 12:44:17 +00:00
Anders Broman
242db04e6b
From Pascal Quantin:
...
Small fixes for Attach Request message decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4198
svn path=/trunk/; revision=30803
2009-11-03 12:16:25 +00:00
Anders Broman
62ae894451
From Pascal Quantin :
...
[NAS EPS] Incorrect decoding of UE Network Capability IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4196
svn path=/trunk/; revision=30802
2009-11-02 22:37:34 +00:00
Anders Broman
1a79f3ead4
Fix Layer 3 Message Contents(?)
...
At least the trace at http://openbsc.gnumonks.org/trac/attachment/wiki/OpenBSCWithSCCP/bssmap_clean.pcap dissects correctly now.
svn path=/trunk/; revision=30799
2009-11-01 20:00:08 +00:00
Stig Bjørlykke
bbc109d1b6
Added some type renames.
...
svn path=/trunk/; revision=30798
2009-11-01 19:16:57 +00:00
Anders Broman
3da9d8fc41
From Holger Freyther:
...
GSM BSSMAP ChanType permitted indicator extension bit decoded wrongly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4185
svn path=/trunk/; revision=30797
2009-11-01 19:11:13 +00:00
Stig Bjørlykke
5c62502644
Added a UAT table to describe enterprise specific-trap types.
...
svn path=/trunk/; revision=30796
2009-11-01 18:45:43 +00:00
Anders Broman
72e8e8dbee
Update to 3GPP TS 25.331 V8.8.0 (2009-09)
...
svn path=/trunk/; revision=30795
2009-11-01 16:56:49 +00:00
Jaap Keuter
d3d53f1b1a
From Markus Koetter:
...
Wireshark fails dissecting dce rpc bind acks, if the bind request had more than 1 ctx.
svn path=/trunk/; revision=30790
2009-11-01 11:52:32 +00:00
Jaap Keuter
d1c54017f3
From Jesper Dangaard Brouer:
...
This patch set improves packet loss detection in for MPEG2 Transport Streams
(RFC 2250 / ISO/IEC 13818-1).
1. Improve loss detection by counting skipped TS frames (currently we only
detect a drop). (only store the info globally)
2. Introduce an analysis tree and record/count the info per TS frame.
svn path=/trunk/; revision=30789
2009-11-01 11:00:00 +00:00
Anders Broman
bfb16c1bcb
- Dissect Target-ToSource-TransparentContainer.
...
- Update to 3GPP TS 25.413 V8.4.0 (2009-09).
svn path=/trunk/; revision=30788
2009-11-01 10:52:17 +00:00
Anders Broman
f03a629ddc
Dissect ToTargetRNC-Container.
...
svn path=/trunk/; revision=30787
2009-10-31 23:21:08 +00:00
Jaap Keuter
0100407124
Fix for bug 4076:
...
Have the option to continue dissection of data even with failed FCS check.
svn path=/trunk/; revision=30786
2009-10-31 20:55:33 +00:00
Guy Harris
a212873733
The first field of a MAC Control frame isn't the "pause" field, it's the
...
opcode; an opcode of 0x0001 means PAUSE. Dissect the opcode field even
if it's not a PAUSE frame.
The second field of a PAUSE frame isn't the "quanta" field, it's the
pause_time field; it's in *units* of quanta.
Don't fetch fields until we need them (so we don't throw an exception if
they're missing until we actually look at them).
Clean up indentation.
svn path=/trunk/; revision=30785
2009-10-31 19:44:17 +00:00
Bill Meier
6b3f4e5a15
Verify bytes exist before doing heuristics check;
...
Registering the dissector publicly doesn't seem to be needed;
Fix a typo in a comment and also some indentation.
svn path=/trunk/; revision=30784
2009-10-31 16:22:50 +00:00
Jaap Keuter
1bde8c5f1f
From mehturt:
...
The following patch adds decoding of "trick mode" fields in MPEG PES packet.
svn path=/trunk/; revision=30783
2009-10-31 16:11:24 +00:00
Bill Meier
7aafce2885
Register dissectors in proto_reg_handoff (not proto_register) in the standard manner;
...
Use col_add_fstr instead of col_clear/col_append-fstr.
svn path=/trunk/; revision=30782
2009-10-31 14:43:05 +00:00
Kovarththanan Rajaratnam
81d90598d8
Remove incorrect comment which refered to a non existant header file
...
svn path=/trunk/; revision=30781
2009-10-31 13:06:15 +00:00
Kovarththanan Rajaratnam
cfb3172f33
Populate protocol column before digging into the buffer (we might throw an exception while doing that)
...
svn path=/trunk/; revision=30780
2009-10-31 13:03:12 +00:00
Kovarththanan Rajaratnam
3b5c05ddef
Make jmirror handle static
...
svn path=/trunk/; revision=30779
2009-10-31 12:54:07 +00:00
Jaap Keuter
0a0c397c52
From Wayne Brassem:
...
I have built and tested a new Wireshark dissector which decodes a mirrored
packet that has an additional prepended UDP header attached to it. The packet
format was designed by Juniper Networks.
svn path=/trunk/; revision=30777
2009-10-31 12:04:42 +00:00
Guy Harris
c9b5bc30d0
assert() doesn't throw an exception, it just immediately crashes the
...
app, and DISSECTOR_ASSERT() throws an exception, but claims the problem
is a dissector bug, not a malformed packet. Presumably the error in
question is the result of a malformed packet, so throw
ReportedBoundsError to indicate that (it's not really the *right*
exception, but the right exception doesn't exist).
svn path=/trunk/; revision=30776
2009-10-31 08:31:21 +00:00
Jaap Keuter
134e77034e
From Márton Németh:
...
When an unknown requests arrives try to parse it using the usual request format.
svn path=/trunk/; revision=30775
2009-10-30 22:46:30 +00:00
Jaap Keuter
a1e524ca85
From Márton Németh:
...
Add support for USB HUB class-specific requests as specified in USB 2.0 Chapter 11 Hub Specification.
svn path=/trunk/; revision=30774
2009-10-30 22:24:23 +00:00
Anders Broman
1a2f69aa03
Remove debug code
...
svn path=/trunk/; revision=30772
2009-10-30 16:25:11 +00:00
Anders Broman
77377a9d22
- Bitrate must be FT_UINT64
...
- Dissect HandoverCommand
svn path=/trunk/; revision=30771
2009-10-30 16:15:27 +00:00
Anders Broman
d3b7b182c1
- In new_octet_aligned_subset_bits() the length check must be on octet not bits.
...
- try to make the code a bit more readable.
svn path=/trunk/; revision=30770
2009-10-30 16:09:32 +00:00
Martin Mathieson
c120fa9b8f
Sequence number should be displayed in DEC, not HEX!
...
svn path=/trunk/; revision=30769
2009-10-30 15:56:43 +00:00
Stig Bjørlykke
a634ff0a08
Corrected name used for STANAG 4406.
...
svn path=/trunk/; revision=30768
2009-10-30 10:55:43 +00:00
Stig Bjørlykke
5c0369ba97
Apply r30376 to asn1 template files.
...
svn path=/trunk/; revision=30767
2009-10-30 10:21:35 +00:00
Stig Bjørlykke
55f080c9c8
Added SNMP to "Decode ASN.1 file as" list.
...
svn path=/trunk/; revision=30766
2009-10-30 10:05:28 +00:00
Jaap Keuter
5cd74a536c
Handle padded RTCP packets ending with SDES correctly as well.
...
svn path=/trunk/; revision=30764
2009-10-29 22:14:54 +00:00
Stig Bjørlykke
1e20ff2638
From Marton Nemeth via bug 4181:
...
Take the USB descriptor length from packet.
svn path=/trunk/; revision=30763
2009-10-29 21:51:20 +00:00
Stig Bjørlykke
6a2aae878d
From Marton Nemeth via bug 4173:
...
Parse USB HID class-specific requests.
svn path=/trunk/; revision=30762
2009-10-29 21:42:16 +00:00
Stig Bjørlykke
373fff9846
From Marton Nemeth via bug 4173:
...
Move bmRequestType field constants to header file.
svn path=/trunk/; revision=30761
2009-10-29 21:32:21 +00:00
Martin Mathieson
f36f5897ee
Tidy up info column output showing partial NACK.
...
svn path=/trunk/; revision=30760
2009-10-29 19:06:10 +00:00
Anders Broman
67697bad60
From Gerasimos Dimitriadis:
...
DTAP: Update of Reject Cause IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4179
svn path=/trunk/; revision=30759
2009-10-29 18:13:17 +00:00
Anders Broman
e2c0856e09
Fix a typo
...
svn path=/trunk/; revision=30754
2009-10-29 08:02:34 +00:00
Anders Broman
108ec05035
Export ToTargetRNC-Container.
...
svn path=/trunk/; revision=30752
2009-10-29 06:45:42 +00:00
Anders Broman
a26552a27f
Update to the Mars verion of the protocol and export HandoverCommand.
...
svn path=/trunk/; revision=30751
2009-10-29 06:19:36 +00:00
Martin Mathieson
2e3dc7f0f4
Flag errors with expert info.
...
svn path=/trunk/; revision=30748
2009-10-28 19:00:41 +00:00
Anders Broman
d5cfd0edc9
- Remove check_col.
...
- Make x2ap work.
svn path=/trunk/; revision=30746
2009-10-28 06:18:05 +00:00
Anders Broman
191f468caf
Missed an #include...
...
svn path=/trunk/; revision=30745
2009-10-28 05:13:31 +00:00
Anders Broman
cd8924f759
Update SCTP ppids, fix a faulty #define.
...
svn path=/trunk/; revision=30744
2009-10-28 05:09:32 +00:00
Anders Broman
423b8b31cd
From Fred Fierling:
...
Fixes bugs in dissection of write attributes, read reporting configuration, and
configure reporting clusters in the ZigBee Cluster Library.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4113
svn path=/trunk/; revision=30731
2009-10-27 19:13:57 +00:00
Anders Broman
26658ed017
From Francesco Fondelli:
...
RSVP extensions for G.709 Optical Transport Networks Control, RFC 4328
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4148
With some changes from me:
-(readme.developer:" Furthermore, 'display' field must be ORed with 'BASE_RANGE_STRING' (e.g. BASE_DEC|BASE_RANGE_STRING)."
- Prefix headerfields with hf_
- Remove check_col
svn path=/trunk/; revision=30727
2009-10-27 06:05:02 +00:00
Anders Broman
cff062cd44
From Herbert Lischka:
...
Minor changes to dissector packet-bacapp.c to solve some strange
views to ReadPropertyMultiple-Acknowledge frames.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4161
svn path=/trunk/; revision=30726
2009-10-27 05:20:19 +00:00
Martin Mathieson
b712bb0f19
Add a preference to control whether or not comment strings are scanned for oob LTE MAC messages. Scanning them is probably quite slow.
...
svn path=/trunk/; revision=30713
2009-10-26 16:40:57 +00:00
Martin Mathieson
eab33c1bb9
Change a filter string for consistency.
...
svn path=/trunk/; revision=30712
2009-10-26 16:39:46 +00:00
Martin Mathieson
afffcffff9
Add support for displaying/filtering some LTE MAC out-of-band events.
...
svn path=/trunk/; revision=30711
2009-10-26 15:39:00 +00:00
Anders Broman
6d8f1356ba
RelocationRequired incorrectly dissected.
...
svn path=/trunk/; revision=30710
2009-10-26 15:12:32 +00:00
Jaap Keuter
4bc1280033
From Jochen Bartl:
...
This patch fixes the display filter for the prefix length of IPv6 external
route updates and the length calculation of the destination address in
IPv6 route updates.
svn path=/trunk/; revision=30703
2009-10-26 07:00:15 +00:00
Anders Broman
565b8c922c
From Jakub Zawadzki:
...
Fix memleaks while creating kademlia hash.
svn path=/trunk/; revision=30702
2009-10-26 05:55:07 +00:00
Martin Mathieson
6dfb4d1f71
Add support for showing/filtering/resaving logged LTE strings.
...
svn path=/trunk/; revision=30700
2009-10-26 00:04:27 +00:00
Martin Mathieson
4474e0d25b
Label a short BSR as "short"
...
svn path=/trunk/; revision=30699
2009-10-25 23:03:11 +00:00
Balint Reczey
460e086f9e
Decode DSL Forum TR-101 PPPoE tags.
...
This fixes bug 3113.
svn path=/trunk/; revision=30697
2009-10-25 20:11:47 +00:00
Gerald Combs
771e9ef518
Option 2 (Time Offset) is signed.
...
svn path=/trunk/; revision=30695
2009-10-25 17:05:08 +00:00
Anders Broman
88bb44a51e
From Jakub Zawadzki:
...
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164
svn path=/trunk/; revision=30691
2009-10-25 11:43:30 +00:00
Stig Bjørlykke
337896f4c6
From Marton Nemeth via bug 4163:
...
Add support for input URBs.
svn path=/trunk/; revision=30690
2009-10-25 10:45:15 +00:00
Anders Broman
53e44c4a73
From Gerasimos Dimitriadis:
...
DTAP: MAP component of indefinite length within Facility IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4157
svn path=/trunk/; revision=30688
2009-10-25 10:14:47 +00:00
Stig Bjørlykke
1637e69118
No point passing a global pointer as a function argument.
...
Made check_ndmp_rm() and check_ndmp_hdr() static.
svn path=/trunk/; revision=30686
2009-10-24 16:30:11 +00:00
Stig Bjørlykke
a3750f1ccf
From Robert Simac via bug 3470:
...
Add the missing ndmp v4 messages, namely the:
NDMP_CONFIG_GET_EXT_LIST
NDMP_CONFIG_SET_EXT_LIST
This may serve as the 1st step into actual extensions (Snapvault etc)
dissector implementation.
svn path=/trunk/; revision=30684
2009-10-24 15:40:35 +00:00
Jaap Keuter
d90cb60f61
From Mithun Roy:
...
The primary header in bundle protocol contains some offset values(destination
scheme offset, destination ssp offset, source scheme offset, source ssp offset,
etc). These are the offsets within the dictionary if the length of the
dictionary length is greater than 0. But if the dictionary length is 0, then
these offset refer to node number and service number respectively(according to
compressed bundle header encoding). For example if destination scheme offset is
2 and the destination ssp offset is 1, then the destination
EID(<node_number>.<service_number>) is 2.1.
Currently the dtn dissector will consider these offsets to be actual offsets in
the dictionary even if the dictionary length is 0. So the values for the
EID's(destination, source, report, custodian) and their schemes are junk
values. For example if the destination scheme offset is 2 and the destination
ssp offset is 1 and the dictionary length is 0(which means the dictionary is
empty), then the destination scheme is 2 bytes after the beginning of the
metadata block(field after dictionary) and destination is 1 byte after the
beginning of the metadata block.
svn path=/trunk/; revision=30682
2009-10-24 11:19:23 +00:00
Jeff Morriss
350729607a
dissect_udp_bundle(): check if dissect_payload_header() or
...
display_metadata_block() return 0 (meaning they failed to decode something and
the offset was not incremented) rather than checking if the resulting offset
is 0.
This fixes the infinite loop reported in:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4156
svn path=/trunk/; revision=30672
2009-10-23 15:55:39 +00:00
Anders Broman
9db0d46eba
Forgot to remove IA5_7BIT_decode(unsigned char * dest, const unsigned char* src, int len);
...
svn path=/trunk/; revision=30671
2009-10-23 05:32:15 +00:00
Anders Broman
ea679ff697
From Gerasimos Dimitriadis:
...
DTAP: Decoding of subaddress information.
sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4150
svn path=/trunk/; revision=30670
2009-10-23 02:12:39 +00:00
Anders Broman
f82442badc
Move IA5_7BIT_decode to strutil.c
...
svn path=/trunk/; revision=30669
2009-10-23 01:56:09 +00:00
Martin Mathieson
f5b4b6e32f
Expert error if (non-padded) PDU is shorter than reported.
...
svn path=/trunk/; revision=30666
2009-10-22 17:22:27 +00:00
Martin Mathieson
0f8ee9cdf9
More long BSR fixes.
...
svn path=/trunk/; revision=30664
2009-10-22 11:45:40 +00:00
Martin Mathieson
b3f5ccdae0
Fix issues with long BSR format, and attach expert info for non-zero RAR TA to correct item.
...
svn path=/trunk/; revision=30663
2009-10-22 10:31:13 +00:00
Jaap Keuter
802dc7f334
From Greg Schwendimann:
...
The 802.3at Power Via MDI TLV dissector is incomplete as it does not decode the
last three bytes. I have attached a patch that decodes the type/source/priority,
PD requested power value, and PSE allocated power value fields.
svn path=/trunk/; revision=30662
2009-10-22 07:10:05 +00:00
Anders Broman
3faf5345ab
From Gerasimos Dimitriadis:
...
DTAP: Progress description depends on coding standard.
Changed to export value strings trough .h file
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4146
svn path=/trunk/; revision=30661
2009-10-22 05:28:53 +00:00
Jeff Morriss
d163d9cad7
Remove non-ASCII characters
...
svn path=/trunk/; revision=30656
2009-10-21 12:56:28 +00:00
Anders Broman
f5f2bf6ecd
From Gerasimos Dimitriadis:
...
DTAP: Call state depends on coding standard.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4145
svn path=/trunk/; revision=30655
2009-10-21 09:38:51 +00:00
Jaap Keuter
d42280adb1
From Joe Eykholt:
...
The Fibre-Channel Extended Link Service request REC (Read Exchange Concise)
is used in error recovery. It is currently identified as REC but not completely
dissected (the payload is shown as data).
svn path=/trunk/; revision=30654
2009-10-21 08:01:35 +00:00
Jeff Morriss
4b6e25c627
s/#if HAVE_KERBEROS/#ifdef HAVE_KERBEROS/
...
svn path=/trunk/; revision=30649
2009-10-20 20:26:51 +00:00
Jeff Morriss
f687349c04
Another, more sensible, attempt to fix the Win64 build.
...
svn path=/trunk/; revision=30641
2009-10-20 16:40:00 +00:00
Anders Broman
e12ab4d346
From Gerasimos Dimitriadis:
...
DTAP: Expert info warning when BCD number malformed
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4143
svn path=/trunk/; revision=30637
2009-10-20 14:42:58 +00:00
Jeff Morriss
d4d62e3e0d
Try to get it compiling on Win64
...
svn path=/trunk/; revision=30636
2009-10-20 14:12:41 +00:00
Stig Bjørlykke
d43aab714c
From Jakub Zawadzki:
...
Make it compile without kerberos.
svn path=/trunk/; revision=30634
2009-10-20 10:20:14 +00:00
Stig Bjørlykke
a34a6bee5e
Extern declare hf_nt_cs_len and hf_nt_cs_size.
...
svn path=/trunk/; revision=30633
2009-10-20 10:03:55 +00:00
Ronnie Sahlberg
3bb1c2cbd4
From Matthieu Patou
...
schannel decryption
svn path=/trunk/; revision=30631
2009-10-20 08:44:26 +00:00
Stig Bjørlykke
33987544f9
Removed some unused prototypes.
...
svn path=/trunk/; revision=30630
2009-10-20 08:27:25 +00:00
Anders Broman
a85999a691
Fix higlight the correct hex value and add a value_string.
...
svn path=/trunk/; revision=30629
2009-10-20 07:42:27 +00:00
Anders Broman
923b04dd82
From Gerasimos Dimitriadis:
...
DTAP: Various enhancements.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4142
svn path=/trunk/; revision=30628
2009-10-20 07:33:01 +00:00
Anders Broman
40447d1c12
Updated decoding of GMM Cause to V8.6.0, i.e. added cause code 0x19 - "Not authorized for this CSG". Changed to use a range_string.
...
Based on
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4132
svn path=/trunk/; revision=30627
2009-10-20 03:13:56 +00:00
Bill Meier
bd8bb405bd
From Matt Watchinski: OMRON-FINS dissector
...
(with some restructuring and cleanup by me).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3226
svn path=/trunk/; revision=30625
2009-10-20 00:12:09 +00:00
Jaap Keuter
288927bc46
Adding RFC 2228 FTP replies.
...
svn path=/trunk/; revision=30623
2009-10-19 21:22:23 +00:00
Jaap Keuter
f55ec2aeff
From Jouni Malinen:
...
WPS encodes Bool attributes as single-octet values. Selected Registrar
attribute is parsed correctly (packet-wps.c), but many of the other Bool
attributes are marked incorrectly to use two-octet fields. This results in
showing incorrect octets for some of the attributes and incorrectly marking
frames invalid if a Bool attribute is included as the last attribute in a WPS
IE.
svn path=/trunk/; revision=30622
2009-10-19 18:36:34 +00:00
Stig Bjørlykke
7b138b5455
Use unsigned int for flags to avoid another warning.
...
svn path=/trunk/; revision=30615
2009-10-19 13:29:01 +00:00
Stig Bjørlykke
17aae178a9
Various code cleanup:
...
- Added standard copyright boiler plate
- Made all local functions static
- Added several checks for valid pointers
- Fixed some variable shadowing
- Fixed some printf formats (%p)
- Removed unused variables
svn path=/trunk/; revision=30613
2009-10-19 13:22:45 +00:00
Jeff Morriss
46fc4eea81
new_octet_aligned_subset_bits(): call tvb_ensure_bytes_exist() before
...
attmepting to malloc memory to ensure we've been asked to decode a reasonable
number of bits (and thus are asking for a reasonable number of bytes from
malloc()).
That should fix the fuzz failure in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4138
Add a comment to new_octet_aligned_subset() asking why we're resetting the
length to tvb_length()--that means we'll never throw an exception.
svn path=/trunk/; revision=30611
2009-10-18 23:19:44 +00:00
Stig Bjørlykke
056c915e61
Removed unused argument in v2_attrval2str().
...
svn path=/trunk/; revision=30606
2009-10-18 21:15:37 +00:00
Stig Bjørlykke
53c447a3aa
Remove a shadowed variable.
...
svn path=/trunk/; revision=30605
2009-10-18 21:14:35 +00:00
Stig Bjørlykke
3587a1acb1
Use %f for double in printf.
...
svn path=/trunk/; revision=30604
2009-10-18 21:13:53 +00:00
Stig Bjørlykke
0fcef72fc6
Use correct type for udp port preference.
...
svn path=/trunk/; revision=30603
2009-10-18 21:13:17 +00:00
Stig Bjørlykke
c92177a771
Use %f for double in printf.
...
Made some functions static.
svn path=/trunk/; revision=30602
2009-10-18 20:14:04 +00:00
Jeff Morriss
6bbd17bcf9
Don't se_alloc() the conversation structure which contains pointers to two
...
g_hash_tables that we then try to free in ros_reinit(). Instead, g_malloc()
the conversation structure and free it (along with the hash tables) in the
reinit function.
svn path=/trunk/; revision=30601
2009-10-18 20:13:56 +00:00
Jeff Morriss
2d8acf2a74
Fix an off-by-one error (<= instead of <) that caused the dissector to
...
reference uninitialized memory, possibly leading to a crash (found by turning
memory scrubbing on).
svn path=/trunk/; revision=30595
2009-10-18 14:46:39 +00:00
Jaap Keuter
8809953430
From Kip McAtee:
...
Suppress spurious packet length error message for LCP or IPCP in PPPoE.
svn path=/trunk/; revision=30594
2009-10-18 13:36:01 +00:00
Jaap Keuter
34f6f0d9e9
From Jouni Malinen:
...
IEEE 802.11k added a new Action frame category: Public Action. I'm proposing
some initial code to recognize this and to add a placeholder for switch
statement that can be used for processing vendor specific Public Action frames
(they are defined in IEEE 802.11w).
svn path=/trunk/; revision=30593
2009-10-18 12:53:29 +00:00
Bill Meier
5d68a812ab
Fix memory leak: re-init defragmentation tables each time a capture file is (re) opened.
...
svn path=/trunk/; revision=30589
2009-10-17 21:42:51 +00:00
Stig Bjørlykke
b7d116667f
From Marton Nemeth:
...
Add the ability to open JPEG/JFIF files directly.
From me:
Some code cleanup + add new file to cmake.
svn path=/trunk/; revision=30588
2009-10-17 20:56:06 +00:00
Jaap Keuter
80424e5ced
From Joe Eykholt:
...
It would be nice to have dissection of the Fibre-Channel FCP
"Sequence retransmission request" (SRR) request.
This is like an FC ELS request, but it has FC type FCP, so it's
a little strange. It seemed like the best place to put it is in
packet-fcp.c but a slight hook is needed in packet-fc.c to
recognize that packet-fcp is the correct dissector.
svn path=/trunk/; revision=30587
2009-10-17 10:19:18 +00:00
Jeff Morriss
bba7f0977c
Based on an issue presented in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4050 :
...
Add an item and an expert info (warning) if there's more data in the tvb than the length parameter indicates.
svn path=/trunk/; revision=30585
2009-10-16 22:15:58 +00:00
Bill Meier
81a03aca75
Another Oops: #include <stdio.h> *is* required .....
...
svn path=/trunk/; revision=30584
2009-10-16 22:12:40 +00:00
Bill Meier
92c387a992
fid_table never used: remove it (Fixes very minor memory leak).
...
svn path=/trunk/; revision=30583
2009-10-16 22:05:49 +00:00
Bill Meier
09cfdb2530
Don't init fc_fragment_table twice via registered_init_routines...
...
svn path=/trunk/; revision=30582
2009-10-16 22:00:41 +00:00
Bill Meier
c4f5ac7cbc
sna_reassembled_table never used: remove it;
...
Move register_init_routine call to proto_register as per convention...
svn path=/trunk/; revision=30581
2009-10-16 21:54:17 +00:00
Bill Meier
8e2f6a26cb
data_reassembled_table not used: remove it.
...
svn path=/trunk/; revision=30580
2009-10-16 21:47:48 +00:00
Bill Meier
e2379fb4a1
Fix memory leak; init fragment_table & reassembled_table in registered init fcn;
...
(Tables were being initted only at Wireshark startup in proto_register)
svn path=/trunk/; revision=30578
2009-10-16 21:35:39 +00:00
Jaap Keuter
5ac529f786
From Joe Eykholt:
...
The FIP dissector shows the VFID descriptor as a 2-byte string instead of the
correct UINT16 type. Also, the name should be changed to just "VFID".
The "Fabric Name" field of the Fabric descriptor was incorrectly labeled.
Also, some lines grew to longer than 80 columns due to other patches.
svn path=/trunk/; revision=30577
2009-10-16 21:26:51 +00:00
Bill Meier
f91657feb9
dtls_fragment_table never used; Remove it.
...
Remove unneeded #includes.
Adjust some indentation & spacing.
svn path=/trunk/; revision=30576
2009-10-16 21:17:57 +00:00
Bill Meier
7a43e8853b
Oops: #include <stdio.h> *is* required .....
...
svn path=/trunk/; revision=30575
2009-10-16 16:01:20 +00:00
Bill Meier
92307f0dda
(Trivial) Fix a typo in a comment.
...
svn path=/trunk/; revision=30574
2009-10-16 15:28:21 +00:00
Bill Meier
22c70b409a
#include <stdio.h> not req'd; Fix some typos in text strings;
...
Adjust some indentation & spacing, reformat some long lines.
svn path=/trunk/; revision=30573
2009-10-16 14:37:40 +00:00
Bill Meier
f59bf50023
Use GSlice instead of GMemChunks for GLib >= 2.10. Fixes a memory leak.
...
svn path=/trunk/; revision=30572
2009-10-16 14:22:00 +00:00
Anders Broman
77c3bfd8c1
From Gerasimos Dimitriadis:
...
DTAP: Decoding of Text String in Network Name IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4121
svn path=/trunk/; revision=30571
2009-10-16 10:38:42 +00:00
Ronnie Sahlberg
2ee73bdf0c
add proper support for infolevel 105 for ff
...
they are different.
svn path=/trunk/; revision=30568
2009-10-16 06:17:55 +00:00
Ronnie Sahlberg
9339cf747c
add dissection of infolevel 0x105 for findfirst
...
this is actually identical to infolevel 0x104 in smb while they differ
in smb2
svn path=/trunk/; revision=30567
2009-10-16 05:31:43 +00:00
Bill Meier
d4a921730b
(Trivial) Fix a typo in a comment
...
svn path=/trunk/; revision=30560
2009-10-15 02:39:06 +00:00
Martin Mathieson
61eda9b14e
Improve DL HARQ resend detection by storing multiple frames per UE.
...
svn path=/trunk/; revision=30557
2009-10-14 10:43:17 +00:00
Ronnie Sahlberg
edcd3abdeb
From Matthieu Patou
...
Update ntlmssp to automatically re-read the keytab file if it changes
svn path=/trunk/; revision=30556
2009-10-14 07:22:40 +00:00
Martin Mathieson
af67d9d1d8
Status report bitmap can be empty, so add test.
...
svn path=/trunk/; revision=30555
2009-10-13 13:52:23 +00:00
Martin Mathieson
7e8d401265
Add detection for suspected DL retx (due to HARQ). Needed if logging is done on UE side of link.
...
svn path=/trunk/; revision=30554
2009-10-13 13:36:58 +00:00
Bill Meier
741bc8368e
#include <stdio.h> not req'd;
...
Adjust some spacing.
svn path=/trunk/; revision=30552
2009-10-12 20:57:01 +00:00
Bill Meier
594855f394
Remove unneeded #includes;
...
Use consistent indentation.
svn path=/trunk/; revision=30550
2009-10-12 18:27:59 +00:00
Kovarththanan Rajaratnam
c82f5a7085
Make all global variables static
...
svn path=/trunk/; revision=30548
2009-10-12 16:59:12 +00:00
Kovarththanan Rajaratnam
913da7cda9
Remove temp files on (clean) exit
...
svn path=/trunk/; revision=30547
2009-10-12 16:57:23 +00:00
Anders Broman
d31ddb200f
From Gerasimos Dimitriadis:
...
DTAP: Facility IE resets PROTOCOL and INFO columns
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4110
svn path=/trunk/; revision=30545
2009-10-12 15:38:16 +00:00
Anders Broman
5ba10f7062
From Gerasimos Dimitriadis:
...
DTAP: Decoding of Emergency Number List IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4111
svn path=/trunk/; revision=30544
2009-10-12 15:32:53 +00:00
Kovarththanan Rajaratnam
3a0ba6b1cb
Let the pidl subdirectory indicate which protocols it contains
...
svn path=/trunk/; revision=30540
2009-10-12 15:07:56 +00:00
Stig Bjørlykke
fd2662b27f
Added a check for num_opts to avoid a theoretical undefined behavior.
...
svn path=/trunk/; revision=30537
2009-10-12 14:43:09 +00:00
Stig Bjørlykke
30b31a46bb
Initialize variables which may be used uninitialized.
...
svn path=/trunk/; revision=30536
2009-10-12 14:29:48 +00:00
Bill Meier
f479b75ea3
Remove #define which is no longer req'd.
...
svn path=/trunk/; revision=30525
2009-10-12 00:54:41 +00:00
Guy Harris
6e478c4f6b
Initialize radius_call, so it's null if we don't pass through the code
...
path that sets it.
svn path=/trunk/; revision=30524
2009-10-12 00:32:34 +00:00
Bill Meier
14bda86689
Replace GMemChunks usage with se_alloc();
...
Remove unneeded #includes;
Fix some spacing.
svn path=/trunk/; revision=30523
2009-10-12 00:31:37 +00:00
Bill Meier
dd44270387
Replace use of GMemChunks by se_alloc();
...
@include <stdlib.h> not req'd;
Use consistent indentation.
svn path=/trunk/; revision=30522
2009-10-12 00:01:59 +00:00
Kovarththanan Rajaratnam
a58c31975e
Don't col_set_str + col_append_xxx. Just add the string instead.
...
svn path=/trunk/; revision=30521
2009-10-11 17:37:56 +00:00
Kovarththanan Rajaratnam
81d9f3030d
Remove more unused variables/forward declarations
...
svn path=/trunk/; revision=30520
2009-10-11 17:25:04 +00:00
Kovarththanan Rajaratnam
0dcf31b8bc
Make some ett/hf variables static
...
svn path=/trunk/; revision=30519
2009-10-11 17:14:19 +00:00
Stig Bjørlykke
6d1dae6f28
Make all proto_* values static.
...
svn path=/trunk/; revision=30516
2009-10-11 16:24:29 +00:00
Stig Bjørlykke
782138e1aa
Corrected some HF_FIELD values.
...
svn path=/trunk/; revision=30510
2009-10-11 14:34:33 +00:00
Stig Bjørlykke
0e80b37df3
Change from C++ comments to C comments.
...
svn path=/trunk/; revision=30509
2009-10-11 14:34:02 +00:00
Stig Bjørlykke
f47bd1e8bf
Make ett_* values static.
...
svn path=/trunk/; revision=30508
2009-10-11 14:33:04 +00:00
Stig Bjørlykke
e0fbe7624b
Make ett_nt_unicode_string static.
...
svn path=/trunk/; revision=30507
2009-10-11 14:32:36 +00:00
Kovarththanan Rajaratnam
4f2332256c
Remove unused variable
...
svn path=/trunk/; revision=30506
2009-10-11 14:21:50 +00:00
Kovarththanan Rajaratnam
f86851262f
Switch over to using seasonal memory since the mgcp dissector was using g_mem_chunks in a seasonal fashion (memory was only freed during file open)
...
svn path=/trunk/; revision=30505
2009-10-11 14:06:56 +00:00
Kovarththanan Rajaratnam
1e32410765
Switch over to using seasonal memory instead of g_mem_chunkS which are deprecated
...
svn path=/trunk/; revision=30502
2009-10-11 10:00:01 +00:00
Jörg Mayer
ec7380a6b1
Creatig static sublibs was not a good idea:
...
=========================================================================
"du -s build" with sublibs:
396868 build
-----------------------------------
"du -s build" without sublibs:
197588 build/
=========================================================================
tshark with sublibs:
-rwxr-xr-x 1 jmayer users 27399706 2009-10-11 08:39 tshark*
-----------------------------------
tshark without sublibs:
-rwxr-xr-x 1 jmayer users 226748 2009-10-11 09:05 tshark*
=========================================================================
So undo the following patches:
------------------------------------------------------------------------
r30459 | krj | 2009-10-10 07:08:48 +0200 (Sa, 10 Okt 2009) | 1 line
Sort subdirectories alphabetically
------------------------------------------------------------------------
r30458 | krj | 2009-10-10 07:03:36 +0200 (Sa, 10 Okt 2009) | 1 line
Add epan/dissectors/CMakeLists.txt which creates a static dissectors library
------------------------------------------------------------------------
--> readd!! *** r30443 | krj | 2009-10-09 21:43:42 +0200 (Fr, 09 Okt 2009) | 1 line
Rename DISSECTOR_ASM_UTILS to LIBWIRESHARK_ASM_FILES since these files belongs to ep
an not dissectors
------------------------------------------------------------------------
r30442 | krj | 2009-10-09 21:17:26 +0200 (Fr, 09 Okt 2009) | 1 line
Add epan/ftypes/CMakeLists.txt which creates a static ftypes library
------------------------------------------------------------------------
r30441 | krj | 2009-10-09 21:13:01 +0200 (Fr, 09 Okt 2009) | 1 line
Add epan/dfilter/CMakeLists.txt which creates a static dfilter library
------------------------------------------------------------------------
r30440 | krj | 2009-10-09 21:05:29 +0200 (Fr, 09 Okt 2009) | 1 line
Add epan/crypt/CMakeLists.txt which creates a static crypt library
------------------------------------------------------------------------
r30439 | krj | 2009-10-09 20:22:22 +0200 (Fr, 09 Okt 2009) | 1 line
Add epan/crc/CMakeLists.txt which creates a static crc library
------------------------------------------------------------------------
To avoid merge problems, I needed to revert r30443 as well, will readd this
one in my next patch.
svn path=/trunk/; revision=30494
2009-10-11 07:28:26 +00:00
Kovarththanan Rajaratnam
08e0d21a4b
Remove redundant forward declarations
...
svn path=/trunk/; revision=30485
2009-10-11 04:38:42 +00:00
Kovarththanan Rajaratnam
bae07625ce
Don't clear INFO column. We do that implicitly when we do a col_add_fstr().
...
svn path=/trunk/; revision=30484
2009-10-11 04:36:43 +00:00
Kovarththanan Rajaratnam
85181bcea1
Don't use C++ reserved keyword 'class'
...
svn path=/trunk/; revision=30483
2009-10-11 04:29:06 +00:00
Bill Meier
9f24b1870b
Replace use of GMemChunk by se_alloc;
...
This fixes a major memory leak in the NCP dissector
caused by the fact that "in recent versions of GLib" (>= 2.10 ?)
g_mem_chunk_destroy doesn't actually free up the mem_chunk memory.
Note that there still appears to be one or more smaller
memory leaks somehow associated with NCP dissection.
Example:
A 40M capture file with mostly NCP frames which resulted in a memory
usage increase of about 20M each time the file was reloaded now results
in a 400K-800K memory usage increase each time the file is reloaded.
(If NCP dissection is disabled, there is minimal memory expansion
each time the file is reloaded).
svn path=/trunk/; revision=30481
2009-10-10 21:13:16 +00:00
Bill Meier
17a2e0b460
Fix a benign no-effect bug;
...
Use consistent indentation.
svn path=/trunk/; revision=30480
2009-10-10 17:49:28 +00:00
Bill Meier
9ac4174e41
Use consistent indentation
...
svn path=/trunk/; revision=30479
2009-10-10 16:57:20 +00:00
Kovarththanan Rajaratnam
b57e27ef8e
ns-cert-ext -> ns_cert_exts to make directory name consistent with filenames
...
svn path=/trunk/; revision=30478
2009-10-10 14:20:33 +00:00
Kovarththanan Rajaratnam
19ee815ea4
Regenerate asn1 dissectors (no functionality change)
...
svn path=/trunk/; revision=30476
2009-10-10 13:39:14 +00:00
Kovarththanan Rajaratnam
251124a935
Introduce PROTOCOL_NAME variable in makefiles
...
svn path=/trunk/; revision=30467
2009-10-10 08:33:05 +00:00
Kovarththanan Rajaratnam
1f57b83867
Correct path to pidl
...
svn path=/trunk/; revision=30466
2009-10-10 08:14:38 +00:00
Kovarththanan Rajaratnam
bf2ec50430
Autogenerating epan/dissectors/dcerpc/* now works
...
svn path=/trunk/; revision=30465
2009-10-10 08:10:28 +00:00
Kovarththanan Rajaratnam
0c8dbe1b49
Only dump to stderr if IDL2WRS_DEBUG is defined
...
svn path=/trunk/; revision=30464
2009-10-10 08:02:57 +00:00
Kovarththanan Rajaratnam
64e717ee94
First stab at autogenerating budb dissector
...
svn path=/trunk/; revision=30463
2009-10-10 06:45:04 +00:00
Kovarththanan Rajaratnam
142131917c
Compile and link idl2wrs
...
svn path=/trunk/; revision=30460
2009-10-10 05:35:21 +00:00
Kovarththanan Rajaratnam
c3f68b724d
Add epan/dissectors/CMakeLists.txt which creates a static dissectors library
...
svn path=/trunk/; revision=30458
2009-10-10 05:03:36 +00:00
Kovarththanan Rajaratnam
78b0ee16e2
Backport r29665 to template file so that the change is not overwritten when we regenerate the dissector
...
svn path=/trunk/; revision=30455
2009-10-09 21:41:06 +00:00
Kovarththanan Rajaratnam
9490d1b74c
Regenerate asn1 dissectors (no change, only some line offset changes)
...
svn path=/trunk/; revision=30454
2009-10-09 21:34:49 +00:00
Kovarththanan Rajaratnam
124f16e826
Rename gsmmap -> gsm_map for consistency
...
svn path=/trunk/; revision=30453
2009-10-09 21:33:18 +00:00
Kovarththanan Rajaratnam
acb940488b
Make a few variables static
...
svn path=/trunk/; revision=30451
2009-10-09 21:06:56 +00:00
Kovarththanan Rajaratnam
1ed0657e50
Remove unused variable
...
svn path=/trunk/; revision=30450
2009-10-09 21:03:07 +00:00
Kovarththanan Rajaratnam
a831d2d2ca
(Windows only) Make sure that register.c depends on make-dissector-reg.py and make-dissector-reg
...
svn path=/trunk/; revision=30448
2009-10-09 20:53:33 +00:00