Commit graph

35662 commits

Author SHA1 Message Date
Bill Meier
a9652ea66e Use correct subtree for proto_tree_add_item in several places: Coverity 1130 [UNUSED];
Also: Reformat a few lines and do some whitespace cleanup.

svn path=/trunk/; revision=37357
2011-05-23 14:11:14 +00:00
Martin Mathieson
c13f268e8b Add missing braces.
svn path=/trunk/; revision=37356
2011-05-23 10:09:08 +00:00
Jörg Mayer
5f28f55229 7.3.2.25 or 802.11-2007 gives an example of length 20, so it is unclear where the 24 came from (unintentionally fixes bug 5942)
svn path=/trunk/; revision=37355
2011-05-23 08:54:47 +00:00
Jakub Zawadzki
0447513ede Clean duplicated contributors.
svn path=/trunk/; revision=37354
2011-05-23 08:03:50 +00:00
Chris Maynard
f6a11de61f Delete unused header field entries found by running checkhf.pl.
svn path=/trunk/; revision=37353
2011-05-23 00:32:40 +00:00
Chris Maynard
010f55017e Added Michael Mann for his contributions to bug 2794.
svn path=/trunk/; revision=37352
2011-05-23 00:05:07 +00:00
Chris Maynard
609c3dd0d4 From Micheal Mann via bug 2794: Fix some display filter field names.
svn path=/trunk/; revision=37351
2011-05-23 00:00:53 +00:00
Bill Meier
9851df836c From Yaniv Kaul: Some 'set but not used' compilation fixes;
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5858

From me: 2 corrections to the patch and sevral other minor changes.

svn path=/trunk/; revision=37350
2011-05-22 22:04:24 +00:00
Gerald Combs
6705660d04 [Automatic manuf, services and enterprise-numbers update for 2011-05-22]
svn path=/trunk/; revision=37346
2011-05-22 15:04:14 +00:00
Michael Tüxen
985a98dd1b Fix the case where you start with interfaces on the command line
(so using ifaces) and then using the GUI (which only deals with
iface).

These kind of problems will completely disappear when the
old strucuture components like iface have completely be
retired. This is the next thing we will work on.

svn path=/trunk/; revision=37345
2011-05-22 11:11:00 +00:00
Michael Tüxen
bfb7d262e8 Use appropriate temporary filename when capturing from multiple interfaces.
svn path=/trunk/; revision=37344
2011-05-21 20:57:00 +00:00
Michael Tüxen
17dd51831f As suggested on the dev list: Use pcapng and threads
when capturing on multiple interfaces even if not specified
on the command line.

svn path=/trunk/; revision=37343
2011-05-21 18:51:25 +00:00
Michael Tüxen
c6c2577bbc Fix the capturing from the GUI. Honor the iface variable.
The next step is to retire the iface variable and use
the ifaces array only. This should simplify things and
fix the cases, where you start wireshark with command
line arguments and also use the GUI.

svn path=/trunk/; revision=37342
2011-05-21 13:22:38 +00:00
Gerald Combs
9be282951b Pass a pcap_options * instead of a pcap_options **.
svn path=/trunk/; revision=37341
2011-05-21 00:10:57 +00:00
Bill Meier
c0922b93b6 Don't assign to a variable which is then not referenced: Coverity 998 [UNUSED].
svn path=/trunk/; revision=37340
2011-05-20 20:41:23 +00:00
Bill Meier
d99149b1d6 Don't assign to an unused variable: Fixes Coverity 874 [UNUSED].
svn path=/trunk/; revision=37339
2011-05-20 20:29:19 +00:00
Bill Meier
fa332472f5 Fix a typo ...
svn path=/trunk/; revision=37338
2011-05-20 20:22:59 +00:00
Bill Meier
046726f454 Remove unneeded code: Fixes Coverity 890 [UNUSED].
svn path=/trunk/; revision=37337
2011-05-20 20:21:14 +00:00
Bill Meier
8504d231c7 Use (what appears to be) the correct tvb for a function call: Fixes Coverity 919 [UNUSED];
#include <stdlib.h> not req'd.

svn path=/trunk/; revision=37336
2011-05-20 20:10:41 +00:00
Bill Meier
fd64c4ae5e Remove unused code: Fixes Coverity 972 [UNUSED].
svn path=/trunk/; revision=37335
2011-05-20 20:00:16 +00:00
Bill Meier
a2b58f051d Add #include <stdlib.h> to files which reference fcns declared in stdlib.h;
(In many cases I previously incorrectly removed the #include <stdlib.h>).

svn path=/trunk/; revision=37334
2011-05-20 19:00:09 +00:00
Gerald Combs
adefc98f12 Add bugs 4985 and 5580 to the list of known problems.
svn path=/trunk/; revision=37333
2011-05-20 17:02:20 +00:00
Bill Meier
f3432a973c Don't assign to a proto_item* if the value won't be used:
Fixes Coverity 903,935,968,985,997,999,1024,1025,1134;
Remove unneeded #includes;
Do whitespace cleanup.

svn path=/trunk/; revision=37331
2011-05-20 15:44:25 +00:00
Bill Meier
4910bc142f Add to comment about using a heuristic; Fix a typo.
svn path=/trunk/; revision=37330
2011-05-20 15:34:29 +00:00
Bill Meier
befd2a6f74 Use correct parent tree when creating a subtree: Fixes Coverity 902 [UNUSED];
Remove unneeded #includes;
Do some whitespace cleanup.

svn path=/trunk/; revision=37329
2011-05-20 15:22:58 +00:00
Bill Meier
57b17b8794 '#if 0' code related to already commented out code: Fixes Coverity 881.
svn path=/trunk/; revision=37328
2011-05-20 15:19:26 +00:00
Bill Meier
d2989164bd Don't assign to a proto_item* if the value won't be used: Coverity 975 [UNUSED]
Remove unneeded prefs callback in prefs registration;
Remove 'if (!initialized)' test from proto_reg_handoff...();
Remove unneeded #include;
Do some whitespace cleanup.

svn path=/trunk/; revision=37327
2011-05-20 14:21:02 +00:00
Anders Broman
b0997749ea Prettify som 3GPP AVP:s
svn path=/trunk/; revision=37326
2011-05-20 13:55:21 +00:00
Stig Bjørlykke
0a3f9da616 gtk_menu_item_set_label() is from gtk 2.16.
svn path=/trunk/; revision=37325
2011-05-20 11:58:00 +00:00
Stig Bjørlykke
2c1ede3dce Include the profile name in the Delete item in the profiles popup.
Fixed creating a new profile from the popup without setting a create from.
Removed some unneeded ep_strdup_printf.

svn path=/trunk/; revision=37324
2011-05-20 11:30:51 +00:00
Jeff Morriss
bcd55c173b Copy data from the TVB into ep_alloc'd memory, rather than saving a pointer into the TVB.
svn path=/trunk/; revision=37323
2011-05-20 03:22:27 +00:00
Jeff Morriss
11ac49f225 Use tvb_get_ephemeral_string() instead of tvb_get_ptr().
svn path=/trunk/; revision=37322
2011-05-20 03:20:20 +00:00
Jeff Morriss
947e2c78c8 Use tvb_bytes_to_str() instead of a homegrown version.
svn path=/trunk/; revision=37321
2011-05-20 03:17:01 +00:00
Jeff Morriss
2a86281027 Use TVB accessor functions instead of tvb_get_ptr()
svn path=/trunk/; revision=37320
2011-05-20 03:15:18 +00:00
Jeff Morriss
d545900d36 Use tvb_ether_to_str()
svn path=/trunk/; revision=37319
2011-05-20 03:12:56 +00:00
Guy Harris
a9447bddf0 Fix annoying typo.
svn path=/trunk/; revision=37318
2011-05-20 02:44:12 +00:00
Jeff Morriss
da8ec2c2d6 Use proto_tree_add_item() instead of proto_tree_add_xxx() with a pointer into
the TVB.

Introduce and start using tvb_get_manuf_name() and tvb_get_manuf_name_if_known()
which do the same as the non-tvb versions but take a tvb and an offset instead
of (commonly) a pointer into a TVB.

svn path=/trunk/; revision=37317
2011-05-20 02:42:14 +00:00
Guy Harris
4b7cc99d00 In at least some versions of OS X SystemStarter gets cranky if the
startup item is group-writable.

svn path=/trunk/; revision=37316
2011-05-20 02:35:05 +00:00
Guy Harris
50330f2dbd Add pdml2html.xsl to the source tarball.
(Can we have a macro that has everything in pkgdata_DATA except for
COPYING, and use that macro in both the definition of pkgdata_DATA and
EXTRA_DIST?)

svn path=/trunk/; revision=37314
2011-05-19 21:11:44 +00:00
Gerald Combs
3e2a422a83 Update the User's Guide.
svn path=/trunk/; revision=37312
2011-05-19 21:09:29 +00:00
Michael Tüxen
eb3ebb5412 Drop privileges after opening all pcap devices, not after the first one...
svn path=/trunk/; revision=37311
2011-05-19 20:48:58 +00:00
Gerald Combs
efcd3f158b 1.6 → 1.7.
svn path=/trunk/; revision=37309
2011-05-19 20:37:36 +00:00
Bill Meier
01a13cc082 Don't assign to an unused 'proto item *': Coverity 1033 & 906
svn path=/trunk/; revision=37308
2011-05-19 20:21:08 +00:00
Michael Tüxen
8b701e108a In case we have no interface information in the array, use the global value.
This fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5935.

svn path=/trunk/; revision=37307
2011-05-19 20:20:35 +00:00
Bill Meier
d868d6385b Create subtree under the correct parent tree: Coverity 1138.
svn path=/trunk/; revision=37306
2011-05-19 20:16:10 +00:00
Bill Meier
d03ad5ad6b Don't assign a value which is never used to a 'proto item *': Covertiy 1135;
Remove some unneeded #includes.

svn path=/trunk/; revision=37305
2011-05-19 20:13:54 +00:00
Gerald Combs
b2561a408c Fix markup.
svn path=/trunk/; revision=37304
2011-05-19 20:13:33 +00:00
Gerald Combs
7868da24aa Update the version and command output.
svn path=/trunk/; revision=37303
2011-05-19 19:52:56 +00:00
Bill Meier
b3f528560b #if 0 some not currently used code: Fixes Coverity 966 [UNUSED]
Convert apparent "4 space tabs" to "4 spaces".

svn path=/trunk/; revision=37302
2011-05-19 19:48:39 +00:00
Bill Meier
00bf3cacb3 Remove unneeded variable and code; Rename a function arg; Fix usage of _U_: Fixes Coverity 1146 [UNUSED]
svn path=/trunk/; revision=37301
2011-05-19 19:22:49 +00:00