Commit Graph

23440 Commits

Author SHA1 Message Date
Stig Bjørlykke a6c7284e3b Added cast of argument to isspace.
svn path=/trunk/; revision=24090
2008-01-14 19:19:47 +00:00
Stig Bjørlykke a2d1e9005d This patch adds support for configuration profiles, which can be used to
configure and use more than one set of preferences and configuration files.

This can be found in the "Configuration Profiles..." menu item from the Edit
menu, or by pressing Shift-Ctrl-A.  It's also possible to start wireshark
and tshark with a named profile by using the "-C ProfileName" option.
A new status pane in the main window will show the current profile.

The configuration files currently stored in the Profiles are:
- Preferences
- Capture Filters
- Display Filters
- Coloring Rules
- Disabled Protocols
- User Accessible Tables

The recent data are by design not added to the profile.

Planned future enhancements:
- make a more convenient function to switch between profiles
- add a "clone profile" button to copy an existing profile
- make the profiles list active and accept return as OK
- save users "Decode as" in the profile
- make new, clone and deletion of profiles more secure
- make some of the recent values available in the profile

This patch also fixes:
- setting default status pane sizes
- a bug setting status pane for packets when not having main lower pane.

svn path=/trunk/; revision=24089
2008-01-14 16:40:23 +00:00
Stig Bjørlykke e189eb8887 Added copy of ethercat.dll, as pointed out by Peter Johansson.
svn path=/trunk/; revision=24088
2008-01-14 12:05:33 +00:00
Tomas Kukosa b1d62c4418 use FN_VARIANT parameter in INTEGER type for planned 64bit variants
svn path=/trunk/; revision=24087
2008-01-14 11:21:09 +00:00
Stig Bjørlykke b0c8583de7 Fixed a guint64 compile issue with a Sun C 5.8 compiler.
Fixed a tree placement.

svn path=/trunk/; revision=24086
2008-01-14 09:51:22 +00:00
Stig Bjørlykke 8b4e80384a Fixed a few "statement not reached" warnings and a "assignment type mismatch" warning.
svn path=/trunk/; revision=24085
2008-01-14 09:39:55 +00:00
Tomas Kukosa 2df94e1092 add ssl_debug_flush() at the end of initialization
svn path=/trunk/; revision=24084
2008-01-14 09:34:26 +00:00
Stephen Fisher 1caef26fa4 Fix seek reading by adding the size of the block length at the end of the
block to the data offset.


svn path=/trunk/; revision=24083
2008-01-14 05:31:38 +00:00
Ulf Lamping 105a6009bd some minor updates
svn path=/trunk/; revision=24082
2008-01-13 22:26:11 +00:00
Stephen Fisher a98ff5a017 Add svn:eol-style native and svn:keywords Id
svn path=/trunk/; revision=24081
2008-01-13 21:10:09 +00:00
Stephen Fisher c352fb3832 Make pcapng.c compile on Unix (with gcc)
svn path=/trunk/; revision=24080
2008-01-13 20:48:36 +00:00
Ulf Lamping 4f565d1a4d add very experimental support for pcapng "PCAP Next Generation Dump File Format" - this is incomplete and buggy, be careful!
svn path=/trunk/; revision=24079
2008-01-13 20:05:07 +00:00
Anders Broman aa81806094 Update package name from IANA's list.
svn path=/trunk/; revision=24078
2008-01-13 17:03:06 +00:00
Anders Broman 02c27c89f0 transactionId wasn't processed for:
SegmentReply/transactionId
TransactionReply/transactionId
TransactionPending/transactionId
Fixes bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2165

svn path=/trunk/; revision=24077
2008-01-13 16:07:52 +00:00
Graeme Lunt 8563c02137 Basic support for the LDAP start_tls extended operation and fix to match up extended operation arguments and results.
svn path=/trunk/; revision=24076
2008-01-13 14:12:47 +00:00
Graeme Lunt abdadc9eae Support for keylists for protocols that use start_tls - where SSL is negotiated at some point during a conversation and cannot be assumed on the basis of the port number alone.
Also dissection of Distinguished Names.


svn path=/trunk/; revision=24075
2008-01-13 14:10:02 +00:00
Jaap Keuter e7f4e2d6e5 From Michael Earnhart:
Patch to add cdp Power_request and Power_available fields
This added the support for the 0x0019 and 0x001a power_request and power_available fields.

Submitted patch slightly modified to present summary line and make more robust.

svn path=/trunk/; revision=24074
2008-01-13 11:56:39 +00:00
Stephen Fisher 9463667692 Fix for bug #2017: VoIP trace crashes Wireshark when specific RTP Player
buttons are clicked


svn path=/trunk/; revision=24073
2008-01-13 04:24:24 +00:00
Sake Blok da42105f77 Clean up the usage information of editcap and change the text
of the -t option to fit its current behaviour

('fixes' bug 2101)


svn path=/trunk/; revision=24072
2008-01-12 18:31:07 +00:00
Sake Blok 6ff98095fe From Martin Peylo (bug 2184), fix for:
The current dissection of GeneralizedTime in packet-ber does not consider all
the possibilities how this field can be constructed.

According to ITU-T X.680 this field can be encoded as
YYYYMMDDhhmmss([\.,]f{1,3})?(([+-]hhmm)|Z)?
This is a regex-like expression where each letter except the literal 'Z'
represents an ASCII encoded digit.

So far only the first 14 digits are dissected and the 15th character is put
into parentheses. This may not show all available information.



svn path=/trunk/; revision=24071
2008-01-12 12:06:56 +00:00
Stephen Fisher aee504c8f5 Fix Windows warning/error: integral size mismatch
Then fix comparison of signed/unsigned warning/error


svn path=/trunk/; revision=24070
2008-01-12 06:38:09 +00:00
Martin Mathieson 432354c001 Don't write closing PDML tag for Data protocol - it uses simple (self-closing) tags.
Fixes bug 2185.

svn path=/trunk/; revision=24069
2008-01-12 00:34:17 +00:00
Jeff Morriss 01df06d697 The Windows compiler thinks that doing return(func_that_returns_void()) in a function that itself returns void is "'void' function returning a value". So don't do that.
svn path=/trunk/; revision=24068
2008-01-11 21:06:00 +00:00
Jeff Morriss 207afe82bb Associate Wireshark with Tektronix K12xx/K15 .rf5 files
svn path=/trunk/; revision=24067
2008-01-11 19:25:51 +00:00
Gerald Combs c9ff99636a Update the documentation style sheet with a modified version of AsciiDoc's
(http://www.methods.co.nz/asciidoc/).

svn path=/trunk/; revision=24066
2008-01-11 18:52:13 +00:00
Anders Broman 0b28f14940 Fix up some display filter names:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1852

svn path=/trunk/; revision=24065
2008-01-11 07:29:27 +00:00
Jaap Keuter 7def8e7b3e From Yukiyo Akisada:
This modifications are for the new protocol support.
HSE protocol was defined at Fieldbus Foundation <http://www.fieldbus.org/>.

svn path=/trunk/; revision=24064
2008-01-11 07:28:01 +00:00
Jeff Morriss d7fb23f849 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2111 : After verifying that there's enough TVB for the smallest possible message, also verify that the length parameter in the message is at least that big.
svn path=/trunk/; revision=24063
2008-01-10 23:16:59 +00:00
Jaap Keuter 3bca993c0b Fix for bug 2187.
Don't cast so rigorously that you loose the mantissa.

svn path=/trunk/; revision=24062
2008-01-10 22:27:28 +00:00
Jeff Morriss 283ddb3d0c Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2186 (many unnamed structs in packet-ecatmb.h) by adding predictable (but not very descriptive) struct names
svn path=/trunk/; revision=24061
2008-01-10 22:19:53 +00:00
Jeff Morriss 3be6284ef3 From Andy Chu: A dissector for China Mobile Point to Point (cmpp) protocol,
it's the SMS protocol used in China.

From me: some code cleanup and convert it from a plugin to a regular
dissector.

svn path=/trunk/; revision=24060
2008-01-10 21:23:53 +00:00
Richard van der Hoff c7f1d0b579 add some comments re desirability of renaming fields
svn path=/trunk/; revision=24059
2008-01-10 16:43:48 +00:00
Richard van der Hoff 1350d63c1e From Chris Maynard (bug 1852):
These packet-g*.c files all have display filter issues:

1) packet-gryphon.c: PROTOABBREV is "gryphon", but display filter fields are
prefixed with only "gryph".

2) packet-gmrp.c: PROTOABBREV is "gmrp", but display filter fields are prefixed
with "garp".

3) packet-gssapi.c: PROTOABBREV is "gss-api", but display filter fields are
prefixed with "gssapi".

4) packet-gvrp.c: PROTOABBREV is "gvrp", but display filter fields are prefixed
with "garp", most of which conflict with packet-gmrp.c's display filter fields.




svn path=/trunk/; revision=24058
2008-01-10 16:35:54 +00:00
Jeff Morriss 0e339e83ed Add the file op APIs (e.g., open()) to the list of prhobited APIs (should use the eth_* versions instead).
svn path=/trunk/; revision=24057
2008-01-10 15:03:58 +00:00
Bill Meier addba66749 Use glib equivalent of ntohs
svn path=/trunk/; revision=24056
2008-01-10 14:42:55 +00:00
Guy Harris aa2d38ffb3 pinfo->pseudo_header can and should be assumed to be non-null by a
dissector.  This fixes Coverity CID 238 (as we *were* assuming it was
non-null in one statement, and then only checking it later).

Set pinfo->p2p_dir to one of P2P_DIR_RECV or P2P_DIR_SENT, as it's
supposed to be, not to a Boolean value, and explain the basis on which
it's being set.

svn path=/trunk/; revision=24055
2008-01-10 09:40:15 +00:00
Guy Harris 3fb946dbec Get rid of extra blank lines at the end of the file.
svn path=/trunk/; revision=24054
2008-01-10 08:50:16 +00:00
Guy Harris 605e462b45 Use WTAP_ENCAP_ERF as the file encapsulation, as that's what we'd
otherwise use as the per-packet encapsulation.

The close routine does nothing; get rid of it - you don't *need* a close
routine (by default, the subtype_close pointer is null, which means that
nothing per-file-type is done when the file is closed).

Make the code to handle the length fields in the ERF header common,
rather than copying it to each group of record types.

svn path=/trunk/; revision=24053
2008-01-10 08:49:11 +00:00
Ronnie Sahlberg 7e919ef623 add support for qpi level 516 : posix acl
svn path=/trunk/; revision=24052
2008-01-09 23:10:17 +00:00
Jeff Morriss f75249281d From Florent Drouin:
fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1727 (pppd format file
incorrectly detected as being an ERF file) by:

The file_seek() call has been replaced by a call to file_read(), so, when the
end of the file is reached and the current record is truncated, we have got an
error.
This solves the problem of bad file format detection.

Additionaly, the ERF heuristic has been improved.

svn path=/trunk/; revision=24051
2008-01-09 22:58:34 +00:00
Jeff Morriss d06b283bb9 dissect_e164_cc(): when the address is BCD coded, don't increment cc_offset just to get the 2nd octet of the address (because cc_offset is used later as the offset where the CC starts).
svn path=/trunk/; revision=24050
2008-01-09 22:25:47 +00:00
Jeff Morriss 52fcbb6ed8 Display the Country Code information in a subtree of the digits (to make it obvious that it's a subfield). Add #defines for the NAI and NP values and use them rather than hex values. Initial the 'np' variable to clean up a warning.
svn path=/trunk/; revision=24049
2008-01-09 22:01:57 +00:00
Anders Broman 1b73351c8d From Shmulik Bezalel:
Present the country code description gsmmap and SCCP.
Added small ASN1 bugfix - missing EXPORTS used by gsmmap.asn(Handle older ver).

svn path=/trunk/; revision=24048
2008-01-09 21:14:01 +00:00
Anders Broman 555355cef3 In case of QoS Information, Length field is missing.
svn path=/trunk/; revision=24047
2008-01-09 20:49:33 +00:00
Jeff Morriss db8bae4fb2 When searching for EOC (because we have an indefinite length) don't stop searching just because we ran out of TVB (thus assuming that the EOC is just beyond the end of the message). Instead, try to keep going which will throw an exception (ReportedBoundsError). I had a packet which was missing the EOC (probably programmer error) and Wirshark was reporting BoundsError (Packet size limited during capture) instead of ReportedBoundsError (Malformed Packet); this patch fixes that.
svn path=/trunk/; revision=24046
2008-01-09 17:06:25 +00:00
Martin Mathieson d786333ab2 #ifdef DEBUG around left-over printfs. Should these just be deleted?
svn path=/trunk/; revision=24045
2008-01-09 16:21:03 +00:00
Jörg Mayer 46db55e4e7 Pavol Rusnak <stick@gk2.sk>:
Fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2183

Strptime function is not properly included. It needs __USE_XOPEN macro, but it
is defined in wrong place. It must be defined before _any_ include file.
Otherwise I get "implicit declaration of function `strptime`" (gcc 4.3.0).


svn path=/trunk/; revision=24044
2008-01-09 16:05:17 +00:00
Tomas Kukosa 27a531e06a more sophisticated H245 OLC handling focusing on more reliable T.38 establishment
svn path=/trunk/; revision=24043
2008-01-09 13:30:31 +00:00
Martin Mathieson 4dd5de365b Explicitly check for missing NULL terminator on RTCP BYE reason string (this bug has been seen on 2 stacks now...).
Fixes bug 2180.

svn path=/trunk/; revision=24042
2008-01-09 12:39:14 +00:00
Guy Harris 0146bbda09 Exit with 1, not 2, if exec fails, so we don't report an additional
error for the exit status, over and above the one for the exec failure.

svn path=/trunk/; revision=24041
2008-01-09 11:50:22 +00:00