Commit Graph

36 Commits

Author SHA1 Message Date
Gerasimos Dimitriadis c840cdd5a0 Remove the address operator from value_string arrays fed to VALS()
svn path=/trunk/; revision=30995
2009-11-17 18:35:27 +00:00
Kovarththanan Rajaratnam 00810ff199 * Prefer col_append_str instead of col_append_fstr for constant strings
* Remove check_col guards

svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam 4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stephen Fisher c4680240d9 Change my e-mail address
svn path=/trunk/; revision=28537
2009-05-31 05:55:15 +00:00
Gerald Combs 79c4c2990b Remove unnecessary tree checks pointed out by Stig.
svn path=/trunk/; revision=28396
2009-05-18 19:14:21 +00:00
Guy Harris a9f463bee4 Clean up indentation.
svn path=/trunk/; revision=28395
2009-05-18 17:47:42 +00:00
Gerald Combs 23d52583ca From Yaniv Kaul via bug 3215:
Attached please find a patch that enables to heuristically find VNC
traffic on non-standard ports.

(it also adds some if(tree) ... around some proto_tree_add_item()
functions)

svn path=/trunk/; revision=28394
2009-05-18 17:23:16 +00:00
Anders Broman c91a384702 Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28356
2009-05-13 19:46:11 +00:00
Bill Meier 79a1441582 FT_BOOLEAN fields w/o bitmasks really should use BASE_NONE (not BASE_DEC,...).
svn path=/trunk/; revision=28317
2009-05-08 20:35:57 +00:00
Bill Meier c0e92cbc04 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27065
2008-12-20 00:09:02 +00:00
Jörg Mayer 4149a23cc5 Trivial warning fixes
svn path=/trunk/; revision=26899
2008-12-02 08:11:23 +00:00
Stephen Fisher 5378ecb53e Fix copy & paste typo
svn path=/trunk/; revision=26882
2008-11-30 10:27:53 +00:00
Stig Bjørlykke 85eab2967b From Federico Mena Quintero (bug 3070):
Add support for TightVNC extensions to the VNC dissector.

It has the following changes:
- Dissect TightVNC negotiation (tunneling, basic authentication, capabilities).
- Dissect X cursor encoding.
- Dissect POINTER_POS encoding.
- Dissect the general form of Tight rectangles.
- Dissect Tight image data (basic compression, JPEG, gradient).
- Handle LastRect encoding.
- Fix some always-true conditions.
- Some code cleanups.

svn path=/trunk/; revision=26825
2008-11-23 14:09:04 +00:00
Jaap Keuter b95f7e92ae Fix for bug 2875:
Fix a final eth_fopen -> ws_fopen
When configuring with --without-zlib these functions need to have some parameters tagged _U_

svn path=/trunk/; revision=26212
2008-09-15 21:50:50 +00:00
Bill Meier 419e3a47f6 Cleanup related to prefs & proto_reg_handoff
svn path=/trunk/; revision=26128
2008-09-03 16:42:35 +00:00
Anders Broman 63c5c71cf8 Remove:
#ifdef NEED_G_ASCII_STRCASECMP_H
#include "g_ascii_strcasecmp.h"
#endif

svn path=/trunk/; revision=24859
2008-04-09 05:36:08 +00:00
Guy Harris 9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Ronnie Sahlberg 8da1f94cca use strcasecmp instead of g_ascii_strcasecmp
svn path=/trunk/; revision=23372
2007-11-06 05:39:28 +00:00
Stephen Fisher fafa0a1c06 Add partial support for TightVNC packet dissection (work in progress).
svn path=/trunk/; revision=23345
2007-11-03 03:03:02 +00:00
Stephen Fisher de7bd77a1f Minor correction to protocol behavior handling when security type "none" is
selected by the client.


svn path=/trunk/; revision=23312
2007-10-30 16:32:26 +00:00
Stephen Fisher c5f2895907 Fix for issue #1 in bug #1947 by doing a major overhaul of how the first
nine or so packets are handled to accommodate authentication type none and
to allow cleaner future improvements.  Includes a few touch ups to the
rest of the dissector as well. 


svn path=/trunk/; revision=23310
2007-10-30 04:42:42 +00:00
Ulf Lamping 411249419d fix some more warnings (type casts)
svn path=/trunk/; revision=21141
2007-03-23 00:51:21 +00:00
Jörg Mayer fb820f0a07 GCC warning fixes
epan/dissectors/
packet-bctp.c:
	no newline at end of file
packet-epl.c:
	C++ style comments are not allowed in ISO C90
packet-sccp.c:
	missing initializer
packet-sccp.h:
	comma at end of enumerator list
packet-sctp.c:
	suggest parentheses around assignment used as truth value
packet-vnc.c:
	control reaches end of non-void function
	pointer targets in passing argument 1 of 'g_strtod' differ in
		signedness
	pointer targets in passing argument 3 of 'vnc_client_to_server'
		differ in signedness
gtk/
main.c:
	C++ style comments are not allowed in ISO C90
u3.h:
	function declaration isn't a prototype

Other (trivial) stuff
packet-sccp.h:
	Add svn properties


svn path=/trunk/; revision=21011
2007-03-09 13:14:09 +00:00
Stephen Fisher 2d334be55d Major overhaul of VNC dissector: split everything into its own function and
bring the server message type dissection nearly to completion.  As for RealVNC
protocol dissection, the only things not working at 100% is the TCP
reassembly and some ZRLE subencoding types.  However, it is is much more useful
shape now than before.
 

svn path=/trunk/; revision=20886
2007-02-21 00:59:16 +00:00
Gerald Combs 4343de3513 Escape non-ASCII characters in the client and server protocol version strings.
svn path=/trunk/; revision=19748
2006-10-31 01:46:59 +00:00
Anders Broman e65847960f From Stephen Fisher:
Modifie the VNC dissector to desegment 
the "server cut text" message type for cases where the cut text is in 
the next tcp segment from the first part of the message.

svn path=/trunk/; revision=19402
2006-10-03 05:48:47 +00:00
Anders Broman 5c682dd6ee From Stephen Fisher:
A patch to bring the VNC dissector almost to completion.

I have not had a chance to finish the server message type "frame buffer 
update," which are the pixel values for screen rectangle updates.  
Everything else is there - tracking the keys the user is pushing, 
ringing a bell on the client, mouse button pushes/pointer movements, 
etc.

svn path=/trunk/; revision=19145
2006-09-05 05:38:11 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Jörg Mayer f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Ronnie Sahlberg ec3ab9ec3e rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the documentation in README.developer
svn path=/trunk/; revision=15270
2005-08-10 13:41:13 +00:00
Ronnie Sahlberg 7035a45c8f ememify some more tvb_get_string() calls
one memleak in vnc related to tvb_get_string() closed.


svn path=/trunk/; revision=15130
2005-07-28 09:35:27 +00:00
Ulf Lamping 49213d49da Very first start of a dissection of the VNC (RFB) protocol.
This is not much more than the dissector skeleton code.

svn path=/trunk/; revision=13746
2005-03-14 00:53:58 +00:00