Commit Graph

30207 Commits

Author SHA1 Message Date
Guy Harris a4b7135ce3 Rename BASE_STRUCTURE_RESET to BASE_DISPLAY_E_MASK, to clarify that it's
a mask to select the base_display_e value from a display field in a
header_field_info structure.

Never select that value by masking out the BASE_RANGE_STRING flag bit,
as that won't continue to work if more flag bits, or other bitfields,
are added.  Instead, mask with BASE_DISPLAY_E_MASK.

Note that the base_display_e value and BASE_RANGE_STRING flag are only
for integral field types, and clarify what BASE_DISPLAY_E_MASK is.

Give at least one of the reasons why hiding protocol fields is not
considered a good idea.

svn path=/trunk/; revision=31249
2009-12-12 03:15:28 +00:00
Guy Harris ed9f7440e3 Clarify that BASE_RANGE_STRING is a flag set in the display field, not
itself a valid value for that field - it should be ORed with a value.

Indicate that it will never be possible to record in a header_field_info
a byte order for all fields, as some protocols do not specify the
endianness of fields (for example, DCE RPC uses "receiver makes it
right", with the sender sending data in its byte order, with an
indication in the packet of what that byte order is).

svn path=/trunk/; revision=31248
2009-12-12 02:33:16 +00:00
Balint Reczey 6b45b0a901 Suggest solutions on the missing MIBs popup window.
svn path=/trunk/; revision=31247
2009-12-12 01:41:32 +00:00
Jaap Keuter 6af0e4e002 From Richard Pecl:
Adding prefs_register_protocol_subtree to libwireshark.def

svn path=/trunk/; revision=31246
2009-12-11 17:35:10 +00:00
Jaap Keuter ba0c85ba08 From Pascal Quantin:
The attached patch force 'svn info' command output as english to enable
detection of svn revision, whatever language is configured in Windows.

svn path=/trunk/; revision=31245
2009-12-11 17:24:57 +00:00
Jaap Keuter 3cb9c84da1 From Martin Willi:
The attached patch fixes the check for types with the long extension format and re-enables it.

svn path=/trunk/; revision=31244
2009-12-11 17:18:00 +00:00
Martin Mathieson 63fc401318 From Pascal Quantin: add PDCP framing method over UDP.
svn path=/trunk/; revision=31243
2009-12-11 14:31:40 +00:00
Jörg Mayer 32141ae771 Add new files
svn path=/trunk/; revision=31242
2009-12-11 11:38:49 +00:00
Guy Harris 56cffa1135 Put in missing comma.
svn path=/trunk/; revision=31241
2009-12-11 09:11:42 +00:00
Jaap Keuter fc5cc7a7fb Fix for bug 3801:
Following r28546 and r30953 this adjusts the timescale in the RTP Graph Analysis, restoring its operation.

svn path=/trunk/; revision=31240
2009-12-11 08:53:19 +00:00
Guy Harris ac73800bfa Just use abs_time_secs_to_str() to display UTC times, now that it has a
flag to tell it to format the time in UTC.

svn path=/trunk/; revision=31239
2009-12-11 08:45:45 +00:00
Guy Harris 818b8c3878 Protect against localtime() failing.
svn path=/trunk/; revision=31238
2009-12-11 08:08:05 +00:00
Guy Harris 38316e0483 The pointer is "tmp", not "tm".
svn path=/trunk/; revision=31237
2009-12-11 07:17:09 +00:00
Guy Harris 229b262e15 Squelch warnings.
svn path=/trunk/; revision=31236
2009-12-11 07:14:52 +00:00
Anders Broman 141e1fb3b3 From Andreas Heise:
fix missing display of max skew in reversed d.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4320

svn path=/trunk/; revision=31235
2009-12-11 06:44:47 +00:00
Guy Harris 488253bfe7 Add the time zone abbreviation to the result of abs_time_to_str() and
abs_time_secs_to_str().

svn path=/trunk/; revision=31234
2009-12-11 03:39:17 +00:00
Guy Harris 0d337768a7 Split "willcollect" into its two component words.
Document "-z conv,ipv6" for Wireshark.  Rewrite the descriptions of the
"-z conv,{type}" options a bit.

svn path=/trunk/; revision=31233
2009-12-11 02:31:47 +00:00
Guy Harris c6a5eacc1b As long as we have an IPv6 tap, we might as well add a "conv,ipv6"
statistic to TShark.

svn path=/trunk/; revision=31232
2009-12-11 02:19:41 +00:00
Jaap Keuter 0209b3014d From Clif Bratcher:
Support for IPv6 in the Conversations window.
Add IPv6 tab to the Endpoints window

svn path=/trunk/; revision=31231
2009-12-10 23:18:08 +00:00
Jaap Keuter 1e9498cf25 From Clif Bratcher:
Add a tap hook to the IPv6 dissector.

svn path=/trunk/; revision=31230
2009-12-10 23:15:12 +00:00
Stephen Fisher b665a515a8 Generated fields should not highlight any bytes in the packet bytes pane.
This is especially true in this case because the indication that an arp
packet is gratuitous is determined with the following code, which checks
multiple fields:

  if (((ar_op == ARPOP_REQUEST) || (ar_op == ARPOP_REPLY)) && (memcmp(spa_val, tpa_val, ar_pln) == 0))
    is_gratuitous = TRUE;
  else
    is_gratuitous = FALSE;


svn path=/trunk/; revision=31229
2009-12-10 22:35:09 +00:00
Guy Harris ab0a5a3e15 Show absolute times as UTC, as was done before.
svn path=/trunk/; revision=31228
2009-12-10 22:20:18 +00:00
Guy Harris 4fde145bd2 Add an argument to abs_time_to_str() and abs_time_secs_to_str()
indicating whether the time should be shown as local time or UTC.  For
now, always pass FALSE, meaning "show as local time".

Clean up some stuff in the SNMP dissector, use abs_time_secs_to_str()
for times with one-second resolution, and update a comment in various
macros in the WSP dissector, while we're at it.

svn path=/trunk/; revision=31227
2009-12-10 22:19:29 +00:00
Guy Harris e1a76d5e2b Well, not quite - proto_tree_add_item() doesn't work on FT_ABSOLUTE_TIME
fields, as there are several different possible time formats, and
there's not yet any way to specify the particular format.  However, we
don't need to format the time stamp - let the Wireshark core code do that.

svn path=/trunk/; revision=31226
2009-12-10 22:15:59 +00:00
Guy Harris 28ccd651bf Just use proto_tree_add_item(), don't use a fancy sequence of code that
yields the same result.

svn path=/trunk/; revision=31225
2009-12-10 21:59:35 +00:00
Guy Harris 9a4bdbf9ea Use existing code to format relative and absolute times.
svn path=/trunk/; revision=31224
2009-12-10 20:48:31 +00:00
Bill Meier 4bc9b95d69 Fix Bug #4319: IPMI dissector crash (on Windows) displaying date/time;
Using strftime(..., "%F %T", ...) crashes on Windows (VC9) (!!);
Use "%Y-%m-%d %H:%M:%S" instead.....

svn path=/trunk/; revision=31223
2009-12-10 20:26:39 +00:00
Stephen Fisher 2e94d6c37a Add a simple description to the PID field.
svn path=/trunk/; revision=31222
2009-12-10 19:15:37 +00:00
Bill Meier f3c1957f7c Fix Bug 4316: Crash when using custom RADIUS dictionary.
(The bug was caused by a variable not being initialized).
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4316

svn path=/trunk/; revision=31221
2009-12-10 18:13:38 +00:00
Gerasimos Dimitriadis 224298d17c Fix for Bug 4311:
Update context in case of Get Body Chunk; recognize empty body packets

svn path=/trunk/; revision=31220
2009-12-09 23:14:31 +00:00
Gerasimos Dimitriadis 2e138172a2 Constrained SEQ OF in PER encoding associated with wrong length;
also take into account cases of length 0.

svn path=/trunk/; revision=31219
2009-12-09 21:18:04 +00:00
Gerasimos Dimitriadis 142b31816c From Mathieu Parent:
Dissector for LDAP Content Synchronization Operation
(Modified in order to remove the unneeded oid_add_from_string's)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4309

svn path=/trunk/; revision=31218
2009-12-09 20:59:20 +00:00
Stig Bjørlykke 5333f8ac36 Cleanup some column alignment code.
svn path=/trunk/; revision=31217
2009-12-09 16:16:04 +00:00
Stig Bjørlykke f10882a1f8 Save column alignment in the old packet list.
svn path=/trunk/; revision=31216
2009-12-09 15:50:20 +00:00
Stig Bjørlykke 40b1be25fa Moved column xalign values.
svn path=/trunk/; revision=31215
2009-12-09 15:48:38 +00:00
Stig Bjørlykke f9ef0270eb Added "No Sorting" and Align menu items to the old packet list
heading popup menu.

svn path=/trunk/; revision=31214
2009-12-09 14:40:19 +00:00
Stephen Fisher 233bb9cd25 When reading NetMon capture files version 2.1 and higher (the latest is 2.2 right
now), the capture file's header encapsulation type is set to 1 for Ethernet for
backwards compability only.  These files use per-packet encapsulation types
instead.  For now, set it to Unknown file encapsulation until we can find a
way to set it to WTAP_ENCAP_PER_PACKET without having to assert in wtap_read()
so the user can see that it is a per-packet encapulation in places such as
the capinfos program.


svn path=/trunk/; revision=31213
2009-12-09 03:27:12 +00:00
Guy Harris 4ac5594f7b Note that there are similar functions to the "to_hexstr" functions
in strutil.c.

svn path=/trunk/; revision=31212
2009-12-09 01:31:41 +00:00
Jaap Keuter ff810ee91c Following bug 4302 added ctime() to the deprecated list.
svn path=/trunk/; revision=31210
2009-12-08 22:26:04 +00:00
Jaap Keuter 0960a7221b Add the Id tag.
svn path=/trunk/; revision=31209
2009-12-08 22:21:51 +00:00
Jaap Keuter f4cd9164cb Make the check work on hexadecimal bitmasks.
svn path=/trunk/; revision=31208
2009-12-08 22:10:35 +00:00
Jaap Keuter 0bd900a72b Fix header field names containing dots.
Move excessive long texts to header field blurb.

svn path=/trunk/; revision=31207
2009-12-08 22:05:55 +00:00
Anders Broman 0f8ab929a6 When freezing/thawing selection gets lost.
svn path=/trunk/; revision=31206
2009-12-08 16:14:01 +00:00
Stig Bjørlykke 86e83facfc Added GCRYPT_LIBRARIES to capinfos.
svn path=/trunk/; revision=31205
2009-12-08 11:04:52 +00:00
Stig Bjørlykke d71b1088f7 From Jakub Zawadzki:
Fix win64 build.

svn path=/trunk/; revision=31204
2009-12-08 10:17:37 +00:00
Stig Bjørlykke 7885ac7b92 Added defines for protocol identifier.
Added hf_addr_ext_form_orig for Originator.
Rewrote strings for addr_form.
Indicate national protocol.
Added expert info for unknown compression.
Some code cleanup.

svn path=/trunk/; revision=31203
2009-12-08 10:14:22 +00:00
Martin Mathieson f1977c1eb7 Add a link to protocol wiki page, where link to example program for UDP framing may be found.
svn path=/trunk/; revision=31202
2009-12-08 10:07:27 +00:00
Anders Broman e59f952b98 From Jakub Zawadzki:
Replace some g_snprintf() with 'probably' faster version.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4303

svn path=/trunk/; revision=31201
2009-12-08 07:45:06 +00:00
Anders Broman 62c3372576 From Jakub Zawadzki:
ctime() is not thread safe and it's obsolete.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4302

svn path=/trunk/; revision=31200
2009-12-08 07:41:43 +00:00
Stephen Fisher c70da4bd10 Update my AUTHORS entry with a few new items
svn path=/trunk/; revision=31199
2009-12-08 07:31:26 +00:00