a protocol tree;
the column values.
This includes stats-tree listeners.
Have the routines to build the packet list, and to retap packets, honor
those requirements. This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.
This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.
While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.
Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.
Clean up some indentation and some gboolean vs. gint items.
svn path=/trunk/; revision=28645
generated from pycrc. The command line used to generate the file is in
epan/crc/Makefile.common. I used "plain" to distinguish it from CCITT,
USB, and other 16-bit CRCs. Integrate the new CRC code into our
infrastructure.
Add crc16_plain_tvb_offset() to epan/crc16.[ch] and use it in
plugins/profinet/packet-pn-rt.c. This _should_ work correctly, but
hasn't been tested.
svn path=/trunk/; revision=27790
- As suggested actually use sizeof(...) rather than a numeric constant.
- g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1.
svn path=/trunk/; revision=27772
that would break compilation for older compilers. Create a "DLL_LDFLAGS"
variable and use it in DLLs and plugins. Use PLUGIN_LDFLAGS and
DLL_LDFLAGS where needed. Don't force i386 code in the TPG plugin.
svn path=/trunk/; revision=27582
As of version 0.99.8, there has been an annoying problem in the ASN.1 dissector:
when using a 'type table' which discribes the ASN.1 syntax of the traced packets,
wireshark would crash on the very first packet. The cause for the crash is an out-of-
boundry write, detected by g_free().
svn path=/trunk/; revision=27507
There was an ugly hack while creating the menu, that tried to detect the stat_group a stats_tree belongs to by looking at the name string. That makes it unnecessarily hard to understand how the menu is really created.
Fix: Add a new function stats_tree_register_with_group() that takes the stat_group as a parameter. Use this function where a stats_tree doesn't fit into the default "unsorted" group.
svn path=/trunk/; revision=27407
should be "%s", with the string used as an argument, just in case the
string contains a "%" character.
Clean up indentation.
svn path=/trunk/; revision=27304
Add some heuristics to the RLM LAPD-over-UDP dissector, so as not to
misdissect as many packets.
Fetch the LAPD dissector handle only once.
Change some Boolean arguments to gboolean from int.
svn path=/trunk/; revision=27217
Remove global variables for packet information, pass these through function calls.
Reduce label_SUB[M|A]_[Method|Attribute] routines.
Actually check column status before writing to it.
svn path=/trunk/; revision=27199
proto_reg_handoff time and store the result.
If we don't call the mtp3 dissector on the payload then call the data dissector
to make it easier to see the payload.
svn path=/trunk/; revision=27160
rudp looks up the ciscosm dissector for every single packet. Make this a one
time in proto_handoff and use the dissector handle.
While at it - decode the checksum when there is one. An indicator is that the
header length has space for the checksum.
Additionally we have seen "stray bytes" after the checksum we can't explain. So
decode them as data when there are some.
svn path=/trunk/; revision=26427
holding those addresses to "void *" and then to "char *" (so we don't
get warnings from casting directly to "char *" or errors from
subtracting two "void *"s), and subtract them, rather than casting the
pointers to an integral type possibly shorter than the pointers (to
avoid warnings and to avoid the admittedly-infinitesimal chance that the
two pointers don't differ in the bits that fit into the integral type).
svn path=/trunk/; revision=26151
packet-infiniband.c:806: warning: variable 'next_tvb' might be clobbered by `longjmp' or `vfork'
seen with gcc 3.4.6 (building for 32-bits on a pentium 4).
svn path=/trunk/; revision=25916
Removed the line
tvb_ensure_bytes_exist(tvb, offset, 44);
from again.
This is not correct, because the frame might have been captured before the
os added the padding bytes. E.g. in Windows the frames are captured on the
protocol layer. When another protocol driver sends a frame this frame does
not include the padding bytes.
Also the dataLength variable in case of bMox==TRUE was not calculated
correctly.
svn path=/trunk/; revision=25738
The ULMAP decoder can get a wrong bit offset when decoding CQICH_Alloc_IE.
The finishing position shoud not pad to byte but pad to the length specified,
which can be nibble aligned.
svn path=/trunk/; revision=25703
and "deprecated" groups the default. Add an "abort" group for code that
shouldn't exit the program. Update the makefiles to call "checkAPIs.pl
-g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl.
svn path=/trunk/; revision=25614