Commit Graph

60 Commits

Author SHA1 Message Date
Gerald Combs c2f0cd5144 Add back DIRTY_CORBA_IDL_DISSECTOR_SRC.
Add DIRTY_CORBA_IDL_DISSECTOR_SRC back to our various makefiles and move
packet-cosnaming.c back to it.

Change-Id: I2f0427ad47bf0e2f166577608da7f5feaf848a48
Reviewed-on: https://code.wireshark.org/review/10691
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-29 22:51:38 +00:00
Michael Mann a9445a4d36 idl2wrs: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
It looks like "items" could have contributed to fields/data being at an incorrect level off of a tree.

Change-Id: I93616ef8b6b364c578f989882045dee42cb6d3c3
Reviewed-on: https://code.wireshark.org/review/8558
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-28 20:11:05 +00:00
Dario Lombardo e1dee7cfb6 dcerpc: fixed distcheck.
Change-Id: Ide0b95278786d45d9c41fb0fe3214dce0880b830
Reviewed-on: https://code.wireshark.org/review/10355
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-02 11:49:19 +00:00
Dario Lombardo 87f2bd45fc idl2wrs: some code cleanups.
Code cleanups include:
- sanity checks for malloc()
- change forbidden APIs into g_* versions
- minor indentation fixes
- add modeline
- add compilation for cmake and autotools

Bug: 11052
Change-Id: I825f04d9703448f9165d188be2bdd185fce5ff5d
Reviewed-on: https://code.wireshark.org/review/10030
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-02 02:28:23 +00:00
Guy Harris 7208355fb9 Don't put CORBA IDL dissectors in ASN1_ variables.
Put them into separate CORBA_IDL_ variables, to keep the two types of
generated dissectors separate.

Change-Id: I4eb091a76ba5bc7d73533ef38fb29adc12a8ec42
Reviewed-on: https://code.wireshark.org/review/7250
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-02-19 10:15:06 +00:00
Stephen Fisher cbc5faa06c Get rid of some GNU make extensions so users can build with
the make that comes with *BSD and other systems now.

Change-Id: Ib2eee8d37e7029202675bac35839b1c0d5fc5131
Reviewed-on: https://code.wireshark.org/review/6320
Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2015-01-05 17:47:56 +00:00
Alexis La Goutte 73613d414a Remove DIRTY_DISSECTOR_SRC
x11 dissector don't have longer warning !
and fix different between Autotools and CMake (about gsm_a_common dissector)

Change-Id: Id9da62d84b8b0bb4b0ed5d8fc62abba4e2442ed2
Reviewed-on: https://code.wireshark.org/review/4621
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-13 02:06:12 +00:00
Alexis La Goutte 4e328e4709 DCERPC: Remove DIRTY_PIDL_DISSECTOR_SRC
Now mapi and drsuapi build without warning !

Change-Id: Iae19af2fd06fd998a13696ba2adf6cd12d311f58
Reviewed-on: https://code.wireshark.org/review/4619
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-12 17:46:58 +00:00
Роман Донченко 549f5c401c Remove obsolete comments regarding the shell version of make-dissector-reg
Change-Id: I93470e8c6e9afd6c1ebf735eb13141586964be0e
Reviewed-on: https://code.wireshark.org/review/3818
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-08-24 20:45:26 +00:00
Jeff Morriss e99bbef405 Don't show us the full Python command-line for building register.c.
The echo and output of make-dissector-reg.py is sufficient.

Change-Id: I89462435e8966012ec057ccd45adb595f692b0fb
Reviewed-on: https://code.wireshark.org/review/3587
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-08-14 00:32:42 +00:00
Joerg Mayer 65ac652a07 Remove make-dissector-reg and require python for autotool builds as well
Change-Id: I6239063a08ba37199a4e95302a3650a80544c750
Reviewed-on: https://code.wireshark.org/review/3562
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-08-12 21:31:34 +00:00
Роман Донченко afa8f21f56 make-dissectors-reg: optimize by factoring out the loops
Instead of calling the grep/sed pipelines for each file, build the
list of files in the beginning and call each pipeline only once,
passing the list to the first grep.

This results in a massive speedup in Cygwin; in my test, the time
it takes to run make-dissector-reg . dissectors packet-*.c in dissectors/epan
is reduced from ~116 to ~3 seconds. I also tried it on NetBSD, where
the time do to the same goes from ~6 to ~0.5 seconds.

Amend makefile comments to elide mentions of invoking multiple processes
per file.

Change-Id: Iad441e7d2b6cc3669dada57646e2f8f6b987fd34
Reviewed-on: https://code.wireshark.org/review/2826
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-07-06 08:08:20 +00:00
Stig Bjørlykke bd38b3152d Support out-of-source checkapi
Always call $(top_srcdir)/tools/checkAPIs.pl with -sourcedir=$(srcdir)
from Makefile.am to allow out-of-source 'make checkapi'.

Change-Id: I60d7e0079984a8ededdacf4517a0738486fa7973
Reviewed-on: https://code.wireshark.org/review/1294
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-25 04:23:46 +00:00
Alexis La Goutte 757aa33220 Continue to remove $Id$ from top of file
(Using sed : sed -i '/^\# \$Id\$/,+1 d') (start with dash)

Change-Id: Ia4b5a6c2302f6a531f6a86c1ec3a2f8205c8c2dd
Reviewed-on: https://code.wireshark.org/review/881
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-31 18:48:06 +00:00
Michael Mann d8265cd8c6 Remove Visual Studio solution and project files (and their existence from Makefiles)
There have been discussions on -dev about removing this and I believe I was the last holdout. Finally convinced that I should just have a local copy (ignored by git)

Change-Id: Ic72a22baf58e3412023cf851f0fce16eb07113b0
Reviewed-on: https://code.wireshark.org/review/681
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-16 18:03:41 +00:00
Alexis La Goutte e5482196b2 Fix indent (Remove space and use tabs)
Change-Id: I9cc33a43e0f06dfad3f9fb53ad0df636f2ea7020
Reviewed-on: https://code.wireshark.org/review/615
Reviewed-by: Evan Huus <eapache@gmail.com>
2014-03-12 16:26:51 +00:00
Martin Kaiser 35708dfd13 create libfiledissectors.a during the autotools build
svn path=/trunk/; revision=50097
2013-06-21 00:08:20 +00:00
Jaap Keuter 827eb58b04 From David Arnold:
Replace use of INCLUDES with AM_CPPFLAGS in all Makefiles to placate recent autotools.

svn path=/trunk/; revision=48261
2013-03-12 06:53:39 +00:00
Jeff Morriss 0dc1b8b4b2 Run checkAPIs on DISSECTOR_SUPPORT_SRC too. This means we check register.c
(not very useful) but it means we'll also check the IPMI subparsers and
usb.c .  (Yes, register.c could be split out into Yet Another Variable but
I'm not sure it's worth it...)

svn path=/trunk/; revision=46399
2012-12-05 15:11:08 +00:00
Stig Bjørlykke 29cdc9a4cf Added Custom.common as dependency for register.c
svn path=/trunk/; revision=44137
2012-07-30 13:54:02 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Jeff Morriss af87b31852 Allow custom dissectors in automake too.
svn path=/trunk/; revision=42707
2012-05-18 16:20:36 +00:00
Jeff Morriss 75c3c92f19 Add a "-build" argument to checkAPIs.pl. Use that argument when building
from makefiles (and thus from the buildbot).

The intention is to be able to tell when a human is running the tool so we
can provide more code-review guidance.

As a starter, enable the "too many proto_tree_add_text() calls" check when
a human is running the tool.

svn path=/trunk/; revision=41943
2012-04-04 20:46:49 +00:00
Jörg Mayer 9781eaf0f5 Sync filelists between autofoo and cmake.
Move some dissectors that throw warnings to DIRTY_
Whitespace cleanups

svn path=/trunk/; revision=40478
2012-01-13 19:29:58 +00:00
Gerald Combs 453d491eae Add Makefile.common to the dependency list for register.c.
svn path=/trunk/; revision=36736
2011-04-20 17:08:40 +00:00
Jeff Morriss c755b2fd54 Oh yeah, there's a reason we don't put targets in Makefile.common: the first target in a makefile is what you get when you just run make (without a target). Revert 35073 and 35069.
svn path=/trunk/; revision=35075
2010-11-30 02:04:55 +00:00
Jeff Morriss f1c066bbee Move some checkapi targets into Makefile.common
svn path=/trunk/; revision=35073
2010-11-29 22:34:04 +00:00
Gerald Combs bc9f8d0cd7 Add Visual C++ project files to the distribution.
svn path=/trunk/; revision=33386
2010-06-30 23:20:03 +00:00
Jeff Morriss 7575b52df7 Add epan/dissectors/dcerpc/ and epan/dissectors/pidl/ to the source distribution
svn path=/trunk/; revision=32879
2010-05-18 15:58:49 +00:00
Jeff Morriss 54082c6ed0 Add Cmake stuff to the source distribution so more people can try it out.
svn path=/trunk/; revision=32807
2010-05-14 16:27:03 +00:00
Jeff Morriss 4661aad9a4 Run checkapi on the dissector header files
svn path=/trunk/; revision=29883
2009-09-13 19:48:22 +00:00
Jeff Morriss ee8f078374 Move all of the scripts in epan/dissectors/ to tools/ .
Add a target ("x11-dissector") to build the X11 dissector.

Put the X11-related files (back) in the source distribution.

svn path=/trunk/; revision=29871
2009-09-12 23:02:34 +00:00
Jeff Morriss 961cd3c6ce From Peter Harris via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2981 :
This patch adds extension support to the X11 dissector.

I've removed the perl script from the make file, since the new one depends on
perl 5.10, xcbproto (at least git as of today), and mesa (at least the
mesa/src/mesa/glapi directory). It seemed easier to just add the generated
header files to svn directly.

svn path=/trunk/; revision=29854
2009-09-11 01:57:59 +00:00
Gerald Combs 367bcb7abd Clean up the last two DIRTY_DISSECTOR_SRC entries.
svn path=/trunk/; revision=29321
2009-08-07 00:15:35 +00:00
Gerald Combs bbac96dcd4 Add Custom.nmake to the distribution.
svn path=/trunk/; revision=26818
2008-11-20 23:07:26 +00:00
Guy Harris 317201b985 Give macros and libraries names that imply that clean dissectors are the
normal case, and dissectors with warnings are the exception; the
ultimate goal is to have only clean dissectors.

Move a bunch of now-cleaned-up dissectors into the "clean" category.

Fix a comment.

svn path=/trunk/; revision=26096
2008-08-26 03:45:42 +00:00
Guy Harris f0acec0696 Fix some macro name errors.
svn path=/trunk/; revision=26092
2008-08-26 01:32:15 +00:00
Guy Harris d7a51fc7de Get rid of an unused variable in the P7 dissector.
Create a set of warning-clean ASN.1 dissectors and build them with
-Werror, to try to prevent errors creeping back in.  Put the P7
dissector there.

svn path=/trunk/; revision=26090
2008-08-26 01:04:39 +00:00
Guy Harris a04774395f Add Makefile.common files for epan/dfilter and epan/ftypes.
Add checkapi rules to Makefile.am files.

svn path=/trunk/; revision=25656
2008-07-02 01:44:30 +00:00
Stig Bjørlykke a6958ba14b Quote argument to test in epan/dissectors/Makefile.am
svn path=/trunk/; revision=24489
2008-02-27 16:27:42 +00:00
Stephen Fisher f002ac6db5 Fix various warnings
Move packet-cops.c out of clean dissectors due to a #define conflict
in the headers of net-snmp with our config.h


svn path=/trunk/; revision=21398
2007-04-13 00:50:23 +00:00
Gerald Combs a0afc5d832 Add a registration symbol cache to make-dissector-reg.py. When you
update a dissector and recompile, make-dissector-reg.py can now pull
its list of registration routines from a cache instead of having to
scan through every dissector.  The time to create register.c has gone
from 20 to 30 seconds down to 2 on my desktop machine.

The cache file is a Python pickle data stream.  It should be portable
across architectures, so we may be able to add it to the distribution
at some point.

svn path=/trunk/; revision=21348
2007-04-06 16:15:36 +00:00
Sebastien Tandel edfd071881 Creation of ALL_DISSECTORS_SRC including all dissectors sources
- used in Makefile.nmake instead of DISSECTOR_SRC
 - used for the target register.c

svn path=/trunk/; revision=21327
2007-04-03 20:22:32 +00:00
Sebastien Tandel 0854c90e87 epan/dissectors/Makefile is now building four libraries :
- asn dissectors : libasndissectors.la
  - pidl dissectors : libpidldissectors.la
  - normal dissectors : libdissectors.la *and* libcleandissectors.la. I
  separated it in two libraries temporarily. The source files used to build
  libcleandissectors.la do not generate warning anymore and the -Werror is used
  to compile them. If we patch a dissector and it doesn't generate warning
  anymore, we have to move the filename dissector from DISSECTOR_SRC to
  CLEAN_DISSECTOR_SRC in epan/dissectors/Makefile.common.

If you want to define specific cflags for one library type, let's say pidl, you
may define libpidldissectors_la_CFLAGS.

svn path=/trunk/; revision=21324
2007-04-03 19:50:04 +00:00
Jörg Mayer b1719dd68f Albert Chin:
Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1078


svn path=/trunk/; revision=19103
2006-08-31 13:14:48 +00:00
Jörg Mayer e226affa31 stephentfisher@yahoo.com:
Adds $(LIBGCRYPT_CFLAGS) to two Makefiles
	(fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1005)


svn path=/trunk/; revision=18753
2006-07-17 19:37:21 +00:00
Gerald Combs b15974d094 libethereal -> libwireshark. idl2eth -> idl2wrs. There are a _lot_ of
changes here.  It compiles OK on OS X, but hasn't been tested anywhere else.

svn path=/trunk/; revision=18260
2006-05-31 00:23:01 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Guy Harris fd1cec8917 Rename "make-reg-dotc" to "make-dissector-reg", and do the same for the
Python versions, as it no longer makes only "register.c", it can also
make a "plugin.c" file for a plugin.

When making "plugin.c", there's no need to include "register.h", as it's
not defining any functions declared there.

svn path=/trunk/; revision=17919
2006-04-20 02:21:28 +00:00
Guy Harris 0c873b006a Update comments.
Fix the Makefile.nmake files to pass the output type argument to
make-reg-dotc or make-reg-dotc.py.

Make tools/make-reg-dotc executable.

svn path=/trunk/; revision=17904
2006-04-19 09:52:23 +00:00