Function dissect_epath() expects path_length in bytes, but the value from the
packet is in words, so there's lots of *2 and /2 in those parts of the code.
In this invocation dissect_epath( tvbIOI, pi, 0, preq_info->IOILen, TRUE );
preq_info->IOILen is in words.
In six places proto_tree_add_item is used with tvb NULL and size 0 to add an
FT_UINT8/16/32 item. I think it should be replaced with proto_tree_add_uint().
svn path=/trunk/; revision=30061
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3542)
The current get_dfs_referral response code is based on old protocol specs,
which are unofficial, erroneous.
I modify packet-smb.c to be confirm to protocol's official spec. Some
changes are:
1. handle referral entry version 2, 3, 4 separately. The current code does
not distinguish v3 from v2, however they are not same.
2. change server type, referral flags etc.
3. refactor some code, such as string dissecting.
Also: From me: a small change to handle possible overflow
when subtracting from a guint16.
svn path=/trunk/; revision=29986
Errors occur which means decrypted_len - esp_iv len will render a negative value and thus
cause the problem. This patch prevents the crash. Not sure if this is a proper fix. At least it
looks like a sane check to do.
svn path=/trunk/; revision=29979
In ntp_fmt_ts() in packet-ntp.c time stamps are displayed to 4 digits (0.1
msec). More digits may be significant (e.g., if GPS local clocks are used).
Change time stamp format in g_snprintf() from
%07.4f
to
%09.6f
svn path=/trunk/; revision=29961
epan\dissectors\packet-edonkey.c
In the fuction dissect_emule_sourceOBFU(): the line
ti = proto_tree_add_item(tree, hf_emule_sourceOBFU, tvb, offset, 7 + ((settings & 0x08) ? 16 : 0), FALSE);
should be
ti = proto_tree_add_item(tree, hf_emule_sourceOBFU, tvb, offset, 7 + ((settings & 0x80) ? 16 : 0), FALSE);
and, the line:
if (settings & 0x08)
should be:
if (settings & 0x80)
That is, 0x08 should be revised to 0x80.
reference: the eMule0.49c source code, file PartFile.cpp, line 2730, in the
function CPartFile::AddSources().
svn path=/trunk/; revision=29957
SDNVs are theoretically unlimited in size. The value of most SDNVs in the
Bundle Protocol is practically limited to far less than a 32 bit number. The
initial dissector included only 1 SDNV evaluation routine which returned a 32
bit number. SDNV fields that evaluated to greater than a 32 bit number were
considered in error. One BP implementation chose to add some syntax to one of
the SDNV fields that extends it to more than 32 bits. The patch included here
adds an evaluation routine that will return a 64 bit number. That routine is
called to evaluate the field where it makes sense to have a value in excess of
32 bits.
svn path=/trunk/; revision=29954
Improved AIM protocol dissector:
* Decodes more values acording to official Oscar spec
* Renamed clientautoresp to client_err (as written in spec)
* Fix decoding orror on rendezvous channel
* Other small improvements
svn path=/trunk/; revision=29953
Version 4.8.0 of collectd introduced two new data source types: DERIVE and ABSOLUTE.
With this patch support for the new data source types is added so they are displayed correctly.
svn path=/trunk/; revision=29947
for the MS Power Level and FPC in the L1 Information and MS Power IEs.
This should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4017
(though I don't have a sample capture to verify the fix and that I didn't
break anything.)
svn path=/trunk/; revision=29944
This patch adds statistics information to the collectd dissector.
Changes by me:
- use ep_alloc for structures being handed to the tap(s) (instead of se_alloc)
- Capitalize the Statistics menu item to get it in the sorted list
svn path=/trunk/; revision=29915
