Commit graph

29109 commits

Author SHA1 Message Date
Kovarththanan Rajaratnam
a05517fd21 (Cosmetic) Reorder functions
svn path=/trunk/; revision=30081
2009-09-22 21:08:48 +00:00
Bill Meier
5bbec764db (Trivial) Rework a comment slightly.
svn path=/trunk/; revision=30080
2009-09-22 20:17:31 +00:00
Anders Broman
2d77aab376 Fix: jyoung SVN #30065; Sort order at start of new capture.
svn path=/trunk/; revision=30079
2009-09-22 20:09:04 +00:00
Kovarththanan Rajaratnam
cf8e2654b4 Remove unused 'offset' parameter
svn path=/trunk/; revision=30078
2009-09-22 20:02:51 +00:00
Anders Broman
4827316ea4 - new_packet_list_resize_column() if we get an empty string from
packet_list_get_widest_column_string() (no visible row) don't
change the colum width.
- packet_list_moveto_end() selection no longer needed.

svn path=/trunk/; revision=30077
2009-09-22 19:36:14 +00:00
Kovarththanan Rajaratnam
760eb47fc1 Add initial support for "two pass analysis" in tshark. This allows tshark to arrive at the same protocol tree as the Wireshark GUI. Before this change tshark only supported a single scan over the file. This effectively means that packets cannot use data that are gathered from frames that appear after the current frame. By scanning twice we give the dissector the opportunity to make forward references.
svn path=/trunk/; revision=30076
2009-09-22 19:28:00 +00:00
Anders Broman
2cacda1823 From Vincent Helfre:
MS network capability enhancement.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4039

svn path=/trunk/; revision=30075
2009-09-22 19:15:30 +00:00
Anders Broman
ffcaf32074 Select the first packet when doing a live capture. In the old packet list this is automatically done as the clist emits a selct-row signal.
Seting focus in new_packet_list_moveto_end() seems also to be needed to make it work properly I'm not 100% sure if it should be done differently.

svn path=/trunk/; revision=30074
2009-09-22 18:51:33 +00:00
Kovarththanan Rajaratnam
0ee2b7754d Rename init_cap_file() to cap_file_init()
svn path=/trunk/; revision=30073
2009-09-22 16:53:11 +00:00
Kovarththanan Rajaratnam
07cb929d6b dfilter_free() can handle a NULL pointer so don't guard against that before calling it
svn path=/trunk/; revision=30072
2009-09-22 16:49:26 +00:00
Kovarththanan Rajaratnam
9398b679e8 Introduce cap_file_add_fdata() and start using it
svn path=/trunk/; revision=30071
2009-09-22 16:39:48 +00:00
Kovarththanan Rajaratnam
e44cb94beb Always initialise fdata even when we don't dissect (we access some of fdatas variables)
svn path=/trunk/; revision=30070
2009-09-22 15:22:53 +00:00
Kovarththanan Rajaratnam
a9a1866acf Simply some logic inside process_packet()
svn path=/trunk/; revision=30069
2009-09-22 15:06:52 +00:00
Kovarththanan Rajaratnam
1e8d9b4937 Make frame_data_set_after_dissect() callers do the necessary checks instead
svn path=/trunk/; revision=30068
2009-09-22 14:50:43 +00:00
Kovarththanan Rajaratnam
627a7c1f47 Switch Wireshark GUI (file.c) over to using frame_data.c
svn path=/trunk/; revision=30067
2009-09-22 14:41:30 +00:00
Kovarththanan Rajaratnam
14d2f617c2 Refactor frame_data_init() into frame_data_set_before_dissect() and frame_data_set_after_dissect().
svn path=/trunk/; revision=30066
2009-09-22 14:23:20 +00:00
Anders Broman
08525e79d7 - Add new_packet_list_set_sel_browse()
- When scrolling to the end don't select the row.

svn path=/trunk/; revision=30065
2009-09-22 12:39:16 +00:00
Anders Broman
b8af7c77c8 From Gerasimos Dimitriadis:
Change of IEs in DTAP MODIFY msg.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4032

svn path=/trunk/; revision=30064
2009-09-22 06:42:10 +00:00
Anders Broman
cbf6e507df Fix minor formating issues by hand(bug 4001).
svn path=/trunk/; revision=30063
2009-09-22 06:34:51 +00:00
Anders Broman
b2356161a5 Fix minor formating issues by hand(bug 4001).
svn path=/trunk/; revision=30062
2009-09-22 06:34:00 +00:00
Jaap Keuter
f4b9554a27 From Julian Fielding:
Function dissect_epath() expects path_length in bytes, but the value from the 
packet is in words, so there's lots of *2 and /2 in those parts of the code.
In this invocation dissect_epath( tvbIOI, pi, 0, preq_info->IOILen, TRUE );
preq_info->IOILen is in words.

In six places proto_tree_add_item is used with tvb NULL and size 0 to add an
FT_UINT8/16/32 item. I think it should be replaced with proto_tree_add_uint().

svn path=/trunk/; revision=30061
2009-09-22 05:49:15 +00:00
Kovarththanan Rajaratnam
054ef7aa0f Make sure that the old packet list works with the changes introduced in r30047
svn path=/trunk/; revision=30060
2009-09-22 05:23:45 +00:00
Kovarththanan Rajaratnam
ace2a16807 Constify colour source
svn path=/trunk/; revision=30059
2009-09-22 04:10:50 +00:00
Jaap Keuter
c09c7fd7cd Fix for bug 4034:
Fix for missing register file and cleanup of code in register_all_py_protocols_func().

svn path=/trunk/; revision=30058
2009-09-21 21:28:11 +00:00
Jaap Keuter
f78265be26 Set svn properties and fix Id keyword.
svn path=/trunk/; revision=30057
2009-09-21 21:25:23 +00:00
Stephen Fisher
60b4a9a3c5 Minor white space cleanup.
svn path=/trunk/; revision=30056
2009-09-21 20:20:02 +00:00
Kovarththanan Rajaratnam
1989aa700d Bring frame_data_init() and add_packet_to_packet_list() more in sync by adding 'ref_time' handling to frame_data_init(). For tshark/rawshark this is unused because they only do a single pass through the capture file
svn path=/trunk/; revision=30055
2009-09-21 20:17:59 +00:00
Kovarththanan Rajaratnam
8af452f83d Constify (missed in r30051)
svn path=/trunk/; revision=30054
2009-09-21 20:00:29 +00:00
Kovarththanan Rajaratnam
aa4af67e1b Only set cumulative bytes after passing the display filter test
svn path=/trunk/; revision=30053
2009-09-21 19:48:53 +00:00
Kovarththanan Rajaratnam
c3647b4e3b Move 'Delta timestamp to previous captured frame' calculation inside add_packet_to_packet_list(). This is done in order to streamline add_packet_to_packet_list() with frame_data_init(). Hopefully we can switch to frame_data_init() soon
svn path=/trunk/; revision=30052
2009-09-21 19:30:06 +00:00
Kovarththanan Rajaratnam
3ea9409792 Store 'color_filter' as const in 'frame_data'
svn path=/trunk/; revision=30051
2009-09-21 18:48:53 +00:00
Kovarththanan Rajaratnam
da5b43c80c Don't include header files that are not required
svn path=/trunk/; revision=30050
2009-09-21 18:31:58 +00:00
Kovarththanan Rajaratnam
702b6ea7d0 Remove unused 'vers' member in capture_file
svn path=/trunk/; revision=30049
2009-09-21 18:30:15 +00:00
Kovarththanan Rajaratnam
8b62ba243b Remove unused 'pstats' member in capture_file
svn path=/trunk/; revision=30048
2009-09-21 18:20:01 +00:00
Kovarththanan Rajaratnam
7ca137e294 Rename capture_file.plist to capture_file.plist_start to make it consistent with capture_file.plist_end
svn path=/trunk/; revision=30047
2009-09-21 18:09:19 +00:00
Kovarththanan Rajaratnam
109875c775 Remove second (redundant) assignment to fdata->cum_bytes
svn path=/trunk/; revision=30046
2009-09-21 17:38:10 +00:00
Kovarththanan Rajaratnam
9831d4c4e1 Reverse order of NEW_PACKET_LIST guard, i.e. #ifdef NEW_PACKET_LIST instead of #ifndef NEW_PACKET_LIST
svn path=/trunk/; revision=30045
2009-09-21 17:32:35 +00:00
Kovarththanan Rajaratnam
9e21f0f2d8 Guard fdata->col_text_len/fdata->col_text with NEW_PACKET_LIST
svn path=/trunk/; revision=30044
2009-09-21 17:12:46 +00:00
Stephen Fisher
d923139789 Fix typo in comment
svn path=/trunk/; revision=30043
2009-09-21 17:09:15 +00:00
Kovarththanan Rajaratnam
3c9afabfe0 (cosmetic change) - reset cumulative bytes together with 'first_ts' and 'prev_dis_ts'
svn path=/trunk/; revision=30042
2009-09-21 15:50:15 +00:00
Kovarththanan Rajaratnam
8527133db0 cf->dfilter is only set if it's valid so assert if that's not the case
svn path=/trunk/; revision=30041
2009-09-21 15:38:40 +00:00
Kovarththanan Rajaratnam
112a677484 Reset cumulative bytes when we open the file
svn path=/trunk/; revision=30040
2009-09-21 15:29:32 +00:00
Kovarththanan Rajaratnam
8dc906da00 Set fdata->num up front and roll back if necessary
svn path=/trunk/; revision=30039
2009-09-21 15:23:33 +00:00
Kovarththanan Rajaratnam
03a9cfe84c Shuffle NEW_PACKET_LIST guard
svn path=/trunk/; revision=30038
2009-09-21 14:13:46 +00:00
Kovarththanan Rajaratnam
8f0d93fb12 Add unsigned int type cast
svn path=/trunk/; revision=30037
2009-09-21 14:01:30 +00:00
Kovarththanan Rajaratnam
d86635a3d8 Introduce a NEW_PACKET_LIST specialized version of add_packet_to_packet_list(). The old one contained too many #ifdef NEW_PACKET_LIST which reduced readability
svn path=/trunk/; revision=30036
2009-09-21 12:14:11 +00:00
Michael Tüxen
5879399609 Add initial support for DNS/SCTP.
svn path=/trunk/; revision=30035
2009-09-21 12:00:03 +00:00
Anders Broman
546014cdaf cf_change_time_formats() is not needed with new packet list.
svn path=/trunk/; revision=30034
2009-09-21 11:58:36 +00:00
Kovarththanan Rajaratnam
46b7430557 Move frame_data_init() declaration to frame_data.h
svn path=/trunk/; revision=30033
2009-09-21 11:26:23 +00:00
Kovarththanan Rajaratnam
859bd0f8b2 Make sure that we track the amount allocated when we're doling out memory from the system pool. The verify pointer stuff should should now work with WIRESHARK_DEBUG_EP_NO_CHUNKS=1 and WIRESHARK_DEBUG_SE_NO_CHUNKS=1
svn path=/trunk/; revision=30032
2009-09-21 10:44:59 +00:00