osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
86,808 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

5 Commits

Author SHA1 Message Date
Gerald Combs 9222bd77cd Remove unneeded modelines in ui. 
Remove the editor modeline blocks from the source files in ui that use 4
space indentation by running

perl -i -p0e 's{ \n+ /[ *\n]+ editor \s+ modelines .* shiftwidth= .* \*/ \s+ } {\n}gsix' $( ag -l shiftwidth=4 $( ag -g '\.(c|cpp|h|m|mm)') )

This gives us one source of indentation truth for these files, and it
*shouldn't* affect anyone since

- These files match the default in our top-level .editorconfig.

- The one notable editor that's likely to be used on these files and
*doesn't* support EditorConfig (Qt Creator) defaults to 4 space
indentation.
 2021-04-20 07:43:39 +00:00
Gerald Combs 212ff30603 RTP: Fixup stream ID hashing. 
Update our hash value when calling add_address_to_hash. Fixes:

________________________________________________________________________________________________________
*** CID 1476121:  Incorrect expression  (USELESS_CALL)
/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/build/ui/rtp_stream_id.c: 141 in pinfo_rtp_info_to_hash()
135     	/* SRC PORT | DST_PORT */
136     	/* SSRC */
137     	/* SRC ADDR */
138     	/* DST ADDR */
139     	hash ^= pinfo->srcport | pinfo->destport << 16;
140     	hash ^= rtp_info->info_sync_src;
>>>     CID 1476121:  Incorrect expression  (USELESS_CALL)
>>>     Calling "add_address_to_hash(hash, &pinfo->src)" is only useful for its return value, which is ignored.
141     	add_address_to_hash(hash, &pinfo->src);
142     	add_address_to_hash(hash, &pinfo->dst);
143
144     	return hash;
145     }
146
 2021-04-15 21:01:28 +00:00
Jirka Novak c7f5646249 VoIP dialogs: Performance improvements 
Retap and UI response are much faster when many RTP streams are
processed. RTP Streams/Analyse 1000+, RTP Player 500+.

Changes:
- RTP streams are searched with hash, not by iterating over list.
- UI operations do not redraw screen after every change, just after all
  changes. UI is locked when rereading packets.
- Sample list during RTP decoding is stored in memory so wireshark uses
  just half of opened files for audio decoding than before.
- Analysis window checkbox area is limited in height
- Dialogs shows shows count of streams, count of selected streams and
  count of unmuted streams
- Documentation extended with chapter about RTP decoding parameters
- Documentation extended with performance estimates
 2021-04-14 14:02:58 +00:00
Guy Harris 20800366dd HTTPS (almost) everywhere. 
Change all wireshark.org URLs to use https.

Fix some broken links while we're at it.

Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c
Reviewed-on: https://code.wireshark.org/review/34089
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2019-07-26 18:44:40 +00:00
Jiri Novak 1b4b5e59e9 RTP: Encapsulation of comparsion of two rtpstreams 
Changes:
- rtpstream_id_t is introduced and its related functions. It encapsulates comparsion of two rtpstreams.
- dest_* renamed to dst_*
- src_port and dst_port are 16bits only.
- sharkd_session.c use common id functions
- IAX2 part related to RTP updated to common *id* function

Change-Id: Id38728a4e5d80363480c7ce42ff9c6eaad069686
Reviewed-on: https://code.wireshark.org/review/28340
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-06-20 08:26:31 +00:00