Commit Graph

86808 Commits (9eeffdc5eb4495446e4869d3b31306a930c44af4)

Author SHA1 Message Date
John Thacker 9eeffdc5eb Fix item length in ASN.1 templates too
Some of the item length changes in !9655 needed to be done with
the ASN.1 templates so that they don't get lost on ASN.1 regeneration.

Fixup ed8ee831fd
2023-02-25 10:48:14 -05:00
Martin Mathieson 93ec018c09 ORAN FH CUS: add section extensions 16, 17, 18, 21 2023-02-25 14:46:01 +00:00
David Perry 1f59c18769 Change some `wmem_packet_scope()` to `pinfo->pool`
As requested [here][1] by @eapache, help with removing calls to
`wmem_packet_scope()` in favour of references to `pinfo->pool`.

* Plugins chosen semi-randomly.
* When a calling function already has a `pinfo` argument, use that.
    * Remove `_U_` from its signature if it was there.
* If a function seems narrowly focused on getting and (possibly)
  returning memory, change the function signature to take a
  `wmem_allocator_t *`.
* If it seems more focused on packet-based operations, pass in a
  `packet_info *` instead and use `pinfo->pool` within.
    * If there are several functions defined with the same call
      signature, add `pinfo _U_` to the argument list of similar
      functions in order to maintain clarity/symmetry.

2023-02-25 05:32:48 +00:00
Zach Chadwick 39aa3cb58a Sharkd: Fix types of prev_frame and ref_frame
The 'frame' command accepts both 'prev_frame' and 'ref_frame' as arguments.
Both should be defined as a UINTEGER rather than a BOOL.
2023-02-25 03:28:18 +00:00
John Thacker ef0e96e447 Qt: Revert to our function for displaying bit speed with units
The Qt formattedDataSize() locale aware function only handles
sizes in bytes, not other units. Revert to using our format_size()
function from wsutil for the bits per second display string in
the Conversation window.

Fix #18211
2023-02-25 01:45:35 +00:00
Jaap Keuter b41a65f99a Draft: wslog: simplify log domain tokenize 2023-02-24 22:13:02 +00:00
Dr. Lars Völker 99c18410e1 TECMP: Changing voltage from string to double 2023-02-24 21:36:19 +00:00
Martin Mathieson c0ba634942 ORAN FH CUS: Add ext20 2023-02-24 21:14:26 +00:00
Dr. Lars Völker 7eeb8daa05 UDS: Fixing names of RDTCI subfunctions 0x0b-0x0e
This fixes the dissection of RDTCI subfunction.

Fixes: #18873
2023-02-24 15:40:36 +00:00
Alexis La Goutte 7bb5cc2c8f fix conflict 2023-02-24 13:50:16 +00:00
Dr. Lars Völker 80ecd172c7 PTP: Fix wrap around issue in PTP analysis code
The PTP analysis code did not support very long traces, in which the PTP
seqid wrapped around (~2.27 hours with 125ms intervals). This is fixed
by ensuring that PTP messages are only matched, if less than 60s apart.

Fixes: #18872
2023-02-24 12:43:59 +00:00
Martin Mathieson 276a70ea92 Fix more warnings from tools/ 2023-02-24 11:11:34 +00:00
Alexis La Goutte bb4548479c .mailmap: Fix Huang Qiangxiong Name 2023-02-24 09:41:46 +00:00
Alexis La Goutte e3aeef70b0 .mailmap: sort file 2023-02-24 09:41:46 +00:00
Alexis La Goutte 6c2b80788d protobuf: fix typo
mssage => message
2023-02-24 09:41:46 +00:00
Alexis La Goutte a65f332abd protobuf: Fix Clang Warning Analyzer
line 764: Value stored to 'subtree' is never read
2023-02-24 09:41:46 +00:00
Dr. Lars Völker b0487565ad TECMP: Fix voltage representation in vendor data
Fixes: #18871
2023-02-23 16:43:53 +01:00
John Thacker 5948274adb Qt: Show date for abs time for long captures in Conversations
Display the date with the absolute time if a conversation in the
conversation table is over 24 hours long. Parse user entered filter
strings for date times as both date times and dates.

Fix #16092
2023-02-23 12:59:50 +00:00
John Thacker 0bd4d9b132 Qt: Mapping between filter proxy column and displayed column
We need to convert between the column selected for filtering
by the user (which is based on what is currently displayed in the
tab) and the column in the model.

The default mapToSource requires a QModelIndex and needs a row,
and thus doesn't work when all rows are filtered out by the current
filter (that is being replaced.) However, since our filterAcceptsColumn
does not depend on the row, we can determine the mapping just based
on the column number.

We want to convert the filter column to the column used in the model
when it is first selected, so that hiding columns later doesn't
accidentally change what column is used for filtering.

Improved fix #18738
2023-02-23 11:23:41 +00:00
João Valverde 91366f56f2 WSDG: Minor logging documentation enhancements 2023-02-23 09:13:07 +00:00
David Perry 9730610c0b TLS: use macros for GREASE checks
The tests in `packet-tls-utils.c` for GREASE values aren't strictly
correct, in that they would falsely ignore a value such as 0x1a2a.

Create a macro to replace this test, which also serves to document the
intent of the test to future developers.

Also create a macro for the reserved values of QUIC transport parameters
which serve a similar function as GREASE.
2023-02-23 01:29:26 +00:00
Alexis La Goutte 56b97c0fa5 file-pcapng-darwin: fix Dead Store found by Clang Analyzer 2023-02-22 22:35:36 +00:00
Mathis Marion e6e3d0e50c Fix Wi-SUN LBS-IE dissector 2023-02-22 19:46:56 +00:00
ismaelrti 4f37a9f450 RTPS: Improving support queries dissection
- Added topic name (tq) suffix in the column information.
- Added topic query kind field dissection
- Added filter for last and intermediate DATA_SESSION submessages
2023-02-22 08:49:00 +00:00
João Valverde a2bc5bd012 doc: Update header preamble for dissector skeleton 2023-02-22 07:09:36 +00:00
John Thacker 33493cb602 Qt: Fix conversation dialog timeline graph columns
Remove the separate copy of the conversation column type
enum in ConversationDialog. It doesn't correspond to the
enum in ATapDataModel, because it doesn't include the
Conversation ID and Total columns.

Delegates set to the Traffic Tree (a QTreeView) apply to
the displayed column number, not the what is displayed
in the column. That is, when columns are hidden (filtered),
the delegates stay with the old column number and end up
being displayed on new content. That's not what we want;
we want to always have the timeline graph on the Start and
Duration columns. Moving around the Delegate depending on
which columns are filtered is complicated; just set the
TimeLine delegate to the entire TrafficTree, and use the
default paint if we're on any column other than Start or
Duration. This does mean that we don't need to store a
map of Delegates.

Use a slightly different way to get TimelineDelegate to
paint the rect with no text using the current style, so
we can use the default paint with text for other columns.

The timeline graph needs to get the value of the Start and
Duration columns as filtered by the proxy column, so have
the model pass in indices so that they can be mapped to
the current displayed column.

Have the timeline graph apply to just the Start or just the
Duration column if only one is visible.

Together these compute the proper pixel values to apply
the timeline graph to the Start and Duration columns regardless
of which columns are displayed and which are filtered, in any
tab, regardless of what optional columns appear in that tab.

Fix #18860
2023-02-22 02:38:12 +00:00
Dylan Ulis a2b584b8bd CIP: Improve connection analysis 2023-02-22 01:57:41 +00:00
Jim Schaettle 88e796260b RDMnet: Bug Fixes
- Endpoint List Get Response
- Endpoint Responders Get Response
2023-02-21 22:35:12 +00:00
Dr. Lars Völker e73ad66d70 UI: Fix typo in tooltip of Time Display Format
Fixes typo in tooltip for "Seconds Since First Captured Packet in
"Time Display Format".
2023-02-21 21:24:25 +00:00
Nicolás Alvarez ef35b9f984 Fix grammar in new logging dev documentation 2023-02-21 14:23:37 -03:00
Michael Tuexen 06d2819969 BBLog: Add support for PRU events
While there, fix also the reporting of unknown types or events
of timers.
2023-02-21 15:51:40 +00:00
Joakim Karlsson ddf1d21c6f file-pcapng: fix might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] 2023-02-21 15:17:07 +00:00
Pascal Quantin 6487885b93 Diameter 3GPP: update some Rx related AVPs 2023-02-21 12:24:30 +00:00
Michael Tuexen 669f9a4735 BBLog: Update event types 2023-02-21 12:00:33 +01:00
Michael Tuexen 2867595882 BBLog: Improve handling of timer events 2023-02-21 09:52:01 +00:00
Guy Harris a4b61bc069 gryphon: fix handling the ioctl code in a response.
It's not in the response message, it's taken from the request message,
so display it with a zero offset and length, so it doesn't match any
bytes in the packet.

It's a 32-bit field, so make it an FT_UINT32.
2023-02-21 00:34:05 -08:00
Guy Harris e5884912cd gmr1_rr: try to explain the 0x100 hack.
I leave it to those more familiar with the protocol to explain this
better or in more detail and, if possible, to come up with a better way
of doing this.
2023-02-20 23:33:57 -08:00
Jaap Keuter 54d8062df6 WSDG: Document logging system 2023-02-21 07:23:15 +00:00
Martin Stigge 9d344f39d0 RSVP: Add missing S2L_SUB_LSP filter.
Now S2L_SUB_LSP objects shows up as "rsvp.s2l_sub_lsp" instead of "rsvp.obj_unknown".
2023-02-21 03:04:36 +00:00
Nicolás Alvarez 180e6cd48e Fix build of PacketListModel with Qt5
a9a7dcec21 broke the build by using std::as_const (new in C++17, we require
C++11). 189d93b4b8 switched to using a for loop with indices, but that
still fails on Qt5, because Qt5 uses int instead of qsizetype.

Switch back to the foreach-style loop, but using C++11 range-for instead of
Qt's foreach (which is semi-deprecated). Also, use qAsConst, which works in
C++11, instead of std::as_const.
2023-02-20 21:34:56 -03:00
Michael Tuexen 2c645005bf BBLog: Prepare for event type specifc info column
While there, improve the handling of unknown event types.
2023-02-20 16:47:55 +01:00
Michael Tuexen 9ee9523e52 BBLog: Display BBLog information for IN/OUT events 2023-02-20 15:15:37 +01:00
Josh Schmelzle d31521e67e ieee80211: Fix Short SSID encodings
Change ENC_NA to ENC_LITTLE_ENDIAN for following Short SSID items:

- hf_ieee80211_ff_fils_discovery_short_ssid
- hf_ieee80211_short_ssid
2023-02-20 11:25:50 +00:00
Martin Mathieson f4e9b9d4a8 Check that value_string values fit into field width 2023-02-20 08:33:34 +00:00
Gilbert Ramirez af82679d9a lua: Check for negative lengths when constructing TvbRange 2023-02-19 22:16:16 +00:00
John Thacker 189d93b4b8 Qt: Substitute for C++17 ism
Replace C++17 ism from !9822 with code with the same effect
that is valid earlier

(cherry picked from commit 50f71efbe0955b32dfb99bb4933f6ff310b39283)
2023-02-19 14:57:04 -05:00
Tomasz Moń 2d4e637fef
USBLL: End transfer reassembly on STALL
Some classes, most notably Mass Storage, use STALL (instead of ZLP) to
prematurely end transfer. Finish reassembly when dissecting STALL. For
IN transfers ending reassembly is pretty straightforward and resembles
ZLP packet. For OUT transfers the reassembled URB is opposite direction
than the STALL handshake itself and last data packet may not be part of
reassembled URB. The last OUT data packet is part of reassembled URB
only if packet was acknowledged with NYET before endpoint was STALLed.
2023-02-19 18:03:01 +01:00
Michael Tuexen ece039ca0c bblog: show textual errno values 2023-02-19 16:37:21 +01:00
Michael Tuexen cd6fe39455 bblog: improve TCP state names
Use the names from RFC 9293 for consistency.
2023-02-19 14:51:59 +00:00
John Thacker 602edb79b9 RTPS: Restore timestamp present flag
        Unused href entry: epan/dissectors/packet-rtps.c: hf_rtps_flag_timestamp_present

created from e93f423504
2023-02-19 14:21:46 +00:00