osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
86,808 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

27 Commits

Author SHA1 Message Date
João Valverde 79c3a77752 Add macros to control lemon diagnostics 
Rename flex macros using parenthesis (mostly a style issue):

DIAG_OFF_FLEX -> DIAG_OFF_FLEX()
DIAG_ON_FLEX  -> DIAG_ON_FLEX()

Use the same kind of construct with lemon generated code using
DIAG_OFF_LEMON() and DIAG_ON_LEMON(). Use %include and %code
directives to enforce the desired order with generated code
in the middle in between pragmas.

Fix a clang-specific pragma to use DIAG_OFF_CLANG().

DIAG_OFF(unreachable-code) -> DIAG_OFF_CLANG(unreachable-code).

Apparently GCC is ignoring the -Wunreachable flag, that's why
it did not trigger an unknown pragma warning. From [1}:

  The -Wunreachable-code has been removed, because it was unstable: it
  relied on the optimizer, and so different versions of gcc would warn
  about different code.  The compiler still accepts and ignores the
  command line option so that existing Makefiles are not broken.  In some
  future release the option will be removed entirely. - Ian

[1] https://gcc.gnu.org/legacy-ml/gcc-help/2011-05/msg00360.html
 2022-11-20 10:11:27 +00:00
João Valverde 09718fb9b3 CMake: Move clang warnings 
Move clang warnings to normal set. Let the CMake compatibility
check control the warning.

Fix or work-around -Wunreachable warnings in the code.
 2022-11-17 01:35:16 +00:00
Stig Bjørlykke 488c831790 Use common indenting space in heading 
Change-Id: I47022f9c7d568ca6d9705ba63c669a980822818a
Reviewed-on: https://code.wireshark.org/review/27229
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-05-01 06:55:55 +00:00
Dario Lombardo fdd426e410 spdx: more licenses converted. 
Change-Id: Ia1650bc02511f7bd47fb90be91b623177f05bcbd
Reviewed-on: https://code.wireshark.org/review/26337
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2018-03-09 04:48:20 +00:00
Ahmad Fatoum 9d49e13166 Remove superfluous null-checks before strdup/free 
NULL checks were removed for following free functions:

- g_free "If mem is NULL it simply returns"
  https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free

- g_slist_free(_full)? "NULL is considered to be the empty list"
  https://developer.gnome.org/glib/stable/glib-Singly-Linked-Lists.html

- g_strfreev "If str_array is NULL, this function simply returns."
  https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strfreev

- g_slice_free "If mem is NULL, this macro does nothing."
  https://developer.gnome.org/glib/stable/glib-Memory-Slices.html#g-slice-free

- g_match_info_free "not NULL... otherwise does nothing"
  https://developer.gnome.org/glib/stable/glib-Perl-compatible-regular-expressions.html#g-match-info-free

- dfilter_free defined in Wireshark code. Returns early when passed NULL
  epan/dfilter/dfilter.c

They were also removed around calls to g_strdup where applicable:

- g_strdup "If str is NULL it returns NULL."
  https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strdup

Change-Id: Ie80c2db89bef531edc3aed7b7c9f654e1d654d04
Reviewed-on: https://code.wireshark.org/review/23406
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: João Valverde <j@v6e.pt>
 2017-10-15 12:38:51 +00:00
Alexis La Goutte 2e1fa634c6 Lemon grammar: fix indent (use tabs) 
Change-Id: I6fa38d5d85b25ac6c55fcfa67d6c8dba8482cc8c
Reviewed-on: https://code.wireshark.org/review/10266
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2015-08-27 04:35:23 +00:00
Alexis La Goutte 09cd306d1c Continue to remove $Id$ from top of file 
(Using sed : sed -i '/^\* \$Id\$/,+1 d') (no space before star)

Change-Id: I318968db2b8512ba1303b5fc5c624c66441658f0
Reviewed-on: https://code.wireshark.org/review/879
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-03-31 18:30:52 +00:00
Gerald Combs 465e4664de Use "(void) <variable/>" to avoid unused variable warnings similar to 
Qt's Q_UNUSED macro.

svn path=/trunk/; revision=54110
 2013-12-14 23:44:25 +00:00
Anders Broman 5a85b7fed2 [-Wmissing-prototypes] 
Use explicit casts.

svn path=/trunk/; revision=48338
 2013-03-16 08:52:09 +00:00
Jeff Morriss 3729335973 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45016
 2012-09-20 01:48:30 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II. 
svn path=/trunk/; revision=43538
 2012-06-28 23:18:38 +00:00
Jörg Mayer 2d7a4646e2 Include config.h in preparation of moving the definition 
of _U_ from the compiler command line into config.h

svn path=/trunk/; revision=40806
 2012-02-02 11:54:33 +00:00
Anders Broman c11c8b0ee0 svn path=/trunk/; revision=38396 2011-08-07 19:58:13 +00:00
Anders Broman 79501e9198 Revert previous commit. 
(Note to self read the description first)

"Returns :
 
a newly-allocated string, with all the upper case characters in str converted to lower case, with semantics that exactly match g_ascii_tolower(). (Note that this is unlike the old g_strdown(), which modified the string in place.)"

svn path=/trunk/; revision=38395
 2011-08-07 19:15:17 +00:00
Anders Broman e48dcbaf15 Replace deprecated glib functions. 
set DG_DISABLE_DEPRECATED for windows build.

svn path=/trunk/; revision=38394
 2011-08-07 19:08:41 +00:00
Luis Ontanon 42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org 
svn path=/trunk/; revision=25937
 2008-08-05 21:03:46 +00:00
Bill Meier fe5c2d9820 g_string_sprintf --> g_string_printf and g_string_sprintfa --> g_string_append_printf 
svn path=/trunk/; revision=25276
 2008-05-11 18:33:49 +00:00
Anders Broman 25b308442d Update Lemon to v1.54 and lempar to v 1.31 from sqlite http://www.sqlite.org/cvstrac/dir?d=sqlite/tool 
svn path=/trunk/; revision=24845
 2008-04-08 09:54:19 +00:00
Luis Ontanon 27556d141a two minor leaks 
svn path=/trunk/; revision=20443
 2007-01-15 20:14:00 +00:00
Ronnie Sahlberg 0c222fdbd0 ethereal to wireshark change 
svn path=/trunk/; revision=18498
 2006-06-17 12:00:41 +00:00
Ronnie Sahlberg 89f022b12b name change 
svn path=/trunk/; revision=18197
 2006-05-21 05:12:17 +00:00
Luis Ontanon f1b498587b remove location from dtd_build_data_t avoiding to (double) free it. 
svn path=/trunk/; revision=16147
 2005-10-06 22:01:52 +00:00
Luis Ontanon 3cf75fd6bb get rid of most dtd leaks. 
There's just one left I'm aware of (the doctype name).


svn path=/trunk/; revision=15990
 2005-09-24 19:03:35 +00:00
Luis Ontanon 4c14b12c25 Because there's more than just text in XML... 
DTDs are imported to create fields


svn path=/trunk/; revision=15851
 2005-09-17 17:05:46 +00:00
Guy Harris 019ed9005f Add a header file to declare routines defined in lexer and used in 
parser, or vice versa.

svn path=/trunk/; revision=15769
 2005-09-12 19:32:35 +00:00
Guy Harris 3db317ca2b Again, "g_strdown()" doesn't return a value in GLib 1.2[.x]. 
svn path=/trunk/; revision=15768
 2005-09-12 15:54:20 +00:00
Luis Ontanon 96326c0b86 the dtd parser (still missing the glue) and few fixes to packet-xml.c 
svn path=/trunk/; revision=15745
 2005-09-10 17:29:15 +00:00