Commit Graph

18887 Commits

Author SHA1 Message Date
Ulf Lamping 9e063e0572 the whole ARGUMENT_CL mimic isn't required any longer - remove it. This should fix compile problems under Unix.
svn path=/trunk/; revision=19416
2006-10-03 20:01:39 +00:00
Ulf Lamping cdb57f37a2 now: Don't have a Save button in the following settings dialogs:
- Edit/Preferences
- View/Coloring Rules
- Capture/Capture Filters
- Analyze/Display Filters
- Analyze/Enabled Protocols

The settings will be automatically saved when pressing the Ok button.

If someone really wants the explicit Save buttons as before - you can get them back at the Edit/Preferences/User Interface page.

svn path=/trunk/; revision=19415
2006-10-03 19:53:10 +00:00
Anders Broman 699c5c66b6 From Florent.Drouin@alcatel.fr:
I did improve the OID management in the tcap dissector.
Now, when a tcap message is reveived, without upper layer, the ACN is saved in the TCAP context, and can be used for the next messages of the dialogue. It is used only when the upper layer session is opened with Tcap only messages.

svn path=/trunk/; revision=19414
2006-10-03 19:24:22 +00:00
Ulf Lamping 9e6c7b11ae Implement a real "Cancel" button for the coloring rules dialog - this was a hard one! It seems to be working without bugs and as designed now.
As this was a huge internal change, new bugs are very probable - please report.

The implementation isn't still perfect, a new dialog internal list could possibly be removed again. 

However, I want to check in at this condition, just in case I make things worse - again.

svn path=/trunk/; revision=19413
2006-10-03 18:39:36 +00:00
Luis Ontanon 8f737d2587 Get it to compile...
svn path=/trunk/; revision=19412
2006-10-03 18:38:04 +00:00
Luis Ontanon 62ecee25ce Update nmakefile to latest changes.
svn path=/trunk/; revision=19411
2006-10-03 18:24:08 +00:00
Anders Broman 8774e7e28e From David Richards:
numerous changes, most notably:

1) BACnetStatusFlags is bit string, not enum, in NotificationParameters
2) Fixes many places where enclosing context tags were not handled properly.
3) Simplify tag decoding logic.  Change to explicit decoding in many 
instances rather
    than read tags in a loop and do a switch based on tag number.  Looping
    ignores out-of-order and other types of tagging errors.

svn path=/trunk/; revision=19410
2006-10-03 18:11:55 +00:00
Luis Ontanon 5d40bae072 MSVCC does not like mixing code and variable declarations
svn path=/trunk/; revision=19409
2006-10-03 18:07:31 +00:00
Anders Broman 83971ab494 Add application/media_control+xml
svn path=/trunk/; revision=19408
2006-10-03 18:04:15 +00:00
Luis Ontanon a4d7156808 H.248 packages...
few things to be fixed:
- // comments,
- not every hf_xxx used might be registered

some packages from the current h248 dissector are still missing.



svn path=/trunk/; revision=19407
2006-10-03 17:24:28 +00:00
Luis Ontanon e23201c62a - Make sure that the registration files are created whenever there's a change
- get rid of 5.0.2 stuff
- add the apply_filter() API


svn path=/trunk/; revision=19406
2006-10-03 14:27:45 +00:00
Martin Mathieson 3474ea868c - Add special case for reading strange encoding of ATM CID field
- Indicate direction of DCH Data in info column
- Assume EDCH payload CRC if 2 bytes are left over (previous test was broken)

svn path=/trunk/; revision=19405
2006-10-03 14:21:07 +00:00
Luis Ontanon 161b9a55ea more Lua APIs:
- set_filter() : sets the main window filter
- reload() : reloads the current capture file
- copy_to_clipboard() : copies its first arfg to the clipboard
- open_capture_file() : opens a capture file for viewing (still broken)


svn path=/trunk/; revision=19404
2006-10-03 12:07:10 +00:00
Anders Broman 179039652b From Stephen Fisher:
always register 
itself on the port from the preferences (defaults to 0) upon launch.  
This allows the user to right-click and use decode as.

svn path=/trunk/; revision=19403
2006-10-03 05:50:28 +00:00
Anders Broman e65847960f From Stephen Fisher:
Modifie the VNC dissector to desegment 
the "server cut text" message type for cases where the cut text is in 
the next tcp segment from the first part of the message.

svn path=/trunk/; revision=19402
2006-10-03 05:48:47 +00:00
Gerald Combs 2649d26145 Fix WEP key bug in the AirPcap code that could cause a crash. Enable
AirPcap by default. Add initial support for the "Any" device in AirPcap
(more to come).

svn path=/trunk/; revision=19401
2006-10-02 23:44:10 +00:00
Ulf Lamping 6cde05da1b missing mark -> select changes
svn path=/trunk/; revision=19400
2006-10-02 23:11:55 +00:00
Ulf Lamping 59d206d18e further code cleanup: don't use the term "marked" for the color filters, the right term is "selected". That caused me "concerns" wether the marked feature of the packet list was involved - which is actually not
svn path=/trunk/; revision=19399
2006-10-02 23:01:33 +00:00
Ulf Lamping b2c8fb8f55 refactor apply_color_filter() as it was a bit confusing - it will also be a bit faster now -
and some other minor code cleanup

svn path=/trunk/; revision=19398
2006-10-02 21:55:26 +00:00
Ulf Lamping 765835ac7a instead of reverting the whole changes by the *first* cancelled dialog box, revert them by clicking "Cancel" on the *last* dialog - this behaviour just makes more sense.
svn path=/trunk/; revision=19397
2006-10-02 20:59:38 +00:00
Michael Tüxen fb6348011a Do not show the Windows specific message on non-Windows systems.
svn path=/trunk/; revision=19396
2006-10-02 19:26:53 +00:00
Ulf Lamping 0be3b04cb1 as noted by Anders Broman: the Win2000 version of copy don't like the /d switch
svn path=/trunk/; revision=19395
2006-10-02 19:07:01 +00:00
Martin Mathieson d0c38312a4 Don't show Tools menu at all if Lua not present
svn path=/trunk/; revision=19394
2006-10-02 13:38:13 +00:00
Martin Mathieson 2bfdb780ee Set correct length for extensions root
svn path=/trunk/; revision=19393
2006-10-02 10:49:57 +00:00
Ulf Lamping 589b473e41 various (huge) code cleanup incl. splitting of the coloring dialog and the actual color rule edit dialog into two files - this makes the things much more clearer now (at least for me)
svn path=/trunk/; revision=19392
2006-10-02 00:13:14 +00:00
Ulf Lamping 2cf4d327f2 If the Cancel button was clicked and another filter dialog is still open - yes that's possible - reverse the changes on it as well to reflect the current internal list.
svn path=/trunk/; revision=19391
2006-10-01 19:34:03 +00:00
Ulf Lamping 889a082501 Change the filter dialog (capture and display filters), so it has a real Cancel button now - the former Close button didn't reverted the changes done.
svn path=/trunk/; revision=19390
2006-10-01 17:59:30 +00:00
Ronnie Sahlberg af410bce95 fix for header digest detection being broken when AHS is used.
we simply forgot to account for the AHS when testing to calculate the crc


svn path=/trunk/; revision=19389
2006-09-30 21:49:11 +00:00
Ronnie Sahlberg 61ac971e2c add dissection of the cdb for service action LIST
(but no decoding of the data in yet)



svn path=/trunk/; revision=19388
2006-09-30 21:08:27 +00:00
Ronnie Sahlberg 71af839c39 the ahs length inside the AHS for an extended cdb includes the reserved byte before the start of cdb data
account for this extra reserved byte in the ahs length so that the reconstructed cdb has the correct length and does not contain one extra byte at the end



svn path=/trunk/; revision=19387
2006-09-30 20:40:04 +00:00
Ulf Lamping ee8abeec9e fix a typo
svn path=/trunk/; revision=19386
2006-09-30 18:30:43 +00:00
Anders Broman 319bbf2bc6 From Reinhard Speyerer:
Update asn1/umts_rrc*/Makefile
for the renamed asn2eth.py -> asn2wrs.py.

svn path=/trunk/; revision=19385
2006-09-30 15:50:38 +00:00
Ulf Lamping 1c93482ec7 add a missing #include
svn path=/trunk/; revision=19384
2006-09-30 14:57:50 +00:00
Graeme Lunt 23937f82c7 A new field information flag, FI_URL, to indicate a field contains a URL.
This is used to display the field underlined and to allow the user to double-click on it (like FT_FRAMENUM) to open the URL in the configured browser. 
Example usage in the x509ce and logotype certificate extensions. 


svn path=/trunk/; revision=19383
2006-09-30 14:37:09 +00:00
Ulf Lamping 3da46255fe remove compiler warnings
svn path=/trunk/; revision=19382
2006-09-30 13:40:36 +00:00
Ulf Lamping 0dd1f103cb we don't need to .. the dirs for the clean targets here
svn path=/trunk/; revision=19381
2006-09-30 13:25:05 +00:00
Graeme Lunt 562beb764a Update for latest lua changes.
svn path=/trunk/; revision=19380
2006-09-30 12:58:52 +00:00
Ronnie Sahlberg c2b08c79d2 add dissection of SCSI OSD CREATE PARTITION
svn path=/trunk/; revision=19379
2006-09-30 10:24:23 +00:00
Ronnie Sahlberg cadbe48610 finish off the remainder of FORMAT OSD for scsi osd dissector
svn path=/trunk/; revision=19378
2006-09-30 10:08:43 +00:00
Ulf Lamping e4d5b387d9 "Pluggable custom makefile"
A custom plugin (not yet to be released to the public) can be added to Makefile.nmake easily. But this has a drawback:
The modified Makefile.nmake appears as a modified file in the commit list and in generated patches (this annoyed me for years).

To solve this I've added a plugin like mechanism which calls a Custom.nmake file for each target (if the file is existing). I've also added a Custom.nmake.example for a quick start.

I don't know how to do this for the Makefile.am, so I leave this as an exercise for the interested reader ;-)

svn path=/trunk/; revision=19377
2006-09-30 09:45:51 +00:00
Ronnie Sahlberg bedacc2bc2 scsi osd updates
iscsi: when iscsi transfers a cdb that is alrger than 16 bytes,  the first 16 bytes are transferred in the normal place in the header and ther remainder of the cdb is transported inside the AHS.

reassemble these cdb into a proper tvb before passing it to the scsi dissector



svn path=/trunk/; revision=19376
2006-09-30 09:34:58 +00:00
Ulf Lamping 4e79f8f307 remove a warning
svn path=/trunk/; revision=19375
2006-09-30 09:15:15 +00:00
Ronnie Sahlberg 62290c9cc5 add an extra_data pointer to the itlq structure where specific commandsets/cdbs can hang additional data that are unique to that commandset/cdb
make the scsi osd service action and getsetattributetype use this facility

furhter enhancements to scsi osd


svn path=/trunk/; revision=19374
2006-09-30 04:10:28 +00:00
Ronnie Sahlberg deef583ae5 scsi opcode 0x7f is variable length so dont clamp the cdb length to 16 bytes
svn path=/trunk/; revision=19373
2006-09-30 01:01:57 +00:00
Ulf Lamping e3883affdd that wasn't a typo, xcopy can't rename files that way
svn path=/trunk/; revision=19372
2006-09-30 00:45:03 +00:00
Ronnie Sahlberg 0afdb9be78 scsi osd additions
we also need to track the serviceaction in the itlq structure so we can decode the data in/out properly


svn path=/trunk/; revision=19371
2006-09-30 00:31:36 +00:00
Ulf Lamping e940ff36b4 from Stephen Fisher:
Attached is a patch for consideration that changes the title in the 
preferences notebook to be the full description of the preference (but 
leaves the short name in the preferences list on the left).

svn path=/trunk/; revision=19370
2006-09-29 22:48:38 +00:00
Ulf Lamping 736bf234e8 fix the context menu "Protocol Preferences" bug AGAIN (bug introduced again in 19291)
svn path=/trunk/; revision=19369
2006-09-29 22:40:55 +00:00
Ulf Lamping d6f0ae689c MSVC doesn't like empty array inits
svn path=/trunk/; revision=19368
2006-09-29 21:53:54 +00:00
Anders Broman 4647b593ee Use #defines from packet-ber.h rather than asn1.h change default ports to Zero.
svn path=/trunk/; revision=19367
2006-09-29 21:27:58 +00:00