Commit Graph

13467 Commits

Author SHA1 Message Date
Guy Harris 9ce4ff20ef Tagged integers have 4 bytes of data (1 byte of tag, 3 bytes of
integer), not 5 bytes.

svn path=/trunk/; revision=13753
2005-03-14 20:23:11 +00:00
Guy Harris a81c8f1738 Some VoIP VLAN query and reply fields have a length of 6, not 7, with
only 2 bytes of data; dissect those differently.

svn path=/trunk/; revision=13752
2005-03-14 19:53:07 +00:00
Guy Harris c7e7167a2b Combine the two switch statements on IE type into one; this cleans
things up a bit (so that if we go through one switch statement we don't
fall into the other).

svn path=/trunk/; revision=13751
2005-03-14 11:12:00 +00:00
Guy Harris 0c70225fc6 Comment changes.
svn path=/trunk/; revision=13750
2005-03-14 10:45:46 +00:00
Ronnie Sahlberg 549ec8ee25 fix typo in name of KINK developer
svn path=/trunk/; revision=13749
2005-03-14 10:27:25 +00:00
Ronnie Sahlberg 59b3267d40 updates for drsuapi
svn path=/trunk/; revision=13748
2005-03-14 09:49:58 +00:00
Guy Harris 5f1b64cf8c Don't cruft up the display of the bitmap with "Tag interpretation".
(Perhaps we should just get rid of the "tag interpretation" field and,
instead, have explicit hf_ values for each of the fields and subfields.)

svn path=/trunk/; revision=13747
2005-03-14 03:08:38 +00:00
Ulf Lamping 49213d49da Very first start of a dissection of the VNC (RFB) protocol.
This is not much more than the dissector skeleton code.

svn path=/trunk/; revision=13746
2005-03-14 00:53:58 +00:00
Ulf Lamping f1f48a30bd fix a bug and add a forward declaration in the example skeleton code
svn path=/trunk/; revision=13745
2005-03-14 00:43:39 +00:00
Guy Harris 4d5d55b604 Handle the packet headeer for sFlow V5, put in a stub dissector for V5
samples, and give the URL of the V5 spec and some hints about how to
handle the private enterprise code in those samples.

For subtrees that cover structures, make the tree cover the entire
structure, not just the first field.

Add the flow sample type and extended data type to the protocol tree.

Set the protocol column name to capitalize "sFlow" the conventional way,
and remove the redundant "sFlow" from the Info column.

svn path=/trunk/; revision=13744
2005-03-13 21:42:51 +00:00
Guy Harris 99d60f21aa Don't attempt to get a pointer to the entire tagged field when
dissecting it; instead, fetch items from the tagged field as we go. 
Also, check the length of the tagged field against a minimum length, if
there is one.

When adding the SSID, just fetch it directly as a string, and leave it
up to the string display code to deal with non-printable characters.

When dissecting a tagged field, don't zero out the "out_buff" buffer
beforehand, just stick in the terminating '\0' afterwards.

svn path=/trunk/; revision=13743
2005-03-13 13:28:06 +00:00
Guy Harris 3fd9dac8e4 Don't use the result of "format_text()" as a format string argument, as
it might contain %'s; instead, use "%s" as the format string.

svn path=/trunk/; revision=13741
2005-03-13 10:26:56 +00:00
Guy Harris d5c1aec8b5 Get rid of extra semicolon - it might be giving MSVC++ heartburn.
svn path=/trunk/; revision=13740
2005-03-13 07:53:19 +00:00
Gerald Combs 9d5ee3cfea Fix a check for the number of suboptions.
svn path=/trunk/; revision=13739
2005-03-13 05:48:43 +00:00
Guy Harris 4047793286 Use the tokenizing routines to parse HTTP request and status lines.
Rename the RequestDissector type to ReqRespDissector as it's used to
dissect status (response) lines as well as request lines.

svn path=/trunk/; revision=13738
2005-03-13 00:49:33 +00:00
Luis Ontanon 3e98d671fd From Graeme Hewson:
don't try to call register_all_plugin_tap_listeners() if configured without plugins.

svn path=/trunk/; revision=13737
2005-03-12 21:36:24 +00:00
Ronnie Sahlberg 8123288f6d some auth padding update from metze
svn path=/trunk/; revision=13736
2005-03-12 21:01:38 +00:00
Ronnie Sahlberg 3a26213e88 the previous drsuapi patch showed how idl2eth can handle embedded arrays just fine.
beautifully fine.

this patch overrides the array,   tells idl2eth to not generate code to unmarshall the conformance blob or the data for the array.

a handwritted replacement function is implemented in the template instead which prettifies the output a lot.



svn path=/trunk/; revision=13735
2005-03-12 12:04:44 +00:00
Ulf Lamping 7d7a541125 from Joerg Mayer: go towards "normal" makefile.
svn path=/trunk/; revision=13734
2005-03-12 11:10:23 +00:00
Ronnie Sahlberg 2ee14eef27 refine IDL
svn path=/trunk/; revision=13733
2005-03-12 10:55:50 +00:00
Ulf Lamping 25531c9a70 from Micheal Duigou: some more doxygen tags
svn path=/trunk/; revision=13732
2005-03-12 09:59:28 +00:00
Jörg Mayer 5ee5f5c71f - Add 3d logo in size 64x64 (copied from Suse, who *may* have generated
it from eicon3d64.xpm)
- Fix comment: The 3d logos seem to have a transparent background

svn path=/trunk/; revision=13731
2005-03-12 09:38:31 +00:00
Ronnie Sahlberg cc6d037933 fix small bug from previous checkin for fixed arrays
svn path=/trunk/; revision=13730
2005-03-12 09:24:54 +00:00
Ronnie Sahlberg 0e3ff62701 initial DRSUAPI dissector
now that we can decrypt DCERPC

the dissection is not complete since idl2eth can not yet handle
all the weird extensions in the idl file yet.


svn path=/trunk/; revision=13729
2005-03-12 09:02:01 +00:00
Jörg Mayer bbba7523e7 warning: function declaration isn't a prototype
svn path=/trunk/; revision=13728
2005-03-12 07:37:14 +00:00
Guy Harris 3d38e6bcea We don't have a TODO file any more; it's on the Wiki.
svn path=/trunk/; revision=13727
2005-03-12 02:16:28 +00:00
Ulf Lamping 910bb6015b removed TODO file, and moved it's content to:
http://wiki.ethereal.com/Development_2fWishlist

to have it all in one place

svn path=/trunk/; revision=13726
2005-03-11 23:14:33 +00:00
Ulf Lamping e378098855 from Micheal Duigou: add some doxygen tags and some changes to README.developer
svn path=/trunk/; revision=13725
2005-03-11 21:14:38 +00:00
Ulf Lamping 801e9dd35e from Stefano Pettini: add CSV export function, similar to PSML export
svn path=/trunk/; revision=13724
2005-03-11 20:56:31 +00:00
Ulf Lamping b8a20994cb add missing dissector_dump_decodes function
svn path=/trunk/; revision=13723
2005-03-11 18:57:12 +00:00
Gerald Combs 76ba06d767 Add a "-G decodes" option to ethereal and tethereal which shows the
filter/selector/protocol associations for each dissector.  This will be
used to improve our automated tests, but someone with time on their 
hands could probably use it to generate a protocol poster using Graphviz.

svn path=/trunk/; revision=13721
2005-03-11 16:17:41 +00:00
Gerald Combs abe1feed27 Copy over more changes from the 0.10.10 release branch.
svn path=/trunk/; revision=13720
2005-03-11 15:47:35 +00:00
Gerald Combs d3ce57cc28 Copy over from the 0.10.10 release branch.
svn path=/trunk/; revision=13718
2005-03-11 15:38:02 +00:00
Guy Harris 092815f97d From Vladimir Kondratiev:
- Give each IE its own subtree, with a summary at the root, and
	  details within the tree.  It allows a condensed view when IE
	  trees are closed.

	- Display country info in multiple protocol tree items, with
	  each (start channel, channels, power) triplet in a separate
	  item.

	- Put a separate item into the protocol tree for each CFP
	  parameter.

svn path=/trunk/; revision=13713
2005-03-11 12:07:30 +00:00
Guy Harris 3057f63c8d Fix the offset for the system uptime field.
svn path=/trunk/; revision=13712
2005-03-11 11:59:27 +00:00
Guy Harris 2368cd28d9 We don't have an SMDS dissector, and it's not clear what dissector
should be used for ATM, so just use the data dissector for now.

The X.25 dissector registers itself as "x.25", not "x25".

svn path=/trunk/; revision=13711
2005-03-11 11:46:48 +00:00
Ronnie Sahlberg 349c5a8699 from metze
various bugfixes and enhancements to decryption of secure ldap


svn path=/trunk/; revision=13710
2005-03-11 09:31:11 +00:00
Guy Harris 009de7a662 From Alexandro Vaquero:
fix the call to "rtp_add_address()" to match the new signature;

	fix a problem with the codec displayed in the "Voip Graph"
	for H245 "RequestMode" messages.

svn path=/trunk/; revision=13709
2005-03-11 03:05:57 +00:00
Guy Harris 6285418a43 Add one more reason to use "tvb_get_string()", as we've had a recent
vulnerability due to somebody fetching a string into a fixed-length
buffer.

svn path=/trunk/; revision=13708
2005-03-11 02:01:17 +00:00
Guy Harris 6db3fe1e96 Just use "tvb_format_text()" to handle strings - don't roll our own
routine to handle that.
 
Don't format the value text into a buffer; just use
"proto_item_append_text()", so we don't run the risk of overflowing the
buffer.

Use "ip_to_str()" to format an IP address - don't roll our own code to
handle that.

Don't make "is_fhss" global - that causes its value to depend on the
last packet dissected, which isn't necessarily the right value for the
packet being dissected.

svn path=/trunk/; revision=13707
2005-03-11 01:35:02 +00:00
Guy Harris c0f813c0a4 Flag an unused argument as unused, to squelch compiler warnings, and
don't flag a used argument as unused.

svn path=/trunk/; revision=13706
2005-03-11 01:15:35 +00:00
Jörg Mayer bce97ef171 Warning fix: voip_calls_dlg.c:733: implicit declaration of function rtp_event_init_tap
svn path=/trunk/; revision=13705
2005-03-10 21:47:35 +00:00
Gerald Combs 0ab3f0586c Sync to recent changes in packet-rtp.h.
svn path=/trunk/; revision=13703
2005-03-10 21:41:24 +00:00
Jörg Mayer 0f764ba58a Warning fix: no newline at end of file
svn path=/trunk/; revision=13701
2005-03-10 21:04:34 +00:00
Luis Ontanon 008054453b From Alejandro Vaquero:
- Automatic dissection of RTP events (RFC2833) set in SDP sessions.
- Add RTP events (RFC2833) to the Voip Graph


svn path=/trunk/; revision=13697
2005-03-10 19:32:22 +00:00
Luis Ontanon 8ee0a507c7 An optimization.
Instead of first running the lexer to create a list of items and then iterate through this items to create the tree, just create the tree from the lexer.


svn path=/trunk/; revision=13696
2005-03-10 17:13:47 +00:00
Gerald Combs 25967a2604 More NEWS updates.
svn path=/trunk/; revision=13694
2005-03-10 15:49:02 +00:00
Jörg Mayer 8783c27b4b Warning fix: function declaration isn’t a prototype
svn path=/trunk/; revision=13693
2005-03-10 14:04:35 +00:00
Jörg Mayer 33145f026d Warning fix: ISO C forbids zero-size array ‘tsns
svn path=/trunk/; revision=13692
2005-03-10 12:49:05 +00:00
Jörg Mayer 9804663036 Trivial warning fixes
svn path=/trunk/; revision=13691
2005-03-10 12:43:35 +00:00