Commit Graph

47471 Commits

Author SHA1 Message Date
Evan Huus 9bdc911c29 From Dominic Spill via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8921
Update the README to reflect the value_string name changes in r48645.

From me: reorganize a bit to promote the use of val_to_str over try_val_to_str
in most cases.

svn path=/trunk/; revision=50557
2013-07-13 15:07:15 +00:00
Jakub Zawadzki af61f188e0 Add new function: validate_offset() which checks if offset is within bounds of tvb.
svn path=/trunk/; revision=50556
2013-07-13 14:51:25 +00:00
Evan Huus 611eaf8069 From Chris Botje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8917
Minor Enhancement to add further to the Fast Message conversation structure to
provide Data Region Address/Name lookup.

From me: use tree for lookups, not slist.

svn path=/trunk/; revision=50555
2013-07-13 14:37:06 +00:00
Martin Kaiser 8bd14d8dba cygwin's dos2unix belongs to the Base category
svn path=/trunk/; revision=50554
2013-07-13 11:41:34 +00:00
Martin Kaiser 19de5ccfa1 From Vaibhav Katkade
Add Netflow Record TrustSec fields
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8928

svn path=/trunk/; revision=50553
2013-07-13 11:33:44 +00:00
Martin Kaiser ed324ee570 PNRP means Peer Name Resolution Protocol
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8929

(fix another typo)

svn path=/trunk/; revision=50552
2013-07-13 11:21:47 +00:00
Jakub Zawadzki d5450ff925 Remove compute_offset_length()
We either want to calculate only offset (compute_offset()), or
offset and remaining length (compute_offset_and_remaining())

Move old generic code to check_offset_length_no_exception())

svn path=/trunk/; revision=50551
2013-07-13 10:28:19 +00:00
Jakub Zawadzki 614e45a25a Call check_offset_length_no_exception() in tvb_bytes_exist(), fix possible integer overflow
svn path=/trunk/; revision=50550
2013-07-13 09:48:55 +00:00
Jakub Zawadzki cae2ce3b05 TVB: rewrite compute_offset_length(), check_offset_length_no_exception() to return exception number instead of FALSE, and 0 instead of TRUE
+ if there's overflow in check_offset_length_no_exception() just set exception, don't clamp end_offset (it could be an issue for 4GB tvbs :>)


svn path=/trunk/; revision=50549
2013-07-13 09:17:32 +00:00
Jakub Zawadzki e26b65f0ec proto_custom_set() cleanup
- Merge _UINT / _INT into one case
- fix possible generation of wrong expression ("some_integer") for unknown value in BASE_NONE field 

svn path=/trunk/; revision=50548
2013-07-13 09:14:25 +00:00
Guy Harris 94c182486c Suggest why the rpathification of the libraries might not be sufficient.
Don't rpathify system libraries.

Rpathify with @rpath, not @executable_path.

Use the right path for the binaries and libraries.

svn path=/trunk/; revision=50547
2013-07-13 01:16:14 +00:00
Chris Maynard 7f46a717f1 If the FCS isn't present, don't indicate "FCS Valid: True". Instead, indicate "FCS Valid: Unknown".
Note: Other changes should be made as well regarding the FCS as part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8859.

svn path=/trunk/; revision=50546
2013-07-12 22:53:56 +00:00
Guy Harris 0f80d54426 Note the issue with setting program_LINK.
svn path=/trunk/; revision=50545
2013-07-12 22:28:37 +00:00
Guy Harris 31f37c2bce Setting wireshark_LINK means that wireshark_LDFLAGS isn't used; there's
no need to set it for the GTK+ version, so don't.  (For Qt, we should
find some other way of forcing it to link wireshark-qt as a C++ program,
perhaps by having a wireshark-qt.cpp file in the top-level source
directory that contains main() and that calls the ui/qt code.)

svn path=/trunk/; revision=50544
2013-07-12 22:06:54 +00:00
Jeff Morriss 600e668361 Add a (GPLv2+) license header, copyright Balint.
svn path=/trunk/; revision=50543
2013-07-12 21:53:52 +00:00
Jeff Morriss f3b4e97bcc Add (GPLv2+) license headers to these scripts, assigning the copyright to
the original author of the scripts (Gerald).

svn path=/trunk/; revision=50542
2013-07-12 21:51:34 +00:00
Chris Maynard cef679ac98 Add the hidden wpan.frame_length to the IEEE 802.15.4 tree, not the top-level tree.
svn path=/trunk/; revision=50541
2013-07-12 21:32:03 +00:00
Guy Harris 1629a0948d When building for 10.6, force the build to use libpng12.
svn path=/trunk/; revision=50538
2013-07-12 19:19:09 +00:00
Jakub Zawadzki d2b93398f9 fix subset tvb: we want to do operation on backing tvb on position: abs_offset + subset_offset, abs_offset - subset_offset makes no sense.
Right now it doesn't really matter, cause tvb subsets always have real_data.

Without fix, and with small modification in ensure_contigous_no_expcetion() to first check for ->tvb_get_ptr() and later real_data
epan doesn't work and it flood console with warnings like:
** (process): WARNING **: Dissector bug, protocol IPv4, in packet 3823: tvbuff.c:976: failed assertion "exception > 0"


svn path=/trunk/; revision=50537
2013-07-12 17:53:51 +00:00
Chris Maynard cab1f9fc0c Allow -C <choplen> to be used more than once so it is now possible to chop bytes from both the beginning and end of a packet in a single step.
svn path=/trunk/; revision=50536
2013-07-12 17:14:19 +00:00
Jeff Morriss 605e212c44 As suggested by Jakub in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8908#c8 :
When auto-expanding previously-expanded children (r50516), only apply
auto-scrolling to the tree the user just expanded (not any of its children
which were auto-expanded).

Also: only expand children of the just-expanded tree, not all instances of
the just-expanded tree.  This prevents expanding, for example, one SCTP chunk's
tree from expanding all other chunks in the same frame.  (Of course moving
between frames will cause the chunks' trees to be expanded.) 

svn path=/trunk/; revision=50535
2013-07-12 13:56:14 +00:00
Alexis La Goutte c44977663a From Matt Texier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8691 Improvement of previous support of RFC5575 BGP flow spec
From me
* Enhance and fix some display tree stuff
* Add Matt to AUTHORS

svn path=/trunk/; revision=50534
2013-07-12 13:55:29 +00:00
Jeff Morriss 2aff467857 Move the ignore entries for ps.c to epan.
svn path=/trunk/; revision=50533
2013-07-12 13:04:28 +00:00
Jeff Morriss 7ad38c4c9c From Dirk De Schepper via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8926 :
The dissector defines some one-byte fields as UFLOAT. Defining them as UINT
fixes the decoding error for CAT48 version 1.21.

svn path=/trunk/; revision=50532
2013-07-12 13:01:17 +00:00
Guy Harris 9997e9f315 ps.h got moved to epan.
svn path=/trunk/; revision=50531
2013-07-12 08:01:52 +00:00
Guy Harris 278567c4ee Revert a change that shouldn't have been checked in.
svn path=/trunk/; revision=50530
2013-07-12 07:29:05 +00:00
Guy Harris 5be96e7552 print.ps moved to epan.
svn path=/trunk/; revision=50529
2013-07-12 07:27:55 +00:00
Jeff Morriss 54ec53ad1e print.c and ps.c are in libwirshark now.
svn path=/trunk/; revision=50528
2013-07-12 06:08:14 +00:00
Jakub Zawadzki 7c9c79ca68 Move bitmask array from ipv4_addr_set_netmask_bits() to ip_get_subnet_mask()
Use it in subnet_mask_lookup_init().

svn path=/trunk/; revision=50527
2013-07-12 05:59:56 +00:00
Jeff Morriss 4dcc156cf3 Move the print modules into epan.
svn path=/trunk/; revision=50526
2013-07-12 03:50:50 +00:00
Jeff Morriss 416c76a728 Fix building ui/qt out of the source tree.
svn path=/trunk/; revision=50525
2013-07-12 03:49:29 +00:00
Jeff Morriss fae759b793 Avoid building ascend.h and ascend.c in parallel (2 bison's running at the same time sometimes results in corrupted output).
svn path=/trunk/; revision=50524
2013-07-12 03:35:44 +00:00
Jeff Morriss 7a3ea48eb8 disabled_protos.c is in libwireshark now.
svn path=/trunk/; revision=50523
2013-07-12 02:40:44 +00:00
Jeff Morriss 60b4764746 disabled_protos.c is in libwireshark now.
svn path=/trunk/; revision=50522
2013-07-12 02:24:25 +00:00
Jeff Morriss 16206348d9 Move disabled_protos.{h,c} into epan.
svn path=/trunk/; revision=50521
2013-07-12 01:40:06 +00:00
Jeff Morriss 687cbef1a8 No need to include epan header files here; include things directly as necessary.
svn path=/trunk/; revision=50520
2013-07-12 01:22:35 +00:00
Guy Harris 725a05be3f frame_data_sequence.c and packet-range.c moved to epan.
svn path=/trunk/; revision=50519
2013-07-12 00:42:14 +00:00
Guy Harris 5f26818162 packet-range.h moved to the epan directory.
svn path=/trunk/; revision=50518
2013-07-12 00:41:22 +00:00
Jeff Morriss 45449ce1a8 Move some more modules into epan.
svn path=/trunk/; revision=50517
2013-07-11 23:57:11 +00:00
Jeff Morriss d7466120c9 Fix the problem reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8908#c3
(the last remaining problem in that bug report):

When we expand a tree, check if any of its children need to be expanded too
(because the user left them expanded when s/he closed the parent).

In the process, rename expand_finfos() to check_expand_children() since the
function expands any children (subtrees) which should be expanded.  Remove
one of that function's parameters too: just reference the global preference
that controls whether scrolling should be done or not.

Replace some tabs with spaces (for consistency).

svn path=/trunk/; revision=50516
2013-07-11 23:01:13 +00:00
Guy Harris 0f003babb3 Fix cut-and-pasteo found by a compiler warning.
Mark an unused parameter as unused.

svn path=/trunk/; revision=50515
2013-07-11 21:54:23 +00:00
Guy Harris b125950d9a Fix typo found by a compiler warning.
svn path=/trunk/; revision=50514
2013-07-11 21:53:19 +00:00
Anders Broman 614194e61f The beginning of an openflow dissector.
svn path=/trunk/; revision=50513
2013-07-11 21:13:27 +00:00
Anders Broman 5dec6b5603 From Tommy Wu:
Add 3gpp2_cvse.

svn path=/trunk/; revision=50512
2013-07-11 21:12:31 +00:00
Anders Broman 7fa8bd0f05 From Tommy Wu:
Use terminology from RFC 4303

svn path=/trunk/; revision=50511
2013-07-11 21:11:28 +00:00
Chris Maynard 6c371815d3 Fix an obvious case of incorrectly comparing the return value of tvb_length_remaining() against non-zero instead of greater than zero. There are other questionable uses of tvb_length_remaining() as well ... and maybe these should all be replaced with tvb_reported_length_remaining() as well?
#BACKPORT(1.10,1.8)

svn path=/trunk/; revision=50510
2013-07-11 15:55:52 +00:00
Jeff Morriss b53ced1e6a get_hfi_and_length() hasn't returned the hfi since r50015: rename it
to get_hfi_length().

svn path=/trunk/; revision=50509
2013-07-11 15:03:43 +00:00
Jeff Morriss b0c5fecc62 Don't mark a used parameter _U_.
svn path=/trunk/; revision=50508
2013-07-11 15:00:39 +00:00
Jeff Morriss 160c35c8e9 For consistency:
s/hf_index/hfindex/g
s/hf_info/hfinfo/g

svn path=/trunk/; revision=50507
2013-07-11 14:58:11 +00:00
Jeff Morriss b6ee11e928 Fix the very long loop fuzz failure reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8923 :
Apply the fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290
to proto_tree_add_bits_item().  That is, test that we have offset+length bytes
left in the TVB before trying to fake the item.

svn path=/trunk/; revision=50504
2013-07-11 14:46:30 +00:00