Commit Graph

8753 Commits

Author SHA1 Message Date
Guy Harris 9ac0cce997 From Martin Regner: fix a problem with vendorIdentifier in some H.225
messages.

svn path=/trunk/; revision=8847
2003-10-31 19:48:29 +00:00
Guy Harris 3a6a79c3c9 From Lars Ruoff:
- fix missing detection of first packet when writing payload.
	- fix bug of erroneous handling of confort noise when writing payload.
	- fix bug of possible endless silence insertion on first packet when
	  writing payload.

svn path=/trunk/; revision=8846
2003-10-31 19:45:16 +00:00
Guy Harris aabe3ec729 From Erwin Rol: update.
svn path=/trunk/; revision=8845
2003-10-31 18:28:32 +00:00
Guy Harris 9ac6d053f0 Update the list of supported capture formats.
svn path=/trunk/; revision=8844
2003-10-31 08:15:14 +00:00
Guy Harris d5185e2b0e Fix some warnings from pod2man.
svn path=/trunk/; revision=8843
2003-10-31 08:13:07 +00:00
Guy Harris 1131dafe62 Temporarily get rid of the "struct tm" in "struct observer_time", and
get rid of the reference to its "tm_gmtoff" member - there are platforms
on which Ethereal runs that don't have "tm_gmtoff" in "struct tm".  If
the time stamp in the packets is nanoseconds since midnight 2001-01-01
*local* time, we'd need to compute the offset between that and midnight
2000-01-01 GMT, and adjust the time with that.

svn path=/trunk/; revision=8842
2003-10-31 08:06:25 +00:00
Guy Harris 4c858d1ae7 Include <windows.h> so that OSVERSIONINFO and the like are defined on
Windows.

svn path=/trunk/; revision=8841
2003-10-31 07:57:22 +00:00
Guy Harris 0247fbeb15 From Scott Emberley: support for reading Network Instruments version 9
capture files.

svn path=/trunk/; revision=8840
2003-10-31 00:43:21 +00:00
Guy Harris 6f7c4c6836 Wrap "x$POD2MAN" in quotes, so if there are spaces in the pathname, the
configure script doesn't fail.  (The Makefile will probably fail, but
that's another matter.)

If "$POD2MAN" is empty, it could mean that pod2man is installed but the
user's path doesn't include the directory in which it's installed; fix
up the error message.

svn path=/trunk/; revision=8839
2003-10-30 22:06:07 +00:00
Guy Harris da6cf18461 If we don't have pod2man, quit - otherwise, we'd just drive on and use
the empty POD2MAN variable in commands, producing very confusing errors.

svn path=/trunk/; revision=8838
2003-10-30 20:30:19 +00:00
Guy Harris b350eb28d3 On UNIX, give up set-UID and set-GID privileges before opening capture
files and immediately after opening capture devices, so we run without
privileges as much as possible.

svn path=/trunk/; revision=8837
2003-10-30 19:56:47 +00:00
Guy Harris deff880da1 From Josef Korelus: fix reversed messages in true_false_string tables.
svn path=/trunk/; revision=8836
2003-10-30 19:43:15 +00:00
Guy Harris c25707861d From Michael Lum: dissect DTAP from RANAP NAS PDU fields.
svn path=/trunk/; revision=8835
2003-10-30 19:39:33 +00:00
Guy Harris ae389a9b32 From Michael Lum: step over unknown parameters.
svn path=/trunk/; revision=8834
2003-10-30 19:38:57 +00:00
Guy Harris 44590a655c "strchr()" and the like would be compared against NULL; "strcmp()",
however, is compared against 0.

svn path=/trunk/; revision=8833
2003-10-30 11:56:36 +00:00
Guy Harris 5560949b15 No zero-length arrays, please.
svn path=/trunk/; revision=8832
2003-10-30 11:54:21 +00:00
Guy Harris 305afc4e97 The quantities in the hcidump header are little-endian, not big-endian.
svn path=/trunk/; revision=8831
2003-10-30 11:53:48 +00:00
Guy Harris 611c971364 Definitions of arrays, with no length specified, are not legal C.
svn path=/trunk/; revision=8830
2003-10-30 11:21:26 +00:00
Guy Harris 75f3ee7ba2 Apply Anders Broman's changes to the Q.931 dissector to the Q.933
dissector:

	fix the offset when putting the cause code in a Cause IE into the
	protocol tree;

	in a Number IE, show the number type, numbering plan, and
	extension indicator as named-field bitfields.

svn path=/trunk/; revision=8829
2003-10-30 08:34:59 +00:00
Guy Harris b10a085434 From Anders Broman:
fix the offset when putting the cause code in a Cause IE into the
	protocol tree;

	in a Number IE, show the number type, numbering plan, and
	extension indicator as named-field bitfields.

svn path=/trunk/; revision=8828
2003-10-30 08:07:30 +00:00
Guy Harris 2494f0bf32 From Michael Lum: squelch a couple of compiler warnings.
svn path=/trunk/; revision=8827
2003-10-30 07:14:27 +00:00
Guy Harris 8e67a430e8 From Michael Lum:
GSM BSSMAP (GSM 08.08) support
	GSM DTAP (3GPP TS 24.008) support
	GSM SMS (3GPP TS 24.011) support
	GSM SS (3GPP TS 24.080) support
	GSM SMS TPDU (3GPP TS 23.040) support

svn path=/trunk/; revision=8826
2003-10-30 07:00:18 +00:00
Guy Harris 2a6b337ad8 #if 0 out the stuff to set the reported length, as it'd throw an
exception if it would increase the reported length.

svn path=/trunk/; revision=8825
2003-10-30 03:15:26 +00:00
Guy Harris 95c1f2f7c9 From Marcel Holtmann: support for reading Linux Bluez Bluetooth stack
"hcidump -w" traces.

Note that Jesper Peterson contributed support for reading Endace ERF
files.

svn path=/trunk/; revision=8824
2003-10-30 03:11:03 +00:00
Guy Harris c37d30442f From Dinesh Dutt:
- Dissector for FICON
	- Dissector for FC-SP (Security Protocol for Fibre Channel)
	- Patches to correct the reassembly of FC fragments.
	- Support for new MDS Port Analyzer Adapters that carry the
	  frame length for truncated frames.

svn path=/trunk/; revision=8823
2003-10-30 02:06:13 +00:00
Tim Potter 090dbfbcb2 Decorate higher level proto_item with NetFn and LUN values in hex.
svn path=/trunk/; revision=8822
2003-10-30 00:39:51 +00:00
Guy Harris 0c0ef44095 Make the "fvalue_set" methods for types whose value is allocated free
any previously-allocated version first, so that they don't leak memory.

From Olivier Biot: add a "proto_item_append_string()" routine, to append
to the string value a protocol tree item has.

svn path=/trunk/; revision=8821
2003-10-29 23:48:14 +00:00
Guy Harris b4bdaa5e9f Put quotes around values for FT_ABSOLUTE_TIME variables, and around
values with white space in them.

svn path=/trunk/; revision=8820
2003-10-29 23:15:35 +00:00
Guy Harris 5f01c7a082 Have the "edit display filters" button do the exact same thing as the
"Edit -> Display Filters..." menu item, as per Ulf Lamping - there's
apparently some problem wherein &args doesn't get passed properly to the
callback.

svn path=/trunk/; revision=8819
2003-10-29 22:39:49 +00:00
Guy Harris b9b73fe54c Plug that leak with a cleanup handler, so we don't leak the variable OID
if we throw an exception fetching the variable value.

svn path=/trunk/; revision=8818
2003-10-29 22:11:08 +00:00
Guy Harris 795ce752e9 ...and there's one leak we missed.
svn path=/trunk/; revision=8817
2003-10-29 22:04:57 +00:00
Guy Harris 596dfa55f0 Another leak that isn't.
svn path=/trunk/; revision=8816
2003-10-29 22:02:11 +00:00
Guy Harris e604b9e693 Actually, one of those *isn't* a leak; don't free something we haven't
allocated yet.

svn path=/trunk/; revision=8815
2003-10-29 22:00:54 +00:00
Guy Harris 04a5cb7737 Fix some memory leaks found by Steve Ford.
svn path=/trunk/; revision=8814
2003-10-29 21:54:45 +00:00
Guy Harris 7d27085948 From Steve Ford: "prefs_register_string_preference()" makes a copy of
any string pointed to by the preference variable - as the value we set
it to is allocated, we should free it after registering the preference.

The register routine is called only once - don't worry about whether
"gbl_diameterDictionary" is null or not.

Get rid of a duplicate credit entry in the man page.

svn path=/trunk/; revision=8813
2003-10-29 21:19:44 +00:00
Guy Harris ca1f1c7f2a From Matthijs Melchior: #ifdef out the GUI code, for now.
svn path=/trunk/; revision=8812
2003-10-29 10:54:17 +00:00
Guy Harris 4a7f74b7d1 There's no need to #define tvb_get_string or tvb_get_stringz - that's
done in Xplugin_api.h.

However, we do need to include "epan/filesystem.h", to declare
"get_datafile_path()".

svn path=/trunk/; revision=8811
2003-10-29 10:37:28 +00:00
Guy Harris fc43317556 Use "get_datafile_path()", rather than constructing the default ASN.1
file path by hand.

Set "default_asn1_filename", not "asn1_filename", to the default path.

svn path=/trunk/; revision=8810
2003-10-28 21:47:32 +00:00
Guy Harris ee2ddb83fc Export "get_datafile_path()", not "get_datafile_dir()" - most if not all
dissectors need only the former, which does the pathname-construction
work for you.

svn path=/trunk/; revision=8809
2003-10-28 21:46:26 +00:00
Guy Harris 8a3e69d832 "get_datafile_dir()" is now in the plugin table.
svn path=/trunk/; revision=8808
2003-10-28 21:04:16 +00:00
Guy Harris 70afd0c1dd Add "get_datafile_dir()" to the plugin API list, for the benefit of
plugins that might get configuration information from a file.

svn path=/trunk/; revision=8807
2003-10-28 21:03:01 +00:00
Guy Harris 7b0e35379f As we don't supply a default ASN.1 SNACC output file, if we get an
ENOENT when trying to open the SNACC file, and the file we're trying to
open is the default file, don't print a warning.

Fix some typoes.

svn path=/trunk/; revision=8806
2003-10-28 20:53:37 +00:00
Guy Harris dc1da82c41 This dissector uses GTK+ calls (which no dissector should); until that's
fixed, use GTK_CFLAGS and GTK_LIBS rather than GLIB_CFLAGS and
GLIB_LIBS.

svn path=/trunk/; revision=8805
2003-10-28 20:44:51 +00:00
Guy Harris 32975a11e6 Fix the Makefile to match other plugin Makefiles.
svn path=/trunk/; revision=8804
2003-10-28 19:27:49 +00:00
Guy Harris 67406fcfd2 From Michael Lum: fixed BCD decoding of filler nibble and fixed some
minor bugs.

svn path=/trunk/; revision=8803
2003-10-28 18:08:52 +00:00
Guy Harris 836f12e207 From Lo�c Minier: get rid of the second of a pair of identical checks.
As per a note by Olivier Biot, make the "multipart/XXX" items all lower
case.

svn path=/trunk/; revision=8802
2003-10-28 17:59:29 +00:00
Guy Harris fa3680223b "%.*" expects an "int" argument giving the precision.
svn path=/trunk/; revision=8801
2003-10-28 17:27:56 +00:00
Ronnie Sahlberg a185c70b18 Full duplex analyzers that capture each direction of a link with a separate NIC will lose the time integrity between the two NICs more often than one might expect.
It is thus relatively common that a data segment and its ACK being swapped in the capture file.

Therefore, drop the condition that a segment must not have been acked yet in the detection of OutOfOrder segments.

Second, fix a bug where we didnt keep track of the ack numbers properly for relative sequence number analysis.

svn path=/trunk/; revision=8800
2003-10-28 08:50:39 +00:00
Guy Harris c68a7d7cb1 From Matthias Melchior: plugin to decode BER-encoded ASN.1 messages,
given a type-table from "snacc" as a protocol description.

svn path=/trunk/; revision=8799
2003-10-28 07:02:38 +00:00
Guy Harris 9c3e2720da From Giles Scott: Alteon/Nortel Transparent Proxy Control Protocol
support.

svn path=/trunk/; revision=8798
2003-10-28 06:44:21 +00:00