Commit Graph

34488 Commits

Author SHA1 Message Date
Anders Broman 9a7dbb4182 From Pascal Quantin:
the attached patch should hopefully please the buildbots

svn path=/trunk/; revision=36095
2011-02-28 15:42:58 +00:00
Anders Broman 4c26d6ccb3 From Pascal Quantin:
patch to fix the various issues

svn path=/trunk/; revision=36094
2011-02-28 14:54:22 +00:00
Anders Broman 6eaae55c79 - RE apply checkapi patch.
- Mark unused parameters (From Pascal Quantin).

svn path=/trunk/; revision=36093
2011-02-28 14:17:52 +00:00
Anders Broman 7f604b779d From Vincent Helfre:
I change the void * descr field as an union to either store a pointer or a value.

Hope it solves the problem.

svn path=/trunk/; revision=36092
2011-02-28 13:55:47 +00:00
Martin Mathieson ee5202f2d8 When doing sequence analysis, allow for the first SN to be seen not to be 0.
This will happen if the capture doesn't include the start of this channel.

svn path=/trunk/; revision=36091
2011-02-28 12:26:26 +00:00
Martin Mathieson 93333d8fa1 Make UL retx use warning, rather than error, expert level.
svn path=/trunk/; revision=36090
2011-02-28 12:24:45 +00:00
Anders Broman e761ed7206 Add private extensions under the right tree.
svn path=/trunk/; revision=36089
2011-02-28 11:34:59 +00:00
Anders Broman 6820a81354 Fix checkapi detected errors.
Missing log message:
From Vincent Helfre:
GSM RLC MAC dissector

There are 2 things remaining to do:

-  Update to Rel 8 the control messages such as Packet Measurement Order, Packet Measurement Report, Packet Cell Change Order, Packet Cell Change Notification…

-  Improve the display by replacing the strings describing the type by a hf field

svn path=/trunk/; revision=36088
2011-02-28 11:33:27 +00:00
Anders Broman eec32e9cbc svn path=/trunk/; revision=36087 2011-02-28 09:43:22 +00:00
Anders Broman 8ec8d3fcc3 Export:
SONtransferRequestContainer
SONtransferResponseContainer
SONtransferCause

svn path=/trunk/; revision=36086
2011-02-27 21:55:35 +00:00
Anders Broman 23e6582724 Add miisng file from
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=36079

svn path=/trunk/; revision=36085
2011-02-27 19:41:34 +00:00
Anders Broman da8918838e Add dissection of SonTransfer-IEs.
svn path=/trunk/; revision=36084
2011-02-27 19:40:30 +00:00
Anders Broman a1e94e7e68 Export SourceCellID.
svn path=/trunk/; revision=36083
2011-02-27 19:39:07 +00:00
Gerald Combs 1afc546580 [Automatic manuf, services and enterprise-numbers update for 2011-02-27]
svn path=/trunk/; revision=36080
2011-02-27 16:03:40 +00:00
Anders Broman f9a0795e3a Export dissect_gsm_map_ISDN_AddressString_PDU();
svn path=/trunk/; revision=36079
2011-02-27 14:54:26 +00:00
Ronnie Sahlberg 2c7c20667d iSCSI REJECT PDU contains the full header of the offending command as payload.
Add dissection of this header.


svn path=/trunk/; revision=36078
2011-02-27 01:11:24 +00:00
Stig Bjørlykke d188988e83 Added functionality for handling global profiles.
Global profiles can be installed in a "profiles" directory in the
Global configuration directory, and a global profile will be copied
to the users profiles on first time usage.

svn path=/trunk/; revision=36077
2011-02-26 17:23:24 +00:00
Anders Broman 2ea4267951 - Add a dissector table for Private Extensions.
- Use ENC_BIG_ENDIAN.

svn path=/trunk/; revision=36075
2011-02-26 09:37:43 +00:00
Bill Meier 0d7508cf8e From Robert Bullen: ... code is not incrementing wtap_dumper.bytes_dumped.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5666

Fro me: use 4 -space indentation (not tab) to match surrounding code lines.

svn path=/trunk/; revision=36074
2011-02-25 20:33:43 +00:00
Bill Meier bec1c07788 From Herbert Oppmann: Fix "RTMP dissector unknown audio codec"
"
The [...] variable rtmpt_audio_codecs should be enhanced.

According to [Flash Developer's Guide]
10 = HE-AAC and 11 = Speex are missing.

There is also [Adobe "RTMP Specification V1.0]
which additionally lists 3 = INTEL (not used), 7 = G711A, 8 = G711U
and 9 = NellyMoser 16kHz.
"

From me: All but 'Intel (not used)' added to the list of audio codecs


svn path=/trunk/; revision=36073
2011-02-25 19:17:17 +00:00
Gerald Combs 16bacf2afc Comments have to be at the beginning of the line.
svn path=/trunk/; revision=36072
2011-02-25 17:17:41 +00:00
Jeff Morriss 06aaf02fba Clean up comments: canaries are also used to pad allocations to an 8-byte boundary.
svn path=/trunk/; revision=36071
2011-02-25 15:49:28 +00:00
Anders Broman ff2bbd35b2 Revert file commited by misstake.
svn path=/trunk/; revision=36070
2011-02-25 15:14:12 +00:00
Anders Broman ee0df56d25 Verify tools fails if wireshark-win32-libs does not exist.
svn path=/trunk/; revision=36069
2011-02-25 15:10:35 +00:00
Anders Broman 1b02abc1eb Verify tools fails if wireshark-win32-libs does not exist.
svn path=/trunk/; revision=36068
2011-02-25 15:09:05 +00:00
Stig Bjørlykke c6abce41f8 Ensure we write the current recent file before copying.
svn path=/trunk/; revision=36067
2011-02-25 15:06:37 +00:00
Jeff Morriss 16f704d831 Add a comment explaining what the canary between allocations looks like.
svn path=/trunk/; revision=36065
2011-02-25 03:18:02 +00:00
Bill Meier 39c2e1f71d From Robert Bullen: Fix "Potential access violation when writing to LANalyzer files"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5698

(Note from me: Before the fix "File ! Save As" in Lanalyzer format
                crashed quite consistently on my Windows 7)

svn path=/trunk/; revision=36061
2011-02-25 00:40:22 +00:00
Bill Meier 3dc7697930 Revert SVN #36059; patch from Bug #5698 to be used instead
svn path=/trunk/; revision=36060
2011-02-25 00:26:37 +00:00
Bill Meier 60817fb9a1 Fix Bug #5698: "Potential access violation when writing to LANalyzer files"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5698

Note: before fix
 File ! SaveAs  in Lanalyzer format crashed quite consistently on Windows.

svn path=/trunk/; revision=36059
2011-02-25 00:15:34 +00:00
Stephen Fisher a62a37fbbe From Roland Knall via bug #5726: Adding a dissector registration, so the
dissector may be called by other dissectors.


svn path=/trunk/; revision=36055
2011-02-24 21:47:37 +00:00
Bill Meier 80b7f99b1c Fix Bug #5716: "dumpcap: -q option behavior doesn't match documentation"
Rework code slightly to print "Packets captured: " at 'dumpcap -q ...' exit.
Also: SigInfo now prints: "Packets captured:  n" iso "n Packets captured".

svn path=/trunk/; revision=36052
2011-02-24 19:26:38 +00:00
Anders Broman 527942b05a Add exports.
svn path=/trunk/; revision=36049
2011-02-24 15:06:16 +00:00
Jeff Morriss f91b39b686 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5724 :
Fix a possible bug/crash with rev 36045.

svn path=/trunk/; revision=36048
2011-02-24 14:49:10 +00:00
Jeff Morriss f2cd4937bc Initialize option_len to avoid a (false positive) unitialized variable warning.
svn path=/trunk/; revision=36047
2011-02-24 14:40:01 +00:00
Jaap Keuter f75eaab39f From Wade Hennessey:
Add support for new header options in the KDP protocol.

svn path=/trunk/; revision=36045
2011-02-24 06:46:47 +00:00
Jaap Keuter 39d38636d1 From Håkon Nessjøen
Additions:
  More correct way of checking direction of packets
  Support for two new packet types: ping, pingreply

svn path=/trunk/; revision=36042
2011-02-24 06:22:52 +00:00
Bill Meier 74bc83a85a Fix Bug #5624: "Unknown MMS multipart media is shown in the wrong subtree"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5624

Do ti = proto_tree_add_text(...,...); yyy=proto_item_add_subtree(ti,...) in the usual manner.

svn path=/trunk/; revision=36039
2011-02-24 03:46:30 +00:00
Gerald Combs 3de62b03c6 Forward port r36036 from trunk-1.4: Make sure we ep_allocate enough
memory.

svn path=/trunk/; revision=36037
2011-02-23 22:49:59 +00:00
Jeff Morriss 2f82a2ee2c From Stephen Donnelly via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5708 :
The ERF record format defines several error flags.

This patch exposes ERF error flags using 'Expert Infos' for highlighting and
counting.

svn path=/trunk/; revision=36035
2011-02-23 17:54:00 +00:00
Jeff Morriss cd99f0aef8 From Fulko Hew via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5709 :
When Wireshark receives an AgentX Ping-PDU that contains a zero length
'context' identifier it emits the following warning:

14:30:20          Warn Dissector bug, protocol AgentX, in packet 1066:
tvbuff.c:2571: failed assertion "bufsize != 0"


The attached patch prevents the warning message from appearing under that
circumstance.  Note:  This patch will also prevent the warning under all other
conditions where a zero length string is specified anywhere in the protocol
dissector.

svn path=/trunk/; revision=36034
2011-02-23 17:45:03 +00:00
Jeff Morriss d8a2cf3c4d From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713 :
Enhance RIPng
* Replace tvb_memcpy/proto_tree_add_text by proto_tree_add_item
* Remove dependency to packet-ipv6.h
* Remove packet-ripng.h (not needed)

Also update AUTHORS file

From me:
Put a check_col() back and reword (shorten) a couple of the new blurbs.

svn path=/trunk/; revision=36033
2011-02-23 17:31:03 +00:00
Jeff Morriss 02d491eed9 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713 :
Enhance PIM 
* Replace struct ip6_hdr/tvb_m by tvb_ip6_to_str
* Remove dependency to packet-ipv6.h

svn path=/trunk/; revision=36032
2011-02-23 17:00:20 +00:00
Anders Broman ed66081a4d From Alexis La Goutte:
Cleanup packet-ipv6.h and dependency.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713

svn path=/trunk/; revision=36031
2011-02-23 13:51:49 +00:00
Gerald Combs 4783795690 Split get_dns_name() into get_dns_name() and expand_dns_name().
In dissect_ms_compressed_string() dissect_mscldap_string() simply call
expand_dns_name() instead of using duplicate (and insecure) code. This
*might* break CLDAP and SMB dissection. If that's the case we should
probably revert get_dns_name() and simplify expand_dns_name().

Fixes infinite recursion errors found by joernchen of Phenoelit.

svn path=/trunk/; revision=36029
2011-02-23 00:51:02 +00:00
Jaap Keuter 740c1c4aeb Fix for bug 5702:
In RFC 5102 (for IPFIX), id=128 is defined as "bgpNextAdjacentAsNumber" which
is DST_AS_PEER and id=129 as "bgpPrevAdjacentAsNumber" which is SRC_AS_PEER.

svn path=/trunk/; revision=36028
2011-02-22 21:19:13 +00:00
Anders Broman a469849210 From Pascal Quantin:
[3GPP protocols] Prettify the display of Mandatory Value information elements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711

svn path=/trunk/; revision=36026
2011-02-22 11:56:10 +00:00
Stig Bjørlykke d9ef8f9ad1 Ensure we always have a valid top_tree for p1.content. This fixes a problem
with other dissectors using p1.content, such as p7.

Reset global content_type_id so this will be correct in more cases.
This is still not a good solution, because ContentType and Content are
generic objects which may occur individual in P7.

Indicate when to report invalid content-type.

svn path=/trunk/; revision=36025
2011-02-22 10:23:44 +00:00
Jaap Keuter 4dd920a9aa From Roland Knall:
WS_MSVC_NORETURN is undeclared under a non-Windows operating system, which
breaks compilation in the files epan/except.c and dumpcap.c as well as any
file including epan/except.h

svn path=/trunk/; revision=36023
2011-02-21 21:33:54 +00:00
Jaap Keuter af7e7f1004 From Yaniv Kaul:
This one parses the extended desktop size pseudo-encoding, as specified in
http://www.tigervnc.com/cgi-bin/rfbproto#extendeddesktopsize-pseudo-encoding

svn path=/trunk/; revision=36022
2011-02-21 21:12:21 +00:00