Commit Graph

82786 Commits

Author SHA1 Message Date
Joel Colledge 9878026a51 DRBD: Add support for new packets including the P_RS_DAGTAG family
These were recently added to the DRBD protocol. See the following
commits at https://github.com/LINBIT/drbd-headers:
098b1fdcdbaa introduce new P_RS_CANCEL_AHEAD
e5d5e6fa9af7 add P_DISCONNECT to stop connect-attempts
1681c4b0166e add dagtag resync request packets
2021-12-02 08:20:40 +00:00
Joel Colledge 91b453a70a DRBD: Correct GitHub URL 2021-12-02 08:20:40 +00:00
Joel Colledge cd8096fba3 DRBD: Remove some unnecessary _U_ attributes
We do use these parameters, so _U_ is unnecessary and misleading.
2021-12-02 08:20:40 +00:00
Gerald Combs fcf945f747 wiretap: Fix an underflow in pcapng.
Make sure account for our rounded option length when we process
opt_endofopt. Fixes #17755.
2021-12-02 04:06:59 +00:00
John Thacker cf0ecc4fe1 nstime: Support ISO 8601 basic format
Add support in iso8601_to_nstime for the ISO 8601 Basic date/time
format that lacks the - and : separators.
2021-12-01 20:50:37 -05:00
Gerald Combs 261d223a30 Packaging: Remove a macOS notarization wait.
Older versions of altool couldn't submit uploads concurrently. According
to

https://threadreaderapp.com/thread/1146464491288219653.html

that's no longer the case for version 4.0 and later. Remove our hacky
concurrency check.
2021-12-01 15:43:15 -08:00
João Valverde 14bb016b5b Add release build configuration to version info 2021-12-01 20:28:25 +00:00
Dr. Lars Völker ce2137c0fc TECMP: LIN Payload was cut 1 byte short (BUGFIX)
During a previous cleanup and improvement of the code a off-by-one bug
was introduced, which is fixed by this patch.

closes #17760
2021-12-01 20:09:33 +00:00
João Valverde 3657788cbb dfilter: Add default grammar type 2021-12-01 19:43:30 +00:00
João Valverde 647decd509 dfilter: Avoid double strdup to save token value
Store the lval token value instead.
2021-12-01 19:42:51 +00:00
João Valverde 557cee31fc dfilter: Save lexical token value to syntax tree
Use that for error messages, including any using test operators.

This allows to always use the same name as the user. It avoids
cases where the user write "a && b" and the message is "a and b"
is syntactically invalid.

It should also allow us to be more consistent with the use of
double quotes.
2021-12-01 13:34:01 +00:00
Odysseus Yang ae14cedd44 MBIM: dissect low level UICC access commands
MBIM_CID_MS_UICC_ATR
MBIM_CID_MS_UICC_OPEN_CHANNEL
MBIM_CID_MS_UICC_CLOSE_CHANNEL
MBIM_CID_MS_UICC_APDU
MBIM_CID_MS_UICC_TERMINAL_CAPABILITY
MBIM_CID_MS_UICC_RESET

Also fixed a minor bug in MBIM_CID_BASE_STATIONS_INFO
2021-12-01 07:57:22 +00:00
John Thacker ebcba787a0 BT-DHT: Fix endless loop
The correct return value for an error condition is 0, which will
cause the caller to then report an error. Fix #17754.
2021-12-01 04:24:27 +00:00
João Valverde a9c36dfb75 epan: Remove unused format_uri() function
Used with the GTK GUI, not used for a long time.
2021-11-30 22:07:09 +00:00
João Valverde 1e0cc18ae8 epan: Remove duplication in format_text_wsp()
This function and format_text() are very similar so use a common
implementation for both.
2021-11-30 21:34:57 +00:00
João Valverde c18e44f563 epan: Fix UTF-8 bitmask for 2-byte codepoint
Fixes format_text_wsp(), use the correct bitmask from format_text().
2021-11-30 21:34:57 +00:00
João Valverde 3e0806ca09 dfilter: Remove dfilter_fail_parse()
Instead of requiring a special error function in the parser
just set the syntax_error flag if an error occurs, in any stage
of compilation. Outside of the parser loop it will not be used
but that is fine.
2021-11-30 19:52:05 +00:00
João Valverde a6f978b4d3 dfilter: Remove two stnode replacement functions
One is unused and the other is only used with a corner
case. They are probably not necessary otherwise.
2021-11-30 19:48:47 +00:00
João Valverde 13783fae6b Add comment with rationale for having format_text_chr().
From fa1027a004.
2021-11-30 19:04:37 +00:00
AndersBroman c6e6f21685 proto.c: Increase PROTO_PRE_ALLOC_HF_FIELDS_MEM 2021-11-30 18:36:30 +00:00
Gerald Combs 54ef97cc01 Packaging: Specify host architectures in our macOS Extras packages.
Add 'hostArchitectures="arm64,x86_64"' to the ChmodBPF and path_helper
distribution XML files. "arm64" isn't specified in

https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/DistributionDefinitionRef/Chapters/Distribution_XML_Ref.html

but seems to be correct:

https://developer.apple.com/forums/thread/667672
https://stackoverflow.com/questions/11487596/making-macos-installer-packages-which-are-developer-id-ready

Blind attempt at fixing #17757.
2021-11-30 09:24:02 -08:00
Moshe Kaplan 3953ddcf57 Add UI header files to Doxygen
Add @file markers for UI
header files so that Doxygen will
generate documentation for them.
2021-11-30 08:01:36 -05:00
Chuck Craft b081651088 Qt: Expert Info - set group summary label to ei_ field name
There is some lose of detail in the group label but eliminates
the misleading information that comes from grabbing the
potentially modified summary of the first entry in the group.

Closes #14892 #14425
2021-11-30 09:45:47 +00:00
Chuck Craft 8a19d8d1c7 cfilters/cli: -f "predef:..." needs cfilters loaded
Restore early loading of cfilters file removed in e0ddc7ad.
2021-11-30 09:30:44 +00:00
Moshe Kaplan a523135202 epan: Add header files to Doxygen
Add @file markers for epan
headers so that Doxygen will
generate documentation for them.
2021-11-30 08:46:49 +00:00
Moshe Kaplan fd5b5e3149 extcap: Add header files to Doxygen
Add @file markers for extcap
headers so that Doxygen will
generate documentation for them.
2021-11-30 08:29:39 +00:00
Piotr Winiarczyk 5d4eb4bc66 btmesh: Add dissectors of sensors opcodes
Add dissectors of sensors and generic properites from Mesh Models document. All opcodes from Mesh Models 1.0.1 are now dissected, but not all Mesh Properties are dissected. Closes #17734.
2021-11-30 08:15:29 +00:00
Moshe Kaplan e45ad9dcef wsutil: Add header files to Doxygen
Add @file markers for wsutil
headers so that Doxygen will
generate documentation for them.
2021-11-30 07:30:34 +00:00
Moshe Kaplan 40016daeb3 Add files with WS_DLL_PUBLIC to Doxygen part2
Add @file markers for remaining non-dissector
files that contain functions exported with
WS_DLL_PUBLIC so that Doxygen will
generate documentation for them.
2021-11-30 06:47:35 +00:00
Moshe Kaplan 65a651d5b9 capture: Add header files to Doxygen
Add @file markers for capture
headers so that Doxygen will
generate documentation for them.

Additionally, update the doxygen
config file per
7fee50274f
merging the caputils and capchild
directories.
2021-11-30 06:27:26 +00:00
Moshe Kaplan 34454a5037 wiretap: Add header files to Doxygen
Add @file markers for wiretap
headers so that Doxygen will
generate documentation for them.
2021-11-29 21:59:23 -05:00
João Valverde 504de90a3c wsutil: Split format_size() enum
Use an enum to select units and a bit flag for the other options,
currently only prefix type.
2021-11-29 22:13:32 +00:00
João Valverde 51f2a56b7c wsutil/str_util: Fix indentation
This file has mixed space and tabs indentation, use the standard
4-space C indentation everywhere.
2021-11-29 22:13:31 +00:00
Moshe Kaplan 1c3a9af869 Add files with WS_DLL_PUBLIC to Doxygen
Add @file markers for most files that
contain functions exported with
WS_DLL_PUBLIC so that Doxygen will
generate documentation for them.
2021-11-29 21:27:45 +00:00
Martin Mathieson 9cfce57ac0 Signal-PDU: Make some functions static 2021-11-29 21:26:59 +00:00
João Valverde 37f2a86207 Move string_or_null() to wsutil 2021-11-29 18:37:03 +00:00
João Valverde dcbd79584d epan/str_util: Remove unused functions
Remove ws_strdup_escape_char(). I don't think it is generic enough to keep,
and it does not seem very efficient either.

Remove string_replace(). This function was used in the GTK GUI.
2021-11-29 18:37:03 +00:00
João Valverde 8e63faff95 Fix Debian symbols 2021-11-29 17:47:53 +00:00
João Valverde 9c61142195 wsutil: Add more character escapes to ws_escape_string()
Add whitespace and other escapes for a better display of strings
in the UI.
2021-11-29 17:47:53 +00:00
João Valverde 54bdc20e45 epan: Rewrite ws_escape_string() to use wmem
Return a wmem-allocated string.

Add boolean argument to enable/disable adding double quotes.
2021-11-29 17:47:53 +00:00
João Valverde 44121e2c3b Move escape_string() to wsutil
Move this utility function to wsutil. Rename to
ws_escape_string().

Also add tests.
2021-11-29 17:47:53 +00:00
Martin Mathieson e11cdf2f46 Fix some spelling errors 2021-11-29 17:46:16 +00:00
Marius David 54cf8b01a4 :q! 2021-11-29 13:29:39 +00:00
Marius David 7990dfdf81 Add new netflow fields for Keysight/Ixia. 2021-11-29 13:29:39 +00:00
Роман Донченко 9afa7413f1 jpeg: implement dissection of large Exif IFD values
That is, those that don't fit in the offset field. This includes support
for RATIONAL/SRATIONAL types.
2021-11-29 09:11:04 +00:00
Stéphane Lapie 2b1c34b243 Fixed the ERSPAN Cisco marker packet dissector 2021-11-29 05:25:42 +00:00
Tomasz Moń 890555b8bd Qt: Qt6.2 compatibility fixes
Wireshark successfully compiles on Windows with Qt6.2 with following
cmake options:
  -DUSE_qt6=ON -DDISABLE_ERROR=ON

QCustomPlot QT 6.2 patch is taken from QCustomPlot forum post by miccs.
2021-11-29 04:55:12 +00:00
Uli Heilmeier c8c9ef0c1c OS Version Info: Improve Windows detection
Figuring out the right Windows version for 10/11 or Server 2016/2019/2022
by using the build number.
2021-11-28 22:16:19 +00:00
Jaap Keuter 32b2018ea9 LTE RLC graph: plug possible memory leak 2021-11-28 22:15:27 +00:00
Gerald Combs 5e345d390b NSIS: Remove some confusing error message text.
If the Visual C++ Redistributable installation fails, don't point users
to KB2999226. It applied to Windows 8.1 and earlier, and is more likely
to cause confusion than help fix the problem. Ping #17748.
2021-11-28 21:31:35 +00:00