DOCSIS 3.0 includes a new Bonded Initial Ranging Request (B-INIT-RNG-REQ) MAC
Management type (34). A simple dissector is needed to decode this message.
svn path=/trunk/; revision=29487
brackets, so the API checks for non-terminated value_string arrays will
not falsely think the arrays are non-terminated.
svn path=/trunk/; revision=29299
- Move proto_register...() to the end of the file as per convention;
- Move ett[] to be local to proto_register...();
- "if (...==-1)" not req'd in proto_register...();
- #include <moduleinfo.h> not req'd;
- Remove unneeded forward declarations.
svn path=/trunk/; revision=29296
- Move proto_register to near the end of the file as per convention;
- Remove unneeded #include <epan/reassemble.h>;
- Comment out unused ett[] array and associated;
svn path=/trunk/; revision=29284
- Comment out code which creates two dissector tables and then
stores a preference value in each of them;
AFAICT the tables are not accessed elsewhere;
- Comment out the no longer required prefs callback specification
in proto_register;
- "if (... == -1)" not req'd in proto_register;
- Remove unused proto_reg_wimax function.
svn path=/trunk/; revision=29283
- Do all find_dissector() calls only once during proto_reg_handoff
(not each time a sub-dissector is called when dissecting frames).
- Move proto_register & proto_reg_handoff to the end of the file as per convention;
- Move a global variables to be local;
- Change a global variable to be static;
- Remove unneeded multiple #include <string.h>
- Remove an unneeded variable and a few unneeded lines of code.
svn path=/trunk/; revision=29282
This patch optimizes proto_tree_prime_hfid() + friends and
plugs a memleak in the process.
From me:
Removed unused hfindex in proto_tree_new_item()
Fixed ref_count entry in struct header_field_info.
svn path=/trunk/; revision=29137
Use the standard "if (!initialized)..." logic in proto_reg_handoff().
Also: use "true_false_string flags_yes_no" as in the original patch.
svn path=/trunk/; revision=28994
1. For some reason: using an using the external tfs_yes_no doesn't work in a plugin;
2. proto_reg_handoff: remove unneeded code;
3. Change the prefs callback to call a function which just enables/disables
the protocol; (using proto_reg_handoff means that the dissector
was re-registered each time the pref was changed);
4. packet-esl.h: use #if 0 instead of /* ... */ to comment out code;
svn path=/trunk/; revision=28986
- New dissector for EtherCAT Switch Link Header added to EtherCAT plugin
- Changed filtering of EtherCAT commands to the abbreviated form:
e.g. ecat.cmd = APWR
From me:
- Mark unused variables
- Fixed a string warning
- Do not initialize a static struct
- Use tfs_yes_no
- Reorder files in Makefile
svn path=/trunk/; revision=28976
Move header field info declarations into function scope.
This is the first step. Another patch will be submitted which actually scrubs
the header field info declarations (remove empty blurbs, etc.)
svn path=/trunk/; revision=28797
a protocol tree;
the column values.
This includes stats-tree listeners.
Have the routines to build the packet list, and to retap packets, honor
those requirements. This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.
This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.
While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.
Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.
Clean up some indentation and some gboolean vs. gint items.
svn path=/trunk/; revision=28645
generated from pycrc. The command line used to generate the file is in
epan/crc/Makefile.common. I used "plain" to distinguish it from CCITT,
USB, and other 16-bit CRCs. Integrate the new CRC code into our
infrastructure.
Add crc16_plain_tvb_offset() to epan/crc16.[ch] and use it in
plugins/profinet/packet-pn-rt.c. This _should_ work correctly, but
hasn't been tested.
svn path=/trunk/; revision=27790
- As suggested actually use sizeof(...) rather than a numeric constant.
- g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1.
svn path=/trunk/; revision=27772
that would break compilation for older compilers. Create a "DLL_LDFLAGS"
variable and use it in DLLs and plugins. Use PLUGIN_LDFLAGS and
DLL_LDFLAGS where needed. Don't force i386 code in the TPG plugin.
svn path=/trunk/; revision=27582
As of version 0.99.8, there has been an annoying problem in the ASN.1 dissector:
when using a 'type table' which discribes the ASN.1 syntax of the traced packets,
wireshark would crash on the very first packet. The cause for the crash is an out-of-
boundry write, detected by g_free().
svn path=/trunk/; revision=27507
There was an ugly hack while creating the menu, that tried to detect the stat_group a stats_tree belongs to by looking at the name string. That makes it unnecessarily hard to understand how the menu is really created.
Fix: Add a new function stats_tree_register_with_group() that takes the stat_group as a parameter. Use this function where a stats_tree doesn't fit into the default "unsorted" group.
svn path=/trunk/; revision=27407
should be "%s", with the string used as an argument, just in case the
string contains a "%" character.
Clean up indentation.
svn path=/trunk/; revision=27304
Add some heuristics to the RLM LAPD-over-UDP dissector, so as not to
misdissect as many packets.
Fetch the LAPD dissector handle only once.
Change some Boolean arguments to gboolean from int.
svn path=/trunk/; revision=27217
Remove global variables for packet information, pass these through function calls.
Reduce label_SUB[M|A]_[Method|Attribute] routines.
Actually check column status before writing to it.
svn path=/trunk/; revision=27199
proto_reg_handoff time and store the result.
If we don't call the mtp3 dissector on the payload then call the data dissector
to make it easier to see the payload.
svn path=/trunk/; revision=27160