1) the GTK+ documentation recommends against it;
2) the X11 implementation of gtk_window_set_title() sets the
icon name to the title, so gdk_window_set_icon_name() doesn't
do anything interesting, and the Win32 and Quartz
implementations of gdk_window_set_icon_name() don't do
anything;
3) gdk_window_set_icon_name() either crashes or complains if
it's handed a null pointer, which happens at startup.
Clean up indentation.
svn path=/trunk/; revision=33739
Dissect the SMB Tree_Connect_Andx Request and Response properly with
extension request and response which are documented in [MS-SMB] — v20100711
svn path=/trunk/; revision=33726
- Added more info for detecting S-Bus telegrams
- Added the display filter sbus.retry for finding re-sent request telegrams
- Added the possibility to jump from the request telegram to the response
telegram
- Added response time to the response telegram
- Added telegram types "Read/Write Block"
- Corrected the "Read System Info" telegram (CRC was not correctly calculated)
- Changed my EMail address
- Small typos corrected
svn path=/trunk/; revision=33718
The Infiniband dissector currently uses a heuristic where it attempts to parse
IBA payloads as if they contained encapsulated traffic with an Ethertype
header. While a relatively common occurrence and thus a fairly useful feature,
this heuristic in many cases causes false-positives which invoke unneeded
dissectors and generate noise in the form of unjustified "malformed packet"
errors these dissectors cause. This patch adds a checkbox to the Infiniband
preferences menu that allows users to disable this feature if desired. The
option remains on by default.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5062
svn path=/trunk/; revision=33703
matches 0xaa55.
I don't know the historic reason for decoding this as "Mysterious Field",
but newer of Network Monitor (3.4) does show this as version and signature.
svn path=/trunk/; revision=33696
In some cases the usage may have been benign since it can be seen by code inspection that the maximum value of the end variable can't exceed the maximum value of the loop variable.
However, on general principles, all the usages have been fixed.
svn path=/trunk/; revision=33692
- Fix dissection of MU_RF_STATS_BLOCK
- Try to dissect embedded 802.11 frames (only works for the
header, there seems to be a constant value of 0xa8b7 between
wireless header and wireless data.
svn path=/trunk/; revision=33682
- Add missing 'user_data' arg as needed;
- Use gboolean rather than int as the type of the value returned.
Also: Cleanup whitespace & reformat long lines in a few cases.
svn path=/trunk/; revision=33679
include the FCS, and use it for the Daintree SNA file format. While
we're at it, explicitly check to make sure the purported packet length
gives it at least one byte of packet data, and fix some print formats to
use %u for unsigned values.
svn path=/trunk/; revision=33678
- Define several event callback functions with the correct number of args;
- Remove several unnecessary 'if (!user_data) exit(10);' code sequences;
- Use 'user_data' arg of event callbacks instead of an object property
in several cases;
- Reformat some long lines.
svn path=/trunk/; revision=33677