Commit graph

36162 commits

Author SHA1 Message Date
Chris Maynard
91f30ab64f From Jakub Zawadzki via bug 6002: Don't set state to STATE_EXPECT_DATA if there's no data to read.
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6002


svn path=/trunk/; revision=37924
2011-07-06 16:22:11 +00:00
Chris Maynard
f16b234b84 Fix memory leak, using ep_alloc() instead of g_malloc().
svn path=/trunk/; revision=37923
2011-07-06 16:03:43 +00:00
Anders Broman
0c812dbe61 From György Szaniszló:
Introduced a new tcp state variable: maxseqtobeacked, this is the
maximum seq number that can be acked by the rev party in normal case.
This new state variable only serves the proper detection of
tcp.analysis.ack_lost_segment indicator, and decouples it from the detection of
tcp.analysis.lost_segment indicator.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6081

svn path=/trunk/; revision=37922
2011-07-06 15:45:56 +00:00
Anders Broman
8e4aa22fa0 From Kluchnikov Ivan:
Decoding Phy Synchronization Field in wimax DL-MAP and Compressed DL-MAP.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6068

svn path=/trunk/; revision=37921
2011-07-06 15:39:25 +00:00
Martin Mathieson
c4dd3e5e5c Add
#if defined(_WIN32) || defined(HAVE_PCAP_CREATE)
around access to interface_options.buffer_size

svn path=/trunk/; revision=37920
2011-07-06 14:56:42 +00:00
Anders Broman
51b2410345 From Ludovic Haessler:
Wrong decoding of RLC/MAC EGPRS Packet Downlink Ack/Nack (3GPP TS 44.060)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6098

svn path=/trunk/; revision=37919
2011-07-06 12:53:04 +00:00
Anders Broman
6fdf0eed8f From HAESSLER:
Abis interface not correctly handled in gsmtap dissector

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6097

svn path=/trunk/; revision=37918
2011-07-06 12:47:21 +00:00
Michael Tüxen
8180111144 Use g_object_set() instead of gtk_object_set().
svn path=/trunk/; revision=37917
2011-07-06 11:35:52 +00:00
Michael Tüxen
b682b5ee01 Get it even linking...
svn path=/trunk/; revision=37916
2011-07-06 11:25:57 +00:00
Michael Tüxen
eef7623fb9 Get it compiling when not having libpcap.
svn path=/trunk/; revision=37915
2011-07-06 11:22:38 +00:00
Jörg Mayer
950e4d19ad Add detection of rpcap support in libpcap and use it if available.
svn path=/trunk/; revision=37914
2011-07-06 09:28:40 +00:00
Michael Tüxen
48683778a0 Add support for multiple interface to the main welcome screen.
This patch is from Irene Ruengeler.

svn path=/trunk/; revision=37913
2011-07-06 09:17:06 +00:00
Guy Harris
859aadfd5f Add a URL for the specifications. (No, the Wireshark source code is not
a specification.)

Put V1 support back, in case there are captures out there with V1
packets and somebody wants to read them.

We don't need two identical tests against the minimum length.

For an unknown version, just put in a text item for the data, don't
append a note to the length field (which is the wrong field to append to
in any case).

Make routines not used outside this file static.

svn path=/trunk/; revision=37912
2011-07-06 05:31:42 +00:00
Guy Harris
ddc6baabbb Constify to squelch compiler warning.
svn path=/trunk/; revision=37911
2011-07-06 04:45:50 +00:00
Guy Harris
fc581f9865 Don't check for "(null)" as the result of a printf operation; don't pass
in a null pointer to %s in the first place!  Not all printf
implementations necessarily emit "(null)" in that case; perhaps GLib's
does, but we shouldn't even depend on that - we should, instead, at
least print something semi-useful in that case (the link-layer type's
numerical value).

Fix syntax errors in the "no libpcap" case.

svn path=/trunk/; revision=37910
2011-07-06 04:09:49 +00:00
Guy Harris
053c583fda Add some additional routine variants that handle string encodings, and
make FT_STRING and FT_UINT_STRING handle string encodings.

Get rid of FT_EBCDIC in favor of FT_STRING with ENC_EBCDIC.

Add some URLs for DRDA.

Clean up some stuff in TN3270 and TN5250, including using ENC_ values
for proto_tree_add_item().

svn path=/trunk/; revision=37909
2011-07-05 23:59:23 +00:00
Guy Harris
2ef2ecde9a The #if 0'ed out code was being used; #if 0'ing it out meant that some
items didn't get put into the protocol tree.  See, for example, the
4548-Bug4668.pcap capture in the Wireshark menagerie (and attached to
bug 4668).

Instead, replace the #if 0'ed out code with code that does what the
non-commented-out line of code did, but doesn't assign to the unused and
now non-existent pi variable.

Make the "hf_id != -1" case the first one, as that should be the
"normal" case.

svn path=/trunk/; revision=37908
2011-07-05 23:14:00 +00:00
Michael Tüxen
1c7349022d Don't use strcpy().
svn path=/trunk/; revision=37907
2011-07-05 21:29:06 +00:00
Guy Harris
9788778543 Add ett_a11_rqi_grantedqos to the list of ett_ values to be allocated.
Clean up indentation.

svn path=/trunk/; revision=37906
2011-07-05 21:11:58 +00:00
Michael Tüxen
8b5eee3639 (Try to) fix compilation when no libpcap is available.
svn path=/trunk/; revision=37905
2011-07-05 21:11:24 +00:00
Michael Tüxen
cb90aa7904 Add initial support for multiple interfaces. More to come after
the capture options dialog box supports also multiple interfaces.

This patch has been developed by Irene Ruengeler.

svn path=/trunk/; revision=37904
2011-07-05 20:34:03 +00:00
Michael Tüxen
4b8f5a1865 Support selecting multiple interfaces in the capture/interfaces
dialog.
Until the capture/options dialog supports multiple interfaces, the
options button is only selectable when 0 or 1 interfaces are selected.
This patch is based on work by Irene Ruengeler.

svn path=/trunk/; revision=37903
2011-07-05 20:29:33 +00:00
Anders Broman
1103e61a2a From Michael Mann:
Added choice to display UTC or local time.  Defaulted to local for "backwards compatibility"

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3384

svn path=/trunk/; revision=37902
2011-07-05 15:22:28 +00:00
Anders Broman
9e5a06a2ef From Sven Eckelmann:
Add support for v14

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6046

svn path=/trunk/; revision=37901
2011-07-05 08:20:23 +00:00
Anders Broman
99d0148b99 From Sven Eckelmann:
Rename HNA to TT to use the same names as upstream.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6046

svn path=/trunk/; revision=37900
2011-07-05 08:17:46 +00:00
Guy Harris
6a4693d7ff Add a URL for DECnet Phase IV specifications.
svn path=/trunk/; revision=37899
2011-07-04 22:01:36 +00:00
Anders Broman
2f05cf4dcf From Michael Mann:
Added ability to display UTC time or UTC time with date.  I liked having the
difference between UTC and local time, not just setting local=UTC.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2629

svn path=/trunk/; revision=37898
2011-07-04 21:43:34 +00:00
Anders Broman
78d22ed8ee From Sven Eckelmann:
Fix size of unicast fragment packet in v12.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5658

svn path=/trunk/; revision=37897
2011-07-04 21:20:18 +00:00
Anders Broman
b00a34230c From Sven Eckelmann:
Remove unused length_remaining.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5658

svn path=/trunk/; revision=37896
2011-07-04 21:16:51 +00:00
Stig Bjørlykke
7bd8379896 Fetch svn revision also when checked out with git-svn.
svn path=/trunk/; revision=37895
2011-07-04 21:14:43 +00:00
Anders Broman
e85447a30f From Sven Eckelmann:
Unify handling of NULL-tree in dissection routines.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5658

svn path=/trunk/; revision=37894
2011-07-04 21:14:02 +00:00
Anders Broman
49b4ec10b6 From Christopher Maynard:
From doc/README.tapping:

IF the tap is going to return private data using the last parameter to
tap_queue_packet() and IF the protocol can appear multiple times inside the
same packet, you will have to make sure that each instance of
tap_queue_packet() is using its own instance of private struct variable
so they don't overwrite each other.

This was the case here, so I changed the static allocation of tap_rec to be
ep_alloc'd.  I also tried to clean up the Info column a bit.  With this patch
applied, the graph now shows the APM and ANM correctly instead of 2 ANM's.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5966

svn path=/trunk/; revision=37893
2011-07-04 20:43:29 +00:00
Anders Broman
42dcd2af62 From Guido Reismueller:
This patch includes alle modem capabilities from DOCSIS 3.0
Until now only modem capabilities 1-12 where implemented.
Now all capabilities 1-40 are included.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6070

svn path=/trunk/; revision=37892
2011-07-04 20:34:04 +00:00
Anders Broman
cdfadace98 From Kluchnikov Ivan:
Update wimax DCD Message mac version values.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6069

svn path=/trunk/; revision=37891
2011-07-04 15:04:50 +00:00
Anders Broman
d6fda1f1f5 From Kluchnikov Ivan:
Wrong length of items in wimax Compressed DL-MAP and UL-MAP.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6067

svn path=/trunk/; revision=37890
2011-07-04 14:57:12 +00:00
Anders Broman
4257e61b6c From Kluchnikov Ivan:
Wireshark cannot decode wimax compressed DL-MAP without FCH burst.
Function is_down_link use the base station address (bs_address), which is set
in function dissect_wimax_fch_decoder.
Changed function is_down_link, it use packet_info->p2p_dir for check if packet
is downlink. 
packet_info->p2p_dir set in GSMTAP.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6066

svn path=/trunk/; revision=37889
2011-07-04 14:33:22 +00:00
Anders Broman
639e59a9f9 From Michael Mann:
Removed "key prefix" need within GUI so it's a little more intuitive (because
that's what this bug is complaining about).  Slight backwards compatibility
issue with UAT (because key prefix was in previous keys), but all development 
(including fix for BUG 1123 that created UAT) has just been on SVN and not
released.

Also adjusted AirPCap (airpcap_loader.c) to account for the lack of "key
prefix".

Addressed some memory leaks/excess string creation.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5985

svn path=/trunk/; revision=37888
2011-07-04 14:07:20 +00:00
Anders Broman
509c6a7fc0 From Roland Knall:
This patch will add preliminary Profinet IO transport protocol dissection to
the openSAFETY protocol.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6063

svn path=/trunk/; revision=37887
2011-07-04 14:00:51 +00:00
Anders Broman
3d17e592d5 From Pascal Quantin:
Do not trigger an assert when reaching an unknown extension in CHOICE and SEQUENCE types.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6087

svn path=/trunk/; revision=37886
2011-07-04 06:22:15 +00:00
Anders Broman
241958363d Error: the blurb for field "Extension header" ("gtp.ext_hdr") matches the field name in packet-gtp.c
svn path=/trunk/; revision=37885
2011-07-04 06:11:38 +00:00
Guy Harris
e02cd7707d Explain a bit more what this does.
svn path=/trunk/; revision=37884
2011-07-04 01:39:13 +00:00
Jakub Zawadzki
ea06298d76 Fix one more undefined reference to `EBCDIC_to_ASCII'
svn path=/trunk/; revision=37883
2011-07-03 21:18:22 +00:00
Anders Broman
3826755b0a From Roland Knall:
implement a named dissector for the PN/IO sub-protocol for
Profinet, as well as a heuristic dissector ("pn_io"), other protocols can
attach too.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6062

svn path=/trunk/; revision=37882
2011-07-03 19:25:34 +00:00
Anders Broman
aea7d0a5bc Add enums to Event-Trigger" code="1006"
svn path=/trunk/; revision=37881
2011-07-03 19:17:18 +00:00
Anders Broman
d86c200706 From Martin Isaksson:
PDCP PDU number extension header support.

svn path=/trunk/; revision=37880
2011-07-03 19:16:21 +00:00
Jakub Zawadzki
6667b33f3f Fix: tvbuff.obj : error LNK2019: unresolved external symbol _EBCDIC_to_ASCII referenced in function _tvb_get_ephemeral_string_enc
Remove duplicated EBCDIC_to_ASCII from libwireshark.def

svn path=/trunk/; revision=37879
2011-07-03 18:59:41 +00:00
Guy Harris
d611c64795 Need to export EBCDIC_to_ASCII().
svn path=/trunk/; revision=37878
2011-07-03 17:54:00 +00:00
Guy Harris
338af96b2e Add a tvb_get_ephemeral_string_enc() routine that's like
tvb_get_ephemeral_string() but takes an ENC_ value for the character
encoding.  Use it in the MQ dissector to fetch strings to put, for
example, into the Info column, so we properly handle EBCDIC strings
there.

svn path=/trunk/; revision=37876
2011-07-03 17:08:25 +00:00
Anders Broman
8b303cc61a From Roland Knall:
The way heuristic dissection was handled by the openSAFETY plugin, could lead
to out-of-memory problems with large files (>50.000 packets). The new version
does not use ep_alloc anymore, but a static boolean instead.

Also, the code registering for the SercosIII dissector got simplified, as the
SercosIII dissector is no longer a plugin.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6061

svn path=/trunk/; revision=37874
2011-07-03 16:03:46 +00:00
Gerald Combs
7e9911ed84 [Automatic manuf, services and enterprise-numbers update for 2011-07-03]
svn path=/trunk/; revision=37873
2011-07-03 15:19:31 +00:00