Commit Graph

47734 Commits

Author SHA1 Message Date
Guy Harris 905eb4d706 Make a routine not used outside file.c static.
svn path=/trunk/; revision=50857
2013-07-23 23:45:24 +00:00
Guy Harris b524ecebd8 Don't cast away constness (except in cases where an API makes that
impossible).

svn path=/trunk/; revision=50856
2013-07-23 23:42:14 +00:00
Guy Harris 8e22ded7f8 Don't cast away constness.
svn path=/trunk/; revision=50855
2013-07-23 23:39:37 +00:00
Guy Harris 0751daed8a Don't cast away constness (except where APIs render that impossible).
svn path=/trunk/; revision=50854
2013-07-23 23:34:45 +00:00
Guy Harris 7f7733579c Don't cast away constness.
svn path=/trunk/; revision=50853
2013-07-23 23:25:04 +00:00
Jörg Mayer 8d5cb217dc Fix ECHLD_TIMEOUT vs ECHLD_TIMED_OUT a second time for today.
svn path=/trunk/; revision=50852
2013-07-23 20:45:25 +00:00
Anders Broman bed8ebd289 Register BSSAP+ by name.
svn path=/trunk/; revision=50851
2013-07-23 19:51:14 +00:00
Guy Harris 76f24a97e6 Clean up capitalization in some option descriptions.
svn path=/trunk/; revision=50850
2013-07-23 19:50:52 +00:00
Guy Harris 3506b0bf53 The Qt documentation appears to indicate that you're expected to include
<QPushButton> if you're using a QPushButton, so:

	1) adding the include is the right fix, not just a duct-tape
	   fix;

	2) <QPushButton>, rather than <qpushbutton.h>, is probably what
	   you're expected to include.

(<QPushButton> is, at least in Qt 5.1, a wrapper that just includes
<qpushbutton.h>.)

svn path=/trunk/; revision=50849
2013-07-23 19:47:14 +00:00
Guy Harris 52972f605d Handle operating systems that are anticipating the day when files should
be read in chunks > 2GB.

svn path=/trunk/; revision=50847
2013-07-23 18:34:10 +00:00
Luis Ontanon c9e6eda769 Yet another iteration...
svn path=/trunk/; revision=50846
2013-07-23 18:26:38 +00:00
Jakub Zawadzki ac16425a1f Free all cloned tvbs, not only first one.
svn path=/trunk/; revision=50844
2013-07-23 17:31:39 +00:00
Jakub Zawadzki 761b763eae Move tvb_new_child_real_data() to tvbuff_real.c with some cleanup
svn path=/trunk/; revision=50843
2013-07-23 17:23:51 +00:00
Alexis La Goutte 3808dfc909 Add RFC6975 (Signaling Cryptographic Algorithm Understanding in DNS Security Extensions (DNSSEC)) support ( DAU, DHU and N3U OPT(ion))
svn path=/trunk/; revision=50840
2013-07-23 14:54:18 +00:00
Alexis La Goutte 4806972c5e Fix warning found by fix-encoding-args
svn path=/trunk/; revision=50839
2013-07-23 14:54:09 +00:00
Alexis La Goutte 4aa7dab163 Enhance DNS Dissector Make DS ( Delegation Signature 43 ) filterable (Update RFC reference...)
svn path=/trunk/; revision=50838
2013-07-23 14:53:59 +00:00
Pascal Quantin 802e7bed77 Try to differentiate a non filled private_data (pointer set to NULL) from an enum with value = 0
svn path=/trunk/; revision=50837
2013-07-23 14:34:46 +00:00
Jörg Mayer a74c3538fc Fix for Bug 8960 - All mongodb query show as [Malformed Packet: MONGO]
proto_tree_add_item doesn't link to be called with FT_STRINGZ and length -1.

svn path=/trunk/; revision=50836
2013-07-23 13:38:39 +00:00
Jörg Mayer 7e4ed00126 Move files to dirty that generate a warning about
variable length array

svn path=/trunk/; revision=50835
2013-07-23 13:24:52 +00:00
Jörg Mayer 8bdf0dd3ff - Fix a typo that was warned about (acually a coding error that
would not have had any effect in this particular case).
- Remove trailing whitespace.

svn path=/trunk/; revision=50834
2013-07-23 13:23:40 +00:00
Jörg Mayer da52691fb1 Include sys/wait.h
svn path=/trunk/; revision=50833
2013-07-23 13:11:16 +00:00
Jörg Mayer eb28276569 Separate sources in
CLEAN_FILES
DIRTY_FILES
and move packet_list_record.cpp to DIRTY.
Now I finally have a compiling qtshark again (clang and Qt5)

svn path=/trunk/; revision=50832
2013-07-23 12:20:33 +00:00
Jörg Mayer 95e60fa7e7 Fix the following error with Duct Tape - long term solution still
recommended ;-)

/home/jmayer/work/wireshark/svn/trunk/ui/qt/summary_dialog.cpp:67:5: error: no matching
+member function for call to 'connect'
    connect(bRefresh, SIGNAL(clicked()), this, SLOT(RefreshData()));
    ^~~~~~~
/usr/include/QtCore/qobject.h:199:36: note: candidate function not viable: cannot
+convert argument of incomplete type 'QPushButton *' to 'const QObject *'
    static QMetaObject::Connection connect(const QObject *sender, const char *signal,
                                   ^
/usr/include/QtCore/qobject.h:202:36: note: candidate function not viable: cannot
+convert argument of incomplete type 'QPushButton *' to 'const QObject *'
    static QMetaObject::Connection connect(const QObject *sender, const QMetaMethod
+&signal,

...

svn path=/trunk/; revision=50831
2013-07-23 12:18:11 +00:00
Jörg Mayer ba356ca6a0 Fix "missing sentinel in function call" with help of
http://stackoverflow.com/questions/12095865/spurious-missing-sentinel-in-function-call

svn path=/trunk/; revision=50830
2013-07-23 12:08:07 +00:00
Jörg Mayer b1627f16fe Sort alphabetically
svn path=/trunk/; revision=50829
2013-07-23 11:20:45 +00:00
Alexis La Goutte 99d0205c93 From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8963
packet-scsi.c add asc/ascq code 2C:0A

Add ASC/ASCQ code 2C:0Ah "PARTITION OR COLLECTION CONTAINS USER OBJECTS" (SPC-4

svn path=/trunk/; revision=50828
2013-07-23 10:37:01 +00:00
Alexis La Goutte d7095ca214 From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8965
Packet-scsi.c: fix subtree reference: ett_sense_osd_completed

The field hf_scsi_sns_osd_object_completed should be dissected under ett_sense_osd_completed instead of ett_sense_osd_not_initiated
(It was a copy-paste error in attachment 10967 from bug 8790)

svn path=/trunk/; revision=50827
2013-07-23 10:36:52 +00:00
Alexis La Goutte c68f439baa From Thomas ERSFELD (GSoC13) Apply changes of revision 50107 to qtshark man pages sorted and added capinfos & reordercap
svn path=/trunk/; revision=50826
2013-07-23 10:32:02 +00:00
Jörg Mayer 812f308620 Use largefile detection in cmake.
Move wiretap/file_wrapper.c back to clean sources.

svn path=/trunk/; revision=50825
2013-07-23 09:41:35 +00:00
Jörg Mayer 1cbd49e61b Copy over cmake largfile detection from the gromacs project.
svn path=/trunk/; revision=50824
2013-07-23 09:40:21 +00:00
Alexis La Goutte d937adcc9e Fix typo (Missing .git in git clone URL)
svn path=/trunk/; revision=50823
2013-07-23 09:37:37 +00:00
Alexis La Goutte 81a0f6d2d7 From Thomas ERSFELD (GSoC13) via remark of Gerald Use QDialogButtonBox for Summary Dialog
(Using a QDialogButtonBox would ensure that the button names, sizes,
 and placement conforms to the UI guidelines for each platform.)

svn path=/trunk/; revision=50822
2013-07-23 08:56:56 +00:00
Alexis La Goutte 8c5f14a440 Fix warning when build Qtshark
summary_dialog.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget1'.
summary_dialog.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget2'.
summary_dialog.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget3'.

svn path=/trunk/; revision=50821
2013-07-23 08:56:47 +00:00
Alexis La Goutte dd6f0d00b8 Fix warning from Windows Buildbot (when build qtshark) .\print_dialog.cpp(41) : warning C4100: 'version_string' : unreferenced formal parameter
svn path=/trunk/; revision=50820
2013-07-23 08:56:38 +00:00
Alexis La Goutte ad78694e76 From Thomas ERSFELD (GSoC13) Prepare inclusion of Follow (TCP/UDP/SSL) feature in Qtshark
svn path=/trunk/; revision=50819
2013-07-23 08:56:30 +00:00
Alexis La Goutte 6cff72548d From Thomas ERSFELD (GSoC13) Qtshark : Columns in the packet list table are not updated when you add one on preference menu
svn path=/trunk/; revision=50818
2013-07-23 08:56:20 +00:00
Jörg Mayer 681c9e7160 Looks like not every version of cmake has the same behaviour wrt
the working directory. So hardcode the path in a case where it
didn't work for everyone.

svn path=/trunk/; revision=50817
2013-07-23 07:41:20 +00:00
Guy Harris efd6675cf6 collectd.data.severity is unsigned, so use proto_tree_add_uint64.
svn path=/trunk/; revision=50816
2013-07-23 05:19:44 +00:00
Anders Broman 2efa4fa8aa From Andreas Bachmann:
allows to display multiple TLVs and the bug of logInterMessagePeriod is fixed.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6126

svn path=/trunk/; revision=50815
2013-07-23 04:47:18 +00:00
Anders Broman d91b6a1872 From Michal Labedzki:
HCI: Improve Class of Device dissection. 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948

svn path=/trunk/; revision=50814
2013-07-23 04:23:19 +00:00
Anders Broman 0bbb2cbbaf From Michal Labedzki:
HCI: Add latest Assigned Numbers 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948

svn path=/trunk/; revision=50813
2013-07-23 04:15:23 +00:00
Anders Broman 46eabdf34d From Michal Labedzki:
Add initial support for 3DS Profile.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948

svn path=/trunk/; revision=50812
2013-07-23 04:09:50 +00:00
Anders Broman 24a60b1d6c From Michal Labedzki:
ATT: remove trailing white characters.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948

svn path=/trunk/; revision=50811
2013-07-23 03:56:38 +00:00
Anders Broman 511757f96c From Michal Labedzki:
SDP: Add support for USB Forum ProductID names.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948

svn path=/trunk/; revision=50810
2013-07-23 03:54:04 +00:00
Anders Broman 93646d0981 From Javier Godoy:
Remove function osd_list_collection and update scsi_osd_svcaction.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8944#attach_11229

svn path=/trunk/; revision=50809
2013-07-23 03:49:44 +00:00
Guy Harris 8bd5a3649a Have get_uint_value() assume it's being passed an encoding value, which
isn't necessarily going to be zero if the item is big-endian.

The last argument to test_length() is an encoding, not a big-endian vs.
little-endian Boolean; name it appropriately.

This fixes bug 8953.

svn path=/trunk/; revision=50806
2013-07-22 23:11:07 +00:00
Guy Harris 9f66191681 The last argument to ptvcursor_add() is an encoding value; pass it one,
not a Boolean endianness value.

svn path=/trunk/; revision=50803
2013-07-22 23:01:30 +00:00
Jörg Mayer 545a84185e Fix for
[ 28%] Building C object epan/CMakeFiles/epan.dir/dissectors/packet-diameter_3gpp.c.o
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-diameter_3gpp.c:232:90: error: 
      unused parameter 'tree' [-Werror,-Wunused-parameter]
  ...*tvb, packet_info *pinfo _U_, proto_tree *tree, void *data _U_) 
                                               ^
1 error generated.
make[2]: *** [epan/CMakeFiles/epan.dir/dissectors/packet-diameter_3gpp.c.o] Error 1


svn path=/trunk/; revision=50799
2013-07-22 21:25:04 +00:00
Jörg Mayer 358f334041 Move file_wrappers.c to dirty files, it has some warnings (turning errors)
when compiled with clang.

Just for documentation:

[  6%] Building C object wiretap/CMakeFiles/wiretap.dir/file_wrappers.c.o
/home/jmayer/work/wireshark/svn/trunk/wiretap/file_wrappers.c:987:28: warning: implicit
      conversion loses integer precision: 'gint64' (aka 'long long') to '__off_t'
      (aka 'long') [-Wshorten-64-to-32]
                if (ws_lseek64(file->fd, off, SEEK_SET) == -1) {
                    ~~~~~~~~~~           ^~~
/home/jmayer/work/wireshark/svn/trunk/wiretap/file_wrappers.c:1051:35: warning:
      implicit conversion loses integer precision: 'long long' to '__off_t' (aka 'long')
      [-Wshorten-64-to-32]
                if (ws_lseek64(file->fd, offset - file->have, SEEK_CUR) == -1) {
                    ~~~~~~~~~~           ~~~~~~~^~~~~~~~~~~~
/home/jmayer/work/wireshark/svn/trunk/wiretap/file_wrappers.c:1076:34: warning:
      implicit conversion loses integer precision: 'gint64' (aka 'long long') to
      '__off_t' (aka 'long') [-Wshorten-64-to-32]
                if (ws_lseek64(file->fd, file->start, SEEK_SET) == -1) {
                    ~~~~~~~~~~           ~~~~~~^~~~~
3 warnings generated.

svn path=/trunk/; revision=50798
2013-07-22 21:23:00 +00:00
Anders Broman 7b0812cc2e Add forgotten update.
svn path=/trunk/; revision=50797
2013-07-22 20:45:11 +00:00