Commit Graph

36359 Commits

Author SHA1 Message Date
Bill Meier 8e01cc53fc Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings;
Also: In various places: compute 'offset' whether or not 'if(tree)'.

svn path=/trunk/; revision=38156
2011-07-21 21:54:09 +00:00
Jeff Morriss 8589a0eb1d Remove the snaplen check added in r37633: the change in r37634 makes it
unnecessary.

svn path=/trunk/; revision=38155
2011-07-21 21:19:18 +00:00
Jörg Mayer fc3bb80871 Add new old-gtk-compat.h to the distribution
svn path=/trunk/; revision=38154
2011-07-21 20:57:10 +00:00
Jörg Mayer 933e244498 Add missing FindGTK3.cmake
Reorder cmake modules to match directory listing order

svn path=/trunk/; revision=38153
2011-07-21 20:50:51 +00:00
Jörg Mayer 41a6524702 Update GSEAL errors
svn path=/trunk/; revision=38152
2011-07-21 20:22:16 +00:00
Jörg Mayer bb7650f70d Fix almost all accesses to ->window
svn path=/trunk/; revision=38151
2011-07-21 20:12:08 +00:00
Bill Meier f161dc95fa Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=38150
2011-07-21 19:10:10 +00:00
Jörg Mayer f298effccd Another one I missed.
svn path=/trunk/; revision=38149
2011-07-21 19:00:55 +00:00
Jörg Mayer 94fbcbfde6 Fix for buildbot failure. Hopefully I didn't miss too many more.
svn path=/trunk/; revision=38148
2011-07-21 18:36:17 +00:00
Jörg Mayer 369929c2f6 Create a file containing macros to provide the access-functions
when the gtk version is too old (for the 2,14,0 case).

Remove all old access methods that were guarded by 2,14,0 tests.

Feel free to do the same for newer guards :-)

svn path=/trunk/; revision=38147
2011-07-21 17:44:02 +00:00
Michael Tüxen f98587d686 Undo the checking of command line interfaces. It might the a pipe...
svn path=/trunk/; revision=38146
2011-07-21 17:30:42 +00:00
Michael Tüxen 77022a66b0 Adopt test to new error handling.
svn path=/trunk/; revision=38145
2011-07-21 16:06:52 +00:00
Michael Tüxen f30c3675ec Fix issue reported by Joerg.
svn path=/trunk/; revision=38144
2011-07-21 16:00:38 +00:00
Martin Mathieson c8cf6094ab Fix a label, and make sure all counters are initialised to 0.
svn path=/trunk/; revision=38143
2011-07-21 15:55:58 +00:00
Michael Tüxen 91df20357a Make sure that the interfaces listed in ifaces really exist.
Some protection code in capture / options.
Obtained from Irene Ruengeler.


svn path=/trunk/; revision=38142
2011-07-21 15:23:46 +00:00
Michael Tüxen 5014f11884 strdup -> g_strdup.
svn path=/trunk/; revision=38141
2011-07-21 12:06:18 +00:00
Michael Tüxen dcac95be11 Add some temporary protection code to support the current capture
options dialog box. It will be removed as soon as the capture options
dialog box supports multiple interfaces.

Received from Irene Ruengeler.


svn path=/trunk/; revision=38140
2011-07-21 11:28:16 +00:00
Jörg Mayer 99e0c43d35 Replace references to style by gtk_widget_get_style (according to
http://developer.gnome.org/gtk/2.24/GtkWidget.html#gtk-widget-get-style
this doesn't require a minimum version)

svn path=/trunk/; revision=38139
2011-07-21 00:16:05 +00:00
Jörg Mayer ada4a40003 Make USE_THREADS actually work with cmake
svn path=/trunk/; revision=38138
2011-07-21 00:13:14 +00:00
Anders Broman a9259c309e From Martin Kaiser:
Add support for the ca_pmt_reply apdu as defined in section 8.4.3.5 of the DVB-CI standard (EN 50221).

Also some new apdu tags and their descriptions are added for completeness.
After applying this patch, DVB-CI support is complete except for reassembly

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6132

svn path=/trunk/; revision=38137
2011-07-20 22:34:57 +00:00
Anders Broman 4b692c92c8 From Lei Chen:
patch to support "Additional MS Radio Access Capability" and "Packet Pause" in packet-gsm_rlcmac.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6133

svn path=/trunk/; revision=38136
2011-07-20 22:07:31 +00:00
Anders Broman 0a65432f96 Use ENC_BIG_ENDIAN.
svn path=/trunk/; revision=38135
2011-07-20 14:09:19 +00:00
Anders Broman c165083608 strdup -> g_strdup
svn path=/trunk/; revision=38134
2011-07-20 13:53:00 +00:00
Michael Tüxen 7a16d2fa87 Synchronize the selection of interfaces between the main welcome
window, the capture/interface dialog box and the capture / start
menu item.
Obtained from Irene Ruengeler.


svn path=/trunk/; revision=38133
2011-07-20 12:51:57 +00:00
Martin Mathieson 3a88c5c7dd Don't sanity-check snaplen against frame length if snaplen is 0.
svn path=/trunk/; revision=38132
2011-07-20 12:24:41 +00:00
Martin Mathieson 7d7f7d870e Register nicer entry points for LTE RRC BCH messages, and use them in RLC, MAC, PDCP.
svn path=/trunk/; revision=38131
2011-07-20 12:19:22 +00:00
Guy Harris 6eec1f97bb Regularize style a bit in help messages.
Clean up capitalization.

Fix a comment.

svn path=/trunk/; revision=38130
2011-07-20 05:49:24 +00:00
Chris Maynard 0506627c30 Apply some endian heuristics when dissecting ICMP originate, receive and transmit timestamps. Fixes bug 6114.
Ref: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6114

svn path=/trunk/; revision=38129
2011-07-20 00:22:31 +00:00
Guy Harris c34b796445 Add a DREP_LITTLE_ENDIAN for the DCE RPC endianness bit in the data
representation.  Use it rather than a raw 0x10.

Add a DREP_ENC_INTEGER() macro that takes a pointer to the data
representation and returns either ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN;
use it for the encoding argument to proto_tree_add_item(), rather than
just the AND of drep[0] and DREP_LITTLE_ENDIAN, as it's not a boolean
any more, and for string values we'll be supporting character encodings
as well and thus won't be able to trust that the 0x10 bit will mean
"little endian".

Use ENC_NA for some other encoding values, i.e. for FT_BYTES and the
like.

Fix a couple of places in the DCOM dissector where we were passing the
byte-order bit rather than the field value to
proto_tree_add_uint_format().

Clean up white space.

svn path=/trunk/; revision=38128
2011-07-19 23:02:02 +00:00
Gerald Combs 3991a62d31 The GTK+ documentation says we can pass NULL to gtk_table_get_size(). Do
that instead of using a dummy variable.

svn path=/trunk/; revision=38127
2011-07-19 22:38:28 +00:00
Stig Bjørlykke 4e20e37aa6 Use ENC_NA for FT_PROTOCOL.
svn path=/trunk/; revision=38125
2011-07-19 19:37:58 +00:00
Stig Bjørlykke cea89ebc80 Use ENC_NA for hf_fragments (FT_NONE).
svn path=/trunk/; revision=38124
2011-07-19 19:37:45 +00:00
Jörg Mayer eedc9b880a Reenable the commented out code. I was able to reproducably break
the compilation but after a complete removal of the build directory
and a rebuild the problem is gone.

svn path=/trunk/; revision=38123
2011-07-19 19:36:26 +00:00
Stig Bjørlykke ba2aae0f8e Use ENC_NA as encoding for FT_PROTOCOL, FT_NONE and FT_BYTES.
svn path=/trunk/; revision=38122
2011-07-19 18:48:31 +00:00
Gerald Combs 1f497af628 Instead of overloading WIRESHARK_LIBS / wireshark_LIBS in Makefile.nmake
use WIRESHARK_LIB_DIR for the location of our external libraries.

svn path=/trunk/; revision=38119
2011-07-19 18:22:46 +00:00
Jörg Mayer fd42af2127 There are some undefined symbols in the code: comment out
the problematic code parts.

svn path=/trunk/; revision=38118
2011-07-19 18:00:08 +00:00
Jörg Mayer 21adeb2cfc Back out parts of 38112, as pointed out by Stig Bj\370rlykke:
The changes in profile_dlg.c, uat_gui.c and new_packet_list.c does not
work.  The tooltip is not displayed, and it's not possible to get the
context menu from a column header in the packet list.
...
I guess gtk_tree_view_column_get_widget() does not return
column->button, which is the widget we use.


svn path=/trunk/; revision=38117
2011-07-19 17:40:23 +00:00
Jörg Mayer 40cc0b57a1 Martin Mathieson: gtk_table_get_size() was only introduced in gtk 2.22
svn path=/trunk/; revision=38116
2011-07-19 17:29:27 +00:00
Martin Mathieson 049643cf28 From Pradip Biswas, bug 6127 - Added Decode for RRC BCCH (BCH and DL_SCH) messages on RLC-over-UDP.
Add separate codes/cases for BCH-over-BCH and BCH-over-DLSCH.

svn path=/trunk/; revision=38115
2011-07-19 16:41:56 +00:00
Gerald Combs e7fce8ccb8 Pull WIRESHARK_LIBS from the system environment if it's available.
svn path=/trunk/; revision=38114
2011-07-19 16:26:42 +00:00
Jörg Mayer 1bf94efa12 Get rid of direct access to struct GtkToggleButton
svn path=/trunk/; revision=38113
2011-07-19 16:02:16 +00:00
Jörg Mayer 6d20f48e88 Fix access to the following stuctures:
GtkCheckMenuItem
GtkTable
GtkTreeViewColumn

svn path=/trunk/; revision=38112
2011-07-19 15:13:36 +00:00
Jörg Mayer 9166443e3c Get rid of all GtkAdjustment element accesses. Fix a bug
introduced when fixing this stuff for rtp_player.c

svn path=/trunk/; revision=38111
2011-07-19 14:33:50 +00:00
Chris Maynard 7bc1f25843 Based on the information provided by Steve Karg via -dev, change all occurrences of ENC_LITTLE_ENDIAN to ENC_BIG_ENDIAN.
Ref: http://www.wireshark.org/lists/wireshark-dev/201107/msg00305.html


svn path=/trunk/; revision=38110
2011-07-19 13:19:49 +00:00
Michael Tüxen 358fcedaba Get the interfaces list from the Capture / Interfaces list in sync
when using the capture / start menu item.

Obtained from Irene Ruengeler.

svn path=/trunk/; revision=38109
2011-07-19 12:42:18 +00:00
Jörg Mayer 4a06b078b6 Fix some errors when compiling with -DGSEAL_ENABLE.
svn path=/trunk/; revision=38108
2011-07-19 11:02:26 +00:00
Stig Bjørlykke f282154ab0 Use correct encoding for proto_tree_add_item().
svn path=/trunk/; revision=38107
2011-07-19 10:51:12 +00:00
Guy Harris 93abdd9804 Use ENC_LITTLE_ENDIAN rather than TRUE in proto_tree_add_item() calls.
(Yes, that means that all but one call uses ENC_LITTLE_ENDIAN, and one
uses ENC_BIG_ENDIAN.  I guess that's how the protocol works....)

svn path=/trunk/; revision=38106
2011-07-19 03:20:02 +00:00
Chris Maynard b968cc5c0b From Michael Mann via bug 5769: In fDevice_Instance(), add field in proper
big-endian byte order.

Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5769

svn path=/trunk/; revision=38105
2011-07-19 02:47:12 +00:00
Guy Harris 2e2dc7179f Work around an annoying problem caused by the collision of GNU gettext's
configure script's attempts to deal with AIX 4 and Lion and/or Xcode 4's
dealings with Fortify.

svn path=/trunk/; revision=38104
2011-07-19 02:29:31 +00:00