The answer to the question "do we need to add hardened runtime
entitlements or exceptions?" in osx-app.sh is "yes". Update a comment
accordingly.
Change-Id: Icc6f9ed31838aa6342f405a244e726586e9c0c4d
Reviewed-on: https://code.wireshark.org/review/32703
Reviewed-by: Gerald Combs <gerald@wireshark.org>
This adds the entitlement to everything we sign. I cannot test a more
granular approach without access to an Apple issued codesigning cert/key
pair.
Bug: 15667
Change-Id: I9fe962a06b681d33853b0944765987e21d21be2d
Reviewed-on: https://code.wireshark.org/review/32700
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reorganize the lists of accessors, with a top-level heading for the byte
order and subheadings for each size.
Also document ENC_HOST_ENDIAN.
Change-Id: I10131e399f6c90624a387c89340f77ea769ab33f
Reviewed-on: https://code.wireshark.org/review/32701
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Require the POD package. Some platforms ship POD translators as a
separate package instead of shipping them with Perl.
Bug: 15513
Change-Id: Ie277f9296d06063581512bc4c2df1d3158117f2c
Reviewed-on: https://code.wireshark.org/review/32685
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
The 'sign' bit was treated like a regular bit because of direct casting to a wider int type
Change-Id: Id0f095fa9bda97ecbdfc32f3610271eeea86fc2e
Reviewed-on: https://code.wireshark.org/review/32688
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
PTK key derivation algorithm for WPA1 uses SHA1 not MD5.
MD5 is used for MIC only.
To avoid regression also add a decrypt test for WPA1 with
GTK rekeying.
Change-Id: Iabcf40c2f74d5dbc1d72cba0718c77020d97f61f
Fixes: v3.1.0rc0-342-g9cf77ec5e1 ("ieee80211: Support decrypting WPA3-Personal / SAE captures")
Reviewed-on: https://code.wireshark.org/review/32691
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Updates some information elements according to
https://www.iana.org/assignments/ipfix/ipfix.xhtml
Adds support for RFC8549
Change-Id: Ic4129df7cfeccd86a7bfb40cbc7181559b85fe50
Reviewed-on: https://code.wireshark.org/review/32690
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
For Windows:
Don't use ws_isatty() - which is a wrapper around _isatty() - to
determine whether the output is to a Windows console or not; it returns
a non-zero value for *any* character device, not just a console.
Instead, use a console API; if it succeeds, it's a console, otherwise it
isn't.
If we're writing to a console, and the
ENABLE_VIRTUAL_TERMINAL_PROCESSING flag is set, or it isn't set but we
can set it, assume the console supports the escape sequences that
request 24-bit color, and use them.
For UN*X:
We can isatty() to determine if the output is to a terminal, as it
doesn't check for character special files, it specifically checks for
terminals (which, in practice, means "device that supports one of the
ioctls to get terminal modes" in most if not all cases; that covers
serial lines, pseudo-ttys, and perhaps some other devices).
Only use the 24-bit color escape sequences if the COLORTERM environment
variable is set to "truecolor" or "24bit".
Bug: 15659
Change-Id: I673667b86bd6b2ab48c06e00ed16b537d6723453
Reviewed-on: https://code.wireshark.org/review/32689
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Disable the following warnings:
../epan/oids_test.c:33:68: warning: initialization of a flexible array member [-Wpedantic]
../epan/oids_test.c:34:57: warning: initialization of a flexible array member [-Wpedantic]
../epan/oids_test.c:38:9: warning: initialization of a flexible array member [-Wpedantic]
../epan/oids_test.c:40:60: warning: initialization of a flexible array member [-Wpedantic]
../epan/oids_test.c:41:54: warning: initialization of a flexible array member [-Wpedantic]
../epan/oids_test.c:45:8: warning: initialization of a flexible array member [-Wpedantic]
../epan/oids_test.c:46:84: warning: initialization of a flexible array member [-Wpedantic]
Change-Id: I6af0d3182162a15ea6e072029a86a32c0c27c575
Reviewed-on: https://code.wireshark.org/review/32686
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Highlight the row in packet list and proto tree when mouse hovers
above the row. This mimics the behaviour on Windows.
Change-Id: I28461f9d7740269bad39893597232fe775f77a86
Reviewed-on: https://code.wireshark.org/review/32619
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The border around inactive+selected packet list items from aaba30a3
was removed in 00776f83 and 53dfec9b. Add this back again.
Use solid color in flat_style_format, no need for a gradient between
the same color.
Remove the empty default_style_format, it does not add anything.
Ping-Bug: 12010
Change-Id: I97df7147b196c73e9f6ec4b9c370ddb6bd54488a
Reviewed-on: https://code.wireshark.org/review/32676
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Make sure we've fetched an address before using it.
Bug: 15642
Change-Id: I94dba50254dfd06f014810a9e779bda3c46352dd
Reviewed-on: https://code.wireshark.org/review/32680
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
In dissect_compressed_beamforming_and_cqi, break out of a loop if our
bit offset doesn't advance.
Bug: 15553
Change-Id: I6212be4c08c42ef1969c1302e85a8e08f1d7547f
Reviewed-on: https://code.wireshark.org/review/32677
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
HTML Help has trouble rendering both straight (') and curly (’) quotes
in its window titles. Make sure we remove them.
Bug: 15656
Change-Id: Ic7ab6652e285c11e50e4acb3fab4fcc12653778c
Reviewed-on: https://code.wireshark.org/review/32674
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
None of the preference require this function to be called again and it
it not designed to be called several times (systematically adds the
dissector handle).
Change-Id: I0aca361902e65668c991e26025236c7ebb0fe946
Reviewed-on: https://code.wireshark.org/review/32666
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Clean up some code where that was already the case, to make it clearer
that it is the case.
Make that be the case in print_stream_text_alloc().
Change-Id: If6ef1ded9dad94ffaccb5d214f70c7e4d0844e8a
Reviewed-on: https://code.wireshark.org/review/32660
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Put values used only by particular subclasses into the subclass data
structure.
Change-Id: Ibb995ebf18ba24449467e932084fbeef03ad1abf
Reviewed-on: https://code.wireshark.org/review/32653
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
For some reason the CMake output to Python is missing, no matter how
hard I try. Use an alternative approach instead where Python executes
CMake and filters the output without relying on pipes in Bash.
Change-Id: I21b8b709c3a944fbd3b07e7fac59702735dd83a4
Reviewed-on: https://code.wireshark.org/review/32628
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
There's nothing to draw.
Maybe we should also avoid it if we didn't get any packets.
Change-Id: If76f7909f78e66b7302d0ab2caa284ca36c43bfb
Reviewed-on: https://code.wireshark.org/review/32649
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Giving the pathname of a temporary file that will be deleted once TShark
exits isn't useful; just refer to "the temporary capture file".
Change-Id: I7333ac3cef4e4ae1076a5b0e3c46a04e0328d505
Reviewed-on: https://code.wireshark.org/review/32645
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Update a URL, raise questions about *which* escape sequences give you
24-bit color on Windows.
Change-Id: Ic88e29de1049824210be2857b75409a5ffa1585e
Reviewed-on: https://code.wireshark.org/review/32624
Reviewed-by: Guy Harris <guy@alum.mit.edu>
The SpecializedResourceReportArg has a different and incompatible
definition in CAMEL phase 4. In phase 2 and 3 it is defined as NULL and
in phase 4 it is defined as CHOICE that contains two NULL fields.
- Add missing CAMEL phase 3 and 4 Application Context Names.
- Move the common code from dissect_camel_v[12] functions into
dissect_camel_all and add dissect_camel_v[34] functions.
- Remove application_context_version as it has never been used and
the version is determined in dissect_camel_v[1234] functions.
Change-Id: I43eea246889786421b22dcfb937708eee814b29e
Reviewed-on: https://code.wireshark.org/review/32611
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Show as expert info and in info column. Link to first request/response.
Change-Id: I990d9a5aec5904dabe22bcb103426a8549cef31b
Reviewed-on: https://code.wireshark.org/review/32615
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Offset and length are 8 bytes long with version 4 and not 4 bytes.
Bug: 15608
Change-Id: Ibfbff9fc8967aab26b504c351225885e185d00fd
Reviewed-on: https://code.wireshark.org/review/32607
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
If the offset for src or dst address is set to 0 it should not be used.
Change-Id: I7ea4da49d5fe33e118bbf4cdf9a241083a0d950f
Reviewed-on: https://code.wireshark.org/review/32600
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
It only clarified the encoding used for URN, so remove the corresponding
comment.
Change-Id: Idbe7e325242c495123df3d8f5babfae32b05a36d
Reviewed-on: https://code.wireshark.org/review/32606
Reviewed-by: Pascal Quantin <pascal@wireshark.org>