osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
33868 commits 23 branches 0 tags 1.3 GiB
Commit graph

10982 commits

Author SHA1 Message Date
Bill Meier
ceb99a4bf0 Fix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles. 
svn path=/trunk/; revision=34963
 2010-11-18 23:02:20 +00:00
Bill Meier
7d38abddaa Fix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles. 
svn path=/trunk/; revision=34962
 2010-11-18 22:55:18 +00:00
Bill Meier
f2030d7270 stats_tree_register() need be called only once (and not each time a port pref is changed); 
(Minor) use tvb_reported_length_remaining() rather than tvb_length_remaining() in a number of places;
Add a comment to get_sametime_message_len() about the minimum length of the tvb when the fcn is called.

svn path=/trunk/; revision=34961
 2010-11-18 21:56:25 +00:00
Stephen Fisher
dbf10b1dc8 From Jon Ellch via bug #5175: Add PPI-GPS protocol dissector patch 
Minor changes by me as detailed in the bug's comment #8.


svn path=/trunk/; revision=34956
 2010-11-18 20:54:14 +00:00
Bill Meier
1d42ee3ebb Use value_string_ext fcns to access a number of value_string arrays; 
Sort several value_arrays in ascending order by value;
Localize a global variable to proto_reg_handoff().

svn path=/trunk/; revision=34955
 2010-11-18 19:37:22 +00:00
Bill Meier
13f264e34a Tighten up TLV processing a bit to prevent a potential loop. 
svn path=/trunk/; revision=34954
 2010-11-18 19:25:11 +00:00
Anders Broman
a6f7c3a8bd Tweak the display of the header. 
svn path=/trunk/; revision=34946
 2010-11-18 16:01:39 +00:00
Anders Broman
da383952df "Fill" value_strings. 
svn path=/trunk/; revision=34935
 2010-11-17 21:58:35 +00:00
Bill Meier
311cac0568 Use value-string_ext fcns to access value_string array; 
Sort value_string_array in ascending order by value;
Reformat display of tag info to be more readable;
Rework TLV processing;
Remove unneeded variable;
Minor whitespace cleanup.

svn path=/trunk/; revision=34933
 2010-11-17 21:40:21 +00:00
Anders Broman
3c998dadc2 value_string_ext fixes. 
svn path=/trunk/; revision=34932
 2010-11-17 16:56:51 +00:00
Jeff Morriss
ea23d55aa5 Remove unneeded stuff from the Copyright notice. Use ENC_BIG_ENDIAN and ENC_NA. 
svn path=/trunk/; revision=34931
 2010-11-17 16:52:20 +00:00
Jeff Morriss
805d04fd15 From Toralf Foerster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5376 : 
A dissector for the SAMETIME protocol.

From me: no need to include gmodule.h, use only ASCII in the author's name.

svn path=/trunk/; revision=34930
 2010-11-17 16:47:03 +00:00
Anders Broman
b4098dfae9 - Update to 3GPP TS 25.413 V9.4.0 (2010-09). 
- Fill the value_strings.

svn path=/trunk/; revision=34929
 2010-11-17 16:23:10 +00:00
Anders Broman
3ffa66319e - Update to 3GPP TS 25.413 V9.4.0 (2010-09). 
- Fill the value_strings.

svn path=/trunk/; revision=34928
 2010-11-17 15:36:53 +00:00
Bill Meier
e65f69766a User value_string_ext fcns to access several value_string arrays; 
Minor reformatting and whitespace cleanup.

svn path=/trunk/; revision=34927
 2010-11-17 14:59:08 +00:00
Anders Broman
263db68ab6 - Update to 3GPP TS 25.413 V9.4.0 (2010-09). 
- Fill the value_strings.

svn path=/trunk/; revision=34925
 2010-11-17 11:48:17 +00:00
Anders Broman
1913b3dd3e - Use SABP:s SCTP ppid. 
- Use value_string_ext.

svn path=/trunk/; revision=34924
 2010-11-17 08:18:30 +00:00
Jaap Keuter
62067368a0 Separate out/update comment block. 
Update IANA assignments.
Use available checksum routines.
Some cleanup and use of convenience macros.

svn path=/trunk/; revision=34922
 2010-11-17 07:42:32 +00:00
Jeff Morriss
37d4ccff56 From Slava via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5335 : 
This patch adds to Wireshark the ability to dissect Infiniband SDP (Socket
Direct Protocol) and CM MADs traffic.

It also contains various other bug-fixes and enhancements. SDP traffic can be
identified automatically (analyzing SDP CM MADs) or manually.

SDP, or Sockets Direct Protocol, is a protocol developed by the Infiniband
Trade Association which enables existing socket-based applications to
transparently utilize the Infiniband capabilities. 

This patch is submitted on behalf of Mellanox Technologies Ltd.

svn path=/trunk/; revision=34918
 2010-11-17 02:57:22 +00:00
Anders Broman
2bb0b3fa19 The IPv6 "element" in PDN address information element is a 8 byte 
IPv6 interface identifier.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5408

svn path=/trunk/; revision=34914
 2010-11-16 20:46:21 +00:00
Anders Broman
838a24aaa0 value_string_ext fixes. 
svn path=/trunk/; revision=34908
 2010-11-16 17:31:29 +00:00
Bill Meier
491f05b16e Use value_string_ext fcns to access several value_string arrays; 
Minor whitespace cleanup.

svn path=/trunk/; revision=34900
 2010-11-16 15:20:33 +00:00
Jeff Morriss
58d018e21a From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5400 : 
The attached patch adds many more DAAP codes to be parsed properly by the DAAP
dissector.
In addition, it fixes some prints.

svn path=/trunk/; revision=34899
 2010-11-16 15:01:43 +00:00
Bill Meier
c52500588e Use value_string_ext fcns to access several value_string arrays. 
svn path=/trunk/; revision=34894
 2010-11-15 23:53:25 +00:00
Martin Mathieson
43bfcfc32a Assert was firing while working out sequence length for user plane frames. 
Treat signalling plane case separately.

svn path=/trunk/; revision=34893
 2010-11-15 23:32:34 +00:00
Bill Meier
3c98cf2ebc Use value_string_ext fcns to access several value_string arrays. 
svn path=/trunk/; revision=34891
 2010-11-15 22:37:35 +00:00
Bill Meier
37742d97d8 Use value_string_ext fcns to access several value_string arrays. 
svn path=/trunk/; revision=34890
 2010-11-15 22:00:33 +00:00
Anders Broman
e1b1ef192c "Fill" value_strings. 
svn path=/trunk/; revision=34888
 2010-11-15 21:32:27 +00:00
Anders Broman
4aef1cc2ed Use value_string ext for address family. 
svn path=/trunk/; revision=34887
 2010-11-15 21:05:03 +00:00
Jeff Morriss
313785c513 From Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5395 : 
The ZigBee security dissector was not recording the short to long address
mappings in Security Headers, preventing the decryption of some payloads. This
patch eliminates the Undecoded warnings in packets 1 and 19 in this test
capture: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5457

The keys to decrypt these packets are listed in the bug.

svn path=/trunk/; revision=34886
 2010-11-15 20:52:41 +00:00
Bill Meier
8548e16613 Use value_string_ext fcns to access a value_string array. 
svn path=/trunk/; revision=34884
 2010-11-15 19:46:07 +00:00
Bill Meier
0f286bbb89 Use value_string_ext fcns to access a value_string array. 
svn path=/trunk/; revision=34883
 2010-11-15 19:15:34 +00:00
Bill Meier
b1554fc198 Use value_string_ext fcns to access certain value_string arrays; 
Whitespace cleanup.

svn path=/trunk/; revision=34882
 2010-11-15 19:08:12 +00:00
Bill Meier
ed7105e21b Update package_name_vals[] value_string array: 
- Add new entries based on: http://www.iana.org/assignments/megaco-h248 last updated 2010-10-01;
- Fix a typo (incorrect value for an entry);
- Switch values between two entries to match the IANA list;
- Switch two entries so list is in ascending order by value.

svn path=/trunk/; revision=34881
 2010-11-15 19:00:16 +00:00
Jaap Keuter
1009be2c17 Skip reserved word in ANCP OAM-Loopback-Test-Parameters TLV. 
svn path=/trunk/; revision=34879
 2010-11-15 18:28:36 +00:00
Jeff Morriss
b0e1f62ef8 From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 : 
I improved the coap dissector.  It is resulted by the 2nd coap test event. 
This patch is diff from 34794.  The fuzzying test passed more than 62000.

Changed:
- removed "#if 0", and expanded exp2().
- added new error codes.
- improved looks of the block options
- renamed to "token" from "opaque_bytes" according to new draft.


From me: Use a use a left shift operation instead of multiplying by 2 many
times.

svn path=/trunk/; revision=34878
 2010-11-15 18:01:19 +00:00
Jeff Morriss
56e024876e From Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5403 : 
Fix recent fuzz failures.

svn path=/trunk/; revision=34877
 2010-11-15 16:56:54 +00:00
Bill Meier
71a74c2f3a Regenerate packet-nbap.c now that asn2wrs sorts value_string arrays used with value_string_ext fcns; 
Change nbap.cnf to use val_to_str_ext to access protocolIE_ID value_string array.
Also: Minor whitespace cleanup in nbap.cnf.

svn path=/trunk/; revision=34876
 2010-11-15 16:46:14 +00:00
Anders Broman
7870de6f95 Fill value_strings. 
svn path=/trunk/; revision=34875
 2010-11-15 16:46:07 +00:00
Anders Broman
84dd318764 Extend value_strings to make full use of value_string_ext. 
svn path=/trunk/; revision=34872
 2010-11-14 20:53:15 +00:00
Anders Broman
bb0eefd834 Fix a cut-n-paste error. 
svn path=/trunk/; revision=34866
 2010-11-14 14:13:52 +00:00
Anders Broman
cfc7e8849c Fix a couple of cut-n-paste errors. 
svn path=/trunk/; revision=34865
 2010-11-14 09:57:42 +00:00
Anders Broman
f49a742f2d From Fred Fierling: 
Patch to fix dissector bug noticed in ZigBee APS commands with null payload.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5384

svn path=/trunk/; revision=34864
 2010-11-13 20:13:30 +00:00
Anders Broman
9afb5801bc Fix a typo. 
svn path=/trunk/; revision=34863
 2010-11-13 20:09:01 +00:00
Martin Mathieson
a8b6aca90c From Pascal Quantin: 
- Set a default RNTI value for each type, in case optional RNTI value isn't supplied.
- Improve range checking of given type against acceptable range of values
- fix misplaced return (this fixed bug 5392)

svn path=/trunk/; revision=34859
 2010-11-13 15:32:29 +00:00
Bill Meier
671344e6cc zbee_mfr_code_names: sort so in ascending order by value; add dummy "Unknown" entries for missing values. 
svn path=/trunk/; revision=34855
 2010-11-12 21:47:41 +00:00
Bill Meier
e2123574dc Fix a crash I introduced in SVN #34692: A value_string ext referenced smb_cmd_vals rather than smb_cmd_vals_ext. 
svn path=/trunk/; revision=34853
 2010-11-12 17:28:01 +00:00
Martin Mathieson
a067c3bb8a Check given RNTI value is consistent with given RNTI-type. 
As suggested in bug 5382.  The reported crash didn't happen for me...

svn path=/trunk/; revision=34852
 2010-11-12 16:59:22 +00:00
Anders Broman
760d2a5cdc Update Camel to TS 29.078 9.2.0 (2010-06) 
svn path=/trunk/; revision=34849
 2010-11-12 14:50:58 +00:00
Stig Bjørlykke
775daf50ce Getting wrong addr_type from the packet is not a dissector bug. 
svn path=/trunk/; revision=34847
 2010-11-12 07:54:39 +00:00
Anders Broman
5d6d0f6fea Update from IANA records. 
svn path=/trunk/; revision=34846
 2010-11-11 21:18:46 +00:00
Anders Broman
2c042dcd15 Use value_string_ext. 
svn path=/trunk/; revision=34845
 2010-11-11 21:18:15 +00:00
Anders Broman
92d5c09ac6 Use value_string_ext. 
svn path=/trunk/; revision=34844
 2010-11-11 17:24:11 +00:00
Anders Broman
d5d1e51d90 Fix indentation. 
svn path=/trunk/; revision=34842
 2010-11-11 07:37:43 +00:00
Anders Broman
ec42f515db From Andrew Feren: 
sflow decode error for some extended formats.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5379

svn path=/trunk/; revision=34840
 2010-11-11 07:34:07 +00:00
Stephen Fisher
b18e8fd1ca Resolve bug #2254: Migrate the 802.1q VLAN dissector into the Ethernet II. 
svn path=/trunk/; revision=34838
 2010-11-10 22:37:30 +00:00
Chris Maynard
31f5ce6193 Convert host name to UTF8 before displaying to info column or in tree. 
Fixes bug 1867.

svn path=/trunk/; revision=34837
 2010-11-10 21:41:10 +00:00
Anders Broman
768498f956 Make value_string_ext for all AVP:s with enums. 
svn path=/trunk/; revision=34835
 2010-11-10 20:11:38 +00:00
Anders Broman
1fbfce3411 Make a more descriptive name for the per vendor avp value_string_ext. 
svn path=/trunk/; revision=34831
 2010-11-10 14:43:20 +00:00
Stig Bjørlykke
8b21f50474 Added hint about "TCP segmentation offload" when IP length == 0. 
Added expert info item for bogus IP length.
Added hint about "IP checksum offload" for invalid IP checksum.
Describe TSO in the preference setting. 

svn path=/trunk/; revision=34830
 2010-11-10 13:49:55 +00:00
Bill Meier
fc5f614cec Fix a few typos in two value_string arrays .... 
svn path=/trunk/; revision=34828
 2010-11-09 22:58:17 +00:00
Anders Broman
18a3357ad3 Fill th Q.850 tables. 
svn path=/trunk/; revision=34827
 2010-11-09 21:13:28 +00:00
Anders Broman
b91ed78bcc Add a value_string_ext. 
svn path=/trunk/; revision=34825
 2010-11-09 17:24:45 +00:00
Anders Broman
8785d27bd8 Define unused AVP:s to make it possible to use value_string_ext for 
common AVP:s.

svn path=/trunk/; revision=34824
 2010-11-09 17:23:57 +00:00
Stig Bjørlykke
34d9ef736b Added an expert info for illegal integer length. 
svn path=/trunk/; revision=34820
 2010-11-09 12:17:11 +00:00
Stig Bjørlykke
c56ac0d6db Removed calls to proto_item_set_expert_flags(), as this will be called 
in expert_add_info_format().

svn path=/trunk/; revision=34819
 2010-11-09 12:15:55 +00:00
Anders Broman
348e0bc54b Use value_string_ext for gsm_a_rr_rxlev_vals. 
svn path=/trunk/; revision=34818
 2010-11-09 07:28:04 +00:00
Anders Broman
2fb8971136 Update to 3GPP TS 29.002 V9.3.0 (2010-09) 
svn path=/trunk/; revision=34814
 2010-11-08 23:15:16 +00:00
Bill Meier
c17c9fff87 Use value_string_ext fcns to access certain value_string arrays; 
Sort a few value_string arrays to be in ascending order by value;
Do minor reformatting and whitespace cleanup.

svn path=/trunk/; revision=34813
 2010-11-08 21:59:39 +00:00
Bill Meier
1c01cbfa60 Remove two duplicate values from rtp_payload_type_short_vals value_string array. 
svn path=/trunk/; revision=34812
 2010-11-08 21:35:14 +00:00
Bill Meier
2de3781872 Remove two duplicate entries from rtp_payload_type_vals array. 
svn path=/trunk/; revision=34811
 2010-11-08 21:24:10 +00:00
Anders Broman
7a4781f2d2 Tweek dns_types. 
svn path=/trunk/; revision=34810
 2010-11-08 18:05:42 +00:00
Anders Broman
cab0cef11d Use value_string_ext for RTP payload types. 
svn path=/trunk/; revision=34804
 2010-11-08 14:43:59 +00:00
Gerald Combs
8b468e9284 The PEN field is 32 bits. 
svn path=/trunk/; revision=34802
 2010-11-07 18:21:22 +00:00
Anders Broman
0d246c79a9 display the the PDU length as "cut short"if it crosses the boundary of the 
* packet and no more packets are available.
Based on the patch from Alexander Koeppe in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5285

svn path=/trunk/; revision=34799
 2010-11-06 21:05:45 +00:00
Martin Mathieson
796dc8927c Use guint16 after all, to avoid breaking the UDP framing protocol. 
8 bits are enough though...

svn path=/trunk/; revision=34798
 2010-11-06 19:22:16 +00:00
Martin Mathieson
3adfed8022 Try to fix by making both use guint8, rather than guint16. 
svn path=/trunk/; revision=34797
 2010-11-06 18:51:08 +00:00
Anders Broman
441c4c5381 Get the Windows build going again. 
- Martin is this the right fix?

svn path=/trunk/; revision=34795
 2010-11-06 15:13:25 +00:00
Bill Meier
b78ec52693 Use value_string_ext fcns to access certain value_string arrays; 
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.

svn path=/trunk/; revision=34794
 2010-11-05 22:44:03 +00:00
Martin Mathieson
76bc0e537b Pass ueid + channel-info into PDCP dissector. 
This will allow me soon to track per-channel sequence numbers...

svn path=/trunk/; revision=34793
 2010-11-05 18:00:35 +00:00
Martin Mathieson
fb0bfc17da Show some reserved bits as hex, not decimal. 
svn path=/trunk/; revision=34792
 2010-11-05 16:47:22 +00:00
Bill Meier
332954fd87 (Trivial) Whitespace cleanup. 
svn path=/trunk/; revision=34790
 2010-11-05 14:27:18 +00:00
Stig Bjørlykke
b9f01a15db Initialize dummy_me to avoid garbage or undefined values. 
svn path=/trunk/; revision=34788
 2010-11-05 08:28:34 +00:00
Stig Bjørlykke
0e66df8719 Put all code handling nwk_hints inside "if (nwk_hints)" to avoid possible 
dereference of null pointer.

svn path=/trunk/; revision=34787
 2010-11-05 08:21:25 +00:00
Stig Bjørlykke
428129d60b Initialize a variable to remove a warning from clang. 
svn path=/trunk/; revision=34786
 2010-11-05 08:13:26 +00:00
Stig Bjørlykke
75c2052a01 Fixed a printf modifier to remove a warning from clang. 
svn path=/trunk/; revision=34784
 2010-11-05 08:04:24 +00:00
Anders Broman
58308341bd From Pascal Quantin: 
[NAS EPS] Display explicitly the spare bits when decoding a TFT
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5371

svn path=/trunk/; revision=34781
 2010-11-05 06:19:57 +00:00
Bill Meier
b21ea034b6 Use value_string_ext fcns to access certain value_string arrays; 
Sort certain value_string arrays to be in ascending numeric order;
Do minor whitespace cleanup and reformatting of long lines.

svn path=/trunk/; revision=34780
 2010-11-04 21:30:42 +00:00
Jaap Keuter
198ecea896 Prevent false related packet information, which may be missing or ignored. 
svn path=/trunk/; revision=34779
 2010-11-04 20:53:02 +00:00
Chris Maynard
0b1df697ea Multi-byte fields are big-endian, so fixed hf_cotp_vp_[src|dst]_tsap_bytes. 
Added link to most up-to-date spec, relegating RFC905 to historic status.

svn path=/trunk/; revision=34778
 2010-11-04 15:34:36 +00:00
Stig Bjørlykke
ca8e499694 Removed unused assignments. 
svn path=/trunk/; revision=34776
 2010-11-04 11:27:34 +00:00
Stig Bjørlykke
51668ba0ca Added check for valid pointers. 
svn path=/trunk/; revision=34775
 2010-11-04 11:27:04 +00:00
Stig Bjørlykke
4a69d9203d Corrected pointer types to avoid warnings from clang. 
svn path=/trunk/; revision=34773
 2010-11-04 11:25:40 +00:00
Jaap Keuter
c1b8394ebc From Alexis La Goutte: 
Fix false positive from checkhf.

svn path=/trunk/; revision=34772
 2010-11-04 06:44:57 +00:00
Jaap Keuter
db699d12c8 From Alexis La Goutte: 
Remove unused header fields.

svn path=/trunk/; revision=34771
 2010-11-04 06:42:17 +00:00
Jaap Keuter
b7920c07c5 From Alexis La Goutte: 
Replace all *_min()/*_max() by MIN() and MAX().

svn path=/trunk/; revision=34767
 2010-11-04 06:36:33 +00:00
Bill Meier
9675740701 Use value_string_ext fcns to access certain value_string arrays; 
Sort several value_string arrays to be in ascending order.
Also: Minor whitespace cleanup.

svn path=/trunk/; revision=34766
 2010-11-03 22:08:49 +00:00
Jaap Keuter
c093ff0bfc From Fulko Hew: 
According to RFC 2741 section 6.2.1 the Open-PDU can have an o.id
field containing a 'null' identifier.  The dissector currently does
not handle it and causes other (misleading) error messages to appear
on the decode window.

svn path=/trunk/; revision=34765
 2010-11-03 20:44:46 +00:00
Bill Meier
f329864abf (Trivial): Fix up a comment. 
svn path=/trunk/; revision=34764
 2010-11-03 18:37:29 +00:00
Bill Meier
0ca948bacf Use value_string_ext fcns to access certain value_string arrays; 
Some whitespace cleanup.

svn path=/trunk/; revision=34763
 2010-11-03 18:28:35 +00:00
Jaap Keuter
dffb55434c From Fulko Hew: 
The hex field highlighting when the 'PDU Header' sub-tree is selected
highlights 5 octets rather than the correct 4 (only) octets.

svn path=/trunk/; revision=34762
 2010-11-03 17:57:22 +00:00
Jaap Keuter
605db4842d From Colin O'Flynn: 
Add a missing NULL pointer check.

svn path=/trunk/; revision=34761
 2010-11-03 17:52:11 +00:00
Chris Maynard
606cb44a24 From Claes Nasten, submitted in bug 2952: 
Here's a patch updating the decoding of write request/responses, decodes the 16
unknown bytes in write requests, decodes the 8 unknown bytes in write responses
and renames length to count as per the SMB2 spec.

svn path=/trunk/; revision=34760
 2010-11-03 16:40:41 +00:00
Anders Broman
160fcdfd8b Update SIP headers. 
svn path=/trunk/; revision=34758
 2010-11-03 13:01:01 +00:00
Jaap Keuter
53fbf796f2 From Fred Fierling: 
Patch to correct various typos

svn path=/trunk/; revision=34757
 2010-11-03 07:30:42 +00:00
Stephen Fisher
dc27b7da2d Don't show \000 at the end of null terminated strings in the info column of the tftp dissector: 
tvb_format_text() -> tvb_format_stringzpad()

svn path=/trunk/; revision=34756
 2010-11-02 20:36:36 +00:00
Chris Maynard
fcdeae7c69 Removed call to proto_item_set_len() for SESSION_MESSAGE case. Protect some 
other of these calls with "if (ti != NULL)".  Fixes bug 5289.

svn path=/trunk/; revision=34755
 2010-11-02 18:43:26 +00:00
Anders Broman
250373865e from Alexis La Goutte: 
Cleanup and update ISAKMP Dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5360

svn path=/trunk/; revision=34754
 2010-11-02 16:58:43 +00:00
Martin Mathieson
829ee8752b Add 'ndi' and 'harq-id' as new MAC-PHY DL attributes. 
svn path=/trunk/; revision=34753
 2010-11-02 15:20:38 +00:00
Martin Mathieson
3c5b012771 Don't allocate context struct until/unless heuristic signature string matches. 
svn path=/trunk/; revision=34752
 2010-11-02 15:17:58 +00:00
Jaap Keuter
694383d4a8 From Simon Leinen: 
The IP Timestamp Option (RFC 781) has three variants.  One (flag=0) just stores
a sequence timestamps in the option, but the other two (flag=1 and flag=3)
store alternate IP addresses and timestamps.

From me:
Mark option full when offset (pointer) is set to one, as per RFC 781.

svn path=/trunk/; revision=34750
 2010-11-02 08:48:06 +00:00
Jaap Keuter
ffab7d1606 From Fred Fierling: 
Update Profile ID Information to ZigBee-053298r17 (2010/7/21)

svn path=/trunk/; revision=34749
 2010-11-02 08:21:29 +00:00
Jaap Keuter
9a1a03eca9 From Daniel Ginsburg: 
draft-ietf-isis-ext-eth specifies an extension to current Ethernet Frame
specifications for hardware and frame format to support payloads greater than
1500 Bytes for Type interpretation and Length interpretation frames.

The extension introduced by draft-ietf-isis-ext-eth is currently used by Cisco
Systems' IS-IS routing protocol implementation when running IS-IS over Ethernet
links with large MTU.

svn path=/trunk/; revision=34748
 2010-11-02 07:54:24 +00:00
Bill Meier
2f8ab63858 Compile (over 100) dfilters only if needed rather than at every Wireshark startup; 
Also: Minor whitespace cleanup.

svn path=/trunk/; revision=34747
 2010-11-01 18:38:13 +00:00
Bill Meier
5227ad988a Use value_string_ext fcns to access various value_string arrays; 
Also: Fix a typo  in packet-zbee.h in the value for #define ZBEE_MFG_CODE_STG


svn path=/trunk/; revision=34746
 2010-11-01 18:33:30 +00:00
Bill Meier
c256942255 Use value_string_ext fcns to access various value_string arrays. 
Also: use value_string_const() instead of value_string() where apropriate;
      minor reformatting & whitespace cleanup.

svn path=/trunk/; revision=34745
 2010-11-01 18:26:34 +00:00
Bill Meier
d318d360d5 Use value_string_ext fcns when accessing value_string arrays. 
svn path=/trunk/; revision=34744
 2010-11-01 17:11:04 +00:00
Tomas Kukosa
0cd1b70bf9 Next PER dissectors related to rev. 34400 (empty constructed types with an extension) are regenerated 
http://anonsvn.wireshark.org/viewvc?view=rev&revision=34400

svn path=/trunk/; revision=34740
 2010-11-01 06:54:51 +00:00
Stig Bjørlykke
8e7b882177 Rebuild, no code changes. 
svn path=/trunk/; revision=34735
 2010-10-31 12:30:19 +00:00
Stig Bjørlykke
8e200fbd29 Corrected abbrev for Source and Destination. 
svn path=/trunk/; revision=34733
 2010-10-31 12:15:41 +00:00
Bill Meier
e52c685b2a Use value_string_ext fcns to access a value_string array; 
Sort value_string array to be in ascending order by value;
Minor whitespace cleanup.

svn path=/trunk/; revision=34729
 2010-10-30 20:03:58 +00:00
Bill Meier
054f1299ab Use value_string_ext fcns to access two value_string arrays; 
Remove two duplicate entries from each of two value_string arrays;
Initialize a global variable each time a file is (reloaded);
Remove two unneeded lines of code;
Minor code re-arrangement & reformatting.

svn path=/trunk/; revision=34728
 2010-10-30 19:37:40 +00:00
Bill Meier
af3d0b2bde Use value_string_ext fcns to access a value_string array. 
svn path=/trunk/; revision=34726
 2010-10-30 18:27:52 +00:00
Jeff Morriss
f5d3a16225 Make tvb_strneql()'s size parameter be a size_t. Remove some now-unnecessary casts. 
svn path=/trunk/; revision=34725
 2010-10-30 18:18:12 +00:00
Bill Meier
b35b79590a Use value_string_ext fcns to access a value_string array; 
Also: Initialize a global variable each time a file (re)loaded;
      Use consistent indentation.

svn path=/trunk/; revision=34721
 2010-10-30 17:39:57 +00:00
Jaap Keuter
31e26fdc74 From John Sullivan: 
Improve RTMP dissection:

  * Handle multi-byte csids
  * Handle extended timestamps
  * Better timestamp defaulting/calculations
  * Dechunking should now cope with any clean high quality capture without
    error (still loses sync on missing/out of order packets, but that's 
    very hard to deal with)
  * Dissect tunnelled RTMPT
  * Dissect more packet types
  * Dissect more AMF0 data types
  * Dissect audio/video control information
  * Use official packet/type names
  * Several new fields
  * Function call/response frame linking
  * Push several useful bits of data up the dissection tree or into the 
    info column for ease of use

svn path=/trunk/; revision=34720
 2010-10-30 16:40:46 +00:00
Bill Meier
a4b536a2c0 Use value_string_ext fcns to access two value_string arrays. 
Minor whitespace cleanup.

svn path=/trunk/; revision=34719
 2010-10-30 16:37:55 +00:00
Jeff Morriss
c8395e01b5 Add an SVN Id to these PIDL-generated dissector headers. A patch to PIDL has been sent upstream to the Samba developers. 
svn path=/trunk/; revision=34718
 2010-10-30 16:29:23 +00:00
Jeff Morriss
e17b9ccec1 Rev 29427 added packet_add_new_data_source() with a comment indicating that 
the data source does not need to be allocated if (!tree).

Rev 30158 took the if (!tree) check out indicating that the check was invalid.

So: (since packet_add_new_data_source() now only calls add_new_data_source()),
remove packet_add_new_data_source().

svn path=/trunk/; revision=34717
 2010-10-30 16:00:30 +00:00
Bill Meier
b94da93586 Minor reformatting and whitespace cleanup. 
svn path=/trunk/; revision=34716
 2010-10-30 15:10:30 +00:00
Anders Broman
a401f477d5 From Jouni Malinen: 
Add an item for IEEE 802.11 vendor specific subtypes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4971

svn path=/trunk/; revision=34715
 2010-10-30 14:48:46 +00:00
Bill Meier
b883b87c4a Use value_string_ext to access one of the value-string arrays. 
Whitespace cleanup.

svn path=/trunk/; revision=34714
 2010-10-30 14:48:21 +00:00
Jeff Morriss
554ed113a9 Add an SVN Id to these PIDL-generated dissectors. A patch to PIDL will be sent upstream to the Samba developers. 
svn path=/trunk/; revision=34713
 2010-10-30 14:35:05 +00:00
Anders Broman
738813862b From Robert Bullen: 
Improve the HTTP dissection of the Response Status Line.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5338

svn path=/trunk/; revision=34712
 2010-10-30 14:29:20 +00:00
Jeff Morriss
58da72c54e Fix the randpkt assertion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5348 : 
Always pass a length of 1 to proto_tree_add_item() for the ctype (this fixes
the assertion).  If the length indicated in the message is not 1, add an
expert info.

svn path=/trunk/; revision=34710
 2010-10-30 12:48:29 +00:00
Chris Maynard
fd2c5fbccc Should be a "new-style" dissector because its caller expects it to be now, but 
need to create the dissector handle using new_create_dissector_handle().
(Similar to SVN #34707).

svn path=/trunk/; revision=34708
 2010-10-30 04:29:19 +00:00
Guy Harris
19ac4ab745 The ASF dissector should be a new-style dissector, so its caller knows 
how much of the packet data it's consumed - but that means the dissector
handle for it must be created with new_create_dissector_handle().

svn path=/trunk/; revision=34707
 2010-10-30 03:34:29 +00:00
Bill Meier
5c0ce795b3 It never rejects a packet, so it's not a "new-style" dissector. 
(Similar to SVN #34704).

svn path=/trunk/; revision=34706
 2010-10-30 02:38:44 +00:00
Chris Maynard
bc2a15d93c Fixed checkAPIs.pl warning, which I forgot to run earlier. Ugh. 
svn path=/trunk/; revision=34705
 2010-10-30 01:09:17 +00:00
Guy Harris
97b0de2fe8 It never rejects a packet, so it's not a "new-style" dissector. 
svn path=/trunk/; revision=34704
 2010-10-29 23:58:38 +00:00
Chris Maynard
a12e86f59f Fixes bug 974 by adding RSP trailer. Also resolves packet-asp "FIXME" for 
IANA Enterprise ID as well as extended packet-asp decoding of authentication
and integrity payloads using the sample capture file attached to the bug.
Fuzz tested ~500 passes on that 3 packet capture file.

svn path=/trunk/; revision=34701
 2010-10-29 22:37:31 +00:00
Bill Meier
28402479cc Use value_string_ext fcns to access two value-string arrays; 
Reorder value-string arrays slightly so they are in ascending order.

svn path=/trunk/; revision=34699
 2010-10-29 22:18:44 +00:00
Stig Bjørlykke
c5bebaa771 One more: 
Make the third argument to a UAT copy callback a size_t.

svn path=/trunk/; revision=34696
 2010-10-29 21:55:04 +00:00
Stig Bjørlykke
340d64e780 Make the third argument to a UAT copy callback a size_t. 
svn path=/trunk/; revision=34695
 2010-10-29 21:51:59 +00:00
Guy Harris
17d4d51b7d Make the third argument to a UAT copy callback a size_t (not that any of 
the callbacks we have use that argument - is it really needed?).

svn path=/trunk/; revision=34694
 2010-10-29 21:11:33 +00:00
Bill Meier
f543357d14 Use value_string_ext fcns to access certain value_string arrays. 
svn path=/trunk/; revision=34692
 2010-10-29 20:22:02 +00:00
Bill Meier
1a365d735c Use value_string_ext to access 'commands' value_string. 
svn path=/trunk/; revision=34690
 2010-10-29 18:33:21 +00:00
Bill Meier
4a43e13976 Use value_string_ext to access several "relatively large" value-strings. 
svn path=/trunk/; revision=34689
 2010-10-29 17:48:39 +00:00
Bill Meier
46416bddda (Trivial) Do 'find_dissector("data");' only once. 
svn path=/trunk/; revision=34688
 2010-10-29 17:42:24 +00:00
Jeff Morriss
aac7d5596e From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5290 : 
RequestID and ResponseID are unsigned.  Show them in hex and decimal.

svn path=/trunk/; revision=34686
 2010-10-29 15:44:11 +00:00
Anders Broman
f01cbcd296 Add cause values. 
svn path=/trunk/; revision=34685
 2010-10-29 15:19:47 +00:00
Jeff Morriss
3971cb5d13 Copy hf variables by value, not by reference. 
svn path=/trunk/; revision=34682
 2010-10-28 18:49:40 +00:00
Jeff Morriss
54e10cb509 Use ENC_LITTLE_ENDIAN and ENC_NA. 
svn path=/trunk/; revision=34681
 2010-10-28 18:37:41 +00:00
Jeff Morriss
e257f75449 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5290 : 
A patch to add support of Mongo Wire Protocol (Used by MongoDB)

From me: use ENC_xxx in proto_tree_add_item() calls.

svn path=/trunk/; revision=34680
 2010-10-28 17:33:18 +00:00
Jeff Morriss
336adde8df Use ENC_NA too 
svn path=/trunk/; revision=34679
 2010-10-28 16:54:04 +00:00
Jeff Morriss
772edf8fb5 Use ENC_BIG_ENDIAN and ENC_LITTLE_ENDIAN 
svn path=/trunk/; revision=34677
 2010-10-28 16:46:38 +00:00
Anders Broman
fe71cbcc99 From Pascal Quantin: 
[NAS EPS] Fix TFT decoding in case of "delete packet filters from existing TFT" operation

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5347

svn path=/trunk/; revision=34666
 2010-10-28 15:06:48 +00:00
Jaap Keuter
e942385e06 From Matt Parrisimo: 
Calculate packet length and checksum.

svn path=/trunk/; revision=34664
 2010-10-27 21:11:46 +00:00
Jeff Morriss
505fbf012a Fix the disssector assertion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3877 : 
The rest of the code assumes that sip can be NULL, so don't assert when it's
not.

Also make fid_cmp() static since it's only used in this module.

svn path=/trunk/; revision=34663
 2010-10-27 21:08:49 +00:00
Jeff Morriss
4a120508d6 Fix the reassembly assertion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3881 : 
Ensure the fragment bytes exist before passing them to the reassembly code.

svn path=/trunk/; revision=34662
 2010-10-27 18:26:54 +00:00
Jaap Keuter
b4d195f256 Try to decode the unknown multipart subtype anyway. 
svn path=/trunk/; revision=34659
 2010-10-27 06:49:39 +00:00
Jaap Keuter
3db66ff53e Try to decode the unknown multipart subtype anyway. 
svn path=/trunk/; revision=34658
 2010-10-27 06:49:18 +00:00
Jaap Keuter
b67c9b05cb Supply an entry to use for unknown multipart subtype. 
svn path=/trunk/; revision=34657
 2010-10-27 06:48:39 +00:00
Anders Broman
f8ba652b62 From Fred Fierling: 
Found a bug in the changes from sizeof -> numeric.

svn path=/trunk/; revision=34656
 2010-10-27 05:30:01 +00:00
Jeff Morriss
945d917122 From Thomas Boehne via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5324 : 
As mentioned before, the heuristics used by packet-adwin-config were weak for
UDP packets. This patch creates a stronger heuristic by checking if one of the
MAC addresses in the UDP packets is in the range assigned to the manufacturer
of the devices that use this protocol (or if it is a broadcast).

That should be relatively safe to do because the protocol is rarely used in
routed networks.

svn path=/trunk/; revision=34654
 2010-10-27 00:42:02 +00:00
Anders Broman
758ee054ab Follow up on: 
You may not use g_int64_hash() or g_int64_equal(), as they are not  present in the minimum version of GLib that we support.  Create a  ieee802154_long_addr structure for long addresses, create hash  routines for those addresses, and use them.

Export and use those routines.

svn path=/trunk/; revision=34653
 2010-10-26 12:43:40 +00:00
Anders Broman
fbb65b97b6 - Get rid of check_col and sizeof 
svn path=/trunk/; revision=34652
 2010-10-26 11:26:28 +00:00
Guy Harris
0f96301a3e You may not use g_int64_hash() or g_int64_equal(), as they are not 
present in the minimum version of GLib that we support.  Create a
ieee802154_long_addr structure for long addresses, create hash
routines for those addresses, and use them.

svn path=/trunk/; revision=34651
 2010-10-26 08:31:16 +00:00
Anders Broman
a3eff92edc g_int64_hash is first available in Glib 2.22 (This needs a proper fixr) This is just to get the build going again. 
svn path=/trunk/; revision=34650
 2010-10-26 07:38:22 +00:00
Anders Broman
30d27cfb05 g_int64_hash is first available in Glib 2.22 
(This needs a proper fixr)
This is just to get the build going again.

svn path=/trunk/; revision=34649
 2010-10-26 06:48:09 +00:00
Anders Broman
809984a493 Try to fix the build 
svn path=/trunk/; revision=34648
 2010-10-26 06:13:42 +00:00
Anders Broman
26f0f7bc7a From Fred Fierling: 
Multi-key Support and Extended Address Mapping for ZigBee Dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5331

svn path=/trunk/; revision=34647
 2010-10-26 05:42:24 +00:00
Anders Broman
161076b23b Minor cleanup, use proto_add_item(). 
svn path=/trunk/; revision=34646
 2010-10-25 20:13:00 +00:00
Jeff Morriss
f7b3c16320 From Pascal Quantin: don't accept packets unless they're over TCP or UDP. 
svn path=/trunk/; revision=34644
 2010-10-25 17:17:52 +00:00
Bill Meier
a8de0b1f76 From Jouni Malinen: preliminary version of Wi-Fi P2P (Wi-Fi Direct) dissector. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5196

From me: Add packet-wifi-p2p.h to Makefile.common DISSECTOR_INCLUDES
         Add dissectors/packet-wifi-p2p.c to epan/CMakelists.txt

svn path=/trunk/; revision=34642
 2010-10-25 16:40:45 +00:00
Jeff Morriss
36390c306f From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5336 : 
Attached patch:
1. Adds port 5985 as a HTTP traffic port (used by MS Powershell remoting over
HTTP)
2. Adds dissection of Kerberos authentication to HTTP.


svn path=/trunk/; revision=34641
 2010-10-25 02:17:41 +00:00
Jeff Morriss
0f93035b15 From Thomas Boehne via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5324 : 
The company I work for uses two proprietary protocols, for which I initially
developed  wireshark plugins. Now we would like to integrate them into the
public wireshark repository. 

I followed the READMEs and converted the plugins into a static dissectors. I
cleaned up the code until checkAPI.pl was silent, translated all terms to
english and ran randpkt and fuzz-testing for a long time. All that I found was
a bug in a different dissector.

From me:
- Fold the header files into the dissectors
- Clean up some memory leaks
- Strengthen the heuristics of adwin-config (the TCP heuristics are still pretty
  weak)
- Make packet-adwin.c a "new style" dissector 
- Use find_or_create_conversation()
- Remove most of the check_col()'s

svn path=/trunk/; revision=34640
 2010-10-25 01:43:54 +00:00
Jeff Morriss
8c7c46d0fc Remove trailing space in field name. 
svn path=/trunk/; revision=34639
 2010-10-25 00:57:41 +00:00
Bill Meier
af4db6059a (Minor) Some whitespace cleanup. 
svn path=/trunk/; revision=34634
 2010-10-24 15:39:36 +00:00
Anders Broman
b1e852cf70 Back out 34627 and friends again. 
svn path=/trunk/; revision=34633
 2010-10-24 15:22:44 +00:00
Bill Meier
2ccfd848fe From Jouni Malinen: Add support for new WSC 2.0 attributes and values 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5196

svn path=/trunk/; revision=34632
 2010-10-24 15:18:43 +00:00
Anders Broman
525f7e0552 Clean up a few proto_add_bytes calls. 
svn path=/trunk/; revision=34630
 2010-10-24 14:15:04 +00:00
Anders Broman
bfcc79bd23 error: ‘ieee802154_short_addr_invalidate’ declared ‘static’ but never defined 
error: ‘ieee802154_long_addr_invalidate’ declared ‘static’ but never defined

svn path=/trunk/; revision=34629
 2010-10-24 14:02:31 +00:00
Anders Broman
252ade740a Try to fix: 
packet-zbee-nwk.c:260: error: static declaration of ‘zbee_table_link_keyring’ follows non-static declaration

svn path=/trunk/; revision=34628
 2010-10-24 11:53:15 +00:00
Anders Broman
43cb273d08 From Fred Fierling: 
Multi-key Support and Extended Address Mapping for ZigBee Dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5331

svn path=/trunk/; revision=34627
 2010-10-24 10:04:29 +00:00
Bill Meier
6d8ea4abd5 From Lori Tribble: Add vendor identifier dissector access to BACnet Private Transfer Msgs 
BACnet has a private transfer service which is vendor specific.  The start of
 each request and response contains the vendor identifier.  I've added a way for
 vendors to provide their own dissectors by registering their vendor identifier.
 The packet-bacapp.c method fConfirmedPrivateTransfer has been modified to look
 for a vendor specified dissector.  If found it will be run.  If not found we
 default to running the standard dissection included in packet-bacapp.c.

 I modified the summary column display for private transfer messages so that the
 summary now displays the Vendor Identifier (V=xx) and the Service Number (SN=xx).

 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5250

From me: Rename sub-dissector tablle to "bacapp.vendor_identifier"
         Change subdissector ui_name to "BACapp Vendor Identifier"

svn path=/trunk/; revision=34625
 2010-10-22 18:13:42 +00:00
Jeff Morriss
a25ece78e5 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5329 : 
Find a patch who clean up PPP dissector
* Remove check_col (from my previous patch #5325)
* Remove the #define ppp_min (unused) 
* Remove some unused ett_* 
* Cleanup NO ARRAY entry (it is a false positive of checkhf tool, it is need {
(in the same line) before a hf_... in hf_register_info struct
* Cleanup Unused entry in VSNP Dissector ( it's really strange, there is no
check when the code was added #4434 ;) )
* minor bug fix...

From me: put one of the check_col()'s (that also protects a val_to_str() call)
back in.

Note: the checkhf tool bug was fixed in rev 34623.

svn path=/trunk/; revision=34624
 2010-10-22 18:05:50 +00:00
Jeff Morriss
052ba7eb46 From Tobias Klauservia https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5327 : 
The current PRP dissector in packet-prp.c does not correctly identify VLAN
tags. It uses the hard coded value 0x8000 to check the ethertype.

The attached patch (against current SVN trunk) changes this to use the
ETHERTYPE_VLAN define from epan/etypes.h and also fixes two misspellings in the
respective comments.

svn path=/trunk/; revision=34622
 2010-10-22 15:08:32 +00:00
Anders Broman
5bf4fc3116 From Vincent Helfre: 
Some improvements for the presentations.

svn path=/trunk/; revision=34620
 2010-10-22 13:35:03 +00:00
Stig Bjørlykke
14d908de38 Corrected check for end of well_known_sids. 
This fixes bug 5328.

svn path=/trunk/; revision=34619
 2010-10-22 10:48:14 +00:00
Stig Bjørlykke
efd9c3e0c9 Fixed printing guint64 variables. 
Removed unused variables.

svn path=/trunk/; revision=34617
 2010-10-22 06:42:55 +00:00
Anders Broman
e64d2d99c0 C++ style comments in packet-windows-common.c 
svn path=/trunk/; revision=34616
 2010-10-22 06:26:42 +00:00
Anders Broman
58be4653b4 packet-smb.c:890: warning: data definition has no type or storage class 
svn path=/trunk/; revision=34615
 2010-10-22 05:47:01 +00:00
Anders Broman
9c9db7d4d4 From CaL Turney: 
Add support for well-known SIDs/RIDs and option to display in hex.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5286

svn path=/trunk/; revision=34613
 2010-10-22 05:15:25 +00:00
Jeff Morriss
9e14fa17fb Replace blurb that matches the field name with NULL 
svn path=/trunk/; revision=34612
 2010-10-22 01:37:06 +00:00
Jeff Morriss
450be02fc2 From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 : 
Update to use add the time as a filterable field and other cosmetic changes.

From me: exp2() seems to be C99 so #if the use of it out.

svn path=/trunk/; revision=34611
 2010-10-21 22:41:39 +00:00
Bill Meier
8d8190c43f Cleanup: 
- Reindent source; cleanup whitespace;
- Remove many unneeded 'if(tree)' & similar (Tnx to Jeff Morriss for the suggestion);
- remove unneeded initializers;
- Reformat some long lines;
- Fix up some comments showing message layout;
- Localize two static global variables.

svn path=/trunk/; revision=34610
 2010-10-21 21:21:26 +00:00
Jaap Keuter
8f0cec63d7 From Sven Schnelle: 
Add dissector for Tektronix Teklink Protocol, used by their Logic Analyzers.
May be useful for reverse engineering their Protocol.

svn path=/trunk/; revision=34609
 2010-10-21 21:02:10 +00:00
Jeff Morriss
bcfa8de44a Add some casts to get the Windows builds going. 
svn path=/trunk/; revision=34608
 2010-10-21 21:02:07 +00:00
Jeff Morriss
8187894200 After calling a subdissector, set a fence on COL_INFO so whatever the 
subdissector put in the Info column stays there.

svn path=/trunk/; revision=34607
 2010-10-21 20:51:06 +00:00
Bill Meier
6ebe1f252f From Srinivasa Pradeep: LDP dissector: Add/update PseudoWire TLV suport. 
RFC 4447 describes new TLV called Generalised PWid FEC in LDP messages with the
 id 0x81. This is related to PsuedoWire setup and maintenance.
 Related to this, following are the TLVs which are defined in RFC 4447 and RFC 4446.
 1. PW Status TLV
 2. PW Interface parameters
 3. PW Group TLV

From me: remove some unused variables; Mark fcn arg as unused.


svn path=/trunk/; revision=34606
 2010-10-21 19:13:57 +00:00
Jaap Keuter
81f60271c6 From Robert Wynn: 
CableLabs has added additional TLV's to DHCP Option 60 Modem capabilities
reporting for their Docsis 2.0 devices.  Additionally, in Docsis 3.0, they have
moved the capabilities portion of Option 60 (sub-option 5) to now reside in the
vendor specific Option 125 using their Enterprise number (4491).

svn path=/trunk/; revision=34605
 2010-10-21 19:01:35 +00:00
Jeff Morriss
01177b103e From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5325 : 
It is a rework of PAP PPP dissector 
- Replace proto_tree_add_text by proto_tree_add_item 
- add col_append_fstr to show information (Peer-ID, Password...)

svn path=/trunk/; revision=34604
 2010-10-21 16:08:29 +00:00
Jeff Morriss
5c18160006 From Shoichi Sakane via bug 5270: minor changes and remove an unused hf variable. 
svn path=/trunk/; revision=34600
 2010-10-21 03:04:15 +00:00
Anders Broman
773a7f4c59 From Fred Fierling: 
Cleanup of unnecessary tree == NULL checks in ZCL dissector

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5321

svn path=/trunk/; revision=34595
 2010-10-20 20:50:39 +00:00
Jeff Morriss
f6a88f2be5 From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 : 
I made a patch to support more COAP options.
some options includes variable length field.

svn path=/trunk/; revision=34592
 2010-10-20 20:40:53 +00:00
Bill Meier
06325a1bd6 (Minor): pretfs callback not req'd; 
Move call to data dissector undet 'if(tree)' so same value of
          offset used whether or not 'tree == NULL'.

svn path=/trunk/; revision=34591
 2010-10-20 18:14:49 +00:00
Jeff Morriss
185d387f62 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 : 
Add dissector for PAPI (Aruba AP Control Protocol), used by Aruba WLAN
Controller).
There is no documentation on this protocol, the dissector is based on my
analysis ...

There is also an experimental "debug dissector" (not enable by default) for
dissecting the rest of data.

Changes by me:
- make it a new-style dissector
- change the name of the "debug" preference
- other minor changes

svn path=/trunk/; revision=34587
 2010-10-20 16:49:21 +00:00
Anders Broman
64d4b08a82 From Vincent Helfre: 
various bug fix and enhancement for Release 8 additionnal parameters.

svn path=/trunk/; revision=34585
 2010-10-20 12:40:13 +00:00
Martin Mathieson
d086e935e1 Add longer desriptions of SOStart and SOEnd fields. 
svn path=/trunk/; revision=34584
 2010-10-20 12:08:22 +00:00
Martin Mathieson
81a49eec81 In heuristic dissector, don't check/allocate struct until/unless signature pattern matches. 
svn path=/trunk/; revision=34582
 2010-10-20 09:58:40 +00:00
Jeff Morriss
dfa6aa82a7 Fix SE memory corruption reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5318 : 
Ensure the digest is smaller than our buffer before copying it.

svn path=/trunk/; revision=34581
 2010-10-20 01:49:32 +00:00
Jeff Morriss
df0692a8e6 Use while loops instead of goto's. 
svn path=/trunk/; revision=34580
 2010-10-20 01:37:03 +00:00
Jeff Morriss
8a7125f063 From Colin O'Flynn and Owen Kirby via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5266 : 
The attached patch begins to add support for RPL to the ICMPv6 file. All
locations that RPL code have been added are marked with a comment allowing this
patch to be reverted at a future time if it is decided to e.g. move all the RPL
code to it's own dissector.

A few values await IANA assignment and are also clearly marked (in
packet-ipv6.h). 

Only the 'metric' option is left unsupported, as it is primarily defined in
another I-D.

svn path=/trunk/; revision=34579
 2010-10-20 01:23:32 +00:00
Bill Meier
6c08c2c43a Use DISSECTOR_ASSERT (not g_assert) in dissectors... 
svn path=/trunk/; revision=34577
 2010-10-20 00:47:23 +00:00
Bill Meier
9787a5734a From Hadriel Kaplan: IPFIX file format support. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5242

svn path=/trunk/; revision=34576
 2010-10-20 00:36:53 +00:00
Anders Broman
a75d7209f5 From Fred Fierling: 
Infinite loop in ZCL Discover Attributes dissection

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5303

svn path=/trunk/; revision=34575
 2010-10-19 19:19:42 +00:00
Anders Broman
c94d711d8e From Alexis La Goutte: 
GRE Enhancements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5314

svn path=/trunk/; revision=34573
 2010-10-19 18:28:00 +00:00
Bill Meier
a88357dbf4 Remove some #if 0'd code I left in by mistake a while back.... 
svn path=/trunk/; revision=34572
 2010-10-19 17:43:52 +00:00
Anders Broman
88622252b1 From Tamás Regõs: 
Make application ID readable from sub dissectors.

svn path=/trunk/; revision=34570
 2010-10-19 15:21:05 +00:00
Bill Meier
7ae3e56828 Use dynamically created value_string_ext to store hash/symbol value_strings; 
Also: minor code reformatting and re-arrangement.

svn path=/trunk/; revision=34569
 2010-10-19 14:31:05 +00:00
Jeff Morriss
a3bf744a0f From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 : 
Remove some unused hf variables.

svn path=/trunk/; revision=34568
 2010-10-19 13:30:40 +00:00
Stig Bjørlykke
1f2b9eca16 Init ett_coap_noop, another fix for bug 5305. 
svn path=/trunk/; revision=34566
 2010-10-19 06:58:08 +00:00
Jeff Morriss
8ad4c4efdd Don't use g_strcmp0(): it only exists in glib > 2.16. 
Make read_length() static.

Start function names at column 0.

svn path=/trunk/; revision=34565
 2010-10-18 21:55:56 +00:00
Bill Meier
be1a3f5a7e Try to fix compile errors on 64 bit systems. 
svn path=/trunk/; revision=34561
 2010-10-18 18:37:07 +00:00
Bill Meier
8832221ca4 Remove some unneeded #includes ... 
svn path=/trunk/; revision=34560
 2010-10-18 17:46:12 +00:00
Martin Mathieson
7e938c7071 Don't clear info column when showing MAC or RLC-level info. 
svn path=/trunk/; revision=34559
 2010-10-18 17:02:19 +00:00
Bill Meier
13b8efbf25 From Holger Grandy: ETCH dissector 
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5095

From me: Fix a bug in add_symbol which caused occasional Wireshark crashes;
         Add additional checking during parse of symbol hash file;
         Improve "directory not found" error message;
         Do misc code cleanup and simplification.

svn path=/trunk/; revision=34558
 2010-10-18 16:15:12 +00:00
Jeff Morriss
b0ab72ac70 Use port range for SCTP too. 
svn path=/trunk/; revision=34557
 2010-10-18 15:56:06 +00:00
Jeff Morriss
418b9b2958 Add SVN:Id tag. Copy copyright notice to the header file. 
svn path=/trunk/; revision=34555
 2010-10-18 13:26:35 +00:00
Jeff Morriss
13c4798e8c Add SVN:Id tag. 
svn path=/trunk/; revision=34554
 2010-10-18 13:24:10 +00:00
Stig Bjørlykke
dcbd634884 Remove blurbs equal to name. 
svn path=/trunk/; revision=34551
 2010-10-18 07:41:47 +00:00
Stig Bjørlykke
7e42c00c9c Added some length checks for integers. 
This fixes bug 5305.

svn path=/trunk/; revision=34550
 2010-10-18 07:13:45 +00:00
Jörg Mayer
6ab1662ca7 Add expert info if the eth src mac has the I/G bit set 
svn path=/trunk/; revision=34548
 2010-10-17 20:28:20 +00:00
Stig Bjørlykke
df48a37c2e Use correct abbrev for fragment entries. 
svn path=/trunk/; revision=34547
 2010-10-17 18:33:50 +00:00
Stig Bjørlykke
54671a1ebe Removed unused entries. 
svn path=/trunk/; revision=34546
 2010-10-17 18:16:44 +00:00
Stig Bjørlykke
305748ea57 Removed unused hf_xcsl. 
svn path=/trunk/; revision=34542
 2010-10-17 16:38:15 +00:00
Stig Bjørlykke
2b32589942 Removed unused hf_sasp. 
svn path=/trunk/; revision=34541
 2010-10-17 16:36:32 +00:00
Stig Bjørlykke
6fd85b83a4 Fixed typo in "Reason" abbrev. 
svn path=/trunk/; revision=34540
 2010-10-17 16:33:28 +00:00
Stig Bjørlykke
18ddeb1de5 Fixed typo in "SSI Noise (dBm)" abbrev. 
svn path=/trunk/; revision=34537
 2010-10-17 14:30:11 +00:00
Stig Bjørlykke
2b37214674 From Pascal Quantin via bug 5301: 
Make the PER constaints check like in the BER dissector.

svn path=/trunk/; revision=34536
 2010-10-17 14:07:05 +00:00
Anders Broman
fdb2192631 From Pascal Quantin: 
[NAS EPS] Enhance dissection of APN-AMBR IE

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5304

svn path=/trunk/; revision=34535
 2010-10-17 14:04:59 +00:00
Stig Bjørlykke
8b5bb7d7ce From Benjamin Roch via bug 3418: 
Use eth.src, eth.dst and eth.type from the ethernet dissector.

From me:
Removed unused code inside #if 0.

svn path=/trunk/; revision=34534
 2010-10-17 14:02:06 +00:00
Stig Bjørlykke
396d8e3e18 From Benjamin Roch via bug 3418: 
Added string values to tte.pcf.type.

svn path=/trunk/; revision=34533
 2010-10-17 13:59:46 +00:00
Stig Bjørlykke
ce60782e08 coap_handle is only used in proto_reg_handoff_coap. 
svn path=/trunk/; revision=34532
 2010-10-17 12:20:25 +00:00
Stig Bjørlykke
38ba5119cd From Pascal Quantin via bug 5301: 
Add expert info when ASN.1 PER constrained integer does not match range.

svn path=/trunk/; revision=34531
 2010-10-17 11:59:10 +00:00
Stig Bjørlykke
9d253d77ad From Shoichi Sakane via bug 5270: 
Added COAP protocol support.

From me:
Made the port number configurable.

svn path=/trunk/; revision=34530
 2010-10-17 11:48:40 +00:00
Martin Mathieson
1077ec28f6 Improve info column when showing PHY info for MAC frames. 
svn path=/trunk/; revision=34529
 2010-10-15 21:32:35 +00:00
Martin Mathieson
52e5567b2e Track and give link back to frame containing previous NACK. 
svn path=/trunk/; revision=34528
 2010-10-15 21:07:45 +00:00
Jörg Mayer
2556852f9e Make the telnet data lines filterable elements. 
svn path=/trunk/; revision=34527
 2010-10-15 21:02:30 +00:00