osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
33868 commits 23 branches 0 tags 1.3 GiB
Commit graph

10982 commits

Author SHA1 Message Date
Chris Maynard
77673564bc From Alex Badea via bug #4149: IPcomp: decompress deflated payloads. 
svn path=/trunk/; revision=35088
 2010-12-01 15:45:24 +00:00
Chris Maynard
4255465926 Rename conflicting draft v2 and v8 display filter fields. Fixes bug 4059. 
svn path=/trunk/; revision=35078
 2010-11-30 17:08:37 +00:00
Jeff Morriss
a7ce50ba95 From Toralf Foerster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5432 : 
The attached patch against that dissector contains :

FIX:
- counting statistics over encrypted packages (line 610 ff)

NEW:
- tag sametime message type 0x0025 as known

MISC:
- better comment
- new line clean ups

svn path=/trunk/; revision=35077
 2010-11-30 17:06:13 +00:00
Martin Mathieson
77cf0462dc From Pascal Quantin: 
I just found a small bug in LTE PDCP dissector with current top of tree.
If global preference global_pdcp_dissect_user_plane_as_ip is set to true, the dissector will try to decode an IP frame even with signalling plane.
PDCP-LTE
    ...0 0000 = Seq Num: 0
    Signalling Data: 0800183aa808
    MAC: 0x00000000 (0)
[Malformed Packet: IP]
    [Expert Info (Error/Malformed): Malformed Packet (Exception occurred)]

With the attached patch, I get the correct output for both signalling and user plane PDUs.

svn path=/trunk/; revision=35076
 2010-11-30 15:10:17 +00:00
Jeff Morriss
c755b2fd54 Oh yeah, there's a reason we don't put targets in Makefile.common: the first target in a makefile is what you get when you just run make (without a target). Revert 35073 and 35069. 
svn path=/trunk/; revision=35075
 2010-11-30 02:04:55 +00:00
Jeff Morriss
f1c066bbee Move some checkapi targets into Makefile.common 
svn path=/trunk/; revision=35073
 2010-11-29 22:34:04 +00:00
Jeff Morriss
050d9379ef Remove a no-longer-used variable. 
svn path=/trunk/; revision=35072
 2010-11-29 22:11:39 +00:00
Anders Broman
623253b010 Change SIP TCP port preference to a range preference. 
svn path=/trunk/; revision=35070
 2010-11-29 21:40:49 +00:00
Anders Broman
e55dcbcdb7 From Andrei Emeltchenko: 
Wrong link type in a packet(bluethouth).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5449

svn path=/trunk/; revision=35064
 2010-11-29 18:15:09 +00:00
Anders Broman
4b5a8bff9e From Vincent Helfre: 
Make it possible to dissect NAS EPS messages without security header.

svn path=/trunk/; revision=35062
 2010-11-29 13:27:00 +00:00
Anders Broman
5a0e550686 From Vincent Helfre: 
I have fixed some issue in the measurement information decoding in packet-gsm_a_rr.c.

svn path=/trunk/; revision=35061
 2010-11-29 13:12:35 +00:00
Anders Broman
879821bc35 Try to fix Buildbot crash output: fuzz-2010-11-28-11164.pcap 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5448

svn path=/trunk/; revision=35060
 2010-11-29 13:02:31 +00:00
Jörg Mayer
7a81be7136 Make the Primary name element filterable in response records. 
Same for Nameserver names.

svn path=/trunk/; revision=35058
 2010-11-28 21:45:15 +00:00
Anders Broman
42e31d3efe From Slava: 
Bug with RWH parsing in Infiniband dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5444

svn path=/trunk/; revision=35056
 2010-11-28 21:08:03 +00:00
Anders Broman
5f1b6a507b From Alex Badea: 
gsm_a_rr: System Information Type 4 / CBCH mobile allocation dissected incorrectly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5436

svn path=/trunk/; revision=35054
 2010-11-28 20:58:26 +00:00
Martin Mathieson
a6368260cc Fix calling of LTE RRC dissector for "rrc_lte_r8" frames. 
svn path=/trunk/; revision=35050
 2010-11-28 15:37:40 +00:00
Stephen Fisher
6c1e90bfd0 Mention SSHv2 RFCs 
svn path=/trunk/; revision=35035
 2010-11-26 23:33:05 +00:00
Jaap Keuter
b1914ff4df Fix for bug 5435: 
Add support for dissecting SLL type 0x17 frames.

svn path=/trunk/; revision=35029
 2010-11-25 19:59:19 +00:00
Chris Maynard
dbe63e9730 Add support for USB isochronous. From Marton Nemeth via bug #5370. 
svn path=/trunk/; revision=35025
 2010-11-24 17:33:58 +00:00
Anders Broman
66053b7b3a From Johannes Lange: 
Function dissect_per_bit_string_display might read more bytes than available (PER dissector).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5394

svn path=/trunk/; revision=35023
 2010-11-24 16:35:23 +00:00
Anders Broman
4d4283ef98 From Johannes Lange: 
Bug 5393 - Wrong length calculation in new_octet_aligned_subset_bits() (PER dissector) .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5393

svn path=/trunk/; revision=35021
 2010-11-24 16:21:04 +00:00
Anders Broman
8fc5892e01 Tighten the heuristic. 
svn path=/trunk/; revision=35020
 2010-11-24 15:15:28 +00:00
Bill Meier
df3c52dc2a Whitespace cleanup; 
Add some braces;

svn path=/trunk/; revision=35018
 2010-11-24 03:43:09 +00:00
Bill Meier
96510d9b38 Tighten up code dissecting message header. 
This corrects the specific issue reported in Bug #3317
wherein the dissector decided there was a valid but unknown
header when dissecting a binary (non text) message with a ":"
as the last byte.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3317

Note that a larger issue remains: the IMF dissector
presumably shouldn't really even try to dissect a
binary payload (which is proably encrypted text).

svn path=/trunk/; revision=35017
 2010-11-24 02:11:43 +00:00
Anders Broman
01eae27dc1 Remove Supported Channels lenght check fixes 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5430

svn path=/trunk/; revision=35016
 2010-11-23 19:42:11 +00:00
Jeff Morriss
cce1bef672 Based on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391#c11 : put some DISSECTOR_ASSERTs and THROW's back in. 
svn path=/trunk/; revision=35014
 2010-11-23 15:27:18 +00:00
Martin Mathieson
e1689f4ad4 Check the DDI while dissecting the header. 
svn path=/trunk/; revision=35013
 2010-11-23 11:01:48 +00:00
Stig Bjørlykke
f7c394dfd0 Initialize no_assoc.app_info=0. 
svn path=/trunk/; revision=35011
 2010-11-22 21:05:49 +00:00
Anders Broman
8bc65842e0 From Mike Morrin: 
In bssmap, track L3 handover target (GSM or UMTS) between PDUs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5294

svn path=/trunk/; revision=35009
 2010-11-22 20:24:12 +00:00
Jeff Morriss
1b04b1b765 From Emil Wojak via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391 : 
I'd like to share my enhancements to the TDS dissector with everyone.
The list of improvements follows:
- nearly complete dissection of RPC calls,
- detection and dissection of the ALL_HEADERS rule,
- corrected some existing proto_tree fields to support filters,
- other minor fixes where the interpretation of data conflicted with the
  official documentation from MS.

I tested the new code on a variety of different TDS captures with many diverse
RPC calls. The code compiles and works on 32-bit Linux, I didn't check those
changes on other platforms though.

From me:

- terminate all value_strings
- change ++*offset to *offset += 1 (I think that's more readable)
- replace all the dissector assertions which could be caused by malformed
  packets with expert infos
- Don't throw ReportedBoundsError when the packets have unexpected data in
  them, just report an expert info and continue on

svn path=/trunk/; revision=35007
 2010-11-22 18:48:54 +00:00
Jeff Morriss
1f4cdf5a9d From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5358 : 
This is a dissector for reload framed message:
ReLOAD packets can be inserted in frame message, as described in
draft-ietf-p2psip-base-10

From me: remove some unnecessary includes.

svn path=/trunk/; revision=35005
 2010-11-22 16:19:39 +00:00
Anders Broman
6224708d6c Remove faulty return, probably forgotten during test. 
Fixing dissection on Via header.

svn path=/trunk/; revision=35004
 2010-11-22 15:02:06 +00:00
Martin Mathieson
c018054581 Add another (unsupported) channel type identifier. 
svn path=/trunk/; revision=35001
 2010-11-22 13:37:13 +00:00
Martin Mathieson
74a74645b1 Add sequence analysis for PDCP, based upon RLC/UM. 
For now, only enable it for logged PDCP frames, i.e. not for PDCP found inside RLC (that won't work properly until RLC re-assembly is implemented).

svn path=/trunk/; revision=35000
 2010-11-22 13:28:49 +00:00
Chris Maynard
37f3870cac Display priority and protocol, even in the case of WCCP2_SERVICE_STANDARD, but 
indicate that these fields are unused in this case and must be zero.
Furthermore, if the value is non-zero, add an expert info warning about it.
Fixes bug 3631.

svn path=/trunk/; revision=34998
 2010-11-22 05:09:57 +00:00
Jaap Keuter
0a9a603814 Fix for bug 5425: 
Add support for dissecting SLL type 0x0C frames.

svn path=/trunk/; revision=34991
 2010-11-21 12:36:24 +00:00
Stig Bjørlykke
3bfd25c34e Removed unused route_preference. 
svn path=/trunk/; revision=34990
 2010-11-21 11:28:42 +00:00
Anders Broman
ebac83d6a3 From Alexis La Goutte: 
ICMPv6 Enhancements : make ICMP option filterable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5424

svn path=/trunk/; revision=34988
 2010-11-21 10:30:35 +00:00
Jaap Keuter
ba2d64102c Fix for bug 5422: 
Add support for dissecting SLL type 0x03 frames.

svn path=/trunk/; revision=34987
 2010-11-20 18:14:30 +00:00
Guy Harris
f54beaed87 Clean up blurbs a bit. Not much we can do about "Description" - what is 
it a description *of*?

svn path=/trunk/; revision=34978
 2010-11-19 19:02:08 +00:00
Jeff Morriss
f424256889 Verify the number of rectangles, sub-rectangles, the number of bytes of cut 
text, etc. are "sane" before:
1) requesting enough bytes (from reassembly) to dissect them all
2) (and) attempting to add them all to the tree

Request all the bytes we'll need to dissect all those rectangles/sub-rectangles
before starting dissection rather than checking before dissecting each
rectangle/sub-rectangle.

Use tvb_get_ephemeral_string().

Use _U_ to mark unused arguments.

Fix up some indentation.

Get rid of one more DISSECTOR_ASSERT.

svn path=/trunk/; revision=34977
 2010-11-19 18:54:19 +00:00
Jeff Morriss
8f642bdb5c From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5366 : 
Several fixes that make Tight VNC negotiation properly parsed.
It was not parsed correctly previously, for multiple reasons.

svn path=/trunk/; revision=34976
 2010-11-19 18:53:40 +00:00
Anders Broman
abc2a1d690 Mark a parameter as unused. 
svn path=/trunk/; revision=34974
 2010-11-19 16:33:12 +00:00
Anders Broman
79939636d1 Pretify dissection of H.248 Annex C.11 SDP equivalents. 
svn path=/trunk/; revision=34972
 2010-11-19 15:43:35 +00:00
Bill Meier
5cb41c00b1 Remove a check_col(); 
Fix a typo;
Minor whitespace cleanup.

svn path=/trunk/; revision=34971
 2010-11-19 15:26:27 +00:00
Bill Meier
19e7c7461f Use value_string_ext fcns to access certain value_string arrays. 
svn path=/trunk/; revision=34970
 2010-11-19 15:21:40 +00:00
Jeff Morriss
c6b7cbd5dc Remove some unnecessary includes. 
svn path=/trunk/; revision=34969
 2010-11-19 13:35:24 +00:00
Martin Mathieson
fe225663ee Reserve not-yet-supported channel type IDs. 
svn path=/trunk/; revision=34967
 2010-11-19 11:42:05 +00:00
Jeff Morriss
431eb6a7be From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5412 : 
Update ReLOAD dissector to reflect draft-ietf-p2psip-base-12

svn path=/trunk/; revision=34966
 2010-11-19 02:32:42 +00:00
Jeff Morriss
075954f5a5 From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 : 
Fix the dissection of the length of the option field.

svn path=/trunk/; revision=34965
 2010-11-19 02:12:19 +00:00
Bill Meier
ceb99a4bf0 Fix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles. 
svn path=/trunk/; revision=34963
 2010-11-18 23:02:20 +00:00
Bill Meier
7d38abddaa Fix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles. 
svn path=/trunk/; revision=34962
 2010-11-18 22:55:18 +00:00
Bill Meier
f2030d7270 stats_tree_register() need be called only once (and not each time a port pref is changed); 
(Minor) use tvb_reported_length_remaining() rather than tvb_length_remaining() in a number of places;
Add a comment to get_sametime_message_len() about the minimum length of the tvb when the fcn is called.

svn path=/trunk/; revision=34961
 2010-11-18 21:56:25 +00:00
Stephen Fisher
dbf10b1dc8 From Jon Ellch via bug #5175: Add PPI-GPS protocol dissector patch 
Minor changes by me as detailed in the bug's comment #8.


svn path=/trunk/; revision=34956
 2010-11-18 20:54:14 +00:00
Bill Meier
1d42ee3ebb Use value_string_ext fcns to access a number of value_string arrays; 
Sort several value_arrays in ascending order by value;
Localize a global variable to proto_reg_handoff().

svn path=/trunk/; revision=34955
 2010-11-18 19:37:22 +00:00
Bill Meier
13f264e34a Tighten up TLV processing a bit to prevent a potential loop. 
svn path=/trunk/; revision=34954
 2010-11-18 19:25:11 +00:00
Anders Broman
a6f7c3a8bd Tweak the display of the header. 
svn path=/trunk/; revision=34946
 2010-11-18 16:01:39 +00:00
Anders Broman
da383952df "Fill" value_strings. 
svn path=/trunk/; revision=34935
 2010-11-17 21:58:35 +00:00
Bill Meier
311cac0568 Use value-string_ext fcns to access value_string array; 
Sort value_string_array in ascending order by value;
Reformat display of tag info to be more readable;
Rework TLV processing;
Remove unneeded variable;
Minor whitespace cleanup.

svn path=/trunk/; revision=34933
 2010-11-17 21:40:21 +00:00
Anders Broman
3c998dadc2 value_string_ext fixes. 
svn path=/trunk/; revision=34932
 2010-11-17 16:56:51 +00:00
Jeff Morriss
ea23d55aa5 Remove unneeded stuff from the Copyright notice. Use ENC_BIG_ENDIAN and ENC_NA. 
svn path=/trunk/; revision=34931
 2010-11-17 16:52:20 +00:00
Jeff Morriss
805d04fd15 From Toralf Foerster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5376 : 
A dissector for the SAMETIME protocol.

From me: no need to include gmodule.h, use only ASCII in the author's name.

svn path=/trunk/; revision=34930
 2010-11-17 16:47:03 +00:00
Anders Broman
b4098dfae9 - Update to 3GPP TS 25.413 V9.4.0 (2010-09). 
- Fill the value_strings.

svn path=/trunk/; revision=34929
 2010-11-17 16:23:10 +00:00
Anders Broman
3ffa66319e - Update to 3GPP TS 25.413 V9.4.0 (2010-09). 
- Fill the value_strings.

svn path=/trunk/; revision=34928
 2010-11-17 15:36:53 +00:00
Bill Meier
e65f69766a User value_string_ext fcns to access several value_string arrays; 
Minor reformatting and whitespace cleanup.

svn path=/trunk/; revision=34927
 2010-11-17 14:59:08 +00:00
Anders Broman
263db68ab6 - Update to 3GPP TS 25.413 V9.4.0 (2010-09). 
- Fill the value_strings.

svn path=/trunk/; revision=34925
 2010-11-17 11:48:17 +00:00
Anders Broman
1913b3dd3e - Use SABP:s SCTP ppid. 
- Use value_string_ext.

svn path=/trunk/; revision=34924
 2010-11-17 08:18:30 +00:00
Jaap Keuter
62067368a0 Separate out/update comment block. 
Update IANA assignments.
Use available checksum routines.
Some cleanup and use of convenience macros.

svn path=/trunk/; revision=34922
 2010-11-17 07:42:32 +00:00
Jeff Morriss
37d4ccff56 From Slava via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5335 : 
This patch adds to Wireshark the ability to dissect Infiniband SDP (Socket
Direct Protocol) and CM MADs traffic.

It also contains various other bug-fixes and enhancements. SDP traffic can be
identified automatically (analyzing SDP CM MADs) or manually.

SDP, or Sockets Direct Protocol, is a protocol developed by the Infiniband
Trade Association which enables existing socket-based applications to
transparently utilize the Infiniband capabilities. 

This patch is submitted on behalf of Mellanox Technologies Ltd.

svn path=/trunk/; revision=34918
 2010-11-17 02:57:22 +00:00
Anders Broman
2bb0b3fa19 The IPv6 "element" in PDN address information element is a 8 byte 
IPv6 interface identifier.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5408

svn path=/trunk/; revision=34914
 2010-11-16 20:46:21 +00:00
Anders Broman
838a24aaa0 value_string_ext fixes. 
svn path=/trunk/; revision=34908
 2010-11-16 17:31:29 +00:00
Bill Meier
491f05b16e Use value_string_ext fcns to access several value_string arrays; 
Minor whitespace cleanup.

svn path=/trunk/; revision=34900
 2010-11-16 15:20:33 +00:00
Jeff Morriss
58d018e21a From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5400 : 
The attached patch adds many more DAAP codes to be parsed properly by the DAAP
dissector.
In addition, it fixes some prints.

svn path=/trunk/; revision=34899
 2010-11-16 15:01:43 +00:00
Bill Meier
c52500588e Use value_string_ext fcns to access several value_string arrays. 
svn path=/trunk/; revision=34894
 2010-11-15 23:53:25 +00:00
Martin Mathieson
43bfcfc32a Assert was firing while working out sequence length for user plane frames. 
Treat signalling plane case separately.

svn path=/trunk/; revision=34893
 2010-11-15 23:32:34 +00:00
Bill Meier
3c98cf2ebc Use value_string_ext fcns to access several value_string arrays. 
svn path=/trunk/; revision=34891
 2010-11-15 22:37:35 +00:00
Bill Meier
37742d97d8 Use value_string_ext fcns to access several value_string arrays. 
svn path=/trunk/; revision=34890
 2010-11-15 22:00:33 +00:00
Anders Broman
e1b1ef192c "Fill" value_strings. 
svn path=/trunk/; revision=34888
 2010-11-15 21:32:27 +00:00
Anders Broman
4aef1cc2ed Use value_string ext for address family. 
svn path=/trunk/; revision=34887
 2010-11-15 21:05:03 +00:00
Jeff Morriss
313785c513 From Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5395 : 
The ZigBee security dissector was not recording the short to long address
mappings in Security Headers, preventing the decryption of some payloads. This
patch eliminates the Undecoded warnings in packets 1 and 19 in this test
capture: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5457

The keys to decrypt these packets are listed in the bug.

svn path=/trunk/; revision=34886
 2010-11-15 20:52:41 +00:00
Bill Meier
8548e16613 Use value_string_ext fcns to access a value_string array. 
svn path=/trunk/; revision=34884
 2010-11-15 19:46:07 +00:00
Bill Meier
0f286bbb89 Use value_string_ext fcns to access a value_string array. 
svn path=/trunk/; revision=34883
 2010-11-15 19:15:34 +00:00
Bill Meier
b1554fc198 Use value_string_ext fcns to access certain value_string arrays; 
Whitespace cleanup.

svn path=/trunk/; revision=34882
 2010-11-15 19:08:12 +00:00
Bill Meier
ed7105e21b Update package_name_vals[] value_string array: 
- Add new entries based on: http://www.iana.org/assignments/megaco-h248 last updated 2010-10-01;
- Fix a typo (incorrect value for an entry);
- Switch values between two entries to match the IANA list;
- Switch two entries so list is in ascending order by value.

svn path=/trunk/; revision=34881
 2010-11-15 19:00:16 +00:00
Jaap Keuter
1009be2c17 Skip reserved word in ANCP OAM-Loopback-Test-Parameters TLV. 
svn path=/trunk/; revision=34879
 2010-11-15 18:28:36 +00:00
Jeff Morriss
b0e1f62ef8 From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 : 
I improved the coap dissector.  It is resulted by the 2nd coap test event. 
This patch is diff from 34794.  The fuzzying test passed more than 62000.

Changed:
- removed "#if 0", and expanded exp2().
- added new error codes.
- improved looks of the block options
- renamed to "token" from "opaque_bytes" according to new draft.


From me: Use a use a left shift operation instead of multiplying by 2 many
times.

svn path=/trunk/; revision=34878
 2010-11-15 18:01:19 +00:00
Jeff Morriss
56e024876e From Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5403 : 
Fix recent fuzz failures.

svn path=/trunk/; revision=34877
 2010-11-15 16:56:54 +00:00
Bill Meier
71a74c2f3a Regenerate packet-nbap.c now that asn2wrs sorts value_string arrays used with value_string_ext fcns; 
Change nbap.cnf to use val_to_str_ext to access protocolIE_ID value_string array.
Also: Minor whitespace cleanup in nbap.cnf.

svn path=/trunk/; revision=34876
 2010-11-15 16:46:14 +00:00
Anders Broman
7870de6f95 Fill value_strings. 
svn path=/trunk/; revision=34875
 2010-11-15 16:46:07 +00:00
Anders Broman
84dd318764 Extend value_strings to make full use of value_string_ext. 
svn path=/trunk/; revision=34872
 2010-11-14 20:53:15 +00:00
Anders Broman
bb0eefd834 Fix a cut-n-paste error. 
svn path=/trunk/; revision=34866
 2010-11-14 14:13:52 +00:00
Anders Broman
cfc7e8849c Fix a couple of cut-n-paste errors. 
svn path=/trunk/; revision=34865
 2010-11-14 09:57:42 +00:00
Anders Broman
f49a742f2d From Fred Fierling: 
Patch to fix dissector bug noticed in ZigBee APS commands with null payload.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5384

svn path=/trunk/; revision=34864
 2010-11-13 20:13:30 +00:00
Anders Broman
9afb5801bc Fix a typo. 
svn path=/trunk/; revision=34863
 2010-11-13 20:09:01 +00:00
Martin Mathieson
a8b6aca90c From Pascal Quantin: 
- Set a default RNTI value for each type, in case optional RNTI value isn't supplied.
- Improve range checking of given type against acceptable range of values
- fix misplaced return (this fixed bug 5392)

svn path=/trunk/; revision=34859
 2010-11-13 15:32:29 +00:00
Bill Meier
671344e6cc zbee_mfr_code_names: sort so in ascending order by value; add dummy "Unknown" entries for missing values. 
svn path=/trunk/; revision=34855
 2010-11-12 21:47:41 +00:00
Bill Meier
e2123574dc Fix a crash I introduced in SVN #34692: A value_string ext referenced smb_cmd_vals rather than smb_cmd_vals_ext. 
svn path=/trunk/; revision=34853
 2010-11-12 17:28:01 +00:00
Martin Mathieson
a067c3bb8a Check given RNTI value is consistent with given RNTI-type. 
As suggested in bug 5382.  The reported crash didn't happen for me...

svn path=/trunk/; revision=34852
 2010-11-12 16:59:22 +00:00
Anders Broman
760d2a5cdc Update Camel to TS 29.078 9.2.0 (2010-06) 
svn path=/trunk/; revision=34849
 2010-11-12 14:50:58 +00:00
Stig Bjørlykke
775daf50ce Getting wrong addr_type from the packet is not a dissector bug. 
svn path=/trunk/; revision=34847
 2010-11-12 07:54:39 +00:00
Anders Broman
5d6d0f6fea Update from IANA records. 
svn path=/trunk/; revision=34846
 2010-11-11 21:18:46 +00:00
Anders Broman
2c042dcd15 Use value_string_ext. 
svn path=/trunk/; revision=34845
 2010-11-11 21:18:15 +00:00
Anders Broman
92d5c09ac6 Use value_string_ext. 
svn path=/trunk/; revision=34844
 2010-11-11 17:24:11 +00:00
Anders Broman
d5d1e51d90 Fix indentation. 
svn path=/trunk/; revision=34842
 2010-11-11 07:37:43 +00:00
Anders Broman
ec42f515db From Andrew Feren: 
sflow decode error for some extended formats.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5379

svn path=/trunk/; revision=34840
 2010-11-11 07:34:07 +00:00
Stephen Fisher
b18e8fd1ca Resolve bug #2254: Migrate the 802.1q VLAN dissector into the Ethernet II. 
svn path=/trunk/; revision=34838
 2010-11-10 22:37:30 +00:00
Chris Maynard
31f5ce6193 Convert host name to UTF8 before displaying to info column or in tree. 
Fixes bug 1867.

svn path=/trunk/; revision=34837
 2010-11-10 21:41:10 +00:00
Anders Broman
768498f956 Make value_string_ext for all AVP:s with enums. 
svn path=/trunk/; revision=34835
 2010-11-10 20:11:38 +00:00
Anders Broman
1fbfce3411 Make a more descriptive name for the per vendor avp value_string_ext. 
svn path=/trunk/; revision=34831
 2010-11-10 14:43:20 +00:00
Stig Bjørlykke
8b21f50474 Added hint about "TCP segmentation offload" when IP length == 0. 
Added expert info item for bogus IP length.
Added hint about "IP checksum offload" for invalid IP checksum.
Describe TSO in the preference setting. 

svn path=/trunk/; revision=34830
 2010-11-10 13:49:55 +00:00
Bill Meier
fc5f614cec Fix a few typos in two value_string arrays .... 
svn path=/trunk/; revision=34828
 2010-11-09 22:58:17 +00:00
Anders Broman
18a3357ad3 Fill th Q.850 tables. 
svn path=/trunk/; revision=34827
 2010-11-09 21:13:28 +00:00
Anders Broman
b91ed78bcc Add a value_string_ext. 
svn path=/trunk/; revision=34825
 2010-11-09 17:24:45 +00:00
Anders Broman
8785d27bd8 Define unused AVP:s to make it possible to use value_string_ext for 
common AVP:s.

svn path=/trunk/; revision=34824
 2010-11-09 17:23:57 +00:00
Stig Bjørlykke
34d9ef736b Added an expert info for illegal integer length. 
svn path=/trunk/; revision=34820
 2010-11-09 12:17:11 +00:00
Stig Bjørlykke
c56ac0d6db Removed calls to proto_item_set_expert_flags(), as this will be called 
in expert_add_info_format().

svn path=/trunk/; revision=34819
 2010-11-09 12:15:55 +00:00
Anders Broman
348e0bc54b Use value_string_ext for gsm_a_rr_rxlev_vals. 
svn path=/trunk/; revision=34818
 2010-11-09 07:28:04 +00:00
Anders Broman
2fb8971136 Update to 3GPP TS 29.002 V9.3.0 (2010-09) 
svn path=/trunk/; revision=34814
 2010-11-08 23:15:16 +00:00
Bill Meier
c17c9fff87 Use value_string_ext fcns to access certain value_string arrays; 
Sort a few value_string arrays to be in ascending order by value;
Do minor reformatting and whitespace cleanup.

svn path=/trunk/; revision=34813
 2010-11-08 21:59:39 +00:00
Bill Meier
1c01cbfa60 Remove two duplicate values from rtp_payload_type_short_vals value_string array. 
svn path=/trunk/; revision=34812
 2010-11-08 21:35:14 +00:00
Bill Meier
2de3781872 Remove two duplicate entries from rtp_payload_type_vals array. 
svn path=/trunk/; revision=34811
 2010-11-08 21:24:10 +00:00
Anders Broman
7a4781f2d2 Tweek dns_types. 
svn path=/trunk/; revision=34810
 2010-11-08 18:05:42 +00:00
Anders Broman
cab0cef11d Use value_string_ext for RTP payload types. 
svn path=/trunk/; revision=34804
 2010-11-08 14:43:59 +00:00
Gerald Combs
8b468e9284 The PEN field is 32 bits. 
svn path=/trunk/; revision=34802
 2010-11-07 18:21:22 +00:00
Anders Broman
0d246c79a9 display the the PDU length as "cut short"if it crosses the boundary of the 
* packet and no more packets are available.
Based on the patch from Alexander Koeppe in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5285

svn path=/trunk/; revision=34799
 2010-11-06 21:05:45 +00:00
Martin Mathieson
796dc8927c Use guint16 after all, to avoid breaking the UDP framing protocol. 
8 bits are enough though...

svn path=/trunk/; revision=34798
 2010-11-06 19:22:16 +00:00
Martin Mathieson
3adfed8022 Try to fix by making both use guint8, rather than guint16. 
svn path=/trunk/; revision=34797
 2010-11-06 18:51:08 +00:00
Anders Broman
441c4c5381 Get the Windows build going again. 
- Martin is this the right fix?

svn path=/trunk/; revision=34795
 2010-11-06 15:13:25 +00:00
Bill Meier
b78ec52693 Use value_string_ext fcns to access certain value_string arrays; 
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.

svn path=/trunk/; revision=34794
 2010-11-05 22:44:03 +00:00
Martin Mathieson
76bc0e537b Pass ueid + channel-info into PDCP dissector. 
This will allow me soon to track per-channel sequence numbers...

svn path=/trunk/; revision=34793
 2010-11-05 18:00:35 +00:00
Martin Mathieson
fb0bfc17da Show some reserved bits as hex, not decimal. 
svn path=/trunk/; revision=34792
 2010-11-05 16:47:22 +00:00
Bill Meier
332954fd87 (Trivial) Whitespace cleanup. 
svn path=/trunk/; revision=34790
 2010-11-05 14:27:18 +00:00
Stig Bjørlykke
b9f01a15db Initialize dummy_me to avoid garbage or undefined values. 
svn path=/trunk/; revision=34788
 2010-11-05 08:28:34 +00:00
Stig Bjørlykke
0e66df8719 Put all code handling nwk_hints inside "if (nwk_hints)" to avoid possible 
dereference of null pointer.

svn path=/trunk/; revision=34787
 2010-11-05 08:21:25 +00:00
Stig Bjørlykke
428129d60b Initialize a variable to remove a warning from clang. 
svn path=/trunk/; revision=34786
 2010-11-05 08:13:26 +00:00
Stig Bjørlykke
75c2052a01 Fixed a printf modifier to remove a warning from clang. 
svn path=/trunk/; revision=34784
 2010-11-05 08:04:24 +00:00
Anders Broman
58308341bd From Pascal Quantin: 
[NAS EPS] Display explicitly the spare bits when decoding a TFT
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5371

svn path=/trunk/; revision=34781
 2010-11-05 06:19:57 +00:00
Bill Meier
b21ea034b6 Use value_string_ext fcns to access certain value_string arrays; 
Sort certain value_string arrays to be in ascending numeric order;
Do minor whitespace cleanup and reformatting of long lines.

svn path=/trunk/; revision=34780
 2010-11-04 21:30:42 +00:00
Jaap Keuter
198ecea896 Prevent false related packet information, which may be missing or ignored. 
svn path=/trunk/; revision=34779
 2010-11-04 20:53:02 +00:00
Chris Maynard
0b1df697ea Multi-byte fields are big-endian, so fixed hf_cotp_vp_[src|dst]_tsap_bytes. 
Added link to most up-to-date spec, relegating RFC905 to historic status.

svn path=/trunk/; revision=34778
 2010-11-04 15:34:36 +00:00
Stig Bjørlykke
ca8e499694 Removed unused assignments. 
svn path=/trunk/; revision=34776
 2010-11-04 11:27:34 +00:00
Stig Bjørlykke
51668ba0ca Added check for valid pointers. 
svn path=/trunk/; revision=34775
 2010-11-04 11:27:04 +00:00
Stig Bjørlykke
4a69d9203d Corrected pointer types to avoid warnings from clang. 
svn path=/trunk/; revision=34773
 2010-11-04 11:25:40 +00:00
Jaap Keuter
c1b8394ebc From Alexis La Goutte: 
Fix false positive from checkhf.

svn path=/trunk/; revision=34772
 2010-11-04 06:44:57 +00:00
Jaap Keuter
db699d12c8 From Alexis La Goutte: 
Remove unused header fields.

svn path=/trunk/; revision=34771
 2010-11-04 06:42:17 +00:00
Jaap Keuter
b7920c07c5 From Alexis La Goutte: 
Replace all *_min()/*_max() by MIN() and MAX().

svn path=/trunk/; revision=34767
 2010-11-04 06:36:33 +00:00
Bill Meier
9675740701 Use value_string_ext fcns to access certain value_string arrays; 
Sort several value_string arrays to be in ascending order.
Also: Minor whitespace cleanup.

svn path=/trunk/; revision=34766
 2010-11-03 22:08:49 +00:00
Jaap Keuter
c093ff0bfc From Fulko Hew: 
According to RFC 2741 section 6.2.1 the Open-PDU can have an o.id
field containing a 'null' identifier.  The dissector currently does
not handle it and causes other (misleading) error messages to appear
on the decode window.

svn path=/trunk/; revision=34765
 2010-11-03 20:44:46 +00:00
Bill Meier
f329864abf (Trivial): Fix up a comment. 
svn path=/trunk/; revision=34764
 2010-11-03 18:37:29 +00:00
Bill Meier
0ca948bacf Use value_string_ext fcns to access certain value_string arrays; 
Some whitespace cleanup.

svn path=/trunk/; revision=34763
 2010-11-03 18:28:35 +00:00
Jaap Keuter
dffb55434c From Fulko Hew: 
The hex field highlighting when the 'PDU Header' sub-tree is selected
highlights 5 octets rather than the correct 4 (only) octets.

svn path=/trunk/; revision=34762
 2010-11-03 17:57:22 +00:00
Jaap Keuter
605db4842d From Colin O'Flynn: 
Add a missing NULL pointer check.

svn path=/trunk/; revision=34761
 2010-11-03 17:52:11 +00:00
Chris Maynard
606cb44a24 From Claes Nasten, submitted in bug 2952: 
Here's a patch updating the decoding of write request/responses, decodes the 16
unknown bytes in write requests, decodes the 8 unknown bytes in write responses
and renames length to count as per the SMB2 spec.

svn path=/trunk/; revision=34760
 2010-11-03 16:40:41 +00:00
Anders Broman
160fcdfd8b Update SIP headers. 
svn path=/trunk/; revision=34758
 2010-11-03 13:01:01 +00:00
Jaap Keuter
53fbf796f2 From Fred Fierling: 
Patch to correct various typos

svn path=/trunk/; revision=34757
 2010-11-03 07:30:42 +00:00
Stephen Fisher
dc27b7da2d Don't show \000 at the end of null terminated strings in the info column of the tftp dissector: 
tvb_format_text() -> tvb_format_stringzpad()

svn path=/trunk/; revision=34756
 2010-11-02 20:36:36 +00:00
Chris Maynard
fcdeae7c69 Removed call to proto_item_set_len() for SESSION_MESSAGE case. Protect some 
other of these calls with "if (ti != NULL)".  Fixes bug 5289.

svn path=/trunk/; revision=34755
 2010-11-02 18:43:26 +00:00
Anders Broman
250373865e from Alexis La Goutte: 
Cleanup and update ISAKMP Dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5360

svn path=/trunk/; revision=34754
 2010-11-02 16:58:43 +00:00
Martin Mathieson
829ee8752b Add 'ndi' and 'harq-id' as new MAC-PHY DL attributes. 
svn path=/trunk/; revision=34753
 2010-11-02 15:20:38 +00:00
Martin Mathieson
3c5b012771 Don't allocate context struct until/unless heuristic signature string matches. 
svn path=/trunk/; revision=34752
 2010-11-02 15:17:58 +00:00
Jaap Keuter
694383d4a8 From Simon Leinen: 
The IP Timestamp Option (RFC 781) has three variants.  One (flag=0) just stores
a sequence timestamps in the option, but the other two (flag=1 and flag=3)
store alternate IP addresses and timestamps.

From me:
Mark option full when offset (pointer) is set to one, as per RFC 781.

svn path=/trunk/; revision=34750
 2010-11-02 08:48:06 +00:00
Jaap Keuter
ffab7d1606 From Fred Fierling: 
Update Profile ID Information to ZigBee-053298r17 (2010/7/21)

svn path=/trunk/; revision=34749
 2010-11-02 08:21:29 +00:00
Jaap Keuter
9a1a03eca9 From Daniel Ginsburg: 
draft-ietf-isis-ext-eth specifies an extension to current Ethernet Frame
specifications for hardware and frame format to support payloads greater than
1500 Bytes for Type interpretation and Length interpretation frames.

The extension introduced by draft-ietf-isis-ext-eth is currently used by Cisco
Systems' IS-IS routing protocol implementation when running IS-IS over Ethernet
links with large MTU.

svn path=/trunk/; revision=34748
 2010-11-02 07:54:24 +00:00
Bill Meier
2f8ab63858 Compile (over 100) dfilters only if needed rather than at every Wireshark startup; 
Also: Minor whitespace cleanup.

svn path=/trunk/; revision=34747
 2010-11-01 18:38:13 +00:00
Bill Meier
5227ad988a Use value_string_ext fcns to access various value_string arrays; 
Also: Fix a typo  in packet-zbee.h in the value for #define ZBEE_MFG_CODE_STG


svn path=/trunk/; revision=34746
 2010-11-01 18:33:30 +00:00
Bill Meier
c256942255 Use value_string_ext fcns to access various value_string arrays. 
Also: use value_string_const() instead of value_string() where apropriate;
      minor reformatting & whitespace cleanup.

svn path=/trunk/; revision=34745
 2010-11-01 18:26:34 +00:00
Bill Meier
d318d360d5 Use value_string_ext fcns when accessing value_string arrays. 
svn path=/trunk/; revision=34744
 2010-11-01 17:11:04 +00:00
Tomas Kukosa
0cd1b70bf9 Next PER dissectors related to rev. 34400 (empty constructed types with an extension) are regenerated 
http://anonsvn.wireshark.org/viewvc?view=rev&revision=34400

svn path=/trunk/; revision=34740
 2010-11-01 06:54:51 +00:00
Stig Bjørlykke
8e7b882177 Rebuild, no code changes. 
svn path=/trunk/; revision=34735
 2010-10-31 12:30:19 +00:00
Stig Bjørlykke
8e200fbd29 Corrected abbrev for Source and Destination. 
svn path=/trunk/; revision=34733
 2010-10-31 12:15:41 +00:00
Bill Meier
e52c685b2a Use value_string_ext fcns to access a value_string array; 
Sort value_string array to be in ascending order by value;
Minor whitespace cleanup.

svn path=/trunk/; revision=34729
 2010-10-30 20:03:58 +00:00
Bill Meier
054f1299ab Use value_string_ext fcns to access two value_string arrays; 
Remove two duplicate entries from each of two value_string arrays;
Initialize a global variable each time a file is (reloaded);
Remove two unneeded lines of code;
Minor code re-arrangement & reformatting.

svn path=/trunk/; revision=34728
 2010-10-30 19:37:40 +00:00
Bill Meier
af3d0b2bde Use value_string_ext fcns to access a value_string array. 
svn path=/trunk/; revision=34726
 2010-10-30 18:27:52 +00:00
Jeff Morriss
f5d3a16225 Make tvb_strneql()'s size parameter be a size_t. Remove some now-unnecessary casts. 
svn path=/trunk/; revision=34725
 2010-10-30 18:18:12 +00:00
Bill Meier
b35b79590a Use value_string_ext fcns to access a value_string array; 
Also: Initialize a global variable each time a file (re)loaded;
      Use consistent indentation.

svn path=/trunk/; revision=34721
 2010-10-30 17:39:57 +00:00
Jaap Keuter
31e26fdc74 From John Sullivan: 
Improve RTMP dissection:

  * Handle multi-byte csids
  * Handle extended timestamps
  * Better timestamp defaulting/calculations
  * Dechunking should now cope with any clean high quality capture without
    error (still loses sync on missing/out of order packets, but that's 
    very hard to deal with)
  * Dissect tunnelled RTMPT
  * Dissect more packet types
  * Dissect more AMF0 data types
  * Dissect audio/video control information
  * Use official packet/type names
  * Several new fields
  * Function call/response frame linking
  * Push several useful bits of data up the dissection tree or into the 
    info column for ease of use

svn path=/trunk/; revision=34720
 2010-10-30 16:40:46 +00:00
Bill Meier
a4b536a2c0 Use value_string_ext fcns to access two value_string arrays. 
Minor whitespace cleanup.

svn path=/trunk/; revision=34719
 2010-10-30 16:37:55 +00:00
Jeff Morriss
c8395e01b5 Add an SVN Id to these PIDL-generated dissector headers. A patch to PIDL has been sent upstream to the Samba developers. 
svn path=/trunk/; revision=34718
 2010-10-30 16:29:23 +00:00
Jeff Morriss
e17b9ccec1 Rev 29427 added packet_add_new_data_source() with a comment indicating that 
the data source does not need to be allocated if (!tree).

Rev 30158 took the if (!tree) check out indicating that the check was invalid.

So: (since packet_add_new_data_source() now only calls add_new_data_source()),
remove packet_add_new_data_source().

svn path=/trunk/; revision=34717
 2010-10-30 16:00:30 +00:00
Bill Meier
b94da93586 Minor reformatting and whitespace cleanup. 
svn path=/trunk/; revision=34716
 2010-10-30 15:10:30 +00:00
Anders Broman
a401f477d5 From Jouni Malinen: 
Add an item for IEEE 802.11 vendor specific subtypes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4971

svn path=/trunk/; revision=34715
 2010-10-30 14:48:46 +00:00
Bill Meier
b883b87c4a Use value_string_ext to access one of the value-string arrays. 
Whitespace cleanup.

svn path=/trunk/; revision=34714
 2010-10-30 14:48:21 +00:00
Jeff Morriss
554ed113a9 Add an SVN Id to these PIDL-generated dissectors. A patch to PIDL will be sent upstream to the Samba developers. 
svn path=/trunk/; revision=34713
 2010-10-30 14:35:05 +00:00
Anders Broman
738813862b From Robert Bullen: 
Improve the HTTP dissection of the Response Status Line.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5338

svn path=/trunk/; revision=34712
 2010-10-30 14:29:20 +00:00
Jeff Morriss
58da72c54e Fix the randpkt assertion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5348 : 
Always pass a length of 1 to proto_tree_add_item() for the ctype (this fixes
the assertion).  If the length indicated in the message is not 1, add an
expert info.

svn path=/trunk/; revision=34710
 2010-10-30 12:48:29 +00:00
Chris Maynard
fd2c5fbccc Should be a "new-style" dissector because its caller expects it to be now, but 
need to create the dissector handle using new_create_dissector_handle().
(Similar to SVN #34707).

svn path=/trunk/; revision=34708
 2010-10-30 04:29:19 +00:00
Guy Harris
19ac4ab745 The ASF dissector should be a new-style dissector, so its caller knows 
how much of the packet data it's consumed - but that means the dissector
handle for it must be created with new_create_dissector_handle().

svn path=/trunk/; revision=34707
 2010-10-30 03:34:29 +00:00
Bill Meier
5c0ce795b3 It never rejects a packet, so it's not a "new-style" dissector. 
(Similar to SVN #34704).

svn path=/trunk/; revision=34706
 2010-10-30 02:38:44 +00:00
Chris Maynard
bc2a15d93c Fixed checkAPIs.pl warning, which I forgot to run earlier. Ugh. 
svn path=/trunk/; revision=34705
 2010-10-30 01:09:17 +00:00
Guy Harris
97b0de2fe8 It never rejects a packet, so it's not a "new-style" dissector. 
svn path=/trunk/; revision=34704
 2010-10-29 23:58:38 +00:00
Chris Maynard
a12e86f59f Fixes bug 974 by adding RSP trailer. Also resolves packet-asp "FIXME" for 
IANA Enterprise ID as well as extended packet-asp decoding of authentication
and integrity payloads using the sample capture file attached to the bug.
Fuzz tested ~500 passes on that 3 packet capture file.

svn path=/trunk/; revision=34701
 2010-10-29 22:37:31 +00:00
Bill Meier
28402479cc Use value_string_ext fcns to access two value-string arrays; 
Reorder value-string arrays slightly so they are in ascending order.

svn path=/trunk/; revision=34699
 2010-10-29 22:18:44 +00:00
Stig Bjørlykke
c5bebaa771 One more: 
Make the third argument to a UAT copy callback a size_t.

svn path=/trunk/; revision=34696
 2010-10-29 21:55:04 +00:00
Stig Bjørlykke
340d64e780 Make the third argument to a UAT copy callback a size_t. 
svn path=/trunk/; revision=34695
 2010-10-29 21:51:59 +00:00
Guy Harris
17d4d51b7d Make the third argument to a UAT copy callback a size_t (not that any of 
the callbacks we have use that argument - is it really needed?).

svn path=/trunk/; revision=34694
 2010-10-29 21:11:33 +00:00
Bill Meier
f543357d14 Use value_string_ext fcns to access certain value_string arrays. 
svn path=/trunk/; revision=34692
 2010-10-29 20:22:02 +00:00
Bill Meier
1a365d735c Use value_string_ext to access 'commands' value_string. 
svn path=/trunk/; revision=34690
 2010-10-29 18:33:21 +00:00
Bill Meier
4a43e13976 Use value_string_ext to access several "relatively large" value-strings. 
svn path=/trunk/; revision=34689
 2010-10-29 17:48:39 +00:00
Bill Meier
46416bddda (Trivial) Do 'find_dissector("data");' only once. 
svn path=/trunk/; revision=34688
 2010-10-29 17:42:24 +00:00
Jeff Morriss
aac7d5596e From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5290 : 
RequestID and ResponseID are unsigned.  Show them in hex and decimal.

svn path=/trunk/; revision=34686
 2010-10-29 15:44:11 +00:00