Commit graph

189 commits

Author SHA1 Message Date
Guy Harris
8ed7a73e22 Fix a bunch of warnings.
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().

Change some data types to avoid those implicit conversion warnings.

When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.

Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers.  Cast
away those warnings in some cases where an API we don't control forces
us to do so.

Enable a bunch of additional warnings by default.  Note why at least
some of the other warnings aren't enabled.

randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.

If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.

svn path=/trunk/; revision=46748
2012-12-26 05:57:06 +00:00
Jeff Morriss
3551a86c36 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45015
2012-09-20 01:29:52 +00:00
Anders Broman
1ae38887b6 From Evan Huus:
Grab-bag of unused variables.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7452

svn path=/trunk/; revision=43616
2012-07-09 01:49:02 +00:00
Jakub Zawadzki
b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Jakub Zawadzki
bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Jeff Morriss
4fdc3c3cc2 Create, and start using, file name preferences.
File name preferences are basically just string preferences except that the
GUI will present a "Browse" button that allows the user to go and find the
file s/he wants (rather than having to blindly type in the full path).

svn path=/trunk/; revision=43228
2012-06-13 01:13:12 +00:00
Jeff Morriss
8204b904b3 Fix Coverity 702421: Handle the possibility that fvalue_to_string_repr()
may return NULL.

svn path=/trunk/; revision=43114
2012-06-05 15:20:31 +00:00
Bill Meier
3d4b3f2784 Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt if Makefile.common is changed
svn path=/trunk/; revision=42972
2012-06-01 14:44:35 +00:00
Bill Meier
1caa79ad80 Windows: Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt if Makefile.common is changed
ToDo: ditto for Makefile.am ?

svn path=/trunk/; revision=42971
2012-06-01 14:08:12 +00:00
Jakub Zawadzki
8a1dc57c03 Remove doubled semicolons and semicolons outside function.
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
Jeff Morriss
75c3c92f19 Add a "-build" argument to checkAPIs.pl. Use that argument when building
from makefiles (and thus from the buildbot).

The intention is to be able to tell when a human is running the tool so we
can provide more code-review guidance.

As a starter, enable the "too many proto_tree_add_text() calls" check when
a human is running the tool.

svn path=/trunk/; revision=41943
2012-04-04 20:46:49 +00:00
Bill Meier
605dea0486 CVARSDLL hasn't been used (is undefined) for a while....
svn path=/trunk/; revision=41180
2012-02-24 16:23:38 +00:00
Anders Broman
8e97665863 Add *.sbr files to the clean target.
svn path=/trunk/; revision=40761
2012-01-29 20:03:39 +00:00
Bill Meier
48ca3d4742 Use GSlice API instead of GMemChunk API for some memory allocation.
svn path=/trunk/; revision=40547
2012-01-16 19:05:32 +00:00
Bill Meier
49eff359e1 Fix a typo in an error message.
svn path=/trunk/; revision=40546
2012-01-16 18:12:18 +00:00
Jörg Mayer
8b8025c5d0 Add a comment about the uncommented glib deprecated warnings.
svn path=/trunk/; revision=38403
2011-08-08 09:39:30 +00:00
Jörg Mayer
553c565699 mate_grammar.lemon:
- Fix a bug my previous patch introduced.

mate/:
- Unset G_DISABLE_DEPRECATED for the mate files.

CMakeLists.txt
configure.in:
- Build with -DG_DISABLE_DEPRECATED so further usage of
  deprecated glib functions will be detected.

svn path=/trunk/; revision=38393
2011-08-07 18:35:36 +00:00
Jörg Mayer
c15ff441c6 Replace deprecated glib functions.
In order to compile the whole project with -DG_DISABLE_DEPRECATED
the mate plugin needs to replace its usage of GMemChunk.
All other places should be clean.

svn path=/trunk/; revision=38392
2011-08-07 18:15:45 +00:00
Stig Bjørlykke
8443bbbf75 Replace all strerror() with g_strerror().
Remove our local strerror implementation.
Mark strerror as locale unsafe API.

This fixes bug 5715.

svn path=/trunk/; revision=37812
2011-06-28 09:00:11 +00:00
Bill Meier
7062abeb00 Don't assign a value to a variable which is then never used: Coverity 1160 [UNUSED]
svn path=/trunk/; revision=37290
2011-05-19 14:11:01 +00:00
Jörg Mayer
2b3167dcf9 Fix another old style function declaration warning
svn path=/trunk/; revision=37281
2011-05-19 05:08:42 +00:00
Guy Harris
d6fdc37988 More fun with GArrays: cast away some warnings that don't report real
alignment problems and that wouldn't even happen if the "data" member of
a GArray were a "void *".

svn path=/trunk/; revision=36855
2011-04-25 21:19:54 +00:00
Alexis La Goutte
2fc740d7d1 Fix (latest) Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36802
2011-04-22 13:11:52 +00:00
Alexis La Goutte
0c598a950d Fix Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36756
2011-04-21 13:33:04 +00:00
Anders Broman
bc0fbb792a Added FALLTHRU comment to avoid a "missing break" warning.
CID 489

svn path=/trunk/; revision=36400
2011-03-29 21:05:29 +00:00
Chris Maynard
10928bc0cc Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.

svn path=/trunk/; revision=36383
2011-03-28 17:04:58 +00:00
Bill Meier
7c41d527fd Removed uneeded 'continue'.
Fixes Coverity 815 ("UNREACHABLE").

svn path=/trunk/; revision=36367
2011-03-27 14:34:19 +00:00
Stig Bjørlykke
1f108b02a0 Allocate correct size of range.
Coverity 718.

svn path=/trunk/; revision=36262
2011-03-22 18:58:32 +00:00
Ronnie Sahlberg
ea9e664fc9 Coverity 420
Remove dead code and add a g_assert_not_reached() at a spot we can definitely never reach.

change a if(x)g_free(x) to a g_free(x)
since g_free(NULL) is just a nop.



svn path=/trunk/; revision=36238
2011-03-22 09:05:26 +00:00
Stig Bjørlykke
a774994572 Added some casts to fix coverity 325.
svn path=/trunk/; revision=36228
2011-03-21 18:33:18 +00:00
Bill Meier
d3efa3ed9f A bit of Windows makefiles rework and cleanup:
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile;
  a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS;
  b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake)
      (This allows disabling "Warnings as Errors" by just changing config.nmake)
  c. CVARSDLL definitions (not usage) have been removed from the various makefiles.
     XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since:
     -DWIN32 and -DNULL=0 do not appear to be needed (any more);
     -D_MT and _D_DLL  are not needed since /MP causes these definitions.
  d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled.
     E.G., 4295: array is too small to include a terminating null character
- config.nmake: reformat some long lines for readability;
- plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile);
- dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ...

svn path=/trunk/; revision=35747
2011-02-02 01:19:53 +00:00
Bill Meier
6e079af172 Whitespace cleanup (remove trailing blanks from lines).
svn path=/trunk/; revision=35711
2011-01-30 22:57:00 +00:00
Bill Meier
17281958a2 Add a comment about some "unreachable code" indicating possible incorrect code someplace.
Fix some spelling..

svn path=/trunk/; revision=35710
2011-01-30 22:42:06 +00:00
Guy Harris
ac3ac6c476 Plugins are not shared libraries, so:
1) don't set thei SOVERSION - run-time-loaded modules don't have
	   an SOVERSION;

	2) build them with link mode MODULE, not SHARED, on all
	   platforms.

(Fixing 1) also fixes the problem with building them as MODULE on OS X.)

svn path=/trunk/; revision=34243
2010-09-24 20:41:34 +00:00
Jörg Mayer
de68ad3066 H. Sivank <hsivank@gmail.com>
I try to configure Wireshark with cmake on macosx 10.6.
It fails with : set_target_properties called with incorrect number of arguments.
Attached a patch to fix this issue.


svn path=/trunk/; revision=34201
2010-09-23 07:02:33 +00:00
Jeff Morriss
54082c6ed0 Add Cmake stuff to the source distribution so more people can try it out.
svn path=/trunk/; revision=32807
2010-05-14 16:27:03 +00:00
Jeff Morriss
b09f79f414 Be sure we initialize the p_id in hf's. This fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3010 .

Also finish the implementation of ShowTimes for GOGs so that the variable gets
initialized (preventing another uninitialized variable warning from Valgrind).

svn path=/trunk/; revision=32465
2010-04-14 18:39:00 +00:00
Jeff Morriss
ef2548d093 Fix up MATE's hf display values so MATE will actually run.
svn path=/trunk/; revision=32464
2010-04-14 14:20:16 +00:00
Jörg Mayer
96779de920 cmake changes:
- Add checking for linker flags
- Install plugins with the name including the Wireshark version.
  This will make it easier to find matching plugin versions if
  files get just copied over.


svn path=/trunk/; revision=32231
2010-03-18 10:27:17 +00:00
Jörg Mayer
67072286bf - Remove the lib prefix for plugin names.
- Remove a (resolved) comment.
- Add a commented out line how to add version infos to the
  plugin's file name.

svn path=/trunk/; revision=31995
2010-02-24 22:32:10 +00:00
Bill Meier
1341fcd87e Fix some gcc -Wshadow warnings.
svn path=/trunk/; revision=31722
2010-01-28 21:49:30 +00:00
Jörg Mayer
d2cc318f4f Beginnings of enabling static builds. Still to do:
* Add -static
* Registration may need different handling
* Add plugins
* Build error in wslua

svn path=/trunk/; revision=30987
2009-11-17 11:58:36 +00:00
Jörg Mayer
9ee31d1d0e cmake will now honor -Werror if configured (default: on)
svn path=/trunk/; revision=30852
2009-11-07 10:07:00 +00:00
Stig Bjørlykke
a52bf035b7 Removed redundant redeclaration of delete_avpl().
svn path=/trunk/; revision=30618
2009-10-19 14:42:10 +00:00
Kovarththanan Rajaratnam
8b8399b711 Use register_dissector_files in the plugins dissectors
svn path=/trunk/; revision=30435
2009-10-09 16:39:34 +00:00
Stig Bjørlykke
cf85342eec Build plugins with cmake on OSX.
svn path=/trunk/; revision=30373
2009-10-06 18:58:09 +00:00
Jörg Mayer
6a2f689235 Fix build of make and asn1 plugins.
svn path=/trunk/; revision=30144
2009-09-25 15:17:45 +00:00
Jörg Mayer
95182116aa CMake:
- Add opcua to the list of plugins to build
- Link the gtk stuff statically into wireshark
- Beginnings of "make install"
- Change a few things about install paths

svn path=/trunk/; revision=30029
2009-09-21 00:19:07 +00:00
Jörg Mayer
5a2247f5a3 Build a few more plugins
svn path=/trunk/; revision=29942
2009-09-16 06:30:03 +00:00
Jeff Morriss
4661aad9a4 Run checkapi on the dissector header files
svn path=/trunk/; revision=29883
2009-09-13 19:48:22 +00:00