checkAPIs.pl doesn't like tvb_get_* parameters because it thinks
proto_tree_add_item should be used. This is just to pacify the check.
Change-Id: If40728bcdf5558c351999057321ffba5d802c7c7
Reviewed-on: https://code.wireshark.org/review/21694
Reviewed-by: Anders Broman <a.broman58@gmail.com>
It's a little more efficient to use proto_tree_add_item, than
proto_tree_add_xxx, passing it the returned tvb_get_xxx value.
Change-Id: I22ddd7ab36e1ee5aae78fc693d7dbac4b4f802f2
Reviewed-on: https://code.wireshark.org/review/21691
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
But the lz4 frame API was introduced in [r123](https://github.com/lz4/lz4/blob/r123/lz4frame.h).
Put the code behind a lz4 version check.
Change-Id: If8a7e5f7f2e7c9beac89eec334368a5b95a1bc3f
Reviewed-on: https://code.wireshark.org/review/21684
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Added sources regarding some magic numbers in the heuristic dissection methods
Added logic to spot 52 bytes long RACH frames to the RACH heuristic dissector
Added a check for common TB length in PCH heuristic dissector.
Change-Id: Icdb06cfb230189b3270da0f4c8b24aa400157ea9
Reviewed-on: https://code.wireshark.org/review/21668
Reviewed-by: Anders Broman <a.broman58@gmail.com>
UndefinedBehaviorSanitizer (UBSan) can catch a lot of issues
(out-of-bounds memory access, integer overflows, undefined shifts,
etc.) and is recommended during development using GCC or Clang. Add an
option for it (similar to ASAN support).
Change-Id: Ib0db50cee9eb5af0f5c4f06e07f3899a3a34702d
Reviewed-on: https://code.wireshark.org/review/21673
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
to avoid duplicated hf
(like for v5 4b90e93f37)
Change-Id: I7658a98c36cc42dc67f85b84fb16f36f5e505032
Reviewed-on: https://code.wireshark.org/review/21672
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Move gtk's fld_tostr() to epan API as uat_fld_tostr.
Change-Id: I01e3b66ca9ea3cd1e2e06e2122190ee42b9ad44b
Reviewed-on: https://code.wireshark.org/review/21664
Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
LZ4F_decompress accepts a NULL parameter to apply default parameters, do
not bother setting a parameter (this also avoids
-Wmissing-field-initializers warnings from clang).
Change-Id: Id2cd8d58cd9339dd5af395092a8104b559b6e194
Reviewed-on: https://code.wireshark.org/review/21675
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
While we're at it, fix a typo in a comment.
Bug: 13711
Change-Id: Ie1e4aa9243ccb10621bf181b232e177c2a7f867c
Reviewed-on: https://code.wireshark.org/review/21676
Reviewed-by: Guy Harris <guy@alum.mit.edu>
At least some compilers will warn about not initializing the reserved
values.
Change-Id: Id907468be757a1cd3137140d285803f3e9f1724a
Reviewed-on: https://code.wireshark.org/review/21674
Reviewed-by: Guy Harris <guy@alum.mit.edu>
for avoid duplicated hf
(like for v5 4b90e93f37)
Change-Id: I2f535e2ed06444959d4c1f1c089fec9693a8b96d
Reviewed-on: https://code.wireshark.org/review/21670
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
for avoid duplicated hf
Change-Id: I93ba76e2594e61f8dec9a78540b46025326b1ee6
Reviewed-on: https://code.wireshark.org/review/21660
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Part 2
Change-Id: I8f59186bdfc64d4c8dac74245cbffdad1c8d4579
Reviewed-on: https://code.wireshark.org/review/21661
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Change-Id: I5b4b020029f3c1587f96ca1fcf5fbfa2ee78ac31
Reviewed-on: https://code.wireshark.org/review/21628
Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Issue reported by Alex
Bug: 13690
Change-Id: I6c0c01569be8474e1cbab0c8ca009c00394e1ffe
Reviewed-on: https://code.wireshark.org/review/21650
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
The handshake_messages for extended master secret start at Client Hello
and end at ClientKeyExchange. Previously all handshake messages in a
record would be hashed, possibly covering those after CKE. Now it will
hash each handshake message separately.
For DTLS, the CH and HVR messages must also be ignored. Additionally,
DTLS needs special treatment to merge multiple fragments.
Bug: 13704
Change-Id: I0c8f19b4c352c0195848ded319b6991d76542720
Reviewed-on: https://code.wireshark.org/review/21625
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Create explicit display filter
- Adding reference to the IEEE 802.15.4 standard
- extract dissect_802154_enhanced_beacon_filter
- Explicit case of header termination
- Fix typo
- Add some cast
Change-Id: I21c5b9eb46c72a377f17113ae729c6aeb79e5d2b
Reviewed-on: https://code.wireshark.org/review/21361
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
and add new field on groupmod with Bucket
Ping-Bug: 13702
Change-Id: If5893d49d6cd7a8ab6b46f1fcfce4fbff4153d1f
Reviewed-on: https://code.wireshark.org/review/21646
Reviewed-by: Anders Broman <a.broman58@gmail.com>
OFPIT_METER is now deprecated and there is a new OFPIT_STAT_TRIGGER
Ping-Bug: 13702
Change-Id: I76b8ab8a86ee59e443fbeac81c45b982bac1b3a2
Reviewed-on: https://code.wireshark.org/review/21644
Reviewed-by: Anders Broman <a.broman58@gmail.com>
no try on real pcap...
Ping-Bug: 13702
Change-Id: I828ae5599704c9bc514b8968d1a15c9a446555d6
Reviewed-on: https://code.wireshark.org/review/21643
Reviewed-by: Anders Broman <a.broman58@gmail.com>
no try on real pcap...
Ping-Bug: 13702
Change-Id: Ia6b048cc8b37bb1697e7378bbcd098a19bff99e3
Reviewed-on: https://code.wireshark.org/review/21642
Reviewed-by: Anders Broman <a.broman58@gmail.com>
'nge.unknown' exists multiple times with NOT compatible types: FT_UINT32 and FT_BYTES
Change-Id: I757e6b4107e4d8103950603d4441248b931bbb15
Reviewed-on: https://code.wireshark.org/review/21638
Reviewed-by: Michael Mann <mmann78@netscape.net>
Change-Id: I0974f13a032a908bcc27f583c3e059f57959881f
Reviewed-on: https://code.wireshark.org/review/21552
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Bug: 13705
Change-Id: I6bd006f216440d071e5c1eeb6b1f996b4a364c62
Reviewed-on: https://code.wireshark.org/review/21629
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Perform sanity check on parsed data rate. Data rate of zero results in a
division by zero in calculate_llac_duration. Do not use data rate if zero.
Bug: 13706
Change-Id: I7883e1052a0965f7927d3a478c0aa992693f7fe1
Reviewed-on: https://code.wireshark.org/review/21626
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Michael Mann