osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
41,731 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

41731 Commits

Author SHA1 Message Date
Jakub Zawadzki 835a1a1b9c Fix memleaks (tvb_get_unicode_string()) 
svn path=/trunk/; revision=44053
 2012-07-26 17:26:05 +00:00
Jakub Zawadzki 80721f5498 Fix memleak in window_icon_realize_cb() 
gtk_window_set_icon_list() duplicates list so after setting we need
to free generated one.

svn path=/trunk/; revision=44052
 2012-07-26 17:23:35 +00:00
Jakub Zawadzki 8f308fe1b1 Revert r44049, frame_data_cleanup() is called when redissecting. 
svn path=/trunk/; revision=44051
 2012-07-26 16:41:34 +00:00
Bill Meier 3b36a23478 Minor cleanup; 
- Create/use an extended value string to access a value string array;
- Reformat to match editor modelines (convert tabs to spaces).

svn path=/trunk/; revision=44050
 2012-07-26 16:13:09 +00:00
Jakub Zawadzki 79c7230cc8 Free frame comment. 
svn path=/trunk/; revision=44049
 2012-07-26 16:09:41 +00:00
Bill Meier f5bc152e48 Minor cleanup, including: 
- remove uneeded #include;
- remove uneeded col_clear();
- widen several var definitions to prevent potential overflow;
- remove uneeded initializers;
- use consistent indentation;
- whitespace.

svn path=/trunk/; revision=44048
 2012-07-26 15:16:04 +00:00
Chris Maynard 64b467543e Well, since 1 instance of wireshark was already changed to Wireshark, we might as well change the rest too for consistency. 
svn path=/trunk/; revision=44047
 2012-07-26 15:10:42 +00:00
Chris Maynard 5c760cce32 Fix more typos. 
svn path=/trunk/; revision=44046
 2012-07-26 15:05:54 +00:00
Jörg Mayer a1f2ea8726 Fix some percieved typos 
svn path=/trunk/; revision=44045
 2012-07-26 14:38:36 +00:00
Jörg Mayer 1df7174946 dfilter.h does not need to include epan.h 
svn path=/trunk/; revision=44044
 2012-07-26 14:37:31 +00:00
Martin Mathieson 7901962209 Fix another uninitialised bug (the same bug in _read() I fixed 
yesterday, also in _seek_read()).  Spotted by running 'valgrind-wireshark.sh -2'.

svn path=/trunk/; revision=44043
 2012-07-26 13:59:20 +00:00
Michael Tüxen 685f74c24d Try to make the buildbot without libpcap happy... 
svn path=/trunk/; revision=44042
 2012-07-26 13:27:18 +00:00
Michael Tüxen 69ee8e5a72 Changes corresping to 
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44040

svn path=/trunk/; revision=44041
 2012-07-26 12:51:30 +00:00
Michael Tüxen 14a808ea3f Get it linking (at least on Mac OS X). 
svn path=/trunk/; revision=44040
 2012-07-26 12:47:48 +00:00
Michael Tüxen baa41c7d99 Mark unused parameter as such. 
svn path=/trunk/; revision=44039
 2012-07-26 12:33:20 +00:00
Anders Broman d20be7ed47 Don't mark used parameters as unused. 
Use the function parameter not the global variable.

svn path=/trunk/; revision=44038
 2012-07-26 12:23:24 +00:00
Anders Broman 46d1c5c5ec If def offending code 
packet-rlc.c:2290:7: error: variable ‘i’ set but not used [-Werror=unused-but-set-variable]

svn path=/trunk/; revision=44037
 2012-07-26 11:39:11 +00:00
Anders Broman de022f5bed Separate the Capture menu actions from main_menu_bar_entries. 
svn path=/trunk/; revision=44036
 2012-07-26 09:43:28 +00:00
Anders Broman 180f7aa1e0 From Jacob Nordgren and Rishie Sharma: 
-  FP and RLC fixed spelling 
- Fixed variable declaration in RRC 
- removed extra ppi in nbap

svn path=/trunk/; revision=44035
 2012-07-26 09:42:07 +00:00
Jakub Zawadzki b90fabe60d Make columnized and colorized bit field. 
svn path=/trunk/; revision=44034
 2012-07-26 09:36:15 +00:00
Jakub Zawadzki d9b0f40749 Add checks if stamp values matches. Remove packet_list_visible_record 
svn path=/trunk/; revision=44033
 2012-07-26 09:20:05 +00:00
Jakub Zawadzki 937ea48213 physical_pos is now used only for checks, ifdef it in PACKET_PARANOID_CHECKS to save some memory 
svn path=/trunk/; revision=44032
 2012-07-26 09:19:52 +00:00
Jakub Zawadzki c5bc6afb0c Exploit short-circuit evaluation, so first check variable, later call function 
svn path=/trunk/; revision=44031
 2012-07-26 09:19:37 +00:00
Jakub Zawadzki 83821d08b3 Move checks outside loop 
svn path=/trunk/; revision=44030
 2012-07-26 09:19:22 +00:00
Jakub Zawadzki 5d14f7e7f2 Pass record to packet_list_change_record() not physical_pos 
svn path=/trunk/; revision=44029
 2012-07-26 09:19:03 +00:00
Anders Broman 71f4754f19 Extend a value string. 
svn path=/trunk/; revision=44028
 2012-07-26 08:16:07 +00:00
Anders Broman aed65b0c7b From Jacob Nordgren and Rishie Sharma: 
- RRC now configures logical channels in HS-DSCH hs, and some HSDSCH common support added 
- RLC: modifed memory management, MAC: dch would set the incorrect logical channel for RLC

svn path=/trunk/; revision=44027
 2012-07-26 08:15:20 +00:00
Bill Meier 65ebfc9db4 The comment in the file says: 
; NOTE: TABS DON'T WORK IN THIS FILE, USE SPACES INSTEAD!!!

So: replace tabs by spaces.

Also: Adjust spacing in a few cases.


svn path=/trunk/; revision=44026
 2012-07-26 04:52:42 +00:00
Chris Maynard e49240205d Fix Coverity CID's 703862-703863: Unintentional integer overflow. 
svn path=/trunk/; revision=44025
 2012-07-26 02:42:40 +00:00
Evan Huus 69a95ad3a2 valgrind-wireshark.sh: 
- add support for 2-pass dissection and config profiles
 - make whitespace a consistent 4-spaces
fuzz-test.sh:
 - update 2-pass support to use -2 and not the old -P
 - add support for fuzz-testing under valgrind with the new -g option

svn path=/trunk/; revision=44024
 2012-07-26 02:38:34 +00:00
Chris Maynard a3a50ecb03 Fix Coverity CID 709737: Structurally dead code. 
svn path=/trunk/; revision=44023
 2012-07-26 02:16:37 +00:00
Chris Maynard 787d832da8 tvb_length_remaining() can return -1, so be sure to deal with it if it does. 
svn path=/trunk/; revision=44022
 2012-07-26 02:00:11 +00:00
Chris Maynard ddaee0898f Fix trivial typos and other misc. minor updates. 
svn path=/trunk/; revision=44021
 2012-07-26 01:50:39 +00:00
Chris Maynard 368db9893c Export proto_unregister_field as requested by Helge Kruse. 
Ref: http://www.wireshark.org/lists/wireshark-dev/201207/msg00210.html

svn path=/trunk/; revision=44020
 2012-07-26 00:18:46 +00:00
Martin Mathieson ca8d59f834 Initialize a byte to avoid more valgrind warnings. 
svn path=/trunk/; revision=44019
 2012-07-25 22:56:08 +00:00
Chris Maynard c6bf60f74b Fix Coverity CID 709738: Unused pointer value. 
svn path=/trunk/; revision=44018
 2012-07-25 22:48:14 +00:00
Martin Mathieson 1d1cc74e93 Zero a struct to avoid branching based upon uninitialised fields 
(previousFrameNum & nextFrameNum).  Spotted by valgrind.

svn path=/trunk/; revision=44017
 2012-07-25 22:02:29 +00:00
Martin Mathieson 2f3a057bca Don't write one payload byte too many. Spotted by valgrind! 
svn path=/trunk/; revision=44016
 2012-07-25 21:53:39 +00:00
Jeff Morriss bcfadcbace zbee.aps was renamed zbee_aps (in r43990). 
svn path=/trunk/; revision=44015
 2012-07-25 21:27:19 +00:00
Gerald Combs f414b3cae3 Revert parts of r43978 and r43976 so that we can catch updates in 
subdirectories.

svn path=/trunk/; revision=44014
 2012-07-25 21:08:44 +00:00
Bill Meier 7b869feb85 Minor cleanup: 
- col_clear() not needed;
- remove some unneeded initializers;
- reformat hf[] entries.

svn path=/trunk/; revision=44013
 2012-07-25 20:46:36 +00:00
Bill Meier 840a58f1f3 Minor cleanup: 
- Create/use extended value string to access value string array;
- col_clear() not needed;
- Remove some unneeded initializers.

svn path=/trunk/; revision=44012
 2012-07-25 20:42:16 +00:00
Bill Meier b53d5078d9 - Call dissector_add-handle() so protocol is 
available under UDP 'decode as';
- Back out use of extended value strings (added in SVN #43942);
   'tshark -G values' on Windows gives a warning as
   to 'Invalid value_string_ext ptr'.
   Issue: On Windows, value_string_ext validation code always
         fails for extended value strings in plugins.
         (Something todo with the linkage mechanism).

svn path=/trunk/; revision=44011
 2012-07-25 20:37:47 +00:00
Jeff Morriss beef3c0791 From Stephen Donnelly via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7500 : 
The default colorfilter for "Bad Checksum" does not include the Ethernet Frame
Check Sequence (FCS) test.

It seems reasonable that it should be included in this filter rule. It is only
indicated if the Ethernet dissector "Validate the Ethernet checksum if
possible" preference is set and the FCS is believed to be present (via wiretap
heuristic/dissector preference).


From me: re-order the list of bad checksum fields.

svn path=/trunk/; revision=44010
 2012-07-25 20:27:46 +00:00
Jeff Morriss 30cb074991 zbee.aps was renamed zbee_aps (in r43990). 
svn path=/trunk/; revision=44009
 2012-07-25 20:09:17 +00:00
Pascal Quantin 70ea1804d8 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7524 : 
8-PSK structure in GSM Classmark 3 is not properly dissected

svn path=/trunk/; revision=44008
 2012-07-25 20:04:33 +00:00
Jakub Zawadzki b3ac15f492 Fix buildbot warning: variable `fdata' set but not used [-Werror=unused-but-set-variable] 
svn path=/trunk/; revision=44007
 2012-07-25 19:25:23 +00:00
Jakub Zawadzki 6349999757 Allocate col_text & col_text_len only for columns not based on frame_data 
svn path=/trunk/; revision=44006
 2012-07-25 18:01:42 +00:00
Jakub Zawadzki 59de6c3a8f Remove packet_list->column_types 
svn path=/trunk/; revision=44005
 2012-07-25 18:00:38 +00:00
Jakub Zawadzki fce74c732b Make PacketListRecord structure private. 
svn path=/trunk/; revision=44004
 2012-07-25 17:59:56 +00:00