osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
39,690 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

39690 Commits

Author SHA1 Message Date
Stig Bjørlykke 7d6fcb871b Renamed dmp_class to sec_class, as this is a more correct variable name. 
svn path=/trunk/; revision=41738
 2012-03-22 12:38:18 +00:00
Stig Bjørlykke 2a9559e200 Removed unused 'msg_type_val' argument to some functions. 
svn path=/trunk/; revision=41737
 2012-03-22 12:37:03 +00:00
Anders Broman afa29e0070 From Yaniv Kaul: 
Enhance the SSL dissector to dissect some Hello extensions.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6979

svn path=/trunk/; revision=41736
 2012-03-22 08:58:19 +00:00
Anders Broman dba2c07cba From Weston Schmidt: 
Add support for ETV Data processing & simple MPEG DSM-CC handling.
Witha a change of the name of dissect() in packet-etv.c to dissect-etv_common().

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6978

svn path=/trunk/; revision=41735
 2012-03-22 08:49:00 +00:00
Chris Maynard 6d09f686dd If the checksum is 0, then only report "no checksum" for UDP/IPv4. This patch is from Jaap Keuter via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6232 
svn path=/trunk/; revision=41734
 2012-03-22 03:41:58 +00:00
Gerald Combs 6f4ab63e89 Add a missing "T". 
svn path=/trunk/; revision=41731
 2012-03-21 23:15:30 +00:00
Gerald Combs 604896658e Don't use GNUTLS 3.0, at least until we determine the impact of their 
license change.

svn path=/trunk/; revision=41728
 2012-03-21 22:52:03 +00:00
Jeff Morriss 1731fc958e From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6977 : 
The attached (trivial) patch adds some missing breaks in switch-case blocks.

This fixes coverity defects #445, #446, #1316 and #1380.

svn path=/trunk/; revision=41727
 2012-03-21 22:18:15 +00:00
Jeff Morriss 5629a3fa00 Fix fuzz failure reported in 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6976 :

Don't assume that all responses have conversations to find.

svn path=/trunk/; revision=41726
 2012-03-21 21:21:58 +00:00
Bill Meier 34e788eb11 'tab-width/tabstop/tabSize' in editor modelines should really always be 8. 
svn path=/trunk/; revision=41725
 2012-03-21 18:27:10 +00:00
Bill Meier ca3e8b5d8b 'tab-width/tabstop/tabSize' in editor modelines should really always be 8; 
Also: In some cases do some whitespace cleanup and some minor reformatting.

svn path=/trunk/; revision=41724
 2012-03-21 18:20:44 +00:00
Martin Mathieson 2fc3322e82 Trivial formatting: Show segment offsets/length closer to associated sequence number 
in partial NACK.

svn path=/trunk/; revision=41723
 2012-03-21 13:53:18 +00:00
Anders Broman f85baa9dfa From Guy Martin: 
Fix
Coverity has 3 complaints about this dissector, reported in CID's 1450-1451
CONSTANT_EXPRESSION_RESULT:

Event result_independent_of_operands: (crid & 3) >> 2 is 0 regardless of the
values of its operands [non-specific operand of assignment].
1385             crid_type = (crid &
MPEG_DESCR_CONTENT_IDENTIFIER_CRID_LOCATION_MASK) >> 2;


Event result_independent_of_operands: flags & 0x1000 is always 0 regardless of
the values of its operands (logical operand of if).
1512             if (flags & MPEG_DESCR_LOGON_INITIALIZE_CONNECTIVITY_MASK) {


Event result_independent_of_operands: flags & 0x1000 is always 0 regardless of
the values of its operands (logical second operand of '&&').
1544         if (offset < end && (flags &
MPEG_DESCR_LOGON_INITIALIZE_CONNECTIVITY_MASK)) {

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6960

svn path=/trunk/; revision=41722
 2012-03-21 13:07:23 +00:00
Martin Mathieson 611dcb0d68 When a TCP graph is summoned, work out how many unique TCP conversations 
are present. However, still only create the graph for the first/only
one.

LTE MAC or RLC frames often contain multiple SDUs that are segments of
the same TCP conversation - this avoids the need to find a frame with
only one SDU.

svn path=/trunk/; revision=41721
 2012-03-21 12:58:50 +00:00
Alexis La Goutte 914a9df522 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=41720
 2012-03-21 11:27:10 +00:00
Michael Tüxen 0f92a3a8d2 From Irene Ruengeler: Restore functinality of last patch. 
svn path=/trunk/; revision=41719
 2012-03-21 09:54:05 +00:00
Alexis La Goutte f5822cdd9e From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6972 
ISAKMP : VendorID CheckPoint : Malformed Packet

Wrong minimum length when there is not CheckPoint "Data" after VendorID

svn path=/trunk/; revision=41718
 2012-03-21 09:49:35 +00:00
Alexis La Goutte 98cd9c9ebb From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6206 
IKE: Life-Duration wrong displayed in LTV format

The Fix commit in Revision 38387 is wrong 
Get the following error message : ISAKMP dissector bug: failed assertion proto.c:2957

use a HF by type (uint32, uint64, bytes...) for life duration

svn path=/trunk/; revision=41717
 2012-03-21 09:28:31 +00:00
Anders Broman 63c19bd071 Disable debug. 
svn path=/trunk/; revision=41716
 2012-03-21 08:58:27 +00:00
Anders Broman b971f1b1a0 From Steve Magnani: 
USB: incorrect generated bInterfaceClass for composite device CONTROL transactions.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6964

svn path=/trunk/; revision=41715
 2012-03-21 08:40:19 +00:00
Anders Broman 254e208558 packet-ieee1722.c:127: warning: 'ieee1722_tree' may be used uninitialized in this function 
svn path=/trunk/; revision=41714
 2012-03-21 06:55:58 +00:00
Guy Harris 7ee4c2fb40 Make the comment I added, saying what scan_local_interfaces() does, more 
accurate.

svn path=/trunk/; revision=41713
 2012-03-21 06:37:34 +00:00
Guy Harris 7f5162352f scan_local_interfaces() isn't in capture_opts.c; don't declare it in 
capture_opts.h.  (It arguably belongs somewhere other than in a file in
ui/gtk, but, if so, move it there, e.g. to something in ui.)

svn path=/trunk/; revision=41712
 2012-03-21 06:31:39 +00:00
Anders Broman 6090a6c659 From Jason Damori: packet-ieee1722.c calls subdissectors too late in dissection https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6974 
svn path=/trunk/; revision=41711
 2012-03-21 06:23:33 +00:00
Guy Harris 4690f02928 Handle bogus values of the error that *should* be coming from 
scan_local_interfaces() (but, currently, isn't, as the code wasn't
correctly restructured).

svn path=/trunk/; revision=41710
 2012-03-21 06:20:01 +00:00
Guy Harris fd72ad5e92 Automake can, at times, be a delicate fragile flower. Apparently, 
having something in wireshark_LDADD that's filled in by the configure
script means that the items referred to by that string aren't treated as
dependencies.

svn path=/trunk/; revision=41709
 2012-03-21 06:13:53 +00:00
Guy Harris 40a034b3f5 Fix 4-space tabs. 
svn path=/trunk/; revision=41708
 2012-03-21 06:10:17 +00:00
Guy Harris f5e58ac3ec If you're not going to use a subtree, don't create it. 
svn path=/trunk/; revision=41707
 2012-03-21 05:40:22 +00:00
Chris Maynard 87d0ec956e Fix Coverity CID 1337: UNUSED_VALUE. 
svn path=/trunk/; revision=41706
 2012-03-21 03:47:48 +00:00
Chris Maynard e64474fba4 Fix Coverity CID 1449: DEADCODE. 
svn path=/trunk/; revision=41705
 2012-03-21 03:22:24 +00:00
Chris Maynard 6c1875f2ea Fix Coverity CID's 1452-1453: UNUSED_VALUE. 
svn path=/trunk/; revision=41704
 2012-03-21 03:19:31 +00:00
Chris Maynard 56b75184bb Fix Coverity CID 1379: UNUSED_VALUE. 
svn path=/trunk/; revision=41703
 2012-03-21 03:14:26 +00:00
Chris Maynard 1574813764 Fix Coverity CID's 1439-1448 OVERRUN_STATIC introduced with r41468. Also fix one additional dead store. 
svn path=/trunk/; revision=41702
 2012-03-21 03:04:15 +00:00
Jeff Morriss 1ee4c9e8a0 activate_link_cb() is only defined and used if we have GTK 2.18 or higher; only prototype it when we have GTK 2.18 or higher. 
svn path=/trunk/; revision=41701
 2012-03-21 02:42:11 +00:00
Chris Maynard f7980fd037 Delete a duplicate line of code. Fixes Coverity CID 1393: UNUSED VALUE. 
svn path=/trunk/; revision=41700
 2012-03-21 02:39:39 +00:00
Chris Maynard 66aa2c5b93 Add missing break between AECP_COMMAND_SET_NAME and AECP_COMMAND_GET_NAME cases. Fixes Coverity CID 1430: MISSING BREAK. 
svn path=/trunk/; revision=41699
 2012-03-21 01:27:22 +00:00
Jeff Morriss 075491702b welcome_if_tree_load() is static and only called (and prototyped) if we HAVE_LIBPCAP, so don't define the function unless we HAVE_LIBPCAP. 
svn path=/trunk/; revision=41698
 2012-03-21 01:22:40 +00:00
Chris Maynard 2cd37852f2 Fix a typo. 
svn path=/trunk/; revision=41697
 2012-03-21 00:47:32 +00:00
Guy Harris 4fe63c565d Well, it doesn't recurse with that code there, but it doesn't fill in 
the interface list box, either.  Remove the #if 0 for now.

svn path=/trunk/; revision=41696
 2012-03-21 00:44:41 +00:00
Guy Harris 7405ba8145 The chimney stuff is Windows-only (not that we shouldn't offer the 
ability to turn offloading off on UN*Xes as well...).

svn path=/trunk/; revision=41695
 2012-03-21 00:36:44 +00:00
Guy Harris d43d1c0a6f Recursion, n. See "recursion". 
svn path=/trunk/; revision=41694
 2012-03-21 00:16:13 +00:00
Guy Harris b551749d28 welcome_if_tree_load() is not used outside ui/gtk/main_welcome.c; make 
it static.

svn path=/trunk/; revision=41693
 2012-03-21 00:09:45 +00:00
Guy Harris e64375d187 #ifdef out some variables used only if we have libpcap. 
svn path=/trunk/; revision=41692
 2012-03-21 00:01:42 +00:00
Guy Harris d230d1663f Just put both clear_capture_box() and fill_capture_box() under one 
#ifdef HAVE_LIBPCAP/#endif.

svn path=/trunk/; revision=41691
 2012-03-20 23:37:23 +00:00
Anders Broman 24298dca48 See if this fixes the OSX build 
svn path=/trunk/; revision=41690
 2012-03-20 23:03:48 +00:00
Anders Broman 14e0bdf07e See if this fixes the OSX build 
svn path=/trunk/; revision=41689
 2012-03-20 22:43:44 +00:00
Anders Broman f246d95f88 make it compile on Windows, \main_welcome.c(1024) : warning C4700: uninitialized local variable 'error' used seems like a logical error, hidden by init to zero. Need proper fix 
svn path=/trunk/; revision=41688
 2012-03-20 22:40:10 +00:00
Michael Tüxen 26dd77f0af From Irene Ruengeler: Make sure we can remove all interfaces and can 
add local interfaces when there are none.
From me: Some whitespace cleanups.

svn path=/trunk/; revision=41687
 2012-03-20 21:13:28 +00:00
Anders Broman dc9a5254f4 From Yaniv Kaul: 
Enhance the Spice dissector to deal with VM name and UUID messages.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6971

svn path=/trunk/; revision=41686
 2012-03-20 16:03:30 +00:00
Anders Broman b959e9cd74 On behalf of Ericsson a dissector for output from a log tool. 
svn path=/trunk/; revision=41685
 2012-03-20 12:32:20 +00:00