Commit Graph

50377 Commits

Author SHA1 Message Date
Guy Harris 7c10c3d617 We need to link with the codecs library.
svn path=/trunk/; revision=53713
2013-12-02 09:06:00 +00:00
Guy Harris c123b131ae Make the declaration of stats_tree_format_as_str() match the definition.
svn path=/trunk/; revision=53712
2013-12-02 08:55:38 +00:00
Guy Harris 40b60cbf55 Do something less catastrophic than crashing if the same name is used in
two codec registrations.

svn path=/trunk/; revision=53711
2013-12-02 08:51:46 +00:00
Guy Harris 0cc1545d05 Move most of the plugin code from epan to wsutil and remove all
knowledge of particular types of plugins.  Instead, let particular types
of plugins register with the common plugin code, giving a name and a
routine to recognize that type of plugin.

In particular applications, only process the relevant plugin types.

Add a Makefile.common to the codecs directory.

svn path=/trunk/; revision=53710
2013-12-02 08:30:29 +00:00
Chris Maynard baf569188a Reject the packet if data is NULL.
svn path=/trunk/; revision=53709
2013-12-02 02:31:33 +00:00
Chris Maynard 9b38829b34 Reject the packet if data is NULL without doing anything else.
svn path=/trunk/; revision=53708
2013-12-02 02:31:04 +00:00
Chris Maynard acc5fd78e4 Reject the packet if data is NULL.
svn path=/trunk/; revision=53707
2013-12-02 02:18:21 +00:00
Chris Maynard 42a64c3557 If data is NULL, the bug, if any, is not with *this* dissector, but with whichever one failed to pass the data properly.
svn path=/trunk/; revision=53706
2013-12-02 02:07:42 +00:00
Chris Maynard a9900375b4 Fix Coverity CID 1134045: Printf format string issue. (As documented in the printf man page for the ' option, "Note that many versions of gcc(1) cannot parse this option and will issue a warning." (r47940 reverted a similar change, so this keeps things consistent.)
svn path=/trunk/; revision=53705
2013-12-02 01:53:13 +00:00
Chris Maynard 87d36305f9 Fix Coverity CID 1134046: Structurally dead code.
svn path=/trunk/; revision=53704
2013-12-02 00:45:44 +00:00
Jörg Mayer 70f4223c2a The changes to work around the msbuild deficiencies broke
dependeny tracking (replaced the list of dissectors by the file
containing the dissectors). Fix that.

svn path=/trunk/; revision=53703
2013-12-01 22:24:59 +00:00
Jörg Mayer 40c6d9abcb Copy over rev 53700 to cmake
svn path=/trunk/; revision=53702
2013-12-01 21:56:40 +00:00
Jörg Mayer 6a34c8c924 Small style changes.
svn path=/trunk/; revision=53701
2013-12-01 21:55:21 +00:00
Anders Broman 9baa93519c Update to V11.7.1 (2013-09)
svn path=/trunk/; revision=53700
2013-12-01 20:34:21 +00:00
Bill Meier eb8b50625a If we're including "config.h" when compiling a codec, then /I.. must be part of CFLAGS.
svn path=/trunk/; revision=53699
2013-12-01 16:50:05 +00:00
Michael Mann 0c9aa51ec5 Patch to include YAML export. Bug 9452 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9452)
From Deon van der Westhuysen
From me: use switch statements instead of if-else

svn path=/trunk/; revision=53698
2013-12-01 15:44:22 +00:00
Gerald Combs 98c8454dd6 [Automatic manuf, services and enterprise-numbers update for 2013-12-01]
svn path=/trunk/; revision=53695
2013-12-01 15:03:49 +00:00
Michael Mann 7ee8d48670 Add MPLS dissector to "ppp.protocol" table. Bug 9492 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9492)
From Peter Paluch

svn path=/trunk/; revision=53694
2013-12-01 13:47:11 +00:00
Jörg Mayer c0f974f9d1 Too litte modify in copy - modify - paste cycle
svn path=/trunk/; revision=53693
2013-12-01 10:58:17 +00:00
Jörg Mayer 38b8e4ecb9 Graham Bloice
- Using gtk[23] is a hack. Implement a clean solution.

Me
- In the current setup, building Qt ONLY is not supported as
  lots of required support libraries are only found in gtk2 and
  gtk3. Print an error in that case.
- Small style changes (lowercasing, whitespace)

svn path=/trunk/; revision=53692
2013-12-01 10:34:01 +00:00
Jörg Mayer 402df00544 Looks like the problem with redefined symbols is not new, it
just got a few new ones.
Add HAVE_STRING_H and HAVE_STDLIB_H to the list.

svn path=/trunk/; revision=53691
2013-12-01 10:10:24 +00:00
Jörg Mayer 244000000d - Rename PCAP_VERSION to WINPCAP_VERSION - the version of the underlying
pcap probably is different from the WinPcap version.
- Set WINPCAP_VERSION for cmake builds to "unknown"
- Oh, the NEWS file changed again.

svn path=/trunk/; revision=53690
2013-12-01 10:05:16 +00:00
Jörg Mayer 6cd4ad721f SBC -> sbc
On Unix case is relevant, so fix it.
Please try to avoid filenames starting with Upper case, it
makes completion so much easier as I only need to remember the
name and not the case.

svn path=/trunk/; revision=53689
2013-12-01 09:18:19 +00:00
Martin Mathieson a9bd097e71 Start teid_data field from the correct offset
svn path=/trunk/; revision=53688
2013-12-01 08:52:06 +00:00
Martin Mathieson da7af5c1f7 Also add filter and expert info for ICMPv6 requests with no responses.
svn path=/trunk/; revision=53687
2013-12-01 08:51:07 +00:00
Michael Mann 9972e5f24a Move codecs.[ch] out of epan and into codecs directory.
This may break easy_codec plugins, but it appears a better/more consistent way is needed to register codecs.  See Guy's comments in bug 7893 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893)

svn path=/trunk/; revision=53686
2013-12-01 03:53:57 +00:00
Gerald Combs 4e2b6b13f6 Use 4-space (PEP 8) indentation. Add modelines.
svn path=/trunk/; revision=53685
2013-12-01 01:53:26 +00:00
Gerald Combs c02bbf9883 Use indentation recommended by PEP 8.
svn path=/trunk/; revision=53684
2013-12-01 01:46:45 +00:00
Gerald Combs 80b4bc004a Fix compatibility with Python 2.5. Tested with 2.5, 2.6, 2.7, and 3.3.
svn path=/trunk/; revision=53683
2013-12-01 01:35:13 +00:00
Jörg Mayer e30fd2f989 Looks like the WinPcap version can only be determined from the
name of the compressed archive - which currently means "only by
manual developer intervention".

svn path=/trunk/; revision=53682
2013-11-30 23:40:25 +00:00
Guy Harris fbaac2cf8b The HAVE_xxx definitions come from config.h; include it.
svn path=/trunk/; revision=53681
2013-11-30 22:17:15 +00:00
Guy Harris 8bdf0ad409 Tag arguments to decodeXXX routines as unused iff we don't support the
codec.

svn path=/trunk/; revision=53680
2013-11-30 22:16:09 +00:00
Michael Mann ac9b982868 Better fix for uninitialized variable warning. Part of bug 9452 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9452)
From Peter Wu.
From me: Leave the "result" variable initialized because I'm not sure code analyzers will consider g_assert_not_reached() enough prevention from using uninitialized "result"

svn path=/trunk/; revision=53679
2013-11-30 21:00:21 +00:00
Michael Mann fd2f05446d Update documentation for tcp_dissect_pdus. Bug 9491 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9491)
From Peter Wu: update to README.dissector
From me: update to WSDG_chapter_dissection.xml

svn path=/trunk/; revision=53678
2013-11-30 20:48:46 +00:00
Michael Mann e2d2d12098 Replace "btsdp" tap with function to query service_infos tree, since that's all dissectors were doing with it. Not used outside of dissectors and cuts down on a few redundant global variables.
svn path=/trunk/; revision=53677
2013-11-30 19:26:18 +00:00
Michael Mann d1e4422a4a Add G.722, G.726 and SBC codecs. G.722 and G.726 are from bug 5619 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5619) and SBC is from bug 7893 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893).
Codecs are added, but (intentionally) not hooked to the RTP player as a "more generic architecture" is desired.  There are some discussions in bug 7893 on how to do this.  One thing to add would be how to handle codecs that may not be supported on all platforms.  Should the codec not be "registered" at all (with a #define over the whole module) or should it's register functions be stubbed (with a #define in each function that requires a non-supported library)

svn path=/trunk/; revision=53676
2013-11-30 15:42:14 +00:00
Pascal Quantin 021efe411c Try to please GCC 4.3.2
svn path=/trunk/; revision=53675
2013-11-30 12:31:36 +00:00
Guy Harris d62b116380 Make the code testing the Rx MCS Bitmask subfield of the Supported MCS
Set field of the HT Capabilities element a bit clearer, and add
comments.

Fix it so it doesn't assign a variable to itself, as clang warns about
that.

svn path=/trunk/; revision=53674
2013-11-30 10:17:30 +00:00
Pascal Quantin 4e3d8291fe From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9490 :
Couple packets in RTPproxy dissector not only with CookieID but also with Call-IDs

svn path=/trunk/; revision=53673
2013-11-30 09:50:04 +00:00
Pascal Quantin 8b179962d5 Update release notes
svn path=/trunk/; revision=53672
2013-11-30 08:30:04 +00:00
Michael Mann 0e669d534d README update. Bug 9174 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9174)
From Peter Wu

svn path=/trunk/; revision=53671
2013-11-30 01:50:12 +00:00
Michael Mann e1532f39ec Tx MCS set is not interpreted properly in WLAN beacon frame. Bug 8894 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8894)
#BACKPORT

svn path=/trunk/; revision=53670
2013-11-30 01:35:03 +00:00
Michael Mann 6d3d1556dc STANAG 5066 DTS Layer dissector. Bug 9217 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9217)
From İbrahim Can Yüce

From me: Update to new tcp_dissect_pdus format, minor whitespace issues noticed in wiretap files.

svn path=/trunk/; revision=53669
2013-11-30 01:18:22 +00:00
Guy Harris e52bce9f1f Fix indentation.
svn path=/trunk/; revision=53668
2013-11-30 00:53:03 +00:00
Michael Mann 00737f834b Add wifi display port to the RTSP dissector. Bug 9339 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9339)
From chaitanya

From me: Add another obsolete preference and cleanup whitespace

svn path=/trunk/; revision=53667
2013-11-30 00:30:56 +00:00
Guy Harris c6efc227a5 Strings are usually unwritable; squelch "constness is being assigned
away" warnings.

svn path=/trunk/; revision=53666
2013-11-30 00:10:18 +00:00
Guy Harris 8c338ea543 Squelch a "parentheses suggested" warning.
Casts from void * are required in C++.

svn path=/trunk/; revision=53665
2013-11-30 00:07:15 +00:00
Guy Harris 216f631e8a Casts required from void * in C++.
svn path=/trunk/; revision=53664
2013-11-30 00:05:24 +00:00
Guy Harris 1d80b1e16c Constify to squelch some warnings.
svn path=/trunk/; revision=53663
2013-11-30 00:02:46 +00:00
Guy Harris 52cfff996e Squelch some "use parentheses" warnings.
Use tab indentation uniformly.

svn path=/trunk/; revision=53662
2013-11-29 23:57:23 +00:00