osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
34,331 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

34331 Commits

Author SHA1 Message Date
Jeff Morriss 7be63e199b Add (commented-out for now) code to check certain function calls for embedded 
(in the argument list) calls to tvb_get_ptr().

svn path=/trunk/; revision=35906
 2011-02-10 22:53:48 +00:00
Jeff Morriss b1d4ef8851 Use tvb_ip_to_str() and tvb_ether_to_str(). 
svn path=/trunk/; revision=35905
 2011-02-10 22:14:05 +00:00
Jeff Morriss b58b5b5c67 Pass NULL as the value_ptr to proto_tree_add_bytes_format(). 
Simplify the code a bit since tvb_ensure_bytes_exist() was already throwing
an exception if all the bytes weren't there.

Use tvb_ether_to_str().

svn path=/trunk/; revision=35904
 2011-02-10 22:07:29 +00:00
Anders Broman 61515ab830 From Alexis La Goutte: 
Cleanup 802.11 Dissector :Enhance SSID, Supported Rates, DS, FH, CFP.. Information Element sub dissector 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=35903
 2011-02-10 21:45:36 +00:00
Chris Maynard 8d47cebd00 Declare ett's as gint, not guint. 
svn path=/trunk/; revision=35902
 2011-02-10 20:55:26 +00:00
Guy Harris e2bdef175d Add the rest of the changes from the patch in bug 5924. Squelches some 
compiler warnings.

svn path=/trunk/; revision=35901
 2011-02-10 20:27:35 +00:00
Gerald Combs ceb650ecee #ifdef → #ifndef. 
svn path=/trunk/; revision=35900
 2011-02-10 20:15:31 +00:00
Gerald Combs 66281f8744 Mark a parameter unused if needed. 
svn path=/trunk/; revision=35899
 2011-02-10 19:50:05 +00:00
Guy Harris d63741d566 Add some information based on a Tektronix manual whose name popped up in 
an email I found when looking for some other stuff and which I then
found with a Google search.

svn path=/trunk/; revision=35898
 2011-02-10 18:27:39 +00:00
Gerald Combs fb3055d41a Remove a bunch of prototypes in airpcap_dlg.h for functions which are 
now static. Make another function static.

svn path=/trunk/; revision=35897
 2011-02-10 17:09:36 +00:00
Jeff Morriss 50e1634f4c Modify proto_tree_add_bytes_format() and proto_tree_add_bytes_format_value() 
so that if the start_ptr is NULL the bytes are extracted from the given TVB
using the given offset and length.

Replace a bunch of:

proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, tvb_get_ptr(tvb, offset, length), [...])

with:

proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, NULL, [...])

svn path=/trunk/; revision=35896
 2011-02-10 16:31:00 +00:00
Michael Tüxen 7154ed5689 Obtained from Thomas Dreibholz: Update SCTP PPIDs. 
svn path=/trunk/; revision=35895
 2011-02-10 12:54:20 +00:00
Stig Bjørlykke 1ba57f4c04 Added a dissector table for AttributeId localForm. 
Use correct object identifier in ModificationList.

svn path=/trunk/; revision=35894
 2011-02-10 10:11:38 +00:00
Anders Broman 60297df554 - Add message name to info col in case of SERVICE REQUEST. 
- Get rid of check_col
- proto_tree_add_item -> ENC_BIG_ENDIAN

svn path=/trunk/; revision=35893
 2011-02-10 08:28:18 +00:00
Jeff Morriss a67d2b9bf7 Use tvb_bytes_to_str_punct() instead of a homegrown version. 
svn path=/trunk/; revision=35892
 2011-02-09 22:43:06 +00:00
Jeff Morriss 685c29d386 Use tvb_bytes_to_str_punct() instead of bytestring_to_str(tvb_get_ptr(), ...) 
svn path=/trunk/; revision=35891
 2011-02-09 22:37:26 +00:00
Jeff Morriss 1d396a69e0 Register ett_gtp_bcm. 
Replace some tabs with spaces.


svn path=/trunk/; revision=35890
 2011-02-09 18:45:32 +00:00
Jaap Keuter 4ac0559b63 From Grzegorz Szczytowski: 
Update of packet-e212.c dissector according to local national regulatory 
MNC assignment document.
www.uke.gov.pl/uke/redir.jsp?place=galleryStats&id=24439

svn path=/trunk/; revision=35889
 2011-02-09 08:46:21 +00:00
Jaap Keuter 814ddc15a3 Accommodate the CMake build on Ubuntu 10.10. 
svn path=/trunk/; revision=35888
 2011-02-09 07:43:34 +00:00
Jeff Morriss 13d8e41e0f A couple of dissectors have/need an NTP-to-nstime routine, so put it in 
packet-ntp and export it to the other dissectors.

Move some macros (now) only used in packet-ntp.c into that file.

svn path=/trunk/; revision=35887
 2011-02-09 03:24:12 +00:00
Jeff Morriss 92cd49b4c2 Rename ntp_fmt_ts() to tvb_ntp_fmt_ts() and make it take a pointer to a TVB and 
an offset instead of (generally) a pointer into the TVB. Then use the standard
accessor functions to get data out of the TVB.


svn path=/trunk/; revision=35886
 2011-02-09 03:00:51 +00:00
Jeff Morriss 5d3a4a06bc Rewrite this dissector's NTP-to-nstime routine to take a TVB and an offset 
instead of a pointer into the TVB.  Then use the standard accessor functions
to get data out of the TVB.


svn path=/trunk/; revision=35885
 2011-02-09 02:54:12 +00:00
Jeff Morriss 69b78fc118 Document that NTP times can be added with proto_tree_add_item(). 
svn path=/trunk/; revision=35884
 2011-02-09 02:43:10 +00:00
Jeff Morriss a527fa4b49 Add NTP times using proto_tree_add_item(). 
Replace a couple not-very-descriptive blurbs with NULL.

svn path=/trunk/; revision=35883
 2011-02-09 02:27:41 +00:00
Anders Broman 87aaac83ce From Holger Freyther: 
Fix the GSMTAP to TETRA table

GSMTAP has the BSCH at 1... this means the table needs to have 9 entries, the
first being 0. 


--------------------------------------------------------------------------------

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5659

svn path=/trunk/; revision=35882
 2011-02-08 22:01:33 +00:00
Jeff Morriss a2fc2ef5e2 Add 3GPP Requesting-Node-Type AVP: it's old but apparently still out there. 
svn path=/trunk/; revision=35881
 2011-02-08 17:45:34 +00:00
Anders Broman 771445d49a from Václav Horčák: 
Bug 5663 - [PATCH] Fix for MEGACO dissector context tracking.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5663

svn path=/trunk/; revision=35880
 2011-02-08 12:33:34 +00:00
Anders Broman 211e3a1eef - Use ENC_BIG_ENDIAN. 
- GSM_A_PDU_TYPE_BSSMAP.

svn path=/trunk/; revision=35879
 2011-02-08 12:32:34 +00:00
Guy Harris fd941f3906 Don't look at any of the fields that come from the Auxiliary Security 
Header unless there *is* an Auxiliary Security Header.

svn path=/trunk/; revision=35878
 2011-02-08 06:55:53 +00:00
Stephen Fisher cf5aeb0c4c Fix compilation problem for GTK+ < 2.18 
graph_analysis.c(1450): error C2039: 'allocation' : is not a member of
'_GtkStyle'


svn path=/trunk/; revision=35877
 2011-02-08 04:12:09 +00:00
Jeff Morriss 045037dc71 Add NTP times using proto_tree_add_item(). 
svn path=/trunk/; revision=35876
 2011-02-08 03:16:35 +00:00
Jeff Morriss b87a80f196 Add support for 4-byte NTP times (only the seconds) in proto_tree_add_item(). 
Use it in packet-diameter.c .  Eliminate an unnecessary local variable.

svn path=/trunk/; revision=35875
 2011-02-08 02:38:51 +00:00
Guy Harris 7e6b4ad3a3 Build with pre-2.18 GTK+es. 
svn path=/trunk/; revision=35874
 2011-02-08 01:48:07 +00:00
Bill Meier e3ae028064 Rename some hf_... vars so name starts with hf_docsis_cmstatus 
svn path=/trunk/; revision=35873
 2011-02-08 01:15:44 +00:00
Stephen Fisher e53853bea0 More -DGSEAL_ENABLE cleanup in preparation for GTK+ 3.0... 
svn path=/trunk/; revision=35872
 2011-02-08 01:01:50 +00:00
Guy Harris 9d6671bbab The checkAPI script doesn't understand arrays of value_string tables, 
and that flavor of two-dimensional array requires you to declare a
maximum size for the value_string tables in the array.  Don't use an
array of value_string tables.

svn path=/trunk/; revision=35871
 2011-02-08 00:57:21 +00:00
Stephen Fisher 09c49ac78c More -DGSEAL_ENABLE cleanup (hopefully without breaking anything)... 
svn path=/trunk/; revision=35870
 2011-02-08 00:56:22 +00:00
Bill Meier 7eb1530061 #if 0 code related to unused "docsis" dissector table; 
Use consistent indentation & other whitespace cleanup.

svn path=/trunk/; revision=35869
 2011-02-08 00:24:10 +00:00
Stephen Fisher 68b0cd7030 Fix bug #5657: Update my mail address 
svn path=/trunk/; revision=35868
 2011-02-07 23:14:54 +00:00
Jaap Keuter d265580072 From Masashi Honma: 
Currently the Wireshark does not support Primary Device Type dissection. 
I made a patch for the dissection based on "Wi-Fi Simple Configuration 
Specification DRAFT Version 2.0.0.51".

svn path=/trunk/; revision=35867
 2011-02-07 22:47:43 +00:00
Jaap Keuter 3312fc1bfe From Hendrik Robbel: 
Dissector for DOCSIS 3.0 CM-STATUS Report Messages.

svn path=/trunk/; revision=35866
 2011-02-07 22:19:38 +00:00
Jaap Keuter 104d4d80a2 Fix parameters to gtk_widget_get_allocation() call. 
svn path=/trunk/; revision=35865
 2011-02-07 22:11:14 +00:00
Anders Broman 42145f2e7c from Holger Freyther: 
gsmtap: Update header file, add tetra support

0001 Minor cleanup - made it look crocked in visual studio, changed bu hand.
0002 Update the definitions from the 'upstream' source 
0003 First bits of tetra decoding included in GSMTAP 
0004 Pass the tetra PDUs to the TETRA decoder 

Changed def. of gsmtap_to_tetra to make it compile.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5659

svn path=/trunk/; revision=35864
 2011-02-07 21:38:55 +00:00
Anders Broman 1d7c05c898 From Alexis La Goutte: 
Cleanup 802.11 Dissector : Enhance add_tagged_field (and sub tagged field dissector)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=35863
 2011-02-07 20:50:13 +00:00
Gerald Combs c257693621 Switch from GtkCList (which is deprecated) to GtkTreeView+GtkListStore. 
Make a bunch of functions static. Get rid of a no-longer-necessary
struct. Clean up other parts of the code.

svn path=/trunk/; revision=35862
 2011-02-07 20:24:42 +00:00
Guy Harris 4efa18be22 Similar corrections here. 
svn path=/trunk/; revision=35861
 2011-02-07 19:43:18 +00:00
Guy Harris c66802f606 Fix typo. 
svn path=/trunk/; revision=35856
 2011-02-07 19:39:05 +00:00
Gerald Combs 6e66cae876 Check for a large packet_len. Fixes a bug reported by Huzaifa 
Sidhpurwala of the Red Hat Security Response Team.

See also: bug 5661.

svn path=/trunk/; revision=35855
 2011-02-07 19:39:05 +00:00
Guy Harris e895aa9ddf "XXX takes a foo * as an argument" != "pass a variable of type foo * to 
XXX"; in the case of gtk_widget_get_allocation(), you have to pass it a
pointer to a variable of type foo, where foo = GtkAllocation.

The same applies to the pre-GTK-2.18 code.

svn path=/trunk/; revision=35854
 2011-02-07 19:37:51 +00:00
Stephen Fisher 3ef2acd516 More -DGSEAL_ENABLE cleanup in preparation for GTK+ 3 
svn path=/trunk/; revision=35853
 2011-02-07 19:24:26 +00:00