We keep our various packaging assets in the "packaging" directory. Move
the Debian assets there. dpkg-buildpackage doesn't seem appear to have a
"debian directory path" option, but symlinking worked in my test
container.
packet-signal-pdu.c:2265:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
packet-signal-pdu.c:2268:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
packet-signal-pdu.c:2271:17: warning: Value stored to 'ti' is never read [deadcode.DeadStores]
Calling setCurrentIndex with QItemSelectionModel::ClearAndSelect clears
the currentIndex, but not the selection, so it doesn't trigger
selectionChanged. However, highlighting depends on the selectionChanged
signal, not currentChanged(), and it's not emitted if we're still on the
same packet/row as the current selection (which can occur if searching
for something that occurs in exactly one packet in a capture.)
Since packet_list_select_row_from_data() cares about where the data
is within the packet, it needs to clear the selection. Fix#8269
Add a checkbox to the packet format group box to allow the
hexdump to only have the main frame instead of secondary data
sources as well, so that Print and Export Packet Dissections can
be used for input to text2pcap.
Since nextseq is incremented by an extra one byte for SYN/FIN packets,
the out-of-order check should take that into account. Otherwise an
immediately retransmitted SYN or FIN is treated as a retransmission.
Related to #13843.
Add comments to indicate what types of display information various field
types are allowed.
Make the error messages for fields that only allow some particular
display information types specific to those types, rather than saying
"no field information allowed". This also gets rid of some
fallthroughs, one of which allows BASE_PROTOCOL_INFO for floating-point
types, which makes no sense.
Show missing sequence numbers with from and to instead of listing
every number in the range as generated fields.
Bonus: explicitly show the range delimiter.
Fixes: #17932
The fix for #17926 got the check backwards, so non-empty arrays, sets,
and bags couldn't be dissected, as they'd always report a "zero-length
item" error. Both versions of the check dissect zero-length items, as
they test for equality, but the old version thought that a
non-zero-length item was also bad, as the offset was greater after
dissecting the item than before dissecting the item.
Gerald Combs