Change-Id: Ic46acac05638bf59910e3cb0986ed14b2257ed55
Reviewed-on: https://code.wireshark.org/review/7483
Reviewed-by: Michael Mann <mmann78@netscape.net>
Thanks to Vlad Tsyrklevich for the report, and Fabian Yamaguchi for the "joern"
tool which found the bug.
Bug: 11023
Change-Id: I53bc998c9934736698e7db5eba09a14e79a7c633
Reviewed-on: https://code.wireshark.org/review/7461
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Decode as far as possible AT commands according to
specifications: HFP 1.6
Change-Id: Ib2cee4df4d9338cc98f28e0fadd067378fba63a9
Reviewed-on: https://code.wireshark.org/review/7472
Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Add ability to jumps to connect or disconnect frame from any frame
binded to specific PSM session, what should improves analyse by user.
Change-Id: Icdf6634bf128ba83721d39cf8986cf16bfb4e7a4
Reviewed-on: https://code.wireshark.org/review/7470
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
X11 can't handle pixmaps more than 32k pixels wide so don't try to feed it
one. This avoids crashes with the complaint "BadAlloc (insufficient
resources for operation)". Instead we simply truncate the graph (and tell the
user). Do this in a way that shows the user the empty portion of the graph.
Hopefully the Qt port can fix this properly.
Note: the bug report says that MacOS is not affected but it should be. So
apply this fix for all on-Windows systems.
Bug: 2630
Change-Id: I71e1bd2f9a62792db06ce887e2bbe7a96d110e0a
Reviewed-on: https://code.wireshark.org/review/7464
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
We only store the last name added (i.e., the last alias) which is the
opposite of what the name resolver does (it returns the first name in the
hosts file).
Just comment the code out for now with a comment explaining why. Maybe some
day we'll have a reason to store the aliases.
Change-Id: I560ac05868a429d31e9d41f3a34af36c4fca1f6c
Reviewed-on: https://code.wireshark.org/review/7466
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Move the "find the frame" stuff to openPacketDialog(), and don't even
bother creating a new PacketDialog if we don't find the frame. This
should squelch Coverity CID 1270934, by giving up quickly if fdata is
null.
Change-Id: I4605ba7e271a55724f02cafed4122f9dd9b1b6f7
Reviewed-on: https://code.wireshark.org/review/7467
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This seems to break the build on OSX 10.5 (?)
This reverts commit b46bd2c7798d1c9e808625250928b40adf11a8bb.
Change-Id: I720de7182804c5c669934e3514e789f2da066867
Reviewed-on: https://code.wireshark.org/review/7459
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Change-Id: If87d6b55cc733ff35a3648860b4559a7082a19b0
Reviewed-on: https://code.wireshark.org/review/7458
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Change-Id: I0c9cc5d574fdd73ecf1f8b32dbbf0ddb2b885116
Reviewed-on: https://code.wireshark.org/review/7437
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Change-Id: I87233df8fc17ac0aca0d9daefcebd95f47699808
Reviewed-on: https://code.wireshark.org/review/7450
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
We don't want to have to change the pcap-ng file against which we
compare, so we hardcode the year here to be the same as the year from
the pcap-ng capture.
Change-Id: Ibd83d06e035341f617b8285f6ba51c749c38a177
Reviewed-on: https://code.wireshark.org/review/7448
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Create TIMEDEFV10() and, for it and for V20, V21, and V22, undefine the
ones used for the read routine and define dummy ones for the read-seek
routines (as those record formats have relative, not absolute, times).
Have all of them set presence_flags.
That way:
1) if we *can* set the time stamps in the seek-read routine, we do;
2) we always set presence_flags in read and seek-read routines.
Change-Id: I837507245e8a0cbc68c7c5fd8365f474d085488e
Reviewed-on: https://code.wireshark.org/review/7445
Reviewed-by: Guy Harris <guy@alum.mit.edu>
No need to try to construct an IEEE floating-point number by hand, piece
by piece; just sign-extend the value to 32 bits, convert that integral
value to a floating-point value, and divide the result by 32768 to
properly scale the value.
(Yes, in practice, the chances are overwhelming that we'll be running on
a machine with IEEE floating point - people probably won't be running us
on a VAX, and the UN*Xes on which we're likely to run on a System/3x0 or
z/Architecture machine require, and use, the new IEEE floating-point
capabilities - but no need to be gratuitiously non-portable.)
Change-Id: Ie90a61847e68c3b849de2984139a97004a4ad659
Reviewed-on: https://code.wireshark.org/review/7444
Reviewed-by: Guy Harris <guy@alum.mit.edu>
The API checks warn about it being deprecated - that doesn't seem to
cause a problem with the buildbot, but does result in failures from the
Petri dish. Format the first and last packet time in an ISO 8601-style
format.
Call them "First packet time" and "Last packet time", rather than "Start
time" and "End time", as they're not necessarily the times when the
capture started or ended.
(Both make the output a bit more like the Statistics -> Summary window.)
Change-Id: Ibf02999851f49c7951c6f6152c70efa271414bd9
Reviewed-on: https://code.wireshark.org/review/7442
Reviewed-by: Guy Harris <guy@alum.mit.edu>
time_t suffices in that case.
Change-Id: Ica7a79fb6f8c7cc7fb6decd5fcd391dccfdb3fc6
Reviewed-on: https://code.wireshark.org/review/7440
Reviewed-by: Guy Harris <guy@alum.mit.edu>
openSAFETY 1.5 will be the next version of the openSAFETY
protocol. This will include all renditions necessary for
future versions of the IEC 61784-3 specifications.
- SNMT service for CT preseeding
- 40 bit counter value flag support
- Adapt CRC calculation for 40bit counter
- Display 40bit counter value
Change-Id: Ia9f8e11de813d27bc14437d32ee3d0486810c634
Reviewed-on: https://code.wireshark.org/review/5728
Reviewed-by: Roland Knall <rknall@gmail.com>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Use nstime_t rather than struct timeval when we want
seconds-and-fractions, so that, when writing the file, we can handle
nanosecond-resolution time stamps. Calculate the relative time stamp as
a 64-bit integer rather than using floating-point.
Use time_t rather than struct timeval if we only want seconds.
Have the routines that write out 16-bit and 32-bit numbers convert them
to little-endian themselves, rather than having to be passed a
little-endian number.
Have a routine that writes out 48-bit values in little-endian order, and
use that to write out packet time stamps.
Change-Id: Ia6e047079e48915647502178e0a1c61177010c62
Reviewed-on: https://code.wireshark.org/review/7438
Reviewed-by: Guy Harris <guy@alum.mit.edu>
We never use it; the autoconf script does, but that's as a result of
some macros that checks for various standard and non-standard-but-common
headers. It's been ages since strings.h was anything other than a BSD
source-compatibility hack, not even needed these days when writing code
for *BSD-flavored OSes, as they have <string.h>.
Change-Id: Iad2dc6e55207b52fc8af494ddfca4089c2eb426b
Reviewed-on: https://code.wireshark.org/review/7434
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Don't include <memory.h> when using memcpy(), include <string.h>.
We don't need to check for memory.h, so don't do it in CMake (we don't
explicitly check for it in autoconf, but it's checked for by some macro
we do use).
Change-Id: I7aa93d4ea93bab9beff597939d3c24aecda3d52e
Reviewed-on: https://code.wireshark.org/review/7433
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This may fix a compile warning-turned-error on an old version of SLES that
Anders reported.
Change-Id: I72e5dec00bc0088cd77a206284221cb43ae89547
Reviewed-on: https://code.wireshark.org/review/7429
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Also fix up some formatting.
Change-Id: I3348179626e97daaddfbc89e3ed21e39915e3de4
Reviewed-on: https://code.wireshark.org/review/7423
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
These gethostbyaddr() calls should be changed to getaddrinfo() but only in
master.
Change-Id: I7e2d31ceb0e072beb7f324336d7b145c3adbe3a0
Reviewed-on: https://code.wireshark.org/review/7402
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Add an "Auto Scroll in Live Capture" action to the Go menu. It's in the
View menu in the GTK+ UI but it seems to make more sense as a navigation
item.
Use a timeout interval for automatic scrolling. I haven't run any tests
to see if this makes a difference but it would seem that the less
drawing we do during a high speed capture the better, particularly for
remote displays.
Update the x-stay-last icons.
Note that we might want to make prefs.capture_auto_scroll a "recent"
setting.
Mark auto_scroll_live and packet_list_check_end GTK+ only.
Bug: 10601
Co-authored-by: Gerald Combs <gerald@wireshark.org>
Change-Id: I645d27c0814f0e4a0d5b01ae68be366847e2522d
Reviewed-on: https://code.wireshark.org/review/7292
Reviewed-by: Gerald Combs <gerald@wireshark.org>
This fixes Windows build in cases when MSVS is installed in non-default
directory.
Change-Id: I9cfa3f728d64e9d5952c68b2b2b70e627d3f5c3e
Reviewed-on: https://code.wireshark.org/review/7426
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Previously, the version field was being dissected as flags.
Change-Id: Ic7d5fd6262e844c9e578dbc29cd5b6e40078ae9f
Signed-off-by: Sean O. Stalley <sean.stalley@intel.com>
Reviewed-on: https://code.wireshark.org/review/7398
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Iso fields in a MA USB header are now dissected,
instead of treating them as non-iso fields.
Change-Id: I13c9ba5b0c54ef0b5130c2e87c7de3de9dbe9e22
Signed-off-by: Sean O. Stalley <sean.stalley@intel.com>
Reviewed-on: https://code.wireshark.org/review/7397
Reviewed-by: Michael Mann <mmann78@netscape.net>
Type-specific subfields of CancelTransferReq/Resp are now dissected.
Change-Id: I0f03e14df936409125b263409de605dde96d53c0
Signed-off-by: Sean O. Stalley <sean.stalley@intel.com>
Reviewed-on: https://code.wireshark.org/review/7396
Reviewed-by: Michael Mann <mmann78@netscape.net>
Packet type values are now consistant with spec.
Also, values in enum mausb_pkt_type are now consistant with
mausb_type_string array.
Change-Id: I515332bdbc1d1f06bd03e3da314c44d7e842f2f9
Signed-off-by: Sean O. Stalley <sean.stalley@intel.com>
Reviewed-on: https://code.wireshark.org/review/7395
Reviewed-by: Michael Mann <mmann78@netscape.net>
These calls were all getting ether addresses which can be gotten by other means.
Change-Id: I9a3d564483c9ee9b8e5183bb9086da8a315c41fc
Reviewed-on: https://code.wireshark.org/review/7421
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Change-Id: Ibc5a51be462d431b85b34cac7a358d736ec7b9db
Reviewed-on: https://code.wireshark.org/review/7422
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
In this case, sometimes we step through the buffer and sometimes we
don't, so we always use strlen(); use a separate pointer when we're
stepping through the buffer.
Change-Id: Id69898760b4c255146c6eae0ab44c1d358c9ccbd
Reviewed-on: https://code.wireshark.org/review/7425
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Either they don't have a pointer into the buffer that they advance, in
which case strlen(buf)+1 works just fine, or they do, in which case
1) they'd better save the pointer to the beginning of the
buffer, so they can figure out how long the string is when
they're done
and
2) they don't need to use strlen(), they can just subtract the
pointers.
Bug: 11016
Change-Id: I81ce9d517336a15bd81f0c6225756ce5178ec6cf
Reviewed-on: https://code.wireshark.org/review/7424
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Add dissectors for IPv6-related IPMI LAN configuration parameters.
Bug:11012
Change-Id: I9b7380d2451acb6d68a03361e26dc3a6ebc129a0
Reviewed-on: https://code.wireshark.org/review/7404
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
The code in question was copied from ui/gtk/capture_file_dlg.c. The dead
assignment there was removed in 68ceffe.
Change-Id: I605f181b623fbd87ab41505d30a79d7a4fe649df
Reviewed-on: https://code.wireshark.org/review/7419
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Dario Lombardo