Commit Graph

9979 Commits

Author SHA1 Message Date
Jörg Mayer 75028e85b4 Bytes should be read with tvb_get_guint8 instead of _ntohs (spotted by Ulf Lamping)
svn path=/trunk/; revision=10076
2004-02-17 10:03:47 +00:00
Guy Harris 2769961d38 Squelch a signed vs. unsigned comparison complaint.
svn path=/trunk/; revision=10075
2004-02-16 20:58:03 +00:00
Ulf Lamping 55e5bb39e9 bugfix from greg morris: two help pages were missing
svn path=/trunk/; revision=10074
2004-02-16 19:07:10 +00:00
Ulf Lamping c01339acd3 bugfix: don't write the recent files list in the wrong order to the recent file
svn path=/trunk/; revision=10073
2004-02-16 19:00:09 +00:00
Olivier Biot fa18c62047 Use col_append_sep_str() instead of col_append_str().
svn path=/trunk/; revision=10072
2004-02-16 18:47:57 +00:00
Ronnie Sahlberg 126383282c From Tomas Kukosa, add a PER helper to dissect BITSTRINGS
svn path=/trunk/; revision=10071
2004-02-16 18:31:40 +00:00
Ronnie Sahlberg 4ddc0aa0b2 Update to fix the bug reported by Zhao, Allen Weitao
using the fix proposed by Tomas Kukosa.

There were a number of dissect_per_choice() calls where the hf field passed
to it were of the wrong type, i.e. not FT_UINT32.

All these instances have been updated to use FT_UINT32.

svn path=/trunk/; revision=10070
2004-02-16 18:23:25 +00:00
Jörg Mayer 462c710e81 Edwin Calo: Extract strings from a postgres datastream
svn path=/trunk/; revision=10069
2004-02-16 16:49:13 +00:00
Jörg Mayer faca48c631 Edwin Calo: Extract strings from a postgres datastream
svn path=/trunk/; revision=10068
2004-02-16 13:30:05 +00:00
Ronnie Sahlberg ec5e89463b Update to kpasswd so that it calls the kerberos dissector to dissect the
AP-REQ and KRB-PRIV ans.1 encoded kerberos blobs

KRB-PRIV (application 21) is not yet supported/handled by the existing kerberos dissector
but will be after next release when the new one makes it test run.

svn path=/trunk/; revision=10067
2004-02-16 09:42:10 +00:00
Jörg Mayer 77137d3263 Put a prominent note at the top that the actual function descriptions can
be found in epan/tvbuff.h

svn path=/trunk/; revision=10066
2004-02-15 07:35:35 +00:00
Guy Harris 8026255c08 Update Andreas Sikkema's e-mail address.
svn path=/trunk/; revision=10065
2004-02-14 22:48:53 +00:00
Guy Harris b50c9c75af Update Andreas Sikkema's e-mail address.
svn path=/trunk/; revision=10064
2004-02-14 22:25:26 +00:00
Guy Harris 621ea65558 From Pavel Kankovsky: fix the name of the channel field in the Prism
802.11 radio header.

svn path=/trunk/; revision=10063
2004-02-14 20:55:24 +00:00
Olivier Biot d5afa61037 Update the Info column.
svn path=/trunk/; revision=10062
2004-02-14 11:13:16 +00:00
Olivier Biot 6bd7b570b5 Add a note on white space conventions (tab expansion different from 8 spaces is
a Bad Idea).

Add a note on the new col_append_sep_str() and col_append_sep_fstr() methods.

svn path=/trunk/; revision=10061
2004-02-14 10:37:22 +00:00
Guy Harris 027cf5a574 From Anders Broman: fix the offsets usd when adding the manufacturer info.
svn path=/trunk/; revision=10060
2004-02-13 19:33:14 +00:00
Guy Harris b5881ce528 Get rid of unused variables and #defines.
svn path=/trunk/; revision=10059
2004-02-13 19:19:13 +00:00
Guy Harris 95d801711b From Alastair Maw: fix DTMF and call transfer dissection.
svn path=/trunk/; revision=10058
2004-02-13 19:15:38 +00:00
Guy Harris 1ca41683a0 Now that Ethereal *itself* (not just Wiretap) can use libz (the Soulseek
dissector can use it), we have to link Ethereal, Tethereal, and dftest
with libz, as well as linking Wiretap with it.

We also probably need to link dftest with the PCRE library, as the
display filter code uses PCRE.

svn path=/trunk/; revision=10057
2004-02-13 02:03:14 +00:00
Guy Harris 75acdcbba0 As noted by Pavel Kankovsky, the "Resolve Name" menu items should be
available if *any* forms of name resolution aren't enabled.  (Well,
actually, it should probably affect only the item the mouse was over
when you selected it, and should be available if name resolution for
that type of name isn't enabled, but....)

svn path=/trunk/; revision=10056
2004-02-13 01:09:52 +00:00
Guy Harris a1667bf2c0 The Help window should be a separate top-level window, not a dialog
subordinate to the main window - it's a separate top-level window in
W2K, Mac OS X, and, I think, both GNOME and KDE.

svn path=/trunk/; revision=10055
2004-02-13 00:56:30 +00:00
Guy Harris 36ece5a17a Add a "window_new()" routine that creates a window of a given type, sets
the title, and arranges to set the icon for it.  Use that instead of
"gtk_window_new()" and separate calls to set the title and arrange to
set the icon.

Regularize #includes a bit.

Clean up white space.

svn path=/trunk/; revision=10054
2004-02-13 00:53:37 +00:00
Guy Harris 5f27347dfa Create only one "Plugins" window per process.
svn path=/trunk/; revision=10053
2004-02-13 00:00:56 +00:00
Guy Harris c5b4dad036 Create only one "About Ethereal" window per process.
svn path=/trunk/; revision=10052
2004-02-13 00:00:25 +00:00
Guy Harris 90cf9a6b7b The HIG's and/or GUI toolkit documentation for:
Mac OS X

	GNOME

	Qt

	KDE

	Windows

all indicate that {message,alert} boxes are modal, at least for the
window to which they apply.  (Presumably the idea is that not forcing
the user to pay attention to the alert box, and allowing more than one
alert box to be up for a given window, causes more problems than not
letting the user do stuff to that window in order to figure out what the
underlying problem is or figure out what to do to fix it - the message
should be sufficient, in most if not all cases, to let you know what the
problem is.)

Make "simple_dialog()" unconditionally make the alert box modal, and get
rid of ESD_TYPE_MODAL.  XXX - we need to make it possible to make an
alert box modal for a given window, rather than just the top-level
window.

svn path=/trunk/; revision=10051
2004-02-12 22:24:28 +00:00
Guy Harris 26536d7a41 Use "guint8" for 8-bit binary data.
"file_getc()" returns either an 8-bit unsigned value, or -1 for error or
EOF; store its return value into an "int", and check for -1 and return
-2, in "esc_read()" (rather than checking "file_error()" at the end).

Clean up some comments, routine names, and variable names - eyeSDN files
are binary, not text.

In "parse_eyesdn_packet_data()", handle the case of an EOF from
"esc_read()".

svn path=/trunk/; revision=10050
2004-02-12 21:25:07 +00:00
Guy Harris 6c0c28136f Eliminate a compiler warning.
Use "guint8" for 8-bit binary data, and use "%u" to print unsigned values.

svn path=/trunk/; revision=10049
2004-02-12 21:04:05 +00:00
Guy Harris ea3e87cb46 From Kendy Kutzner: don't use variable-length arrays, not all C
compilers support them.

Also, use "tvb_memdup()" to make a copy of the compressed data - it's
faster, and also checks to make sure the data is actually there (it
throws an exception before allocating anything).

svn path=/trunk/; revision=10048
2004-02-12 20:58:01 +00:00
Guy Harris f689434393 From Yaniv Kaul: the response to an V5 authentication response is a V5
authentication response, not a V5 command.

Clean up white space.

svn path=/trunk/; revision=10047
2004-02-12 20:47:27 +00:00
Guy Harris 0aef15283a Note that 164 is reserved for Juniper chassis-internal meta-information
(DLT_JUNIPER_MONITOR/LINKTYPE_JUNIPER_MONITOR).

Fix a typo.

svn path=/trunk/; revision=10046
2004-02-12 19:49:08 +00:00
Ulf Lamping c976800b49 from Anders Broman: added some tips for compiling with GTK2 and other things
svn path=/trunk/; revision=10045
2004-02-12 07:59:58 +00:00
Guy Harris 60096bfad9 Use -1 rather than 0 as the SCAN_FAILED return value from the lexical
analyzer on errors, and check for SCAN_FAILED from the lexical analyzer
and abort the parse if we see it; 0 means "end of input", and we want to
distinguish errors from end-of-input, so that we can report errors as
such.

If we see end-of-input while parsing a double-quoted string, report the
error (missing closing quote).

Fix the URL for the "Start conditions" section of the Flex manual.

svn path=/trunk/; revision=10044
2004-02-11 22:52:54 +00:00
Guy Harris b9b4a23834 Make an existence test of an arbitrary entity syntactically valid, but
check, in the semantics-checking phase, that we're testing a field, so
that we can give a better message than, for example, "Unexpected end of
filter string." for an existence test with a misspelled field name.

svn path=/trunk/; revision=10043
2004-02-11 21:20:52 +00:00
Guy Harris 87e20f8067 From Anders Broman: dissect manufacturer information in
"dissect_h225_h221NonStandard()".

svn path=/trunk/; revision=10042
2004-02-11 20:55:02 +00:00
Guy Harris 131be6ce7d Map WTAP_ENCAP_IEEE_802_11_WITH_RADIO to DLT_IEEE802_11, for now; we
could probably map it to one of the many different 802.11+radio headers,
but we should probably just have *one* Wiretap encapsulation for 802.11,
with a radiotap-style list of attributes attached to it.

svn path=/trunk/; revision=10041
2004-02-11 20:47:00 +00:00
Guy Harris 5f7e403326 Include EyeSDN USB S0 trace files in the list of file formats we read.
svn path=/trunk/; revision=10040
2004-02-11 20:30:28 +00:00
Jörg Mayer faf27fecc6 Christian Wagner: Support for the Soul Seek P2P protocol
svn path=/trunk/; revision=10039
2004-02-11 20:23:20 +00:00
Guy Harris 2df960325a From Rolf Fiedler: support for reading EyeSDN USB S0 trace files.
svn path=/trunk/; revision=10038
2004-02-11 20:05:16 +00:00
Guy Harris b2a64dc261 The top-level Makefile.nmake doesn't yet get all the source files from
Makefile.common, so we have to add alert_box.obj to the list of object
files for Ethereal.

svn path=/trunk/; revision=10037
2004-02-11 09:58:13 +00:00
Guy Harris f99bb93e55 Cast "char" values to "guchar" before passing them to <ctype.h> macros,
so that characters with the 8th bit set don't get sign-extended and
cause the macros not to return the right answer.

svn path=/trunk/; revision=10036
2004-02-11 09:19:54 +00:00
Guy Harris 8177fbd550 From Prabhakar Krishnan: dissect NetApp ONTAP file handles.
svn path=/trunk/; revision=10035
2004-02-11 04:34:38 +00:00
Guy Harris 6b1a0bf430 Most taps that now include "tap_menu.h" no longer need to include
<stdio.h> to define FILE; get rid of the include.

svn path=/trunk/; revision=10034
2004-02-11 04:28:49 +00:00
Guy Harris 153428c21d From Michael Lum: add tap for GSM MAP message statistics.
svn path=/trunk/; revision=10033
2004-02-11 04:27:44 +00:00
Guy Harris 9aa32731b9 From Michael Lum: add tap for GSM MAP message statistics.
svn path=/trunk/; revision=10032
2004-02-11 04:19:03 +00:00
Guy Harris 8e4a1c1cc6 Move the declaration of "register_tap_menu_item()" into a new
"tap_menu.h" file, and have the Ethereal taps include that rather than
"menu.h", so we don't have to worry about making sure we've included
<stdio.h> to define FILE, etc. just because some "menu.h" functions
require it.

svn path=/trunk/; revision=10031
2004-02-11 04:17:05 +00:00
Guy Harris 2e4e229739 Get rid of the "Question" alert box type - rename it to "Confirmation",
as that seems to be the name used in the GNOME HIG, at least.  Make it
use the Warning icon (that's what the GNOME HIG says - and it's also
what's used for the equivalent on Windows), and use it for the "Save
current capture?" alert boxes.

svn path=/trunk/; revision=10030
2004-02-11 03:55:48 +00:00
Guy Harris 34349cedcc Give alert boxes an empty title on UN*X and a title of "Ethereal" on
Win32, to match the GNOME HIG on UN*X and the Win32 HIG on Windows (or,
at least, to approximate the Win32 HIG on Windows).

svn path=/trunk/; revision=10029
2004-02-11 03:40:17 +00:00
Guy Harris 75b5cbf585 Replace the "cf_XXX_error_message()" routines with
"cf_XXX_failure_alert_box()" routines that put the alert box up, and
directly call the "alert_box.h" routines for OS errors.

svn path=/trunk/; revision=10028
2004-02-11 02:02:38 +00:00
Guy Harris 3a4e71a724 Add "write_failure_alert_box()" to put up an alert box for a failed
attempt to write to a file (or close a file opened for writing).

Get rid of no-longer-needed #includes of <epan/filesystem.h>.

svn path=/trunk/; revision=10027
2004-02-11 01:37:13 +00:00