Commit Graph

83238 Commits

Author SHA1 Message Date
Jérôme HAMM 7356889242 Adding secret management in DSB. 2022-01-07 13:42:33 +00:00
Jérôme HAMM c187020304 Enhancing debug logs. 2022-01-07 13:42:32 +00:00
Jérôme HAMM 2874b979ad Changing format of secret key file. 2022-01-07 13:42:32 +00:00
Gerald Combs 947d80c477 GitLab CI: Swap the Ubuntu package and latest Clang builds.
The Ubuntu APT Package job takes a long time to run. Do so after merging
and add a package test job, similar to the other Linux package builds.
The Latest Clang job has been detecting errors that also affect macOS.
Run it for merge requests. Fix Ubuntu build caching.
2022-01-07 03:32:26 +00:00
John Thacker c14d731e45 CMS: get rid of globals
Get rid of the global content_tvb and object_identifier_id in
the CMS dissector, and put them in a packet scoped proto data
struct, so that when there's a non fatal exception retrieving
the OID we don't use the global value from a previous packet
(or worse, file), since what the content_tvb and object_identifier_id
pointed to were both packet scoped that could lead to memory
access violations.

Clear the values of the OID and the content_tvb each time before
they are retrieved, so that values from a previous PDU of CMS
in the same packet aren't used either. This was not quite as bad
as using a value already freed, but still bad.

Fix #17800, #17809, #17835
2022-01-07 03:17:07 +00:00
Guy Harris 06bc298fbd FAQ: point to the User's Guide section of the Npcap guide.
(Yes, the top-level page calls it the "User's Guide", but it has a
section called the "User's Guide", as well as an "Introduction" and
sections about development with Npcap and about the Npcap internals.)
2022-01-06 17:15:32 -08:00
Gerald Combs c65f0a5a15 Update our Npcap URLs.
The official Npcap web site is now https://npcap.com/. Update our URLs
to match. Fixes #17838.
2022-01-06 16:12:30 -08:00
Dario Lombardo acc0260c84 tcp: add syn cookie support.
Fix: #17082.
2022-01-06 22:34:30 +00:00
Alexis La Goutte 95ef3a2d45 bpsec: fix warning about -Wprototypes (proto_register/reg_handoff_bpsec 2022-01-06 20:03:11 +00:00
Alexis La Goutte 22de61a063 bpsec: fix -Wdocumentation warnings 2022-01-06 20:03:11 +00:00
Gerald Combs 7f5f7c8285 Tools: Remove git-review from rpm-setup. 2022-01-06 11:24:31 -08:00
Gerald Combs 11d8520f69 Tools: Add openSUSE 15.3 requirements to rpm-setup. 2022-01-06 10:36:16 -08:00
John Thacker bf643c2649 SABP: Update ASN.1 template
Update the SABP ASN.1 template file for the changes made by commit
dec5590b5b so they aren't lost.
2022-01-06 14:28:20 +00:00
John Thacker bc9e8ea5b3 MPEG PES: Update conformance file for unify PES header bit fields
Update the conformance file for MPEG PES to produce the changes of
commit 5573d3c4e8
2022-01-06 09:12:55 -05:00
John Keeping e9900c38c2 usb: dissect other speed config descriptors
Other speed config descriptors are identical to config descriptors, it's
just the request that is different.  Handle this request so that other
speed config responses are decoded.
2022-01-06 11:59:53 +00:00
Uli Heilmeier b587d6a266 BGP: Fix next_hop decoding
Related to wireshark/wireshark#17836
2022-01-06 11:12:30 +01:00
Matthew Weant 29324f9409 EAP: Fix dissection of encrypted IMSI identifiers 2022-01-06 07:27:46 +00:00
j.novak@netsystem.cz 428f222853 Extcap: Extcaps must be fully configured before start of capture 2022-01-06 07:02:11 +00:00
Роман Донченко 6b8c32fa7a rfc7468: allow multiple structures per file
It's common to put multiple certificates in one RFC 7468 file in order to store
a certificate chain, as described in the introduction to RFC 7468 itself.
Support this usage by presenting each such certificate (or any other encoded
structure - the code doesn't discriminate) as a separate packet.

The new parsing code supports arbitrary line lengths, so update the detection
code to support arbitrary line lengths as well. Instead of probing up to 20
lines, we now try to find the first pre-encapsulation boundary in the first
2048 bytes of the file. I chose this new limit so that it works roughly the
same in practice as the old one (it's equal to 20 lines times 80 characters
per line, rounded to a power of two).
2022-01-06 06:29:54 +00:00
John Thacker 858402d3c7 packaging: Fix RPM -qt subpackage requires
The BuildRequires and Requires for the -qt subpackage need to
go into its %package section, not its %description section.
The dependencies were not being enforced, but instead being added
to the description of the GUI package.
2022-01-06 04:33:00 +00:00
Gerald Combs 734d8cfbee GitLab CI: Update a couple of RPM builds.
Switch from Centos 8 to Rocky Linux 8 and switch from openSUSE 15.2 to
15.3. Alphabetize our Linux jobs.
2022-01-06 04:18:44 +00:00
Roman Volkov 5573d3c4e8 mpeg pes: unify PES header bit fields displaying
Add a bit-mask for 'scrambling-control' field to add a displaying of
bits occupied by the field.
2022-01-06 04:03:55 +00:00
Roman Volkov 59012e34df mpeg descriptor: add Partial Transport Stream Descriptor (0x63) 2022-01-06 03:49:06 +00:00
j.novak@netsystem.cz e1a8f0119e Extcap prefs: Editor remembers empty values 2022-01-06 03:48:27 +00:00
Dr. Lars Völker 4d9f29150e Signal-PDU: Adding support for zero-terminated and UTF strings
This patch adds support for zero-terminated strings as well as UTF-8 and
UTF-16 strings.

This patch also fixes a check for the signal list UAT (scaler, offset).
2022-01-06 03:17:05 +00:00
Michael Tuexen b3c24758b3 macos-setup.sh: Simplify building nghttp2 2022-01-05 20:58:32 +00:00
Pascal Quantin adca11dd5c range_string: follow-up of 893290c 2022-01-05 20:34:15 +00:00
Martin Mathieson f1c31deb61 UDS: make a function static 2022-01-05 20:15:16 +00:00
Dr. Lars Völker 9b43910bc2 PTP: Source Code Cleanup (formatting) 2022-01-05 17:40:32 +00:00
Gerald Combs e9bc60ace4 macos-setup.sh: Update the PCRE URL.
As noted on https://pcre.org/, ftp.pcre.org has been shut down. Switch
to SourceForge and bump the version to 8.45. Fixes #17834.
2022-01-05 17:01:23 +00:00
John Thacker 4b5d54f5ea packaging: Bump RPM glib2 version to 2.38
We require glib2 version 2.38 now, increase the version requirement
in the RPM spec file to match.
2022-01-05 10:21:23 -05:00
John Thacker 2cb8f34721 packaging: Remove unnecessary Requires
Automatic dependency generation has been around since RPM 4.0 (September
2000). The BuildRequires are sufficient for all of these; the automatic
dependences for the .so files works and are superior as they are versioned.

Red Hat and SUSE both recommend using automatic dependencies and
avoiding unnecessary Requires in spec files:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires
https://en.opensuse.org/openSUSE:Package_dependencies
2022-01-05 09:53:17 -05:00
João Valverde 7afb52c479 ws_assert: refactor assertions 2022-01-05 13:31:53 +00:00
João Valverde 1dfba751e5 wslog: Replace ws_assert() 2022-01-05 13:31:52 +00:00
João Valverde f7b904f328 wslog: Convert to C99/POSIX types 2022-01-05 13:31:52 +00:00
João Valverde 947c617812 Remove some circular dependencies on wireshark.h 2022-01-05 13:31:52 +00:00
João Valverde 232628322c wslog: Rewrite macros 2022-01-05 13:31:52 +00:00
João Valverde 3f27a830fc wslog: Use a wider type for line 2022-01-05 13:31:52 +00:00
Dr. Lars Völker 0f2cf2b331 Signal-PDU: reformatting for consistency
The code was not formatted consistently. This patch cleans this up.
2022-01-05 13:06:59 +01:00
Alexis La Goutte a68fd7b09d macos-setup: Update nghttp2 release
there is some CVE and bug fix...
2022-01-05 10:10:38 +00:00
Benedikt Heumüller 893290c603 Extended range_string to 64 bit 2022-01-05 09:14:46 +00:00
Dr. Lars Völker 382fe23aa8 UDS: add subdissector support
Adding subdissector support to UDS and allow Signal PDUs for it.

This patch supports:
- ReadDataByIdentifier (RDBI) Reply
- WriteDataByIdentifier (WDBI) Request
- RoutineControl (RC) Request
- RoutineControl (RC) Reply
2022-01-05 06:06:33 +00:00
Gerald Combs 27ccf26b4b BLF: Fix a coverity warning.
Fix

```
*** CID 1496851:  Resource leaks  (RESOURCE_LEAK)
/builds/wireshark/wireshark/wiretap/blf.c: 1621 in blf_read_apptextmessage()
1615         }
1616
1617         gchar *text = g_try_malloc0((gsize)apptextheader.textLength);
1618
1619         if (!blf_read_bytes(params, data_start + sizeof(apptextheader), text, apptextheader.textLength, err, err_info)) {
1620             ws_debug("not enough bytes for apptext text in file");
>>>     CID 1496851:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "text" going out of scope leaks the storage it points to.
1621             return FALSE;
1622         }
1623
1624         /* returns a NULL terminated array of NULL terminates strings */
1625         gchar **tokens = g_strsplit_set(text, ";", -1);
```
2022-01-05 05:21:25 +00:00
John Thacker 98378d76d0 packaging: ENABLE_RPATH_ORIGIN on Fedora RPM build
Fedora Linux recently turned on some hardcore RPATH hardening
that causes RPM build to fail with a wide variety of prefixes unless
$ORIGIN is enabled.

It builds fine with /usr as the prefix because in that case we disable
the RPATH.

In the long run perhaps we should have the rpm-package target use the
standard prefix of /usr instead of the CMAKE_INSTALL_PREFIX, but even
so we want the spec file to work if /usr/local is set as the prefix.
Fix #17830
2022-01-04 21:48:31 -05:00
John Thacker 007883408f packaging: Fix git-export-release.sh when CI_COMMIT_SHA undefined
Commit 0d820ddc8d added set -u to
the script, so the test for CI_COMMIT_SHA (added in commit
e7296d5208) needs to be changed
so there isn't a fatal error if it is unset.
2022-01-05 01:21:08 +00:00
Guy Harris ec0aaf1811 ftype-time: check for NULL from gmtime() and localtime().
On Windows, they return NULL for times prior to the Epoch.
2022-01-04 15:35:18 -08:00
Guy Harris 72a4210828 text_import: "localtime()" is an API, "local time" is local time. 2022-01-04 15:17:30 -08:00
Gerald Combs 74a9d3bb67 Docs: Fix release notes markup.
AsciiDoc headings need to start at the beginning of the line. Bump the
next version.
2022-01-04 20:34:13 +00:00
Roman Volkov 0a4f3d62e5 mpeg table: implement Selection Information Table (SIT) 2022-01-04 20:13:09 +02:00
Luca Deri 39df51c46d Added missing nDPI ClassifierId
For more information about classification engine ids see:
https://www.iana.org/assignments/ipfix/ipfix.xhtml#classification-engine-ids
2022-01-04 13:57:14 +00:00