Commit Graph

8251 Commits

Author SHA1 Message Date
Guy Harris 71034c5a3f From Jean-Michel Fayard: show in Tools:Summary window statistics about
packets that passed the current display filter, as well as about the
entire capture.

Document the Tools:Summary item in the man page.

Update Gerald's e-mail address.

svn path=/trunk/; revision=8344
2003-09-02 22:10:32 +00:00
Guy Harris a3a1ee8850 From Andreas Sikkema: Facility for H.245 to display short message types
instead of long ones (introduces new preference, default is off):
  OpenLogicalChannel OpenLogicalChannel OpenLogicalChannel OpenLogicalChannel
  OLC OLC OLC OLC

svn path=/trunk/; revision=8343
2003-09-02 21:40:34 +00:00
Guy Harris 8946ac347e From Andreas Sikkema: improved Info column output for multiple H.225
messages and faststart ( I think, lost track, kind of).

svn path=/trunk/; revision=8342
2003-09-02 21:37:44 +00:00
Guy Harris ecb9143eac "tvb_new_subset(tvb, 0, tvb_length(tvb), -1)" is equivalent to
"tvb_new_subset(tvb, 0, -1, -1)", which is equivalent to just "tvb" -
it's creating a "subset" that includes the entire tvbuff.  Don't bother
with the "tvb_new_subset()" call.

svn path=/trunk/; revision=8341
2003-09-02 21:26:22 +00:00
Guy Harris 4db8a31785 From Anders Broman: add a preference option to enable the display of the
whole SIP message as text lines, as well as showing the dissected
message.

svn path=/trunk/; revision=8340
2003-09-02 21:23:43 +00:00
Guy Harris 42c646eeb4 From Joakim Wiberg: change additional status display to word array
instead of byte array.

svn path=/trunk/; revision=8339
2003-09-02 21:17:31 +00:00
Guy Harris 5f0c445718 From Anders Broman: add a few more user IDs to the M3UA Service Indicator.
svn path=/trunk/; revision=8338
2003-09-02 21:14:43 +00:00
Guy Harris cad432d183 From Dinesh Dutt:
use the value_string tables for SOF and EOF values, rather than
	the string tables, and get rid of the string tables;

	add another desegmentation check;

	other cleanups.

svn path=/trunk/; revision=8337
2003-09-02 21:10:54 +00:00
Guy Harris 79697e6fe4 As noted earlier, Q.922 doesn't really specify the NLPID-based
encapsulation, so don't tag the packet as having "Q.922 Encapsulation"
if it has NLPID-based encapsulation.  Don't tag it with "Cisco
Encapsulation", either - both of those can be inferred from the dissection.

svn path=/trunk/; revision=8336
2003-09-02 21:06:16 +00:00
Guy Harris 454806eeff Use "dissect_xdlc_control()" to dissect the control field of Frame Relay
packets that have one.  Add an argument to "dissect_xdlc_control()" to
indicate whether it should append the information to the Info field or
just put it in the Info field.

Use the #defines for the DLCI bitfields to extract the DLCI bits when
constructing the DLCI.

svn path=/trunk/; revision=8335
2003-09-02 19:18:52 +00:00
Guy Harris 7cb23da0fb Don't show the DTE/DCE direction indicators if they're not supplied.
svn path=/trunk/; revision=8334
2003-09-02 18:45:06 +00:00
Guy Harris 8aee4ddf4a Q.933 doesn't define the use of an NLPID in the payload of a Frame Relay
packet (Q.922 doesn't really do so, either, but...).

Do a full dissection of the octets of the address field, don't just
assume a 2-octet address field.

Clear the Info column.

svn path=/trunk/; revision=8333
2003-09-02 18:33:11 +00:00
Gerald Combs 9d603ccc2c Make sure the color selection dialog displays a color selection widget.
Tweak the button layout slightly.

svn path=/trunk/; revision=8332
2003-09-02 18:27:50 +00:00
Michael Tüxen 20188db349 Fixed a typo.
svn path=/trunk/; revision=8331
2003-09-02 11:05:55 +00:00
Michael Tüxen 7730201e97 Fixed a bug regarding the summary of in/outbound streams in INIT/INIT-ACK chunks.
svn path=/trunk/; revision=8330
2003-09-02 11:03:59 +00:00
Ronnie Sahlberg b0bec4d79a When putting the filename in the titlebar
just put the filename there and not the full path to the file.

svn path=/trunk/; revision=8329
2003-09-02 08:27:43 +00:00
Guy Harris cd1524c319 C89 doesn't let you declare stuff in the middle of blocks, even if some
versions of GCC do.

svn path=/trunk/; revision=8328
2003-09-01 23:47:01 +00:00
Gerald Combs d87e75c585 Make the capitalization of the "Name Resolution" frame consistent with the
other frames.

svn path=/trunk/; revision=8327
2003-09-01 01:49:20 +00:00
Guy Harris 9f62e50a7d From Devin Heitmueller: make offsets into tvbuffs 32-bit.
svn path=/trunk/; revision=8326
2003-09-01 00:01:39 +00:00
Richard Sharpe 3d6f1d76e7 Add support for building with ucd-snmp on RH9.0. We need to link with
-L/usr/kerberos/lib -ldes425 ...

This works on Linux (RH 9.0) but I am not sure about Solaris. Solaris is
such a difficult environment to work with compared to Linux or FreeBSD.

svn path=/trunk/; revision=8325
2003-08-31 22:08:57 +00:00
Guy Harris 109619e6c9 From Andreas Sikkema:
hide some more fields behind the "show asn.1 internals"
	preference;

	show the booleans as values true or false, instead of set or not
	set.

svn path=/trunk/; revision=8324
2003-08-31 00:49:37 +00:00
Guy Harris f437701a78 From Andreas Sikkema:
- fix RAS messages to clear the INFO column correctly;

- make H.245 messages tunneled within H.225 messages add their message
  type to the Info column.

svn path=/trunk/; revision=8323
2003-08-31 00:32:19 +00:00
Guy Harris f11ef57387 Include "tap.h" to get "remove_tap_listener()" declared.
svn path=/trunk/; revision=8322
2003-08-31 00:31:05 +00:00
Ronnie Sahlberg 10833b30b2 Updates and bugfixes from Andreas and Martin
svn path=/trunk/; revision=8321
2003-08-30 22:47:48 +00:00
Ronnie Sahlberg 82c1757345 Remove the individual reset functions and replace with a common one in the helpers file.
cleanup part 5?

svn path=/trunk/; revision=8320
2003-08-30 01:18:16 +00:00
Ronnie Sahlberg ce8477a3ed step 3 in endpoint talkers cleanup
get rid of the draw_packets wrapper in the individual endpoint files

svn path=/trunk/; revision=8319
2003-08-30 01:05:03 +00:00
Ronnie Sahlberg 1b81e773a7 step two in endpoint talkers cleanup
move the windows destroy function to the common helpers file

svn path=/trunk/; revision=8318
2003-08-30 00:53:15 +00:00
Ronnie Sahlberg 7789678033 step one in endpoint talkers cleanup
svn path=/trunk/; revision=8317
2003-08-30 00:47:43 +00:00
Guy Harris 9e7a9fb037 Give the name of the I-D for LWAPP.
svn path=/trunk/; revision=8316
2003-08-29 22:57:55 +00:00
Guy Harris a42fd8fa50 From David Frascone: LWAPP support.
svn path=/trunk/; revision=8315
2003-08-29 22:27:14 +00:00
Guy Harris c8ea407526 Set "addr" before using it, regardless of whether "ip_summary_in_tree"
is set or not.  Copy the destination address, not the source address,
when processing the destination address.

svn path=/trunk/; revision=8314
2003-08-29 22:15:19 +00:00
Guy Harris ebd1b7a744 From Matthijs Melchior: In "asn1_string_value_decode()", put in a
trailing '\0', to simplify use of the resulting data as a C string.

svn path=/trunk/; revision=8313
2003-08-29 19:13:28 +00:00
Ronnie Sahlberg 2475b0ed97 If something is a KeepAlive it is just a keepalive and not also a dup ack
svn path=/trunk/; revision=8312
2003-08-29 11:40:24 +00:00
Ronnie Sahlberg 431a30d061 If the FIN flag is set it is NOT a keepalive
fix small typo

svn path=/trunk/; revision=8311
2003-08-29 11:15:13 +00:00
Ronnie Sahlberg 4135309cbd Add endpoint talkers support for FDDI to ethereal and tethereal
Welcome FDDI into the endpoint talkers family.

Nobody gets left behind!

svn path=/trunk/; revision=8310
2003-08-29 10:59:12 +00:00
Ronnie Sahlberg 19a99f8a34 Make the hex to string conversion code in find_dlg.c handle ':' characters
such as you might find when doing "prepare" on a FT_BYTES field.

So one need not delete the ':' characters manually

svn path=/trunk/; revision=8309
2003-08-29 09:32:16 +00:00
Guy Harris 56664b9b77 Make the CList of character sets non-editable, so you only get to choose
from what we offer.  (XXX - should it be an option menu, instead?)

svn path=/trunk/; revision=8308
2003-08-29 04:56:46 +00:00
Richard Sharpe 625ce0f651 Make the configure flag --with-ucd-snmp consistent with --with-net-snmp.
That is, change it from --with-ucdsnmp.

svn path=/trunk/; revision=8307
2003-08-29 04:20:22 +00:00
Guy Harris 1cf6565adc Get rid of the EBCDIC stuff in the find dialog - it's not supported yet,
so we shouldn't torment the users by offering it.

Check the string type and convert it to an internal representation in
the GUI code; have the search code deal only with the internal
representation.

Save the case-sensitivity flag, and the indication of where string
searches look, along with other search parameters.

Upper-casify the string, for case-insensitive searches, in the GUI code;
don't save the upper-casified string, so it doesn't SHOUT at you when
you next pop up a "find" dialog.

Convert the hex value string to raw binary data in the GUI code, rather
than doing so in the search code.  Check that it's a valid string.

Connect the signals to the radio buttons after the pointers have been
attached to various GUI items - the signal handlers expect some of those
pointers to be attached, and aren't happy if they're not.

Have "find_packet()" contain a framework for searching, but not contain
the matching code; instead, pass it a pointer to a matching routine and
an opaque pointer to be passed to the matching routine.  Have all the
routines that do different types of searching have their own matching
routines, and use the common "find_packet()" code, rather than
duplicating that code.

Search for the Info column by column type, not by name (the user can
change the name).

When matching on the protocol tree, don't format the entire protocol
tree into a big buffer - just have a routine that matches the text
representation of a protocol tree item against a string, and, if it
finds a match, sets a "we found a match flag" and returns; have that
routine not bother doing any more work if that flag is set.
(Unfortunately, you can't abort "g_node_children_foreach()" in the
middle of a traversal.)

Free the generated display filter code after a find-by-display-filter
finishes.

svn path=/trunk/; revision=8306
2003-08-29 04:03:46 +00:00
Gerald Combs 6fc18311a6 From Vincent Jardin: Add support for Teredo
(draft-huitema-v6ops-teredo-00.txt).

svn path=/trunk/; revision=8305
2003-08-29 02:27:31 +00:00
Gerald Combs 9685960b40 Copy the source and destination addresses into a guint32, so that we don't
bus error on RISC systems.

svn path=/trunk/; revision=8304
2003-08-29 01:57:37 +00:00
Guy Harris 2af6770410 From Greg Morris: put borders around the options to delimit them and
indicate where they apply, and give tooltips to some of the options.
Disable the "Filter:" button unless we're searching with a display filter.

Use "Frame data" instead of "Hex" for the option to search the raw frame
data, use "Decoded packet" instead of "Decode" for the option to search
the strings in the protocol tree display, and use "Packet summary"
instead of "Summary" for the option to search the Info column in the
packet list display, to make it a bit clearer what's being searched.

svn path=/trunk/; revision=8303
2003-08-28 23:25:55 +00:00
Guy Harris 3a174693ba Clean up white space.
svn path=/trunk/; revision=8302
2003-08-28 22:51:07 +00:00
Olivier Abad 0c678f74c7 Marking packets with the middle mouse button works now with GTK2.
svn path=/trunk/; revision=8301
2003-08-28 20:33:14 +00:00
Gilbert Ramirez e2d7335584 Fix signed/unsigned comparison warning.
svn path=/trunk/; revision=8300
2003-08-28 17:26:15 +00:00
Ronnie Sahlberg de0002bbdf Fix small display bug. we returned the wrong value from dissect_per_choice and it made us display the wrong string sometimes
svn path=/trunk/; revision=8299
2003-08-28 14:41:20 +00:00
Ronnie Sahlberg 9c561b384a Update to H.225 when H.245 is tunneled in some octet strings,
call the h245 dissector instead of just showing the octet string content as some random hex bytes

svn path=/trunk/; revision=8298
2003-08-28 14:29:41 +00:00
Ronnie Sahlberg 9ce749fd8a update to h245 to decode the county codes
from anders broman

svn path=/trunk/; revision=8297
2003-08-28 12:57:24 +00:00
Guy Harris 6bbe0b5834 Update a comment.
svn path=/trunk/; revision=8296
2003-08-28 04:46:13 +00:00
Guy Harris a224698042 Make "process_reassembled_data()" do the check for fragmentation not
being complete and for fragmentation being trivial (i.e., the packet in
question is both the first and last fragment).  Have its callers *not*
do that check - this lets "process_reassembled_data()" put in the
"Reassembled in" item for fragments other than the last fragment.

Add a "Reassembled in" field to TDS.

svn path=/trunk/; revision=8295
2003-08-28 04:19:29 +00:00