Commit Graph

46234 Commits

Author SHA1 Message Date
Gerald Combs 6cbb955d00 Install the new global profiles and add them to the distribution.
svn path=/trunk/; revision=49122
2013-05-01 21:53:57 +00:00
Jörg Mayer 4c444efdf1 Make the python scripts work on systems where python is a link
to python3: explicitely call the python2 binary.

svn path=/trunk/; revision=49121
2013-05-01 21:50:44 +00:00
Guy Harris 1fe16c1d6a Fix warning.
svn path=/trunk/; revision=49118
2013-05-01 21:15:47 +00:00
Michael Mann b787f03df3 Remove some global variables in favor of private_data member of asn1_ctx_t. Bug 7060 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7060). This should (mostly) passify the bug, but it appears like this could be done with a lot more ASN.1 dissectors.
svn path=/trunk/; revision=49117
2013-05-01 20:54:31 +00:00
Gerald Combs bf579224ae Add a "profiles" directory. Add a Bluetooth global profile with the
current default+Bluetooth colors and a Classic global profile with the
old 1.8 colors. Remove the Bluetooth rules from the default profile.

svn path=/trunk/; revision=49116
2013-05-01 20:31:50 +00:00
Jörg Mayer dbd718c606 Whitespace fixes: Indented lines should not start with
spaces followed by tabs.

svn path=/trunk/; revision=49115
2013-05-01 19:51:46 +00:00
Jeff Morriss 695d3fde1c Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8622 :
hsrp2.md5_auth_data is added to the tree with a length of 16 so declare it as
FT_BYTES instead of FT_UINT32 (using the latter causes an assertion in
trunk-1.8 and an expert info in trunk and trunk-1.10).

svn path=/trunk/; revision=49114
2013-05-01 19:42:28 +00:00
Jörg Mayer acc90e3d59 Diederik de Groot <dkgroot@talon.nl>
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8616

Further enhancements to packet-skinny.c, change cast. filters
to skinny. filters.
While I'm not sure whether that this is really correct, we don't
have any sample capture to verify whether the old solution really
worked. At least that way checkfiltername.pl doesn't complain
any more ;-)

Me: Tiny whitespace fixes.

svn path=/trunk/; revision=49113
2013-05-01 19:16:02 +00:00
Jeff Morriss 56552cb0fa Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8618 :
Allow port 0 in RSA Key List.

(This has been broken since r36875.)

svn path=/trunk/; revision=49111
2013-05-01 14:19:10 +00:00
Jeff Morriss d64f28d617 Remove cmake/modules/FindPYTHON.cmake from the source distribution.
svn path=/trunk/; revision=49109
2013-05-01 13:22:25 +00:00
Jörg Mayer 436270ffab Sort the list of packages to make it easier to check results.
svn path=/trunk/; revision=49107
2013-05-01 10:40:12 +00:00
Jörg Mayer 10bd5631e4 Print the version of the include files that will be used.
svn path=/trunk/; revision=49106
2013-05-01 10:34:15 +00:00
Jörg Mayer 30653b7e16 - Fix logic for finding packages with differing Find-name
and returned variable-names:
  Old: Provide the var name and adapt the find-name
  New: Provide the find-name and adapt the var name
  This allows for different packages with the same var name.
  This chage effects Qt4 and PythonInterp.
- Replace self created FindPYTHON with cmake provided
  FindPythonLibs.

svn path=/trunk/; revision=49105
2013-05-01 09:20:59 +00:00
Anders Broman e9f90d8c42 Make C12.22 work over UDP.
svn path=/trunk/; revision=49104
2013-05-01 08:34:40 +00:00
Evan Huus f19efd05f7 Remove singly-linked list from the wmem TODO list. Now that it has append
all of the really important stuff is there, and emem doesn't provide it at all
so it's not blocking migration.

svn path=/trunk/; revision=49103
2013-05-01 01:09:57 +00:00
Jörg Mayer cd160c7af2 Our scripts do ont work with python3, so only pick up a python2
executable.

Reported on #wireshark by McEnroe

svn path=/trunk/; revision=49102
2013-05-01 00:53:59 +00:00
Evan Huus 0844929247 Follow-up to r49055 as noted on
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7359

The BER integer dissection routines take an hf_id, but that can be -1.
Only fetch the type (to check signedness) if hf_id >= 0, as otherwise this
causes a dissector bug. Default to signed if given no hf_id - I don't know
whether this should be unsigned or not, but the old behaviour was that
everything was signed so it's not a regression at least.

svn path=/trunk/; revision=49101
2013-04-30 23:19:47 +00:00
Jörg Mayer aa9a1a7206 Add Diederik de Groot to the AUTHORS list
svn path=/trunk/; revision=49100
2013-04-30 22:06:33 +00:00
Jörg Mayer e4f71b08a0 Diederik de Groot <dkgroot@talon.nl>
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8616

Update Skinny Dissection Code (CM7.1 + / SPCP Message)

Me:
- Remove some trailing whitespace
- Numerically sort deviceTypes and replace older values with new ones
- Reenable the return FALSE statement in the heuristics - it works for me.

svn path=/trunk/; revision=49099
2013-04-30 21:53:39 +00:00
Evan Huus 108a75a603 Add 'dtds' and 'fix' directories to the checklicense whitelist, they don't
appear to be things we have licensing power over (IANAL).

svn path=/trunk/; revision=49095
2013-04-30 01:34:19 +00:00
Evan Huus e8c813b2ea In part from Raúl Pérez Clavero via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8275
Implement wmem_slist_append().

svn path=/trunk/; revision=49094
2013-04-30 01:23:10 +00:00
Michael Mann 78ebc850ba Convert 'Old GFID' and 'New GFID' to FT_GUID type.
From Niels de Vos, Bug 8612 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8612)

svn path=/trunk/; revision=49093
2013-04-30 00:55:18 +00:00
Evan Huus c0c0b10f96 A few more doxygen fix-ups.
svn path=/trunk/; revision=49092
2013-04-30 00:55:03 +00:00
Gerald Combs 9120bf883e Move the contents of wsar_html/core to wsar_html. Create tag files for
core, epan, and ui, and link them to each other to varying degrees. This
seems to be the best way to organize our documentation. The alternative
is to switch to a single doxygen.cfg and manually add files to different
groups or sections.

Add a wireshark.dox file which contains markup for the main page. Add
.dox and .txt to svnadd. Clean up our tag files. Force wsar_html to
rebuild each time.

svn path=/trunk/; revision=49091
2013-04-30 00:27:02 +00:00
Gerald Combs 160af64058 State that we don't support U3 any more.
svn path=/trunk/; revision=49090
2013-04-29 23:08:31 +00:00
Gerald Combs b2e88f3d5e Darken and saturate the "trouble" backgrounds a bit.
svn path=/trunk/; revision=49084
2013-04-29 17:13:24 +00:00
Evan Huus c17d706c8c Specify to CppCheck that Wireshark code is C89, not the default C11.
svn path=/trunk/; revision=49083
2013-04-28 23:30:29 +00:00
Gerald Combs 6608eddd3d [Automatic manuf, services and enterprise-numbers update for 2013-04-28]
svn path=/trunk/; revision=49079
2013-04-28 14:03:34 +00:00
Guy Harris 2cd4b0f607 Fix suspected copy-and-pasteo.
svn path=/trunk/; revision=49078
2013-04-28 01:09:00 +00:00
Evan Huus b39cf04f14 Add CppCheck to the list of things to run before submitting code for review.
svn path=/trunk/; revision=49077
2013-04-27 23:11:06 +00:00
Evan Huus c17893650c Silence a false-positive warning from older GCCs:
'acetype4' may be used uninitialized in this function

svn path=/trunk/; revision=49076
2013-04-27 15:00:52 +00:00
Evan Huus 0a530b2a1f When fuzzing with valgrind and running without -T, run with -v so that the
argument string is non-empty. Perhaps this will fix the fuzz-bot which fails
to run with the empty argument string...

svn path=/trunk/; revision=49075
2013-04-27 14:03:45 +00:00
Evan Huus 132ee18259 From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8605
Numerous improvements to NFS ACL/ACE dissection. For a complete list see
comment #11 of the bug.

From me:
- fix an infinite loop caught by fuzzing
- fix an out-of-bounds memory access caught by valgrind
- add missing {0,NULL} terminator to value_string array

svn path=/trunk/; revision=49074
2013-04-27 13:59:46 +00:00
Martin Kaiser 600e5ac301 remove unnecessary if (tree) checks
I hope this prevents bugs like the one fixed in r48917

svn path=/trunk/; revision=49073
2013-04-27 13:06:28 +00:00
Martin Kaiser 3beb9a36a3 free the linkname allocated by g_strdup()
set linkname to unknown for interfaces without a linkname (e.g.  pipes)
remove "this should not happen" warnings

svn path=/trunk/; revision=49072
2013-04-27 12:35:30 +00:00
Martin Kaiser e1bc174b39 when a named pipe is added to the interfaces list, it has no linktype
this triggered the g_assert(linktype) in create_and_fill_model()
    
the assert is not necessary as both gtk_list_store_set() and g_free()
can handle NULL parameters
    
remove the assert and add set linktype to "unknown" if the interface
has no linktype 

svn path=/trunk/; revision=49071
2013-04-27 09:55:46 +00:00
Guy Harris 2013b5ad31 Fix a comment (the "it worked but didn't pop up a window" conclusion
came from a bad test).

svn path=/trunk/; revision=49070
2013-04-27 03:51:40 +00:00
Guy Harris a36a0a7a84 Update comments.
svn path=/trunk/; revision=49069
2013-04-27 02:57:16 +00:00
Evan Huus 5deac1e6e1 Wmem string-buffer improvements:
- better tests
- fix a bug caught by the better tests
- implement append_c and append_unichar, with tests

Wmem string-buffers now have feature parity with their emem equivalents, so
remove them from the TODO list.

svn path=/trunk/; revision=49060
2013-04-26 21:30:24 +00:00
Gerald Combs 32352fb1a2 Update the capture start, stop, and restart icons and development badge
with enhanced versions from Elliott.

Switch the interface configuration icon to the "gear" version. This
matches the gear in the capture icon.

svn path=/trunk/; revision=49059
2013-04-26 21:10:35 +00:00
Jeff Morriss cbc09f6fc5 Set svn:mime-type
svn path=/trunk/; revision=49057
2013-04-26 20:30:04 +00:00
Gerald Combs b53b4becdd Try to determine the repository URL automatically.
svn path=/trunk/; revision=49056
2013-04-26 19:50:43 +00:00
Evan Huus 5b8a3df249 From me: only sign-extend BER integers if the field is actually signed
From Guy: override two fields in the GOOSE ASN.1 dissector to be unsigned

Together these fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8250


svn path=/trunk/; revision=49055
2013-04-26 19:23:36 +00:00
Evan Huus 63ef04ec84 Fix a whole bunch of doxygen warnings, mostly typos or renamed parameters.
svn path=/trunk/; revision=49053
2013-04-26 18:28:21 +00:00
Gerald Combs 098997e5fb Buildbot (via Twisted) sets a restrictive umask. Unset it before we run
Doxygen.

svn path=/trunk/; revision=49052
2013-04-26 18:23:05 +00:00
Gerald Combs ea5829c50b Add some Doxygen checks.
svn path=/trunk/; revision=49051
2013-04-26 17:49:00 +00:00
Jeff Morriss 32d6384725 Set svn:eol-style and svn:keywords
svn path=/trunk/; revision=49049
2013-04-26 15:28:30 +00:00
Jeff Morriss c1dbdee5a1 Fix up indentation
svn path=/trunk/; revision=49048
2013-04-26 13:53:53 +00:00
Guy Harris edfe2fc28c Work around a bug in a Microsoft security fix.
svn path=/trunk/; revision=49046
2013-04-26 04:42:20 +00:00
Guy Harris 889e2d6e5e Get rid of leftover debugging variable.
svn path=/trunk/; revision=49045
2013-04-26 01:01:32 +00:00