Commit graph

6664 commits

Author SHA1 Message Date
Guy Harris
6b72decb11 From Fritz Budiyanto: add a missing g_ntohs() for flow_label in the
gtpv0 decoder.

svn path=/trunk/; revision=6749
2002-12-05 22:31:13 +00:00
Ronnie Sahlberg
834c08904b Fix two compiler warnings
svn path=/trunk/; revision=6748
2002-12-05 22:19:24 +00:00
Ronnie Sahlberg
6488851a0b Fix for DCERPC detection when carried ontop of SMB.
If we do not see the TreeConnect call when a TID is connected, we did not
know it was a IPC share.
If we do not know what kind of share it is we assume it being a normal one
and thus read/write data to that share is normal file i/o.


Update the dissector so that IF it sees a Transaction SMB carrying PIPE (dcerpc)
then we assume that all other read/write to that TID is also DCERPC.
I.e. we assume the entire TID is IPC.

svn path=/trunk/; revision=6747
2002-12-05 22:15:54 +00:00
Guy Harris
49157b5f2c It seems pretty clear that a PDU_AUTH3 really is an AUTH3 PDU, and we
know what it is (a PDU for the third stage in a 3-way authentication
handshake, as is done with NTLMSSP authentication, for example) - get
rid of the question mark after "AUTH3".

svn path=/trunk/; revision=6746
2002-12-05 18:26:10 +00:00
Michael Tüxen
385249b3c1 Fixed a bug regarding the handling of correlation ids.
svn path=/trunk/; revision=6745
2002-12-05 10:19:13 +00:00
Michael Tüxen
d154bf7d16 Added support for the Implementers Guide.
svn path=/trunk/; revision=6744
2002-12-04 17:07:26 +00:00
Tim Potter
572e5b49cf Some constant for getprinter level 7 decoding.
svn path=/trunk/; revision=6743
2002-12-04 06:05:42 +00:00
Tim Potter
31754bcb7c Decode getprinter level 7.
svn path=/trunk/; revision=6742
2002-12-04 05:41:47 +00:00
Gerald Combs
3835ed4585 Bump the version to 0.9.8. Update NEWS and ChangeLog to October 24.
svn path=/trunk/; revision=6741
2002-12-04 04:26:14 +00:00
Gerald Combs
9967550369 Include <string.h> so that memcpy() is properly declared.
svn path=/trunk/; revision=6740
2002-12-03 15:21:28 +00:00
Michael Tüxen
15db969b7a - added RFC 3331 indication to the protocol column entry.
svn path=/trunk/; revision=6739
2002-12-03 09:31:48 +00:00
Michael Tüxen
f0141612ed - Updated to RFC 3331 version.
- Improved handling of padding bytes.
- Some cleanup of the code.

svn path=/trunk/; revision=6738
2002-12-03 09:29:11 +00:00
Guy Harris
c5ea448c8e I've seen a capture with a TDS packet type of 18 at the beginning of the
session; treat all packet type values >= 1 and <= 18 as valid packet
types.

Do standard TCP desegmentation of Netlib buffers, and do reassembly of
TDS messages fragmented over multiple Netlib buffers, rather than doing
the "remember what was in the last TCP segment" stuff; I've seen nothing
to indicate that a TDS message would continue past the last byte of a
"last buffer in request or response" Netlib buffer, and the "remember
what was in the last TCP segment" stuff was complicated and buggy,
perhaps irreparably so ("buggy" as in "crashes").

Make the top-level protocol item for a TDS message be an item for
"proto_tds", and put both the Netlib header and TDS stuff under that
item - that's what Microsoft Network Monitor does.

Get rid of the unused Netlib heuristic subdissector list.

Don't make a new data source for NTLMSSP data in a TDS message - the
data is just a slice of the message, it's not transformed from ASCII hex
to binary, or reassembled, or anything such as that.

Tokens are tokens, not PDUs.

Make the heuristics a bit stronger, to reject packets that are clearly
not TDS packets.  Once the heuristics match, make a non-heuristic
dissector the dissector for the conversation.

Quit dissecting the TCP segment (or reassembled data) if we have a
Netlib buffer with a length < 8, as it's not large enough to even have a
Netlib header.

svn path=/trunk/; revision=6737
2002-12-03 08:36:48 +00:00
Guy Harris
ef94d501a7 Make the fragment item table static and const.
Call the pieces of a multi-frame NetBIOS message fragments, not
segments.

Fix a typo.

svn path=/trunk/; revision=6736
2002-12-03 08:24:58 +00:00
Guy Harris
eccad76867 Show all 6 digits of precision in the time stamp column when displaying
absolute time stamps (we were already doing that for relative and delta
time stamps).

svn path=/trunk/; revision=6735
2002-12-03 02:38:39 +00:00
Guy Harris
ca90d7c688 Cast const pointer arguments to "g_free()" and "g_hash_table_foreach()"
to "gpointer", so that we only get warnings when we turn on the extra
GCC warning checks.

svn path=/trunk/; revision=6734
2002-12-03 02:07:07 +00:00
Jörg Mayer
acbf9274fe Include packet-wlancap.h into the tarball
svn path=/trunk/; revision=6733
2002-12-03 01:44:22 +00:00
Jörg Mayer
4169436eb9 Add compat_macros.h to the tarball
svn path=/trunk/; revision=6732
2002-12-03 01:26:31 +00:00
Guy Harris
6005765a80 Values in Microsoft protocols that don't have their byte order specified
by DCE RPC are usually little-endian; fix a bunch of
"proto_tree_add_item()" calls (most are for byte-array or string fields,
so the byte order doesn't make a difference, but one is a number).

Put an item into the protocol tree for the encrypted NT password block.

Mallocate the buffer for the Unicode version of the password, rather
than assuming it'll fit in 256 bytes.

"g_malloc()" never returns NULL - it either allocates memory or aborts -
so don't check for a mallocation failure.

Don't try to decrypt the NT password block if we don't have a password.

svn path=/trunk/; revision=6731
2002-12-03 01:20:56 +00:00
Jörg Mayer
5dc048d7a5 Gcc was afraid that hs_tree might be used uninitialized. It wasn't, but
silence the warning anyway.

svn path=/trunk/; revision=6730
2002-12-03 01:09:00 +00:00
Jörg Mayer
940af02c66 Update FAQ
svn path=/trunk/; revision=6729
2002-12-03 00:43:11 +00:00
Jörg Mayer
74e583091b Update manuf file
svn path=/trunk/; revision=6728
2002-12-03 00:41:08 +00:00
Guy Harris
dd8f630768 From Devin Heitmueller:
add MD4 and RC4 crypto support;

	use it to decrypt the NT password encryption block in
	UnicodeChangePassword2.

svn path=/trunk/; revision=6727
2002-12-03 00:37:27 +00:00
Guy Harris
59932f2722 Don't cast away constness, and fix variable and structure member
qualifiers as necessary to ensure that we don't have to.

"strcmp()", "strcasecmp()", and "memcmp()" don't return booleans; don't
test their results as if they did.

Use "guint8", not "guchar", for a pointer to (one or more) 8-bit bytes.

Update Michael Tuexen's e-mail address.

svn path=/trunk/; revision=6726
2002-12-02 23:43:30 +00:00
Guy Harris
8414298f89 Make the format argument to the "col_XXX_fstr()" routines, and the "str"
argument to "col_append_str()", const pointers; they're not modified by
the routines in question.

svn path=/trunk/; revision=6725
2002-12-02 23:34:40 +00:00
Guy Harris
cfa04730cf "dfilter_compile()" doesn't modify the string pointed to by its first
argument; make it a const pointer.

svn path=/trunk/; revision=6724
2002-12-02 23:28:16 +00:00
Guy Harris
a55fa6743a Get rid of some no-longer-used routines; there are other routines that
have taken their places.

svn path=/trunk/; revision=6723
2002-12-02 21:20:26 +00:00
Guy Harris
066036ad09 From Olivier Biot: show the packet sequence number and the "Missing
Packets" value in the WTP header in decimal, not hex.

svn path=/trunk/; revision=6722
2002-12-02 20:18:46 +00:00
Guy Harris
b2dc84a384 Update Michael Tuexen's e-mail address.
svn path=/trunk/; revision=6721
2002-12-02 20:08:45 +00:00
Guy Harris
ab90e3212e Cast the result of "tvb_get_ptr()" to a "const char *", not a "char *".
svn path=/trunk/; revision=6720
2002-12-02 20:04:44 +00:00
Guy Harris
b74f119d9a Don't discard the constness of arguments to GHashTable functions.
svn path=/trunk/; revision=6719
2002-12-02 20:04:07 +00:00
Guy Harris
d0a55f13d9 "ip6_to_str()" takes a const pointer as an argument, so you don't have
to cast away the constness of pointers passed to it.

svn path=/trunk/; revision=6718
2002-12-02 20:03:10 +00:00
Guy Harris
f6998aaa23 Get rid of a no-longer-used variable.
svn path=/trunk/; revision=6717
2002-12-02 20:01:55 +00:00
Guy Harris
293ec59fea From Jason House: MSVC++ doesn't like cases with no statements, so add
break statements.

svn path=/trunk/; revision=6716
2002-12-02 19:44:09 +00:00
Olivier Abad
0f3a25cafd Put back the "width" local variable in proto_cb() which is used only by
the GTK1.2 UI.

svn path=/trunk/; revision=6715
2002-12-02 11:05:58 +00:00
Olivier Abad
90b9fa59f6 Make the new protocol list work with GTK2. The "status" column uses a
toggle button instead of a text.

svn path=/trunk/; revision=6714
2002-12-02 10:59:23 +00:00
Michael Tüxen
691cc43cdf Updated the handling of padding bytes.
Support of IG updated to version 01.
Changed e-mail address.

svn path=/trunk/; revision=6713
2002-12-02 10:54:57 +00:00
Olivier Abad
1010194bec Remove gtk_tree_view_set_search_column() which is not needed.
svn path=/trunk/; revision=6712
2002-12-02 10:53:34 +00:00
Gerald Combs
d59c4bd399 Allow keyboard-only navigation of the Protocols dialog. Protocols can
be enabled or disabled using the space bar.  Update the documentation
accordingly.

svn path=/trunk/; revision=6711
2002-12-02 02:28:54 +00:00
Gerald Combs
a10da42709 Enable/disable protocols with a single click. Fix the behavior of
cancelling the Protocols dialog, which my previous checkin broke.

svn path=/trunk/; revision=6710
2002-12-01 22:51:56 +00:00
Guy Harris
0d103e3852 From Brad Hards:
Support for mDNS/LLMNR "cache flush" bit
	Label mDNS and DNS differently in the Protocol column
	Clean up summary line for PTR records

svn path=/trunk/; revision=6709
2002-12-01 20:50:52 +00:00
Guy Harris
25c3ac74fb The previous change caused the delta time to be the delta between a
frame and the previous frame in the capture - a frame that might not be
displayed, so you don't know what it was - rather than the previous
frame in the display, as is intended.  Fix that.

svn path=/trunk/; revision=6708
2002-12-01 20:19:44 +00:00
Gerald Combs
07e0a47740 Update some text in the help dialog.
Replace the large matrix of protocol togglebuttons with a GtkCList. The
CList displays three columns: the enabled/disabled state, the protocol's
abbreviated name and the protocol's full name.  Protocols can be enabled
or disabled by double-clicking on them.  The enable all, disable all, and
invert buttons were left intact.

I made a half-assed attempt at Gtk2 support by copying code from
plugins_dlg.c.  It's incomplete, and probably won't compile.

Using check boxes in the first column instead of the word "Disabled" would
have been nice.  GtkCLists don't let you embed anything besides text and
pixmaps unfortunately.

Update the man page accordingly.

We still need a way to save a list of disabled protocols.

svn path=/trunk/; revision=6707
2002-12-01 19:11:54 +00:00
Ronnie Sahlberg
eb6384af0d Added some flags and value_Strings for netlogon
svn path=/trunk/; revision=6706
2002-11-30 08:34:28 +00:00
Ronnie Sahlberg
f896a13596 From Like H, update to NETLOGON. DSROLEGETPRIMARYDOMAININFO is actually ENUMERATETRUSTEDDOMAINS
svn path=/trunk/; revision=6705
2002-11-29 23:20:41 +00:00
Ronnie Sahlberg
b0e0a37e9e From Luke H. Update to GetDomainInfo
svn path=/trunk/; revision=6704
2002-11-29 22:35:54 +00:00
Ronnie Sahlberg
d5f5ebd79e Updte for io-stat to make it more powerful.
There is not a third option Advanced... in addition to frames/tick and bytes/tick.


See ethereal man page for description and how one can use this to graph how NFS response time MAX/MIN/AVG changes over time.

svn path=/trunk/; revision=6703
2002-11-29 11:37:33 +00:00
Ronnie Sahlberg
56e511657d calculate delta and rel time earlier and unconditionally of whether the packet passed the displayfilter or not.
there may be tap listeners that want to examine this field.

svn path=/trunk/; revision=6702
2002-11-29 11:02:13 +00:00
Guy Harris
85fd3afd2f Before dissecting the payload of a Protocol-Reject LCP packet, save the
current "this is an error packet" flag and set that flag, so the payload
is dissected as the payload of an error packet rather than as a "real"
packet.

svn path=/trunk/; revision=6701
2002-11-28 22:18:53 +00:00
Guy Harris
b16fb8f257 Fix "addr_ip6_to_str" to reflect the fact that "ip6_to_str()" now takes
a const pointer as its argument.

svn path=/trunk/; revision=6700
2002-11-28 22:13:52 +00:00