Change-Id: Id1dff9050ba2224833ee9a83298e0da95d8b3a9c
Reviewed-on: https://code.wireshark.org/review/33683
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Change-Id: I655b5b9eb75d339afbd8b9184ef85ffb7dd33774
Reviewed-on: https://code.wireshark.org/review/33681
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
proto_tree_add_item() does no validation if ENC_UTF_8 is used as the
encoding, so there's no guarantee that the value of a string field is
valid UTF-8, and in some dissectors UTF-8 strings are fetched with other
mechanisms and then added with proto_tree_add_string().
We need to do some cleanup on string handling.
Bug: 15848
Change-Id: Ifc43111dbb47c478fa11280f2f771d90202499fa
Reviewed-on: https://code.wireshark.org/review/33677
Reviewed-by: Guy Harris <guy@alum.mit.edu>
We were using fields in the pcapng_t that weren't set yet to report the
version number in question; use the variables we were checking.
Change-Id: Ib03bafe62d8c7b1aa54b2ef22640e3b00722142a
Ping-Bug: 15862
Reviewed-on: https://code.wireshark.org/review/33671
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Since IE number used to match during parsing is implied from enum
position, having those enum values commented out make
BE_SELECTED_PLMN_ID fall in the wrong position (expected 0x94), and thus
not matching it correctly during parse.
Enabling the not-yet fully supported IEs which were under "ifdef 0"
doesn't make the current situation worse than before, so let's simply
enable it and pass NULL as a function for those.
Change-Id: I70063e653acf588f3d07bb8900afa3a48e124d6d
Reviewed-on: https://code.wireshark.org/review/33667
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This has to be a complete overhaul of PacketListRecord. For now it is reverted
This reverts commit d95262bf74.
Change-Id: Id72dc6911f68c9b811110332588b3da474791d31
Reviewed-on: https://code.wireshark.org/review/33666
Reviewed-by: Roland Knall <rknall@gmail.com>
Couchbase DCP sequence numbers start from zero, incrementing by one
for each message; and are generally displayed inside Couchbase as
decimal.
For ease of use with Wireshark dumps, print them as decimal instead of
hex.
Change-Id: I590fe137b96263d589e0ccc3161b57ffee40854b
Reviewed-on: https://code.wireshark.org/review/33660
Reviewed-by: Ben Huddleston <ben.huddleston@couchbase.com>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Jim Walker <jim@couchbase.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
While at it, ensure that we have no overflow when parsing the sub-TLV.
Bug: 15856
Change-Id: I2ceb30fd8a6abc2577c9df7baf6ceb45ee5f5b38
Reviewed-on: https://code.wireshark.org/review/33656
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Add a `-l n` option which will check the .c and .cpp files from the last
[n] commits.
Fix some shellcheck warnings.
Change-Id: I8185d6c6c5b08576315b47847795d210d47b042e
Reviewed-on: https://code.wireshark.org/review/33646
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
with last draft, there is temporary registered value to IANA
Global Association Source (30)
Extended Association Id(31)
ASSOCIATION (40)
Bug: 15834
Change-Id: I07a1eefdf650a295a6b9d9ae457f9d85204dab63
Ping-Bug: 11782
Reviewed-on: https://code.wireshark.org/review/33641
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This is no more required.
Change-Id: Ib88066eaa0cb7f8b30cfe93bbdc797882802b992
Reviewed-on: https://code.wireshark.org/review/33642
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
This reverts commit 5d0fec3363.
"set -e" breaks all macOS builds after completing the script block.
Change-Id: I5c297fd4b1b816d3143fa8fd8a51eb848c7c2de4
Reviewed-on: https://code.wireshark.org/review/33638
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
The TCP MSS option is annotated by expert items as follows:
- in a SYN packet the lack of the MSS option could indicate
a misconfigured node.
- in a non-SYN packet the presence of the MSS option could indicate
a malfunctioning node.
Change-Id: Ie3827cd6c7dcf605ac2f72a3a080418611637070
Reviewed-on: https://code.wireshark.org/review/33632
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Move plus-8.png to stock_icons/8x8 and rename it list-add.template.png
which conforms to the Freedesktop icon naming specifications and makes
it a template icon.
Update our style sheet when we recive a QEvent::PaletteChange.
Ping-Bug: 15511
Change-Id: I4b8ddcb4eb64f11faec21d5df4a3fd7fdc5cf488
Reviewed-on: https://code.wireshark.org/review/33626
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
If a DnD is initiated from the ProtoTree it actually copies the complete
text of the expanded tree elements. This can be dropped in any text-window
outside of Wireshark
Change-Id: Ia174bcf2f061ddb23439c3243149bb54a1ba89d9
Reviewed-on: https://code.wireshark.org/review/33630
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
If you start dragging on an empty field, you pick up the value of
a field you drag over. This is fixed
Change-Id: I7e1c5e353dbc79ee1193b305729fb44d62d98470
Reviewed-on: https://code.wireshark.org/review/33629
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
wmem should not be used inside a model, as the memory managment of
those models is part of the responsibility of Qt. It could happen,
that the file is closed, but the model still needs to access the
information, in which case the memory access fails.
Change-Id: I740a4bae61cc32f0f0245515c23abf175ef588f1
Reviewed-on: https://code.wireshark.org/review/33622
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Allow for drag-and-drop on info and protocol columns. Protocol columns
may also be dragged to the display filter, everything else is dragged
as plain-text and can just be used as text
Change-Id: I0fff390580c22175efe50037b18d7199949fd8eb
Reviewed-on: https://code.wireshark.org/review/33621
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Only initiate drag-and-drop when the left mousebutton has been
clicked, and also add the filter as plain text, so to enable
dragging to external applications.
Change-Id: I2f6ac7f9c543d003070c2a6c0ce671ed5a215669
Reviewed-on: https://code.wireshark.org/review/33620
Petri-Dish: Roland Knall <rknall@gmail.com>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Change-Id: Id67a159615ba2d8edbfabd36d33d3e01438a3c77
Reviewed-on: https://code.wireshark.org/review/33625
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
USBPcap 1.5.0.0 features two main changes:
* Introduction of USB IRP Info transfer type (0xFE)
This type is used when the IRP is of general interest to the user,
but does not really directly match to any USB payload. When such
type is encountered, display the URB Function code in Info column.
Currently following URB functions are recorded as USB IRP Info:
* URB_FUNCTION_SYNC_RESET_PIPE_AND_CLEAR_STALL
* URB_FUNCTION_SYNC_RESET_PIPE
* URB_FUNCTION_SYNC_CLEAR_STALL
* URB_FUNCTION_ABORT_PIPE
* URB_FUNCTION_CLOSE_STATIC_STREAMS
* Introduction of control stage COMPLETE (0x03)
The control transactions are now recorded as 2 packets: SETUP and
COMPLETE. All Wireshark versions since the USBPcap pseudoheader
support was implemented correctly pass the data to subdissectors.
This makes the USBPcap control packets behave just like usbmon.
Ping-Bug: 15842
Change-Id: Idc0edf2a0fcf58997531c492293e0719f037493f
Reviewed-on: https://code.wireshark.org/review/33623
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
It was used for two purposes:
1) passing the subcommand to dissectors for the request setup,
parameters, and data;
2) getting the security descriptor and extended attribute length
from the request parameters and passing them to the dissector
for the request data.
It was completely unused for responses.
Pass the subcommand as an argument to all routines that need it,
pass pointers to local variables to the request parameters dissector,
and pass those variables to the request data dissector.
This makes it a bit clearer what information is needed where, and
completely eliminates the structure for response dissection.
Change-Id: I431daa79da41dc4166490a564efee71cdb83edc1
Reviewed-on: https://code.wireshark.org/review/33614
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Bruno Verstuyft
Pau Espin