Commit Graph

14205 Commits

Author SHA1 Message Date
Olivier Biot 97babfb98d From Gilbert Ramirez - Fix a FT_NONE with a bitmask (shouldn't have one).
svn path=/trunk/; revision=14459
2005-05-28 00:51:56 +00:00
Ronnie Sahlberg 0890269d05 from Gilbert,
make kink compile again on non-kerberos builds.

encapsulate a call to decrypt kerberos to only be compiled in when compiling with kerberos.


svn path=/trunk/; revision=14458
2005-05-27 21:39:38 +00:00
Ronnie Sahlberg 6879e6da67 from didier fix for the regression for bug 62
svn path=/trunk/; revision=14457
2005-05-27 21:33:27 +00:00
Anders Broman d328993c0d From Martin Mathieson
packet-rdt.c:
- register a configurable UDP port (off by default, but needed where setup traffic isn't captured)
- dissect extra 'buffer info' fields
- move bit fields into 'flags' subtrees
- misc. minor fixes and improvements (mainly formatting)
Missed eralier...

svn path=/trunk/; revision=14456
2005-05-27 18:35:19 +00:00
Luis Ontanon 4cd25ccc5e don't use a static buffer for preference values, allocate it, and, if necessary reallocate so that
the string always fits.


svn path=/trunk/; revision=14455
2005-05-27 18:33:09 +00:00
Gilbert Ramirez c2454f0260 Add a "-G fields3" report which prints the bitmask of the field, and avoids
printing the blurb twice, like fields2 does.
Add a script, fsanity.py, to check sanity of FT definitions. Right now the
only check is for bitmasks for integer-like fields.

svn path=/trunk/; revision=14454
2005-05-27 15:13:09 +00:00
Ronnie Sahlberg 94d8512749 From T.Nakashima
updates to KINK


svn path=/trunk/; revision=14453
2005-05-27 08:53:07 +00:00
Ronnie Sahlberg 864245ef6e cket wsp is creating string items and later appending to them and their value at runtime which breaks when the TRY_TO_FAKE_THIS_ITEM() is used.
Add a comment to proto_item_append_string() explaining the "danger" and what needs to be done if one decides to use proto_item_append_string()

Add a small change to WSP so that it will disable this speed optimization so not to trigger a DISSECTOR_BUG in proto_item_append_string()




svn path=/trunk/; revision=14452
2005-05-27 06:00:08 +00:00
Ronnie Sahlberg 0938d01e38 GdKEventScroll is not available in GTK-1.2
svn path=/trunk/; revision=14451
2005-05-27 05:04:03 +00:00
Guy Harris cb3bc515e2 The DESIRE_ and OS_ values are bit indices, not numerical values that
appear by themselves; get rid of the value_string tables for them.

svn path=/trunk/; revision=14450
2005-05-27 02:30:10 +00:00
Ulf Lamping abab83d6e4 fix #203: the scroll event handler used an inappropriate implementation to get event values, fixed this. On win32 this was working before and after the changes, so the bug *might* remain ...
svn path=/trunk/; revision=14448
2005-05-26 23:18:10 +00:00
Ulf Lamping de4bd60dcb show the complete filename in the statusbar, as there's no good reason to hide it (bugzilla #198)
fix various log related problems

svn path=/trunk/; revision=14447
2005-05-26 21:49:48 +00:00
Ulf Lamping f04a2a23ba changed the loglevel of "capture kill" from message to info (it's no action that the user directly triggered)
svn path=/trunk/; revision=14446
2005-05-26 21:45:58 +00:00
Ulf Lamping 56465457d6 add log.h
svn path=/trunk/; revision=14445
2005-05-26 20:23:13 +00:00
Anders Broman 93eee03ae8 From Martin Mathieson:
This 2-liner:
- adds the correct item for localconnectionoptions param
- recognises the message verb "MESG"

svn path=/trunk/; revision=14444
2005-05-26 20:13:42 +00:00
Anders Broman 7f936ea1c4 These 2 patches make RDT support pretty complete now:
From Martin Mathieson:

packet-rdt.c:
- register a configurable UDP port (off by default, but needed where setup traffic isn't captured)
- dissect extra 'buffer info' fields
- move bit fields into 'flags' subtrees
- misc. minor fixes and improvements (mainly formatting)

packet-rtsp.c:
- improve detection of RDT as the transport
- allow interleaved frame data to be dissected as RDT packets

svn path=/trunk/; revision=14443
2005-05-26 20:11:35 +00:00
Ulf Lamping 2c672ff840 fix #125: as suggested, the data in rechdr has to be kept over several calls to capture_loop_dispatch, so put it in the loop_data
svn path=/trunk/; revision=14442
2005-05-26 19:38:26 +00:00
Ulf Lamping 6a853e1bc3 some cleanup of capture error notification handling
svn path=/trunk/; revision=14441
2005-05-26 19:06:01 +00:00
Ulf Lamping edf3ec1d92 don't use stdout but stderr for logging, as this will confuse the capture childs sync_pipe (has to be solved later)
svn path=/trunk/; revision=14440
2005-05-26 18:29:09 +00:00
Ulf Lamping 464c90155b avoid two gcc warnings
svn path=/trunk/; revision=14439
2005-05-26 18:03:34 +00:00
Ulf Lamping 5d404864f2 use the log features of the GLib to have verbose output of the capturing engine, e.g. GLib provides different domains for different submodules. Output more verbose than warning level will be disabled by default (just like before).
use the console_log_handler in main.c for win32 AND unix now

Currently use the log for the capturing engine (only), as I desperately needed a log output for debugging.


svn path=/trunk/; revision=14438
2005-05-26 17:50:27 +00:00
Gerald Combs 4a5deae575 In some places we call proto_tree_add_item() with hfindex and length
values that may not be valid (e.g. dissect_ber_octet_string()
in packet-ber.c).  If the length is invalid, get_uint_value() or
get_int_value() will abort.  Change them to throw an exception instead.
This keeps us from having to do a lot of extra work in the dissector.

Fixes bug 182.


svn path=/trunk/; revision=14437
2005-05-26 14:53:39 +00:00
Ulf Lamping 351214282d the capture child might not respond shortly after bringing it up (especially it will block, if no input coming from an input capture pipe (e.g. mkfifo) is coming in)
to prevent problems, bring the main GUI into "capture mode" right after successfully spawn/exec the capture child, without waiting for any response from it

svn path=/trunk/; revision=14436
2005-05-25 23:28:59 +00:00
Ulf Lamping b3b72959a2 forgot to init savefilestring = NULL;
svn path=/trunk/; revision=14435
2005-05-25 22:20:46 +00:00
Ulf Lamping a3d36ae031 add const to pcap_next_ex() parameter, as WinPcap 3.1 beta 4 (and libpcap 0.8) requires it
svn path=/trunk/; revision=14434
2005-05-25 21:37:46 +00:00
Anders Broman a67a1fb29b Back out the two last changes by popular demand :)
as we don't want multiple language versions.

svn path=/trunk/; revision=14433
2005-05-25 18:27:33 +00:00
Ulf Lamping fbe12a9a22 fix #199: encapsulate capture filename, to avoid problems with spaces in the filename (win32 only)
svn path=/trunk/; revision=14432
2005-05-25 17:46:04 +00:00
Guy Harris d22b1f3cbe Update URLs for WinPcap.
svn path=/trunk/; revision=14431
2005-05-25 16:59:59 +00:00
Guy Harris 4a1414164f Add some more reassembly routines.
svn path=/trunk/; revision=14430
2005-05-25 08:25:14 +00:00
Ulf Lamping d35789c6c7 fix IRemUnknown2 UUID
svn path=/trunk/; revision=14429
2005-05-24 20:01:08 +00:00
Ulf Lamping 5fd2ecb1d5 add values for STDOBJREF flags
svn path=/trunk/; revision=14428
2005-05-24 20:00:14 +00:00
Ulf Lamping c911c15371 dissect ORPC this/that of RemoteCreateInstance
svn path=/trunk/; revision=14427
2005-05-24 19:59:20 +00:00
Ulf Lamping 5812f26b65 dissect ServerAlive response
svn path=/trunk/; revision=14426
2005-05-24 19:57:37 +00:00
Gerald Combs 1c650087ac Add extra TLV length checks and signedness fixes. Fixes the infinite loop in
bug 196.

svn path=/trunk/; revision=14425
2005-05-24 16:46:18 +00:00
Gerald Combs 1a5605dc21 Throw an exception instead of calling g_assert_not_reached(). Fixes bug 175.
svn path=/trunk/; revision=14424
2005-05-24 13:50:20 +00:00
Guy Harris ea838882e6 Include "webbrowser.h" to declare "browser_open_url()".
svn path=/trunk/; revision=14423
2005-05-24 01:28:25 +00:00
Gerald Combs f6d48e45c8 Make sure we don't loop when we dissect concatenated PDUs. Make some int
values larger in order to keep them from overflowing.

svn path=/trunk/; revision=14422
2005-05-23 21:18:14 +00:00
Anders Broman f462883ea8 Warning fix:
packet-camel.h:49: warning: 'dissect_camel_DestinationAddress' declared 'static' but never defined
do this change also for the template file.

svn path=/trunk/; revision=14421
2005-05-23 18:37:45 +00:00
Jörg Mayer 19e90d9a5c Warning fix:
packet-bacapp.c:1264: warning: ISO C does not allow extra ';' outside of
a function


svn path=/trunk/; revision=14420
2005-05-23 12:32:37 +00:00
Jörg Mayer 4a6049d3b1 Warning fix:
packet-camel.h:49: warning: 'dissect_camel_DestinationAddress' declared 'static' but never defined


svn path=/trunk/; revision=14419
2005-05-23 12:19:00 +00:00
Jörg Mayer 83f9a803ac Warning fix:
packet-bacapp.c:1266:1: warning: C++ style comments are not allowed in ISO C90
packet-bacapp.c:1266:1: warning: (this will be reported only once per input file)


svn path=/trunk/; revision=14418
2005-05-23 12:18:10 +00:00
Anders Broman 33aa290b25 From Steve Karg:
* added additional value string enumerations from BACnet-2004
* removed vendor specific value string enumerations
* corrected some value strings enumerations that were incorrect
* refactored some common strings as strings + format
* refactored some value strings to use a reserved range and a 
proprietary range by using val_to_split_str function which now correctly 
shows the split range when a value is not matched.
* corrected some spelling errors
* converted some item text values to dissector registration
* added protocol tree for the BACnet tag headers
* added value strings tree display for some bit string BACnet properties
* added value strings tree display for some enumerated BACnet properties
* changed the conversion of signed, unsigned, and enumerated BACnet 
values to use ntohx functions.
* added proper handling for large values of signed, unsigned, and 
enumerated BACnet values.
* refactored BACnet Null and Boolean Tag tree
* refactored BACnet Real and Double Tag tree
* changed comments into functions for special tags
* changed some white space to match existing file style
* refactored tvb_reported_length to tvb_length_remaining to simplify
* corrected octet-string tree when length is zero
* refactored octet-string tree to use tvb_bytes_to_str
* corrected application tagged productions that were context tagged
* corrected context tagged productions that were application tagged
* corrected offset for BACnet character strings
* refactored some identical service request tree handling
* changed confirmed APDU to highlight the correct portion of the APDU
* changed some dissector registration values to display as decimal
* changed cast in call to iconv() to fix compiler warning
* corrected bit-wise AND in AtomicFile tree handling

packet-bvlc.c
* added error text in tree when encoded length doesn't match actual length

svn path=/trunk/; revision=14417
2005-05-23 05:52:28 +00:00
Luis Ontanon dbe55501fc at this point mate should be working as it did before the grammar
- pdu transports were upside down (ip/tcp vs tcp/ip)
 - the gop to gog index was not being populated
 - tell svn to ignore generated c files


svn path=/trunk/; revision=14416
2005-05-22 00:44:34 +00:00
Luis Ontanon 86a30241db PDU, GOP and GOG should be at the same level not nested
svn path=/trunk/; revision=14415
2005-05-21 15:47:18 +00:00
Ulf Lamping 4eec579041 don't crash if packet.dll is not available, add some more packet.dll version numbers
svn path=/trunk/; revision=14414
2005-05-21 11:10:16 +00:00
Ulf Lamping 7c7ee07c4e bugfix: prevent a (null pointer access) crash with very early WinPcap version < 2.3
svn path=/trunk/; revision=14413
2005-05-21 11:08:48 +00:00
Ulf Lamping f6831ab340 bugfix: mark pcap_freecode() as optional, as it's not available by WinPcap 2.3
add optional pcap_next_ex() which is currently unused

svn path=/trunk/; revision=14412
2005-05-21 09:59:49 +00:00
Ulf Lamping b5d1f77046 as suggested by Loris: add wpcap_packet_get_version() and check the packet.dll version before using it (very restrictive for now, will check for exact DLL version strings). If version is unknown, ask user to continue or not.
svn path=/trunk/; revision=14411
2005-05-21 09:41:57 +00:00
Anders Broman b91e9cb311 From Javier Acuna:
It adds "CIC" info display on the comments column for ISUP
It adds a small Help button that open up a window that offers you to vist the Wiki page containing the explanation of the Dialog window.


svn path=/trunk/; revision=14410
2005-05-21 09:26:16 +00:00
Anders Broman c40a7d2ad9 From Javier Acuna:
filter packets by their Billing ID

svn path=/trunk/; revision=14409
2005-05-21 09:13:28 +00:00