Commit Graph

14205 Commits

Author SHA1 Message Date
Gerald Combs c2b4cd7993 Don't roll our own buffer-overflow-able string_to_hex() routine
when there's a perfectly good tvb_bytes_to_str() lying around, just
_begging_ to be used.

Fix up white space.

svn path=/trunk/; revision=14304
2005-05-04 15:35:21 +00:00
Uwe Girlich c1c395dc2d Added RPC/ONC SYSTEM_ERROR accept state.
svn path=/trunk/; revision=14303
2005-05-04 13:09:46 +00:00
Anders Broman be12da7f98 Dissect GPRS user data.
svn path=/trunk/; revision=14302
2005-05-03 20:53:21 +00:00
Ulf Lamping 1a9152727b add a *lot* more dissections of the various PN-IO blocks
svn path=/trunk/; revision=14301
2005-05-03 19:58:05 +00:00
Gerald Combs 985f94ec24 In proto_tree_set_string(), don't set a null fvalue or Ethereal will throw
a hissy fit.  Fixes bug 157.

svn path=/trunk/; revision=14299
2005-05-03 19:33:02 +00:00
Gerald Combs 9ab36a73a8 Back out all of the tvb_ensure_bytes_exist() calls. They shouldn't be
neccessary any more, and were causing problems.

svn path=/trunk/; revision=14298
2005-05-03 18:43:06 +00:00
Gerald Combs 2ab34cb095 Fix two places where we might loop infinitely, including the one found in
bug 155.  Fix a couple of compiler warnings.

svn path=/trunk/; revision=14289
2005-05-03 14:36:08 +00:00
Michael Tüxen 0332e7c9dd Base the assoc search on port/vtags only.
svn path=/trunk/; revision=14288
2005-05-03 08:34:11 +00:00
Anders Broman 07e46b0c48 From Nils O. Sel?sdal:
- Decodes all the remaining bitfields in 9P
- Tidies up display a bit (using more subtrees)
- Fixes a few fields that are better off displayed as decimal/octal.


svn path=/trunk/; revision=14287
2005-05-03 05:22:43 +00:00
Gilbert Ramirez 32660dc86e Fix typos in error messages.
svn path=/trunk/; revision=14286
2005-05-03 02:07:26 +00:00
Ulf Lamping 4e3c0cde68 move the pn-dcp dissector into the profinet plugin
svn path=/trunk/; revision=14285
2005-05-03 01:39:00 +00:00
Lars Roland 5bb4e926aa add the new target "install-plugins" to nmake makefile
in the plugins subdirectory. This target will copy all plugins to plugins/$(VERSION), thus (t)ethereal will
find and load the plugins when called from within the source tree.

call this target from the main nmake makefile after
installing other dependencies. call it from the nmake makefile
in the doc subdirectory before calling "tethereal -G".
This way "tethereal -G" will recognize the filterable
fields from the plugins, too.


svn path=/trunk/; revision=14284
2005-05-03 01:03:33 +00:00
Lars Roland cca89430e4 add another lenght check in the megaco dissector.
Fixes bug 150.

svn path=/trunk/; revision=14283
2005-05-03 00:19:08 +00:00
Michael Tüxen 9125cf4c7e Get profinet compiling on Unix.
svn path=/trunk/; revision=14282
2005-05-02 22:15:00 +00:00
Gerald Combs 313d9105f3 From Rich Coe:
- fix memory leak when Assoc packet is processed repeatedly in ethereal

 - removed unused partial packet flag

 - added better support for DICOM VR
     - sequences
     - report actual VR in packet display, if supplied by xfer syntax 
     - show that we are not displaying entire tag string with '[...]',
       some tags can hold up to 2^32-1 chars

 - remove my goofy attempt at trying to get access to the fragmented packets
   (anyone have an idea on how to fix this ???)

 - process all the data in the Assoc packet even if display is off

 - limit display of data in Assoc packet to defined size of the data even
   if reported size is larger

 - show the last tag in a packet as [incomplete] if we don't have all the data

 - added framework for reporting DICOM async negotiation (not finished)
   (I'm not aware of an implementation which currently supports this)

 - still need to fix display of continuation packets

svn path=/trunk/; revision=14280
2005-05-02 21:56:40 +00:00
Michael Tüxen b4af92846c Provide an indication to taps if the verification tag is reflected.
svn path=/trunk/; revision=14278
2005-05-02 20:45:22 +00:00
Gerald Combs 949a9da364 Break out of an infinite loop. Fixes bug 154.
svn path=/trunk/; revision=14277
2005-05-02 20:30:56 +00:00
Anders Broman a105502f35 Dissect URLC correctly and add dissection of LCC PDU.
svn path=/trunk/; revision=14276
2005-05-02 20:26:56 +00:00
Gerald Combs 3d582e6e55 In dissect_mgcp_firstline(), throw an exception if tokenlen > 4. This fixes
bug 145, but may not be the best solution.

svn path=/trunk/; revision=14275
2005-05-02 20:05:03 +00:00
Anders Broman c1a1967218 Add dissection of Q.850 cause.
svn path=/trunk/; revision=14274
2005-05-02 18:32:57 +00:00
Anders Broman 5a2d87c586 Add dissection of q850 cause.
svn path=/trunk/; revision=14273
2005-05-02 18:32:00 +00:00
Anders Broman be5db98edd Correct some AVP:s and minor updates from iana.org
svn path=/trunk/; revision=14272
2005-05-02 18:31:15 +00:00
Anders Broman 3f395aec51 Use the correct parameters in a function call.
svn path=/trunk/; revision=14271
2005-05-02 18:30:14 +00:00
Gerald Combs f2ffbf0a46 Prep for the next release. ETA Wednesday (the 4th).
svn path=/trunk/; revision=14270
2005-05-02 16:34:24 +00:00
Gerald Combs b233c06fb2 From Cvetan Ivanov:
This patch fixes the slightly broken logic in the loop which searches
for establisted call in isup_calls_packet.

The problem is that (right_pair) is set to false if we see call on the
same CIC as existing conversation, but with different opc/dpc pair:

at this point dpc/opc pair is not checked, so any call with the same
CIC matches:

voip_call.c:851
                                 else{
                                         right_pair = FALSE;
                                 }

and then the correct conversation is never found, because right_pair is
never reset for this packet, which leads to total confusion of the call
tracking logic

Fixed by initializing right_pair = TRUE for every loop iteration 

svn path=/trunk/; revision=14269
2005-05-02 14:45:43 +00:00
Gerald Combs f8765a5a28 From Cvetan Ivanov:
1) dissect_isup_calling_party_number_parameter reported malformed packet
if the calling party number IE contains empty number (possibly with
presentation set to 'number not available')

I've basicly added if(length > 0) around the digits tree dissector,
which may not be obvious from the patch becase of the indenting of the
entire block.

2) As the tap_calling_number is static, if there is call with missing
calling_party_number IE, it gets assigned the calling party number of
the previuos call containing such IE.

fixed by adding tap_calling_number = NULL;
in the beginning of dissect_isup_message, and

tap_rec.calling_number=tap_calling_number?tap_calling_number:g_strdup("");

in the end to avoid segfault

Those things may not happen too often in the telecom world, but happen
all the time with VoIP.


svn path=/trunk/; revision=14268
2005-05-02 14:41:07 +00:00
Gerald Combs 8398cb4066 Add "plugins/profinet/Makefile" to configure.in.
svn path=/trunk/; revision=14267
2005-05-02 14:24:09 +00:00
Gerald Combs bf48f8e4d4 Check for a few more integer overflows. Found during fuzz testing.
svn path=/trunk/; revision=14266
2005-05-02 14:12:42 +00:00
Michael Tüxen 23d022349d - Add support for libpcap files for MTP2 with a per packet header
indicating the direction, narrowband/broadband, and interface number.
- Add support to display the direction and interface number.
- Add support to packet-mtp2.c to use the broadband/narrowband indication.

svn path=/trunk/; revision=14265
2005-05-02 14:07:33 +00:00
Michael Tüxen 5e89412e0c Fix a bug in counting DATA chunks.
svn path=/trunk/; revision=14264
2005-05-02 14:04:25 +00:00
Michael Tüxen 8403c50a91 Get rid of trailing \
svn path=/trunk/; revision=14263
2005-05-02 10:59:51 +00:00
Ulf Lamping 9656f54e9b as Thomas Boehne suggested, put each plugin target into it's own line, so private plugins can better keep in track with the official Makefile's
svn path=/trunk/; revision=14262
2005-05-02 10:47:12 +00:00
Ulf Lamping cf33dbddb3 added the profinet plugin
svn path=/trunk/; revision=14261
2005-05-02 10:35:37 +00:00
Gerald Combs 2e0f4b9750 Fix a couple of infinite loops. Make similar changes elsewhere to keep the
code consistent.

svn path=/trunk/; revision=14260
2005-05-02 00:57:44 +00:00
Lars Roland 2f5fee9c99 Add an install-deps target to the nmake makefiles.
This target will copy all files, mainly dlls, which
are necessary to run (t)ethereal to the source tree.

After copying all necessary dlls to the source tree,
you can run (t)ethereal directly from the source tree.

svn path=/trunk/; revision=14259
2005-05-01 23:03:45 +00:00
Michael Tüxen e0d7600bb5 Fix chunk length handling. Go back to initial concept that
the chunk_length always is the length indicated in the packet header.

svn path=/trunk/; revision=14258
2005-05-01 21:00:26 +00:00
Michael Tüxen d33365dc43 Get rid of some debug code.
svn path=/trunk/; revision=14257
2005-05-01 13:59:07 +00:00
Michael Tüxen 8a852887ae Editorial stuff.
svn path=/trunk/; revision=14256
2005-05-01 13:55:09 +00:00
Michael Tüxen b3f69cada5 Editorial stuff
svn path=/trunk/; revision=14255
2005-05-01 13:53:53 +00:00
Gerald Combs 17fa218ed5 Make sure we pass a positive length to proto_item_set_len().
svn path=/trunk/; revision=14254
2005-05-01 13:52:15 +00:00
Michael Tüxen 053504ca5c Editorial stuff.
svn path=/trunk/; revision=14253
2005-05-01 13:52:05 +00:00
Michael Tüxen db8ff6d946 Editorial cleanups
svn path=/trunk/; revision=14252
2005-05-01 13:51:07 +00:00
Michael Tüxen 05f840c40e Editorial cleanups.
svn path=/trunk/; revision=14251
2005-05-01 13:50:02 +00:00
Gerald Combs 9f61403c0b Break out of another infinite loop. Found during fuzz testing.
svn path=/trunk/; revision=14250
2005-05-01 13:36:00 +00:00
Ulf Lamping a46d7d2d59 set subversion attributes
svn path=/trunk/; revision=14249
2005-04-30 20:55:21 +00:00
Ulf Lamping 48aee19b1a move the profinet related files to a plugin (step by step), to make prototyping and further development easier (at least for me :-)
svn path=/trunk/; revision=14248
2005-04-30 20:52:20 +00:00
Gerald Combs 6ba8b243b0 Fix a buffer overflow found during fuzz testing.
svn path=/trunk/; revision=14247
2005-04-30 19:37:03 +00:00
Ulf Lamping 2777289f85 removed various gcc warnings
svn path=/trunk/; revision=14246
2005-04-30 17:23:33 +00:00
Gerald Combs a416a4b6f5 Check for an integer overflow. Fixes bug 149.
svn path=/trunk/; revision=14245
2005-04-30 16:42:04 +00:00
Ronnie Sahlberg 75438b269f From Miklos Szurdi :
update to GSM_A to display the maximum bit rate properly



svn path=/trunk/; revision=14244
2005-04-30 16:29:03 +00:00