Since nextseq is incremented by an extra one byte for SYN/FIN packets,
the out-of-order check should take that into account. Otherwise an
immediately retransmitted SYN or FIN is treated as a retransmission.
Related to #13843.
Add comments to indicate what types of display information various field
types are allowed.
Make the error messages for fields that only allow some particular
display information types specific to those types, rather than saying
"no field information allowed". This also gets rid of some
fallthroughs, one of which allows BASE_PROTOCOL_INFO for floating-point
types, which makes no sense.
Show missing sequence numbers with from and to instead of listing
every number in the range as generated fields.
Bonus: explicitly show the range delimiter.
Fixes: #17932
The fix for #17926 got the check backwards, so non-empty arrays, sets,
and bags couldn't be dissected, as they'd always report a "zero-length
item" error. Both versions of the check dissect zero-length items, as
they test for equality, but the old version thought that a
non-zero-length item was also bad, as the offset was greater after
dissecting the item than before dissecting the item.
Apparently on Windows, if a dialog contains spaces it is not properly
opened via /select. But opening the file via QDesktopServices leads to
the file not being selected in the open explorer windows (expectation by
the user). Therefore the original change is restored, but with a
differenc call which should handle the space issue in most cases better
than before. See
https://stackoverflow.com/questions/3490336/how-to-reveal-in-finder-or-show-in-explorer-with-qt
for a short explanation (bottom of post)
Fixes#17927
Within the cKSUMTYPE-GSSAPI (0x8003) BLOB we should not try to decrypt
CRED data if etype 0 is used.
This is used by a Heimdal client as the authenticator is already
encrypted. Windows encrypts it again using the same key that was
used to encrypt the authenticator.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Windows clients use pA-TGS-REQ before pA-FX-FAST, which means
we have a the subkey from the pA-TGS-REQ
AP-REQ/Authenticator before we try to decrypt the
pA-FS-FAST/enc-fast-req.
But a Heimdal client sends pA-FX-FAST before pA-TGS-REQ.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Add handling of application/senml+cbor and application/sensml+cbor.
This dissector does not give a good representation of the content
and should be improved.
g_utf8_validate_len doesn't exist until glib 2.60, so just
use g_utf8_validate. It does the same thing when the length parameter
is unsigned. Fixes CentOS 7.
Add BASE_SHOW_UTF_8_PRINTABLE and related function tvb_utf_8_isprint
for supporting fields of bytes that are "maybe UTF-8" (default or
SHOULD be UTF-8 but could be something else, with no encoding indicator),
such as SSID fields in IEEE 802.11 (See #16208), certain OctetString
fields in Diameter or PFCP, and other places where
BASE_SHOW_ASCII_PRINTABLE is currently used. Fix#5307
Jérôme HAMM