On glib-1.2 systems g_ascii_strcasecmp() is in libwireshark (which we don't
want to include in dumpcap) and anyway our code should be the only thing
calling dumpcap with "-Z"--so hopefully there's no need for doing a
case-insensitive comparison.
(This is another argument for adding a "utils" library.)
svn path=/trunk/; revision=24462
building man pages. Make ws.css in the current directory depend on
$(srcdir)/docbook/ws.css, not just docbook/ws.css, so that builds work
outside the source directory. Clean up ws.css in the current directory
when doing "make distclean".
svn path=/trunk/; revision=24449
1. Clean up dumpcap 'as a child' err msg handling so that:
- all err msgs are properly formatted when being sent
back to the parent.
- any log Critical, Warning, etc messages
are sent back to parent and are properly formatted.
2. Change handling of -w <...> slightly in capture_opts.c
so that wireshark provides a good error message if
there is a 'write permissions' issue on the file.
(Previously the error popup said only
"Child exited with status 2").
This fixes bug #2288.
Add some conditionalized DEBUG_CHILD_DUMPCAP code for
dumpcap debug logging to a file.
svn path=/trunk/; revision=24446
filter expressions such as filter == value, which won't work as a custom
column. We may need to modify its behavior to prevent entire expressions
from being entered. For the time being though, it does check the filter
syntax itself as well.
svn path=/trunk/; revision=24441
epan/dissectors/packet-bacapp.c the BACnetErrorCode array contains incorrect
enumeration mappings for BACnet error codes. Attached is a version of the file
with the mappings straightened out.
svn path=/trunk/; revision=24435
- In proto_tree_set_uint and proto_tree_set_int use value adjusted for bitmask.
- Removed col_custom_set_fstr in proto_tree_set_boolean to get a correct
adjusted value in proto_tree_set_uint.
- Set a default column width shorter than COL_INFO.
svn path=/trunk/; revision=24417
surprised by, for example, "i" not comparing equal to "I" in Turkish
locales.
Make gMessageType local - it's not used as a global variable. Also,
make it a pointer to const, so that we don't have to cast away the
constness.
dissect_giop_fragment() doesn't use the "header" argument, so get rid of
it.
Clean up indentation a bit.
The first element of a value_string is the value, and the second
argument is the string; fix up the initialization of the table of code
set values.
Fix a proto_tree_add_text() call to match the format and the arguments.
svn path=/trunk/; revision=24411
GIOP reassembly fails when first packet of a PDU is received Out-of-Order
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1453
The patch changed to use value_string but not all values included in the current value_string.
svn path=/trunk/; revision=24410