Commit graph

28276 commits

Author SHA1 Message Date
Bill Meier
5aef94e6eb reassemble.h: update two comments; reassemble.c: correct a typo.
svn path=/trunk/; revision=29205
2009-07-27 13:59:53 +00:00
Anders Broman
d446944c82 From Gerasimos Dimitriadis:
Decoding support for 4 DTAP IEs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3777

svn path=/trunk/; revision=29204
2009-07-27 13:08:17 +00:00
Anders Broman
cb771536df From Kovarththanan Rajaratnam:
Only fill in frame_data vals when needed.

svn path=/trunk/; revision=29203
2009-07-27 08:33:26 +00:00
Anders Broman
9ca4ac2bed From Kovarththanan Rajaratnam:
Use frame_data values .

svn path=/trunk/; revision=29202
2009-07-27 03:34:57 +00:00
Anders Broman
e040dac13f Revert change by mistake.
svn path=/trunk/; revision=29201
2009-07-26 22:18:11 +00:00
Anders Broman
f79c2aaeb7 "Create" the time cols when we render them making change of time format fast.
svn path=/trunk/; revision=29200
2009-07-26 22:16:36 +00:00
Anders Broman
3bbe2106c5 From Kovarththanan Rajaratnam:
- Don't issue a row_inserted signal. Rely on our caller to have  
disconnected the model from the view.

-  Removing col_fmt from row_data. It wasn't being used. If we need to store
the column format in the future that should probably be placed in the
PacketList instead of the PacketListRecord
2) Remove double allocation of col_text. Now we allocate it in
new_packet_list_append() and pass it on to packet_list_append_record()
3) Use se_alloc instead of se_alloc0 because we explictly set all the
parameters we use.

svn path=/trunk/; revision=29199
2009-07-26 22:11:46 +00:00
Gerald Combs
b0bb6889f4 [Automatic manuf and enterprise-numbers update for 2009-07-26]
svn path=/trunk/; revision=29196
2009-07-26 15:03:27 +00:00
Anders Broman
5fbc5d6f58 From Kovarththanan Rajaratnam:
Only clear packet list store if we need to redissect.

svn path=/trunk/; revision=29195
2009-07-26 10:34:07 +00:00
Guy Harris
be2a84c231 Note that libpcap fails if it tries to read a file with a snapshot
length > 65535, so we shouldn't use a larger value.

svn path=/trunk/; revision=29194
2009-07-26 00:32:22 +00:00
Stephen Fisher
53ded7dae6 Remove two unused variables and mark a function paramter as unused
svn path=/trunk/; revision=29193
2009-07-25 20:13:46 +00:00
Anders Broman
90b1e0ebed From Kovarththanan Rajaratnam:
Include needed header (unbreak OSX buildbot)

svn path=/trunk/; revision=29192
2009-07-25 10:40:10 +00:00
Anders Broman
10e3b340ba From Kovarththanan Rajaratnam:
packet_goto_next_previous_frame

svn path=/trunk/; revision=29191
2009-07-25 09:45:35 +00:00
Anders Broman
be084ae799 From Kovarththanan Rajaratnam:
New packet list: enable goto first/last packet (Optimized)

svn path=/trunk/; revision=29190
2009-07-25 07:50:53 +00:00
Stephen Fisher
14852c1384 Update my e-mail address with a reference to the AUTHORS file
svn path=/trunk/; revision=29189
2009-07-25 03:23:37 +00:00
Anders Broman
9feddc7ef4 From Kovarththanan Rajaratnam:
New packet list: enable packet history
Me: Add a comment.

svn path=/trunk/; revision=29188
2009-07-24 21:25:21 +00:00
Anders Broman
2e29868357 Use g_slice if glib >=2.10
svn path=/trunk/; revision=29187
2009-07-24 13:50:57 +00:00
Anders Broman
9bf46cd286 When using the new packet list select the first packet when the file read is complete. This should take care of the crash when closing WS.
svn path=/trunk/; revision=29186
2009-07-24 08:10:33 +00:00
Bill Meier
b86e69f348 Use consistent indentation ...
svn path=/trunk/; revision=29185
2009-07-23 21:25:02 +00:00
Bill Meier
3b4b7023b9 Fix some whitespace ....
svn path=/trunk/; revision=29184
2009-07-23 20:53:44 +00:00
Bill Meier
882b917466 Fix emacs editor modeline to be a 'safe" value.
svn path=/trunk/; revision=29183
2009-07-23 20:52:54 +00:00
Anders Broman
f0d16b990f From Gerasimos Dimitriadis:
Minor enhancement to LAI decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3770

svn path=/trunk/; revision=29182
2009-07-23 20:36:16 +00:00
Guy Harris
241aa76fc9 Saved by removing the bell.
svn path=/trunk/; revision=29181
2009-07-23 18:36:25 +00:00
Bill Meier
65faee6470 Set editor modelines to be consistent between emacs and vi/ex;
Indentation and whitespace cleanup;

svn path=/trunk/; revision=29180
2009-07-23 17:46:09 +00:00
Martin Mathieson
7f00738810 From Kovarththanan Rajaratnam: avoid circular dependency.
svn path=/trunk/; revision=29179
2009-07-23 11:19:05 +00:00
Guy Harris
7b07422574 Don't divide the data rate by 2 - that loses information (yes, I have a
trace with at least one packet transmitted at 5.5 Mb/s).

Clean up indentation.

svn path=/trunk/; revision=29178
2009-07-23 09:32:58 +00:00
Anders Broman
832087bfbf - Ambiguous value for radiotap datarate.
The value given to proto_tree_add_uint_format() was not divided by 2.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3747
- remove check_col()
- Indentation changes.

svn path=/trunk/; revision=29177
2009-07-23 08:56:09 +00:00
Anders Broman
733bdd4e56 Try to get the #includes right - take 2.
svn path=/trunk/; revision=29176
2009-07-23 08:53:13 +00:00
Anders Broman
b4a0cda41e Try to get the #includes right.
svn path=/trunk/; revision=29175
2009-07-23 07:57:32 +00:00
Anders Broman
ded297677f From Kovarththanan Rajaratnam:
Precompile custom columns filters.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3767

svn path=/trunk/; revision=29174
2009-07-23 05:48:39 +00:00
Anders Broman
1e7878b53d From Steve Karg:
BACnet Action property not decoded correctly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3766

svn path=/trunk/; revision=29173
2009-07-23 05:38:34 +00:00
Anders Broman
f1e8e405ce From Neil Piercy:
Another missing RRC dissector chaining link.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3769

svn path=/trunk/; revision=29172
2009-07-23 05:32:31 +00:00
Gerald Combs
1e93d53b56 Use "svn info" to fetch the version by default. Fetch the repository path as
well. Add the repository path to the version strings.

svn path=/trunk/; revision=29171
2009-07-22 23:59:15 +00:00
Anders Broman
0b0ff6cdcf Get rid of check_col() in some of the more frequently used dissectors.
svn path=/trunk/; revision=29170
2009-07-22 21:33:47 +00:00
Anders Broman
213a926bd9 From kovarththanan Rajaratnam:
Pass column_info as a pointer (new packet list).

svn path=/trunk/; revision=29169
2009-07-22 17:35:28 +00:00
Anders Broman
69e79617ef From Jakub Zawadzki:
This patch fix return value in new_packet_list_find_row_from_data when !select

From Me: Change back the cell coloring and remove the horizontal-separator making the colorinjg look the same as in the old packet list.

svn path=/trunk/; revision=29168
2009-07-22 15:23:08 +00:00
Martin Mathieson
41b86b26b8 Improve/expand checks on reserved bit values.
svn path=/trunk/; revision=29167
2009-07-22 13:21:15 +00:00
Anders Broman
45c1df205f From Jakub Zawadzki:
This patch makes row coloring alike GtkCList version
 (remove white space between cells/columns)

svn path=/trunk/; revision=29166
2009-07-22 08:54:38 +00:00
Anders Broman
c9b459f8e6 Take 2:
From Jakub Zawadzki:
This patch is cut&paste code from gtk/main_packet_list.c:packet_list_compare()
to new function frame_data_compare()
+ it make use of new function inside packet_list_compare() and
packet_list_compare_records()

svn path=/trunk/; revision=29165
2009-07-22 08:11:50 +00:00
Anders Broman
f186fba577 From Jakub Zawadzki:
This patch is cut&paste code from gtk/main_packet_list.c:packet_list_compare()
to new function frame_data_compare()
+ it make use of new function inside packet_list_compare() and
packet_list_compare_records()

svn path=/trunk/; revision=29164
2009-07-22 08:09:22 +00:00
Anders Broman
203fb3f25f Minor indentation fixes.
svn path=/trunk/; revision=29163
2009-07-22 06:00:53 +00:00
Stephen Fisher
c570bf42e2 Change some g_malloc() calls to g_new() to make the code easier to read.
svn path=/trunk/; revision=29162
2009-07-22 05:02:24 +00:00
Stig Bjørlykke
7e99557d05 Another try to fix the compiler warnings on win64.
svn path=/trunk/; revision=29161
2009-07-21 22:23:34 +00:00
Stig Bjørlykke
49cb1d37ee Cummulative number of packets lost is a signed 24 bits value.
This fixes bug 3763.

Cleanup some proto_tree_add_uint() -> proto_tree_add_item().

svn path=/trunk/; revision=29160
2009-07-21 22:09:31 +00:00
Stig Bjørlykke
8c4abdfb47 From didier gautheron via bug 3762:
This patch removes col_expr in frame_data structure,
it can be recomputed when needed.

svn path=/trunk/; revision=29159
2009-07-21 16:48:16 +00:00
Guy Harris
8300e59b2f More gsizery.
svn path=/trunk/; revision=29158
2009-07-21 09:05:16 +00:00
Guy Harris
a864f7d89a GLib documentation says the 3rd and 5th arguments to g_iconv are "gsize
*"s.

svn path=/trunk/; revision=29157
2009-07-21 08:53:39 +00:00
Anders Broman
f610ec3c46 size_t -> int to make the Win64 build bot happy.
svn path=/trunk/; revision=29156
2009-07-21 08:35:24 +00:00
Stig Bjørlykke
6dbdc38c53 Initialize bacapp_invoke_id to avoid a compiler warning.
svn path=/trunk/; revision=29155
2009-07-21 08:07:40 +00:00
Martin Mathieson
a2d0ad942f Stop using the C++ 'true' and 'false'.
I still get a compilation error...

packet-bacapp.c: In function `dissect_bacapp':
packet-bacapp.c:6350: warning: 'bacapp_invoke_id' might be used uninitialized in this function

... although I've followed the paths (including the setting of 'segment'), and it looks bogus to me.


svn path=/trunk/; revision=29154
2009-07-21 07:59:16 +00:00