Fix two calls of proto_tree_add_item() when proto_tree_add_uint()
was meant. Passing the actual value of a field instead of an encoding
into proto_tree_add_item() has unexpected results. Fix#17909.
(The whole area of this dissector would probably be cleaner with
more calls to add_item(), but this is a smaller change consistent
with the rest.)
After commit 16ddc9ab19, we don't need to call srtcp_add_address
separately for a multiplexed connection. Do call it on a client hello
with only a single protection profile offered, in case of a one way
connection, though. Related to #13193.
The RTP dissector supports RFC 5761 multiplexing by default, always
passing payload types that conflict with RTCP to the RTCP dissector.
Thus, when a [S]RTP stream is set up by srtp_add_address, it should
pass along the information to the RTCP dissector so that the rtcp_info
and srtcp_info information is attached to the conversation as well.
Helps with DTLS-SRTP (#13193).
Fix regressions in AppleShare dissection by correcting the length
of afp.access and afp.file_bitmap fields to be UINT16 as specified
in the AppleShare protocol specification.
Fix reuse of afp.file_bitmask in CatSearchExt as a 16 and as a 32 bit
value by introducing afp.request_bitmask for the 32 bit Request
Bitmap.
Closes#17907.
dissections by introducing hf_afp_request_bitmap for the 32 bit
Request Bitmap in FPCatSearchExt. Made the hf_afp_access_*
FT_BOOLEANs have a width of 16 to reflect the fact that
hf_afp_access_mode needs to be a FT_UINT16 as AFP spec defines
access mode as a short.
Fix regressions in AppleShare dissection by correcting the length
of afp.access and afp.file_bitmap fields to be UINT16 as specified
in the AppleShare protocol specification. Closes#17907
The Release Identifer field is only one nibble in GTP'. So in
Release 15 of 3GPP TS 32.295, an extra octet, Release Identifier
Extension, was added to support CDRs encoded with Release 16 and
higher of TS 32.298. Fix#17903.
Use the information in a use_srtp Extension in a Server Hello to
set up SRTP and SRTCP sessions according to RFC 5764. It is RECOMMENDED
that symmetric RTP be used with DTLS-SRTP, and RTP and RTCP traffic may
be multiplexed, so set up all four possible connections.
Fix#17905.
As the owner name of each NSEC3 record is Base32-encoded, the Next
Hashed Owner Name field in those records should also be displayed in
Base32-encoded form. This enables the user to quickly tell what span of
hashed owner names is covered by a given NSEC3 record.
If RTCP is chosen via Decode As, decode as RTCP.
If SRTCP is chosen via Decode As, decode as SRTCP (assuming that
all packets are encrypted, because we can't tell where the E bit is
in that case.)
If possible [S]RTCP is found via the heuristic dissector, assume either
RTCP or (encrypted) SRTCP based a preference. Perhaps later the heuristic
dissector could be improved to make a better decision.
This was done for all generated values in commit:
commit 7e99bbf32b
Author: John Thacker <johnthacker@gmail.com>
AuthorDate: Tue Nov 23 21:36:02 2021 -0500
Commit: John Thacker <johnthacker@gmail.com>
CommitDate: Thu Dec 2 20:40:22 2021 -0500
BER: Make GeneralizedTime a FT_ABSOLUTE_TIME
...
But we need to also do it for manual stuff.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Roman Volkov