Commit Graph

82681 Commits

Author SHA1 Message Date
Dr. Lars Völker 56d100d6ea MKA: Adding Announcement TLV parsing and Cipher Suite
This patch adds support to parse the Announcement TLV in MKA and the
Cipher Suite announcement within it.
2021-11-21 20:18:56 +01:00
Gerald Combs 730a4c0b85 Docs: Update our supported macOS version information. 2021-11-21 18:36:57 +00:00
Uli Heilmeier 3c73fa5d55 Revert "tests: fix test fails on Ubuntu, fix #17730"
This reverts commit 78067deb89.
Commit d5ba1fe2 unsets XDG_CONFIG_HOME when setting up the environment.

Related to #17730
2021-11-21 17:47:32 +00:00
Gerald Combs 92045d98c0 [Automatic update for 2021-11-21]
Update manuf, services enterprise numbers, translations, and other items.
2021-11-21 16:24:28 +00:00
John Thacker ca71d1624c gryphon: Create pkt_info if it doesn't exist
Try to retrieve the per packet info data first, and create it if
it doesn't exist, rather than assuming it is there on the second
pass. Prevents segfaults in cases with strange TCP sequence issues
(that still show up as bugs in the TCP dissector.) Fix #17737.
2021-11-21 09:23:07 -05:00
Dr. Lars Völker abf9ed5f11 MKA: Adding support for Announcement TLV padding (Bugfix) 2021-11-21 14:04:41 +00:00
John Thacker b5917d0182 wmem: Add a multimap
A number of protocols have IDs that can be reused that are used as
lookup keys. In most cases the frame number should be used as well
to differentiate repeat appearances of an ID. For response/request
matching, it is frequently useful to find the most recent frame number
(greatest value less than or equal to the current one) that contained
an ID.

We can achieve that by using a multimap that stores values with a given
ID in a tree keyed with the frame number. This works better than using
a map or a tree alone:

1) A map isn't ordered, so doesn't allow for less than or equal comparison.
2) Using a tree requires an ordering on all the ID components, and then
   having to test all the components other than the frame number separately
   for equality after retrieval.

Currently the multimap does not support inserting items without specifying
the tree key (and having the multimap generate a key), because the total
capacity of trees (including deleted nodes) is not tracked. If other use
cases are needed, this could be added later along with more generic
multimap support.

Use a multimap in ANSI MAP, ANSI TCAP, and GSM SMS, all of which need to
match lookup IDs that can be reused. Fix #7653.
2021-11-21 07:16:55 -05:00
Gerald Combs e2703507c2 Update a bunch of GLib documentation links.
Change our developer.gnome.org/glib URLs to
developer-old.gnome.org/glib. The official documentation for GLib
appears to be at https://docs.gtk.org/glib/, but it has a different
layout than the gnome.org content (and is surprisingly resistant to
exploration IMHO). We can switch to developer-old.gnome.org using a
simple substitution and it still seems to be updated, so do that for
now.
2021-11-20 21:33:17 +00:00
Stig Bjørlykke a8643ab254 Qt: Fix column validation in columnString()
The column parameter in PacketListRecord::columnString() must be
below cap_file->cinfo.num_cols to be valid. An issue with this check
may be triggered when switching profile.
2021-11-20 17:22:33 +00:00
Odysseus Yang 5a7c23c5da MBIM: dissect MBIM_CID_BASE_STATIONS_INFO
MBIM_CID_BASE_STATIONS_INFO
2021-11-20 16:44:24 +00:00
Stig Bjørlykke 3badea1e80 btle: Improve Advertising Data reassembly
Copy Advertiser Address from AUX_ADV_IND if not present in AUX_CHAIN_IND
to make reassembly work. Check for valid reassembled data before
doing dissect_ad_eir().
2021-11-20 15:38:24 +00:00
Michael Tuexen 2b52d14d62 BBLog: Fix the handling of skipped blocks 2021-11-20 00:10:28 +01:00
Gerald Combs 389cf9d752 HICP: Use wmem_strsplit.
As the GLib documentation says, g_strsplit returns "A newly-allocated
NULL-terminated array of strings. Use g_strfreev() to free it." Call
wmem_strsplit instead so that we clean up after ourselves. Blind attempt
at fixing #17736.
2021-11-19 17:58:27 +00:00
João Valverde f1b10644a7 Release notes: Add back note about display filter syntax
This indicates a deprecation that was removed, that is relevant
to note for this release.
2021-11-19 10:16:02 +00:00
Pascal Quantin 4921183e33 GTPv2: fix dissection of 5GS TAC
Fixes #17738
2021-11-19 04:51:05 +00:00
Gerald Combs f0b2bb7472 Docs: Clean up the release notes. 2021-11-18 18:43:33 -08:00
Gerald Combs d5ba1fe2fc Test: Make sure XDG_CONFIG_HOME isn't set.
Make sure the environment factory in fixtures_ws.py unsets
XDG_CONFIG_HOME, otherwise tests can fail. Ping #17730.
2021-11-18 20:55:46 +00:00
Georg Sauthoff faf03149af Don't close stdin on spawn error
This solves the following issue:

In cases where `mmdbresolve` fails to execute (e.g. when it's simply
missing from a tree) the spawn fails such that a zero initialized file
descriptor is closed (i.e. stdin). The close is silent, unless one
executes something like `tshark -r - ...` where a bad file descriptor
is reported then.
2021-11-18 19:24:09 +00:00
eason wei 61e4529fe5 tests: fix the test case running warning.
Fix the test_follow_dccp_existing_flow test case warning in suite_follow_dccp.py.
2021-11-18 07:55:22 +00:00
Martin Mathieson 263189e23d Fix some spelling errors. 2021-11-18 04:43:51 +00:00
Joerg Mayer 8772147021 Cmake: Qt6 extends CMAKE_MODULE_PATH, work around this 2021-11-17 17:30:28 +00:00
Joerg Mayer d52478436d macos-setup.sh: Update some tools
- Cmake to 3.21.4
- Sparkle to 1.27.0
- Asciidoctor to 2.0.16
- AsciidoctorPdf to 1.6.1
2021-11-17 16:18:50 +00:00
easonweii 78067deb89 tests: fix test fails on Ubuntu, fix #17730
unset the env variable XDG_CONFIG_HOME in ubuntu.yaml (action config file), wireshark will use $HOME evn variable;
and i test those two solutions, all test case is success;
2021-11-17 22:41:55 +08:00
Aidan MacDonald a8a3a3093c USB Attached SCSI protocol dissector
This is capable of dissecting UASP traffic on a USB 2.0
bus, provided Wireshark sees the interface descriptor.

Dissecting USB 3.0 traffic won't work properly because we
don't have access to an URB's bulk stream ID, so the data
transfer can't be attributed properly to commands.
2021-11-17 13:27:57 +01:00
Aidan MacDonald 660dded383 Refactor USB mass storage class dissector
The existing dissector only handles the Bulk-Only Transport
protocol but occupies the USB dissector hooks for all mass
storage class traffic.

To facilitate alternative protocols like UASP, direct all
mass storage class traffic to a stub dissector which will
dispatch to the real dissector based on other information,
such as the USB interface protocol.

Heuristic dissectors are still attached directly to the
core USB hooks.
2021-11-17 13:27:56 +01:00
Chuck Craft f748c91bb2 Qt (ByteView): update preference on hover state change; WSUG typo 2021-11-17 09:43:11 +00:00
Filip Kågesson f9be0f0c8c HICP: Added dissector to support Host IP Configuration Protocol.
A new dissector was added to support dissection of the HICP protocol.
2021-11-16 21:43:17 +00:00
Luckinger Florian 2172cd3e95 EBHSCR: Add dissection of LIN packets 2021-11-16 21:28:54 +00:00
Luckinger Florian f9398d82fb EBHSCR: Update dissection of ethernet frames
Add new bits to status field. Add column info for frames with no ethernet
payload.
2021-11-16 21:28:54 +00:00
Luckinger Florian b43d4a8c28 EBHSCR: Add dissection of FlexRay packets
Dissect FlexRay specific EBHSCR header of frame packets, symbol packets,
slot status packets and start of cycle packets. Payload of frame packets
and symbol packets is prepared and passed to the FlexRay dissector.
2021-11-16 21:28:54 +00:00
Jirka Novak ffd1f1cecf VoIP calls dialog: fix generated filter
New 'in { }' syntax requires comma between items so filter generator in
VoIP calls dialog must use it too.
2021-11-16 21:02:05 +01:00
Michael Tuexen 74d0c147a1 TCP Black Box Log: Fix and improve some fields 2021-11-16 17:17:34 +00:00
Jaap Keuter 5f7806a496 c-ares: move domain from haxx.se to its own .org
With c-ares release 1.18.0 the URLs were updated to c-ares.org.
Let's do the same.
2021-11-16 17:02:50 +00:00
Jaap Keuter 4f8e7f0d1c Add direct GitLab reference in GitHub PR lockdown text
Nothing more annoying than having to read a bunch of documentation, while
all you need is one fundamental piece of information: the right repo.
2021-11-16 16:47:09 +00:00
João Valverde 3c7894e2a0 dfilter: Add compilation result to log output
Add result output to console log, in addition to intermediate debug
information. This allows tracing the result using the log only.
2021-11-16 13:52:30 +00:00
João Valverde edf1e72d0c capture: Lower log level for debug output 2021-11-16 12:47:54 +00:00
João Valverde 75bb51eef9 dfilter: Clean up some debug statements, second try
Add just a console entry for check_test(), in a more compact
form.

Remove logging of the call chain. This was partially replaced by the
printout of the syntax tree.
2021-11-16 11:27:04 +00:00
João Valverde c4337d0dc5 dfilter: Give more context for regex error messages 2021-11-16 11:18:09 +00:00
John Thacker 18abdc3ebc ansi_map,ansi_tcap: Fix typos, comment out unused fields
Fix a couple of typos that referred to the wrong fields, and comment
out some unused fields.
2021-11-16 01:46:34 -05:00
John Thacker 4015aa954c TCAP,CAMEL: Always enable SRT and Counter stats
The Service Response Time stats for CAMEL (and TCAP, which must be
enabled as well) are reliable and not that processor intensive. They
should be always enabled, just like the SRT stats for other protocols.

This also makes things less confusing with regards to the CAMEL
opcode counter stats, which were only enabled if the SRT preferences
were also set, since they use the same tap.

Also remove a unused function declaration in a header.
2021-11-16 05:06:41 +00:00
Gerald Combs 5005a696e4 GitLab CI: Bump our minimum macOS Intel version. 2021-11-15 15:59:51 -08:00
Gerald Combs 4105d78681 GitLab CI: Switch the macOS Intel build to Qt 5.15.3. 2021-11-15 15:31:52 -08:00
Pascal Quantin 5c8969b5d7 Windows: add PCRE2 DLL to installers 2021-11-15 23:07:15 +01:00
Gerald Combs 6ee1390b86 Qt: Make Lua dialogs children of the main window.
Pass the funnel operations ID to new_text_window and new_dialog so that
we can assign parent widgets when we create new FunnelTextDialogs and
FunnelStringDialog. This should ensure that they're destroyed properly.
Ping #17590.
2021-11-15 20:03:16 +00:00
Gerald Combs 64275ff196 macOS: Update some comments in osx-app.sh. 2021-11-15 09:26:20 -08:00
João Valverde 14c52913e2 CMake: Improve a status message and add a comment 2021-11-15 16:36:17 +00:00
João Valverde aa1515b32b CMake: Fix typo 2021-11-15 16:36:17 +00:00
Martin Mathieson 8003096260 PDCP-LTE: add missing _lte to register function name 2021-11-15 12:50:37 +00:00
João Valverde 4403bd98d9 tools: Add MSYS2 setup script to install dependencies 2021-11-15 12:24:49 +00:00
João Valverde df968b5342 tools: Add Arch Linux setup script to install dependencies
This was intentionally kept simple (matches the philosophy of Arch).

In particular I wasn't so concerned about what is a required build
dependency and what is an optional build dependency to compile the
programs. I don't know why one would ever wish to skip installation
of non-essential library dependencies. But others are very welcome
to extend this intentionally barebones effort.

The script also adds an "--install-all" flag to install everything
at once. I keep forgetting the name of the other options.

I used the build optional flag to install packages required to build
documentation and so on. Ancillary stuff.
2021-11-15 11:25:29 +00:00